- Aug 20, 2020
-
-
Bartosz Sosnowski authored
Fixes an issue on Windows, where Unicode in NODE_OPTIONS was not parsed correctly. Fixes: https://github.com/nodejs/node/issues/34399 PR-URL: https://github.com/nodejs/node/pull/34476 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
Dennis Ameling authored
Uses x64 node executable for running .js files in arm64 cross-compilation scenarios. MSI can now be created by running `vcbuild.bat release msi arm64` Refs: https://github.com/nodejs/node/issues/25998 Refs: https://github.com/nodejs/node/issues/32582 PR-URL: https://github.com/nodejs/node/pull/34009 Reviewed-By:
João Reis <reis@janeasystems.com>
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/34809 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Justice Almanzar authored
PR-URL: https://github.com/nodejs/node/pull/34768 Fixes: https://github.com/nodejs/node/issues/34767 Fixes: https://github.com/nodejs/node/issues/34447 Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
-
Antoine du HAMEL authored
PR-URL: https://github.com/nodejs/node/pull/34584 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com>
-
cjihrig authored
This commit adds validation to the IP address returned by the net module's custom DNS lookup() function. PR-URL: https://github.com/nodejs/node/pull/34813 Fixes: https://github.com/nodejs/node/issues/34812 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Anna Henningsen authored
Some stylistic changes to bring this more in line with what our tests currently look like, and add a note about general flakiness. PR-URL: https://github.com/nodejs/node/pull/34685 Reviewed-By:
-
Antoine du HAMEL authored
The `module` core module is available for both CJS and ESM users, it deserves its own page. PR-URL: https://github.com/nodejs/node/pull/34747 Refs: https://github.com/nodejs/modules/issues/539 Reviewed-By:
-
Richard Lau authored
Change format of logged messages when run on GitHub Actions (i.e. when the `GITHUB_ACTIONS` environment variable is true) so that broken links are highlighted inline in pull requests. Signed-off-by:
Mary Marchini <oss@mmarchini.me> Reviewed-By:
-
Richard Lau authored
Signed-off-by:
-
Jerome T.K. Covington authored
In other api docs, it seems that deprecated classes and methods are listed along with others, and marked as deprecated. In tls docs, deprecations were listed at the bottom of the document. This commit reorders them to what seems to be the standard, and corrects some links in doc/api/deprecations.md PR-URL: https://github.com/nodejs/node/pull/34687 Reviewed-By:
-
Frank Lemanschik authored
PR-URL: https://github.com/nodejs/node/pull/34786 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
-
Denys Otrishko authored
Refs: https://github.com/nodejs/node/issues/34765 PR-URL: https://github.com/nodejs/node/pull/34795 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/34829 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Hilla Shahrabani authored
PR-URL: https://github.com/nodejs/node/pull/34800 Reviewed-By:
-
Rich Trott authored
There doesn't seem to be a reason for this test to have to stay in sequential. It appears to have been placed there out of caution. PR-URL: https://github.com/nodejs/node/pull/34755 Reviewed-By:
-
Michaël Zasso authored
Running outside of the main Node.js context prevents us from upgrading the WPT harness because new versions more aggressively check the identity of globals like error constructors. Instead of exposing globals used by the tests on vm sandboxes, use worker threads to run everything. PR-URL: https://github.com/nodejs/node/pull/34796 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Rich Trott authored
Documentation-only: Recommend people use the static methods on crypto.Certificate() and not the legacy API constructor. PR-URL: https://github.com/nodejs/node/pull/34697 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
-
Rich Trott authored
The text for the legacy API sends mixed signals. It's legacy, but still supported, so not deprecated, but not recommended. Let's begin to clarify this by removing "not recommended". If we want to not-recommend it, let's doc-deprecate it properly, or at least include an explanation as to why it's not recommended. PR-URL: https://github.com/nodejs/node/pull/34697 Reviewed-By:
-
Rich Trott authored
In test-http-destroyed-socket-write2, the assert.strictEqual() in the default case of the switch statement will always fail because it checks for a value that is already accounted for in one of the switch cases. Convert it to assert.fail(). PR-URL: https://github.com/nodejs/node/pull/34793 Reviewed-By:
-
Rich Trott authored
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our code base and dependencies. Move to legacy errors. PR-URL: https://github.com/nodejs/node/pull/34792 Reviewed-By:
-
Anna Henningsen authored
The `set_abort_on_uncaught_exception(false)` line was supposed to prevent aborting when running Workers in `--abort-on-uncaught-exception` mode, but it was incorrectly set and not checked properly in the should-abort callback. PR-URL: https://github.com/nodejs/node/pull/34724 Backport-PR-URL: https://github.com/nodejs/node/pull/34815 Reviewed-By:
-
Anna Henningsen authored
This can currently be triggered when posting a closing FileHandle. Refs: https://github.com/nodejs/node/pull/34746#issuecomment-673675333 PR-URL: https://github.com/nodejs/node/pull/34766 Backport-PR-URL: https://github.com/nodejs/node/pull/34814 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/34070 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34782 Reviewed-By:
-
Mary Marchini authored
s/docs/doc/g Signed-off-by:
Mary Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/34811 Reviewed-By:
-
Mary Marchini authored
PR-URL: https://github.com/nodejs/node/pull/34739 Reviewed-By:
-
Luigi Pinca authored
Fixes: https://github.com/nodejs/node/issues/34787 PR-URL: https://github.com/nodejs/node/pull/34789 Reviewed-By:
-
Rich Trott authored
The three tests that use common.rootDir do not need the root dir. They just need an arbitrary directory that will exist. Use tmpdir.path instead. PR-URL: https://github.com/nodejs/node/pull/34772 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34769 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/node/pull/34727#issuecomment-672862034 PR-URL: https://github.com/nodejs/node/pull/34769 Reviewed-By:
-
davkor authored
Refs: https://github.com/google/oss-fuzz/pull/3860 Fixes: https://github.com/nodejs/node/issues/33724 PR-URL: https://github.com/nodejs/node/pull/34761 Fixes: https://github.com/nodejs/node/issues/33724 Reviewed-By:
-
Voltra authored
Reference format: `RFC <rfc id> <section path>` PR-URL: https://github.com/nodejs/node/pull/33671 Reviewed-By:
Pranshu Srivastava <rexagod@gmail.com> Reviewed-By:
-
Denys Otrishko authored
* use util.inspect for value presentation * allow to optionally specify error reason PR-URL: https://github.com/nodejs/node/pull/34671 Reviewed-By:
-
Derek Lewis authored
This patch converts the "read package scope" algorithm's while loop into a do-while loop enabling items at the filesystem root dir to be considered within the scope of a sibling package.json also at the filesystem root dir. Fixes: https://github.com/nodejs/node/issues/33438 Co-authored-by:
-
Mary Marchini authored
PR-URL: https://github.com/nodejs/node/pull/34737 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
João Reis authored
PR-URL: https://github.com/nodejs/node/pull/34721 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ash Cripps <ashley.cripps@ibm.com> Reviewed-By:
-
cjihrig authored
libuv 1.39.0 will begin requiring uv_setup_args() to be called before attempting to access the process title. This commit adds uv_setup_args() calls that were missing in order for the test suite to pass (and updates the documentation). PR-URL: https://github.com/nodejs/node/pull/34751 Reviewed-By:
-
Rich Trott authored
Many style guides (including Microsoft's) suggest avoiding _may_ because it can be unclear. Using _can_ or _might_ tends to increase clarity. An example in this change: > They may not change to a Runtime Deprecation until the next major > release. It's not clear if that means "They can not change until the next major release" or "They might not change until the next major release but also might change before then". Using _can_ or _might_ instead of _may_ clears up the ambiguity. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may PR-URL: https://github.com/nodejs/node/pull/34749 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Tobias Nießen authored
The previous code changed the private key of the ECDH object, but removed the public key if deriving it from the private key failed. Instead, if deriving the public key fails, neither the private nor the public key stored in the ECDH object should be updated. PR-URL: https://github.com/nodejs/node/pull/34302 Reviewed-By:
-
