Commits · v13.x-staging · github.com / v8-riscv / node

May 11, 2020

build: add --error-on-warn configure flag · 0744547a

Daniel Bevenius authored Apr 06, 2020

This commit adds a configuration time flag named error-on-warn:
$ ./configure --help | grep -A1 error-on-warn
  --error-on-warn       Turn compiler warnings into errors for node core
                        sources.

The motivation for this is that CI jobs can use this flag to turn
warnings into errors.

PR-URL: https://github.com/nodejs/node/pull/32685


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>

0744547a

Apr 30, 2020
- Working on v13.14.1 · 3a0821b2
  Ruben Bridgewater authored Apr 30, 2020
```
PR-URL: https://github.com/nodejs/node/pull/33122
```
  3a0821b2
Apr 29, 2020

2020-04-29, Version 13.14.0 (Current) · 9fc74f16

Ruben Bridgewater authored Apr 28, 2020

Notable Changes:

* async_hooks**:
  * Merge `run` and `exit` methods (Andrey Pechkurov)
    https://github.com/nodejs/node/pull/31950
  * Prevent sync methods of async storage exiting outer context
    (Stephen Belanger)
    https://github.com/nodejs/node/pull/31950
* vm:
  * Add `importModuleDynamically` option to compileFunction (Gus
    Caplan)
    https://github.com/nodejs/node/pull/32985

New core collaborators:

With this release, we welcome two new Node.js core collaborators:

* Juan José Arboleda @juanarbol
  https://github.com/nodejs/node/pull/32906
* Andrey Pechkurov @puzpuzpuz
  https://github.com/nodejs/node/pull/32817

PR-URL: https://github.com/nodejs/node/pull/33122

9fc74f16

Apr 28, 2020

doc: assign missing deprecation code · 386d158a

Richard Lau authored Apr 27, 2020



Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: https://github.com/nodejs/node/pull/33109
Refs: https://github.com/nodejs/node/pull/32807


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

386d158a

http: doc deprecate abort and improve docs · 9d18408b

Robert Nagy authored Apr 13, 2020

Doc deprecates ClientRequest.abort in favor of
ClientRequest.destroy. Also improves event order
documentation for abort and destroy.

Refs: https://github.com/nodejs/node/issues/32225

PR-URL: https://github.com/nodejs/node/pull/32807


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

9d18408b

n-api: fix false assumption on napi_async_context structures · 4fc7877e

legendecas authored Apr 19, 2020

napi_async_context should be an opaque type and not be used as same as
node::async_context.

PR-URL: https://github.com/nodejs/node/pull/32928


Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

4fc7877e

doc: improve WHATWG url constructor code example · de3ab9f5

Liran Tal authored Apr 11, 2020

Currently, the URL docs for the WHATWG URL spec support are
somewhat lacking in their code example of how to access the
new URL constructor that lives inside the core url package.

PR-URL: https://github.com/nodejs/node/pull/32782


Reviewed-By: Anna Henningsen <anna@addaleax.net>

de3ab9f5

build: fix vcbuild error for missing Visual Studio · bd40a8b3

Thomas authored Apr 04, 2020

The previous error was wrongly redirecting users
to the ICU installation steps, which is unrelated to
missing Visual Studio.

PR-URL: https://github.com/nodejs/node/pull/32658


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

bd40a8b3

doc: make openssl maintenance position independent · be55aac1

Sam Roberts authored Apr 21, 2020

It used to have some `cd` commands that if done literally would
invalidate the subsequent commands. Modify them to be more accurate,
which also simplifies pasting them directly into the console from the
guide while doing an update.

PR-URL: https://github.com/nodejs/node/pull/32977


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

be55aac1

module: refactor condition · c97a7ce3

Myles Borins authored Apr 21, 2020

PR-URL: https://github.com/nodejs/node/pull/32989


Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

c97a7ce3

doc: improve release documentation · 79d92b29

Michaël Zasso authored Apr 24, 2020

Extract the "Cherry-pick the Release Commit to master" part to its own
section and be more precise about what should be done to handle
conflicts.

PR-URL: https://github.com/nodejs/node/pull/33042


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>

79d92b29

src: add AsyncWrapObject constructor template factory · b953ab61

Stephen Belanger authored Apr 24, 2020

PR-URL: https://github.com/nodejs/node/pull/33051


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

b953ab61

doc: document major finished changes in v14 · 6b6c8d08

Robert Nagy authored Apr 25, 2020

Added description of semver-major changes to finished in v14.

PR-URL: https://github.com/nodejs/node/pull/33065


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

6b6c8d08

test: refactor test-async-hooks-constructor · 6984fbcf

himself65 authored Apr 26, 2020

PR-URL: https://github.com/nodejs/node/pull/33063


Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

6984fbcf

util,readline: NFC-normalize strings before getStringWidth · c239cc65

Anna Henningsen authored Apr 25, 2020

The assumption here is that decomposed characters render like their
composed character equivalents, and that working with the former
comes with a risk of over-estimating string widths given that
we compute them on a per-code-point basis. The regression test
added here (한글 vs 한글) is an example of that happening.

PR-URL: https://github.com/nodejs/node/pull/33052


Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

c239cc65

cluster: removed unused addressType argument from constructor · 0f4d5138

Yash Ladha authored Apr 21, 2020

When intializing the constructor for cluster master we are heavily using
a generic structure, but the effect of passing arguments that are
related to shared_handle is that there is a stale argument passed.

We can avoid such scenarios as all the remaining entities are being
destructured from the message object.

PR-URL: https://github.com/nodejs/node/pull/32963


Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

0f4d5138

src: do not compare against wide characters · 14cf9043

Christopher Beeson authored Apr 19, 2020

PR-URL: https://github.com/nodejs/node/pull/32921


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

14cf9043

src: fix empty-named env var assertion failure · 018de28b

Christopher Beeson authored Apr 18, 2020

Setting an environment variable with an empty name on Windows resulted
in an assertion failure, because it was checked for an '=' sign at the
beginning without verifying the length was greater than 0.

Fixes: https://github.com/nodejs/node/issues/32920
Refs: https://github.com/nodejs/node/pull/27310

PR-URL: https://github.com/nodejs/node/pull/32921


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

018de28b

worker: fix process.env var empty key access · 428fca1f

Christopher Beeson authored Apr 26, 2020

PR-URL: https://github.com/nodejs/node/pull/32921


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

428fca1f

doc: add documentation for transferList arg at worker threads · 9ebcd79a

Juan José Arboleda authored Apr 16, 2020

Ref: https://github.com/nodejs/node/pull/32278

PR-URL: https://github.com/nodejs/node/pull/32881
Refs: https://github.com/nodejs/node/pull/32278


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

9ebcd79a

deps: update archs files for OpenSSL-1.1.1g · 28c39d32

Hassaan Pasha authored Apr 21, 2020

After an OpenSSL source update, all the config files need to be
regenerated and committed by:
   $ cd deps/openssl/config
   $ make
   $ git add deps/openssl/config/archs
   $ git add deps/openssl/openssl/include/crypto/bn_conf.h
   $ git add deps/openssl/openssl/include/crypto/dso_conf.h
   $ git add deps/openssl/openssl/include/openssl/opensslconf.h
   $ git commit

PR-URL: https://github.com/nodejs/node/pull/32971


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

28c39d32

deps: upgrade openssl sources to 1.1.1g · 29d7202d

Hassaan Pasha authored Apr 21, 2020

This updates all sources in deps/openssl/openssl by:
    $ cd deps/openssl/
    $ rm -rf openssl
    $ tar zxf ~/tmp/openssl-1.1.1g.tar.gz
    $ mv openssl-1.1.1g openssl
    $ git add --all openssl
    $ git commit openssl

PR-URL: https://github.com/nodejs/node/pull/32971


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

29d7202d

tls: add highWaterMark option for connect · f6274afd

rickyes authored Apr 12, 2020

PR-URL: https://github.com/nodejs/node/pull/32786
Fixes: https://github.com/nodejs/node/issues/32781


Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

f6274afd

deps: V8: backport 3f8dc4b2e5ba · 5caa627d

Ujjwal Sharma authored Apr 22, 2020

Original commit message:

    [intl] Remove soon-to-be removed getAllFieldPositions

    Needed to land ICU67.1 soon.

    Bug: v8:10393
    Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489


Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Frank Tang <ftang@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67027}

Refs: https://github.com/v8/v8/commit/3f8dc4b2e5baf77b463334c769af85b79d8c1463

PR-URL: https://github.com/nodejs/node/pull/32993


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

5caa627d

buffer,n-api: fix double ArrayBuffer::Detach() during cleanup · 18fd841a

Anna Henningsen authored Apr 24, 2020

These calls could fail if the `ArrayBuffer` had already been explicitly
detached at some point in the past.

The necessary test changes already came with 4f523c2c and could
be ported back to v12.x with a backport of this PR.

Fixes: https://github.com/nodejs/node/issues/33022
Refs: https://github.com/nodejs/node/pull/30551

PR-URL: https://github.com/nodejs/node/pull/33039


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

18fd841a

doc: avoid tautology in README · dd1cc1a4

Ishaan Jain authored Apr 22, 2020

Changed "UTC time" on Line 82 to "UTC" as it created a tautology.

PR-URL: https://github.com/nodejs/node/pull/33005


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

dd1cc1a4

test: remove timers-blocking-callback · 790c4534

Jeremiah Senkpiel authored Apr 15, 2020

If the bug this test is intented to catch is reintroduced, or if
5aac4c42 is effectively reverted, many
(50+) tests time out, rendering this test redundant and unnecessary.

in particular, the following timer tests catch an effective revert of
5aac4c42:

not ok 21 parallel/test-timers-api-refs
not ok 22 parallel/test-timers-args
not ok 23 parallel/test-timers-destroyed
not ok 25 parallel/test-timers-nested
not ok 26 parallel/test-timers-interval-throw
not ok 28 parallel/test-timers-non-integer-delay
not ok 32 parallel/test-timers-ordering
not ok 33 parallel/test-timers-refresh
not ok 34 parallel/test-timers-refresh-in-callback
not ok 35 parallel/test-timers-reset-process-domain-on-throw
not ok 40 parallel/test-timers-timeout-to-interval
not ok 41 parallel/test-timers-uncaught-exception
not ok 42 parallel/test-timers-timeout-with-non-integer
not ok 43 parallel/test-timers-unenroll-unref-interval
not ok 44 parallel/test-timers-unref
not ok 45 parallel/test-timers-unref-active
not ok 46 parallel/test-timers-unrefd-interval-still-fires
not ok 47 parallel/test-timers-unrefed-in-callback
not ok 48 parallel/test-timers-user-call
not ok 49 parallel/test-timers-zero-timeout

Refs: https://github.com/nodejs/node/issues/21781

PR-URL: https://github.com/nodejs/node/pull/32870


Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

790c4534

src: assignment to valid type · f1556900

Yash Ladha authored Apr 16, 2020

We are converting the argument to a uint32_t value
but the lvalue is not consistent with the casting.

PR-URL: https://github.com/nodejs/node/pull/32879


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

f1556900

vm: add importModuleDynamically option to compileFunction · 88096997

Gus Caplan authored Apr 21, 2020

Fixes: https://github.com/nodejs/node/issues/31860

PR-URL: https://github.com/nodejs/node/pull/32985


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

88096997

inspector: only write coverage in fully bootstrapped Environments · 5dc4349a

Joyee Cheung authored Apr 21, 2020

The NODE_V8_COVERAGE folder and the source map computation are setup
during pre-execution since they rely on environment variables as well
as JS states. Therefore, we need to give up serialization of JS
coverage profiles for Environments that have not go through
pre-execution. Currently this is only possible for Environments
created using the embedder API CreateEnvironment().

As a result we won't have JS coverage data for most cctests, but if
that proves to be necessary we could just run
lib/internal/main/environment.js for these Environments created for
cctests.

Fixes: https://github.com/nodejs/node/issues/32912
Refs: https://github.com/nodejs/node/commit/65e18a8e9f912dfa04a804124b6a19514bb45165
Refs: https://github.com/nodejs/node/commit/5bf43729a403b992cc90b5cdbbaaf505769d1107
https://github.com/nodejs/node/commit/8aa7ef7840ef5f7161f3195e51a3fa6783290160

PR-URL: https://github.com/nodejs/node/pull/32960
Refs: https://github.com/nodejs/node/commit/8aa7ef7840ef5f7161f3195e51a3fa6783290160


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

5dc4349a

lib: unnecessary const assignment for class · d178250b

Yash Ladha authored Apr 21, 2020

PR-URL: https://github.com/nodejs/node/pull/32962


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>

d178250b

src: delete MicroTaskPolicy namespace · bd096bd8

Juan José Arboleda authored Apr 14, 2020

PR-URL: https://github.com/nodejs/node/pull/32853


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

bd096bd8

test: better error validations for event-capture · a223ccc7

Adrian Estrada authored Apr 10, 2020

PR-URL: https://github.com/nodejs/node/pull/32771


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

a223ccc7

doc: updated directory entry information · fae1aed6

Eileen authored Apr 11, 2020

Fixes: https://github.com/nodejs/node/issues/25595

subdirectory

updated def

PR-URL: https://github.com/nodejs/node/pull/32791


Reviewed-By: Anna Henningsen <anna@addaleax.net>

fae1aed6

test: refactor events tests for invalid listeners · 4169bc4d

Adrian Estrada authored Apr 11, 2020

PR-URL: https://github.com/nodejs/node/pull/32769


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

4169bc4d

lib: simplify function process.emitWarning · 2c364d46

himself65 authored Apr 22, 2020

PR-URL: https://github.com/nodejs/node/pull/32992


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

2c364d46

doc: ignore no-literal-urls in README · e372b8b6

Nick Schonning authored Apr 22, 2020

 Membership lists are currently formatted in a specific way for tooling

PR-URL: https://github.com/nodejs/node/pull/32676


Reviewed-By: Rich Trott <rtrott@gmail.com>

e372b8b6

doc: convert bare email addresses to mailto links · a5bed1e2

Nick Schonning authored Apr 22, 2020

reflowed for line length after increased url size

PR-URL: https://github.com/nodejs/node/pull/32676


Reviewed-By: Rich Trott <rtrott@gmail.com>

a5bed1e2

doc: ignore no-literal-urls in changelogs · f7c7713a

Nick Schonning authored Apr 05, 2020

PR-URL: https://github.com/nodejs/node/pull/32676


Reviewed-By: Rich Trott <rtrott@gmail.com>

f7c7713a

doc: add angle brackets around implicit links · 2eb52622

Nick Schonning authored Apr 05, 2020

PR-URL: https://github.com/nodejs/node/pull/32676


Reviewed-By: Rich Trott <rtrott@gmail.com>

2eb52622