- Oct 19, 2016
-
-
Rod Vagg authored
-
- Oct 18, 2016
-
-
Rod Vagg authored
This is a security release. All Node.js users should consult the security release summary at https://nodejs.org/en/blog/vulnerability/october-2016-security-releases/ for details on patched vulnerabilities. Notable changes: * c-ares: fix for single-byte buffer overwrite, CVE-2016-5180, more information at https://c-ares.haxx.se/adv_20160929.html (Rod Vagg) PR-URL: https://github.com/nodejs/node/pull/9154
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/9155 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
João Reis <reis@janeasystems.com>
-
Rod Vagg authored
Backport of https://github.com/nodejs/node/pull/8849 for c-ares 1.9.0. Incorrect string length calculation when passing escaped dot. - CVE: CVE-2016-5180 - Upstream bug: https://c-ares.haxx.se/adv_20160929.html PR-URL: https://github.com/nodejs/node/pull/9108 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/9107 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
- Sep 28, 2016
-
-
Rod Vagg authored
-
Rod Vagg authored
This is a security release. All Node.js users should consult the security release summary at https://nodejs.org/en/blog/vulnerability/september-2016-security-releases/ for details on patched vulnerabilities. Notable changes: * buffer: Zero-fill excess bytes in new `Buffer` objects created with `Buffer.concat()` while providing a `totalLength` parameter that exceeds the total length of the original `Buffer` objects being concatenated. (Сковорода Никита Андреевич) * http: - CVE-2016-5325 - Properly validate for allowable characters in the `reason` argument in `ServerResponse#writeHead()`. Fixes a possible response splitting attack vector. This introduces a new case where `throw` may occur when configuring HTTP responses, users should already be adopting try/catch here. Originally reported independently by Evan Lucas and Romain Gaucher. (Evan Lucas) - Invalid status codes can no longer be sent. Limited to 3 digit numbers between 100 - 999. Lack of proper validation may also serve as a potential response splitting attack vector. Backported from v4.x. (Brian White) * openssl: Upgrade to 1.0.1u, fixes a number of defects impacting Node.js: CVE-2016-6304 ("OCSP Status Request extension unbounded memory growth", high severity), CVE-2016-2183, CVE-2016-6303, CVE-2016-2178 and CVE-2016-6306. * tls: CVE-2016-7099 - Fix invalid wildcard certificate validation check whereby a TLS server may be able to serve an invalid wildcard certificate for its hostname due to improper validation of `*.` in the wildcard string. Originally reported by Alexander Minozhenko and James Bunton (Atlassian). (Ben Noordhuis) PR-URL: https://github.com/nodejs/node-private/pull/71
-
- Sep 27, 2016
-
-
Rod Vagg authored
Compile out hardware engines. `ENGINE_load_builtin_engines()` is not called in v0.10 so this does not represent a known security vulnerability. Backport of https://github.com/nodejs/node-private/pull/58 PR-URL: https://github.com/nodejs/node-private/pull/68 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Сковорода Никита Андреевич authored
This makes sure that no uninitialized bytes are leaked when the specified `totalLength` input value is greater than the actual total length of the specified buffers array, e.g. in Buffer.concat([Buffer.alloc(0)], 100). PR-URL: https://github.com/nodejs/node-private/pull/67 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Ben Noordhuis authored
Use unsigned types for size calculations. Fixes a warning that was drowning out everything else because zone-inl.h is included in every source file: ../deps/v8/src/zone-inl.h: In member function 'void* v8::internal::Zone::New(int)': ../deps/v8/src/zone-inl.h:61:32: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] if (limit < position || size > limit - position) { PR-URL: https://github.com/nodejs/node-private/pull/62 Reviewed-By:Rod Vagg <rod@vagg.org>
-
Ben Noordhuis authored
Shifting a negative constant value is no longer allowed unless the -fpermissive flag is in effect. Fixes the following build errors: ../deps/v8/src/objects.h:5188:47: warning: left shift of negative value [-Wshift-negative-value] static const int kElementsKindMask = (-1 << kElementsKindShift) & ../deps/v8/src/objects.h:5188:44: error: left operand of shift expression '(-1 << 3)' is negative [-fpermissive] static const int kElementsKindMask = (-1 << kElementsKindShift) & ../deps/v8/src/objects.h:7376:39: warning: left shift of negative value [-Wshift-negative-value] (~kMaxCachedArrayIndexLength << kArrayIndexHashLengthShift) | ../deps/v8/src/objects.h:7376:36: error: left operand of shift expression '(-8 << 26)' is negative [-fpermissive] (~kMaxCachedArrayIndexLength << kArrayIndexHashLengthShift) | And: ../deps/v8/src/liveedit.cc:205:44: warning: left shift of negative value [-Wshift-negative-value] static const int kEmptyCellValue = -1 << kDirectionSizeBits; ../deps/v8/src/liveedit.cc:205:41: error: left operand of shift expression '(-1 << 2)' is negative [-fpermissive] static const int kEmptyCellValue = -1 << kDirectionSizeBits; PR-URL: https://github.com/nodejs/node-private/pull/62 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Ben Noordhuis authored
Incorporates changes from commit e3452535 ("tls: better error reporting at cert validation") to test/simple/test-tls-check-server-identity.js to make back-porting the patch easier. CVE-2016-7099 PR-URL: https://github.com/nodejs/node-private/pull/62 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Evan Lucas authored
Previously, the reason argument passed to ServerResponse#writeHead was not being properly validated. One could pass CRLFs which could lead to http response splitting. This commit changes the behavior to throw an error in the event any invalid characters are included in the reason. CVE-2016-5325 PR-URL: https://github.com/nodejs/node-private/pull/48 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Evan Lucas authored
Back port of https://github.com/nodejs/node/commit/7e9b0dd6949aaa6afda4da9f41e1d60d9b to v0.12 PR-URL: https://github.com/nodejs/node-private/pull/48 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Shigeki Ohtsu authored
In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. (cherry picked from commit 9f0f7c38e6df975dd39735d0e9ef968076369c74) Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25368
-
Shigeki Ohtsu authored
reapply b9106137 PR: #9451 PR-URL: https://github.com/joyent/node/pull/9451 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR: #25523 PR-URL: https://github.com/joyent/node/pull/25523 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm> PR: #25654 PR-URL: https://github.com/joyent/node/pull/25654 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
Fedor Indutny authored
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . PR: #9451 PR-URL: https://github.com/joyent/node/pull/9451 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR: #25523 PR-URL: https://github.com/joyent/node/pull/25523 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm> PR: #25654 PR-URL: https://github.com/joyent/node/pull/25654 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
Shigeki Ohtsu authored
sha256-x86_64.pl does not exist in the origin openssl distribution. It was copied from sha512-x86_64.pl and both sha256/sha512 scripts were modified so as to generates only one asm file specified as its key hash length. PR: #9451 PR-URL: https://github.com/joyent/node/pull/9451 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR: #25523 PR-URL: https://github.com/joyent/node/pull/25523 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm> PR: #25654 PR-URL: https://github.com/joyent/node/pull/25654 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
Shigeki Ohtsu authored
All symlink files in `deps/openssl/openssl/include/openssl/` are removed and replaced with real header files to avoid issues on Windows. Two files of opensslconf.h in crypto and include dir are replaced to refer config/opensslconf.h. PR-URL: https://github.com/nodejs/node/pull/8718 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Myles Borins <mborins@us.ibm.com>
-
Shigeki Ohtsu authored
This just replaces all sources of openssl-1.0.1u.tar.gz into deps/openssl/openssl. PR-URL: https://github.com/nodejs/node/pull/8718 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Myles Borins <mborins@us.ibm.com>
-
- Jun 24, 2016
-
-
Ben Noordhuis authored
Work around spec violations in V8 where it checks that `this == NULL`. GCC 6 started exploiting this particular kind of UB, resulting in runtime crashes. Fixes: https://github.com/nodejs/node/issues/6724 PR-URL: https://github.com/nodejs/node/pull/6738 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Rod Vagg authored
-
- Jun 23, 2016
-
-
Rod Vagg authored
This is a security release. All Node.js users should consult the security release summary at https://nodejs.org/en/blog/vulnerability/june-2016-security-releases/ for details on patched vulnerabilities. Notable changes: * libuv: (CVE-2014-9748) Fixes a bug in the read/write locks implementation for Windows XP and Windows 2003 that can lead to undefined and potentially unsafe behaviour. More information can be found at https://github.com/libuv/libuv/issues/515 or at https://nodejs.org/en/blog/vulnerability/june-2016-security-releases/. * V8: (CVE-2016-1669) Fixes a potential Buffer overflow vulnerability discovered in V8, more details can be found in the CVE CVE-2016-1669 at https://www.cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2016-1669 or at https://nodejs.org/en/blog/vulnerability/june-2016-security-releases/. Commits: * [3374f579] - deps: update libuv to 0.10.37 (Saúl Ibarra Corretgé) https://github.com/nodejs/node/pull/7293 * [fcb9145e] - deps: backport 3a9bfec from v8 upstream (Myles Borins) https://github.com/nodejs/node-private/pull/43 PR-URL: https://github.com/nodejs/node-private/pull/52
-
Saúl Ibarra Corretgé authored
Fixes: https://github.com/nodejs/node/issues/7199 Refs: https://github.com/nodejs/node/pull/2723 PR-URL: https://github.com/nodejs/node/pull/7293 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Myles Borins authored
Some of the logic from `zone.cc` is found in `zone-inl.h` in this release stream. Original commit message: Fix overflow issue in Zone::New When requesting a large allocation near the end of the address space, the computation could overflow and erroneously *not* grow the Zone as required. BUG=chromium:606115 LOG=y Review-Url: https://codereview.chromium.org/1930873002 Cr-Commit-Position: refs/heads/master@{#35903} PR-URL: https://github.com/nodejs/node-private/pull/43 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
- May 06, 2016
-
-
Rod Vagg authored
-
Rod Vagg authored
Notable changes: * npm: Correct erroneous version number in v2.15.1 code (Forrest L Norvell) https://github.com/nodejs/node/pull/5987 * openssl: Upgrade to v1.0.1t, addressing security vulnerabilities (Shigeki Ohtsu) https://github.com/nodejs/node/pull/6553 - Fixes CVE-2016-2107 "Padding oracle in AES-NI CBC MAC check" - Fixes CVE-2016-2105 "EVP_EncodeUpdate overflow" - See https://nodejs.org/en/blog/vulnerability/openssl-may-2016/ for full details
-
Forrest L Norvell authored
PR-URL: https://github.com/nodejs/node/pull/5987 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
- May 05, 2016
-
-
Shigeki Ohtsu authored
In openssl s_client on Windows, RAND_screen() is invoked to initialize random state but it takes several seconds in each connection. This added -no_rand_screen to openssl s_client on Windows to skip RAND_screen() and gets a better performance in the unit test of test-tls-server-verify. Do not enable this except to use in the unit test. (cherry picked from commit 9f0f7c38e6df975dd39735d0e9ef968076369c74) Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/joyent/node/pull/25368
-
Shigeki Ohtsu authored
Regenerate asm files with Makefile without CC and ASM envs. Fixes: https://github.com/nodejs/node/issues/6458 PR-URL: https://github.com/nodejs/node/pull/6553 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Shigeki Ohtsu authored
reapply b9106137 PR: #9451 PR-URL: https://github.com/joyent/node/pull/9451 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR: #25523 PR-URL: https://github.com/joyent/node/pull/25523 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm> PR: #25654 PR-URL: https://github.com/joyent/node/pull/25654 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
Fedor Indutny authored
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . PR: #9451 PR-URL: https://github.com/joyent/node/pull/9451 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR: #25523 PR-URL: https://github.com/joyent/node/pull/25523 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm> PR: #25654 PR-URL: https://github.com/joyent/node/pull/25654 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
Shigeki Ohtsu authored
sha256-x86_64.pl does not exist in the origin openssl distribution. It was copied from sha512-x86_64.pl and both sha256/sha512 scripts were modified so as to generates only one asm file specified as its key hash length. PR: #9451 PR-URL: https://github.com/joyent/node/pull/9451 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> PR: #25523 PR-URL: https://github.com/joyent/node/pull/25523 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm> PR: #25654 PR-URL: https://github.com/joyent/node/pull/25654 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
Shigeki Ohtsu authored
All symlink files in `deps/openssl/openssl/include/openssl/` are removed and replaced with real header files to avoid issues on Windows. Fixes: https://github.com/nodejs/node/issues/6458 PR-URL: https://github.com/nodejs/node/pull/6553 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Shigeki Ohtsu authored
This just replaces all sources of openssl-1.0.1t.tar.gz into deps/openssl/openssl. Fixes: https://github.com/nodejs/node/issues/6458 PR-URL: https://github.com/nodejs/node/pull/6553 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Apr 01, 2016
-
-
Rod Vagg authored
-
Rod Vagg authored
Notable changes: * npm: Upgrade to v2.15.1. IMPORTANT: This is a major upgrade to npm v2 LTS from the previously deprecated npm v1. (Forrest L Norvell) * npm: Upgrade to v2.15.1. Fixes a security flaw in the use of authentication tokens in HTTP requests that would allow an attacker to set up a server that could collect tokens from users of the command-line interface. Authentication tokens have previously been sent with every request made by the CLI for logged-in users, regardless of the destination of the request. This update fixes this by only including those tokens for requests made against the registry or registries used for the current install. IMPORTANT: This is a major upgrade to npm v2 LTS from the previously deprecated npm v1. (Forrest L Norvell) https://github.com/nodejs/node/pull/5967 * openssl: OpenSSL v1.0.1s disables the EXPORT and LOW ciphers as they are obsolete and not considered safe. This release of Node.js turns on `OPENSSL_NO_WEAK_SSL_CIPHERS` to fully disable the 27 ciphers included in these lists which can be used in SSLv3 and higher. Full details can be found in our LTS discussion on the matter (https://github.com/nodejs/LTS/issues/85). (Shigeki Ohtsu) https://github.com/nodejs/node/pull/5712 PR-URL: https://github.com/nodejs/node/pull/5968
-
Forrest L Norvell authored
PR-URL: https://github.com/nodejs/node/pull/5968
-
- Mar 15, 2016
-
-
Shigeki Ohtsu authored
DES-CBC-SHA is LOW cipher and disabled by default and it is used in tests of hornorcipherorder. They are changed as to - use RC4-SHA instead of DES-CBC-SHA. - add AES128-SHA to entries to keep the number of ciphers. - remove tests for non-default cipher because only SEED and IDEA are available in !RC4:!HIGH:ALL. Fixes: https://github.com/nodejs/LTS/issues/85 PR-URL: https://github.com/nodejs/node/pull/5712 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Shigeki Ohtsu authored
openssl-1.0.1s disables EXPORT and LOW ciphers by default. They are obsoleted ciphers and not safe for the current use. Node LTS also deprecates them. Fixes: https://github.com/nodejs/LTS/issues/85 PR-URL: https://github.com/nodejs/node/pull/5712 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-