- Dec 26, 2015
-
-
Rich Trott authored
Some files in `lib` were using `require` to load modules that were subsequently not used in the file. This removes those `require` statements. PR-URL: https://github.com/nodejs/node/pull/4396 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rich Trott authored
Remove unused variable and refactor checking for event firing. PR-URL: https://github.com/nodejs/node/pull/4395 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
- Dec 25, 2015
-
-
Santiago Gimeno authored
Make sure the server is not closed until both responses have been received. PR-URL: https://github.com/nodejs/node/pull/3958 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
- Dec 24, 2015
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/4384 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rod Vagg authored
Allows more freedom in adding additional headings to addon.markdown, otherwise it'll try and convert each block under a heading to a test case. We need to have at least a .js and a .cc in order to have something to test. Fixes regression caused by adding a new 3rd-level heading in d5863bc0 PR-URL: https://github.com/nodejs/node/pull/4411 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Max Barinov authored
This http code allows us to provide a fair reason when we can't return some data to the client by legal issues. IETF https://datatracker.ietf.org/doc/draft-ietf-httpbis-legally-restricted-status/ Fixes: #4376 PR-URL: https://github.com/nodejs/node/pull/4377 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Adri Van Houdt authored
Fix: #4246 PR-URL: https://github.com/nodejs/node/pull/4315 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Jackson Tian authored
When create Buffer from a Buffer will copy data from old to new even though length is zero. This patch can improve edge case 4x faster. following is benchmark results. new: buffers/buffer_zero.js n=1024: 2463.53891 old: buffers/buffer_zero.js n=1024: 618.70801 PR-URL: https://github.com/nodejs/node/pull/4326 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jackson Tian authored
Use createBuffer to reduce new Uint8Array() and setPrototypeOf. PR-URL: https://github.com/nodejs/node/pull/4340 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
James M Snell authored
General improvements to buffer.markdown including new examples, a few fixes to existing examples, consistent formatting and others PR-URL: https://github.com/nodejs/node/pull/4370 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
James M Snell authored
General improvements to the documentation in addons.markdown. PR-URL: https://github.com/nodejs/node/pull/4320 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Santiago Gimeno authored
Check the stderr output in the `close` event as it's not guaranteed to be fully available when the `exit` event is fired. PR: #4364 PR-URL: https://github.com/nodejs/node/pull/4364 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
James M Snell authored
Maintenance Update Notable changes * Roughly 78% of the commits are documentation and test improvements * domains: - Fix handling of uncaught exceptions (Julien Gilli) [#3884](https://github.com/nodejs/node/pull/3884) * deps: - Upgrade to npm 2.14.12 (Kat Marchán) [#4110](https://github.com/nodejs/node/pull/4110) - Backport 819b40a from V8 upstream (Michaël Zasso) [#3938](https://github.com/nodejs/node/pull/3938) - Updated node LICENSE file with new npm license (Kat Marchán) [#4110](https://github.com/nodejs/node/pull/4110)
-
- Dec 23, 2015
-
-
Brian White authored
Without these changes, the pi1-raspbian-wheezy CI node was timing out on these tests. PR-URL: https://github.com/nodejs/node/pull/4387 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Fedor Indutny authored
https requests with different SNI values should not be sent over the same connection, even if the `host` is the same. Server may want to present different certificate or route the incoming TLS connection differently, depending on the received servername extension. Fix: https://github.com/nodejs/node/issues/3940 PR-URL: https://github.com/nodejs/node/pull/4389 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Mudit Ameta authored
If the deprecated NODE_REPL_HISTORY_FILE is set to default node history file path ($HOME/.node_repl_history) and the file doesn't exist, then node creates the file and then crashes when it tries to parse that file as JSON thinking that it's an older JSON formatted history file. This fixes that bug. This patch also prevents node repl from throwing if the old history file is empty or if $HOME/.node_repl_history is empty. Fixes: https://github.com/nodejs/node/issues/4102 PR-URL: https://github.com/nodejs/node/pull/4108 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Ali Ijaz Sheikh authored
These types are no longer used in the file and V8 4.9 no longer defines these types anymore. PR-URL: https://github.com/nodejs/node/pull/4381 Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
- Dec 22, 2015
-
-
Dave authored
socket.destroy() triggers a 'close' event from the socket which triggers the onClose handler of HTTPAgent which calls self.removeSocket(). So by calling self.removeSocket() prior to socket.destroy() we end up with two calls to self.removeSocket(). If there are pending requests, removeSocket ends up creating a new socket. So if there are pending requests, each time a request completes, we tear down one socket and create two more. So the total number of sockets grows exponentially and without regard for any maxSockets settings. This was noticed in https://github.com/nodejs/node/issues/4050. Let's get rid of the extra calls to removeSocket so we only call it once per completed request. PR-URL: https://github.com/nodejs/node/pull/4172 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Claudio Rodriguez authored
assert.deepEqual: when actual and expected are typed arrays, wrap them in a new Buffer each to increase performance significantly. PR-URL: https://github.com/nodejs/node/pull/4330 Fixes: https://github.com/nodejs/node/issues/4294 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Evan Lucas authored
String#repeat is quite a bit faster than new Array().join(). PR-URL: https://github.com/nodejs/node/pull/3900 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Dec 21, 2015
-
-
Jeremiah Senkpiel authored
Notable changes * openssl: Upgrade to 1.0.2d, fixes CVE-2015-1793 (Alternate Chains Certificate Forgery) https://github.com/nodejs/io.js/pull/2141.
-
Rod Vagg authored
Maintenance release Notable Changes: * v8: Fixed an out-of-band write in utf8 decoder. This is an important security update as it can be used to cause a denial of service attack. * openssl: - Upgrade to 1.0.2b and 1.0.2c, introduces DHE man-in-the-middle protection (Logjam) and fixes malformed ECParameters causing infinite loop (CVE-2015-1788). See the security advisory for full details. (Shigeki Ohtsu) #1950 #1958 * build: - Added support for compiling with Microsoft Visual C++ 2015 - Started building and distributing headers-only tarballs along with binaries -
Rod Vagg authored
Maintenance release Notable Changes: * crypto: significantly reduced memory usage for TLS (Fedor Indutny & Сковорода Никита Андреевич) #1529 * npm: Upgrade npm to 2.9.0. See the v2.8.4 and v2.9.0 release notes for details.
-
- Dec 20, 2015
-
-
Brian White authored
This provides more information when encountering a syntax or similar error when executing a file with require(). Fixes: https://github.com/nodejs/node/issues/4286 PR-URL: https://github.com/nodejs/node/pull/4287 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Brian White authored
On Windows there can exist some race condition where the notification of the client's `socket.destroy()` isn't received before the server writes to the socket. This race condition was more evident/reproducible on a single core system. This commit fixes the flakiness by waiting until the server's connection event handler has been called to destroy the client socket and perform the server socket write. Fixes: https://github.com/nodejs/node/issues/4057 PR-URL: https://github.com/nodejs/node/pull/4342 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
João Reis <reis@janeasystems.com>
-
- Dec 18, 2015
-
-
Fedor Indutny authored
Load the certificate chain from the PFX file the same as we do it for a regular certificate chain. Fix: #4127 PR-URL: https://github.com/nodejs/node/pull/4165 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Trevor Norris authored
Set process.env array entries in JS. PR-URL: https://github.com/nodejs/node/pull/3780 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
process.hrtime() was performing too many operations in C++ that could be done faster in JS. Move those operations over by creating a length 4 Uint32Array and perform bitwise operations on the seconds so that it was unnecessary for the native API to do any object creation or set any fields. This has improved performance from ~350 ns/op to ~65 ns/op. Light benchmark included to demonstrate the performance change. PR-URL: https://github.com/nodejs/node/pull/3780 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
Improve performance of process._getActiveHandles by sending handles in batches to JS to be set on the passed Array. Add test to check proper active handles are returned. Alter implementation of GetActiveRequests to match GetActiveHandles' implementation. PR-URL: https://github.com/nodejs/node/pull/3780 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
Improve performance by pushing directory entries to returned array in batches of 8 using pushValueToArray() in JS. Add benchmarks to demonstrate this improvement. PR-URL: https://github.com/nodejs/node/pull/3780 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
For performance add headers to the headers Array by pushing them on from JS. Benchmark added to demonstrate this case. PR-URL: https://github.com/nodejs/node/pull/3780 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
The initial implementation of setPropByIndex() set the value of an Array by index during development. Though the final form of the function simply pushes passed values to an array as passed by arguments. Thus the functions have been renamed to pushValueToArray() and push_values_to_array_function() respectively. Also add define for maximum number of arguments should be used before hitting the limit of performance increase. Fixes: 494227bb "node: improve GetActiveRequests performance" PR-URL: https://github.com/nodejs/node/pull/3780 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Fedor Indutny authored
Do not emit `upgrade` if the server is just advertising its protocols support as per RFC 7230 Section 6.7. A server MAY send an Upgrade header field in any other response to advertise that it implements support for upgrading to the listed protocols, in order of descending preference, when appropriate for a future request. Fix: https://github.com/nodejs/node/issues/4334 PR-URL: https://github.com/nodejs/node/pull/4337 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl>
-
Brian White authored
This fixes breakage introduced in 94b9948d when writing the max EventEmitter listeners warning to stderr. PR-URL: https://github.com/nodejs/node/pull/4279 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/4325 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ben Noordhuis authored
Fix a segmentation fault when the debug message handler was called from a context without an associated `node::Environment`. Fixes: https://github.com/nodejs/node/issues/4261 Fixes: https://github.com/nodejs/node/issues/4322 PR-URL: https://github.com/nodejs/node/pull/4328 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Bo Borgerson authored
This just removes an assignment to `ret` of a value that's not used before it's overwritten. Immediately following the assigment is an `if/else` in which both branches assign to `ret` without using it. PR-URL: https://github.com/nodejs/node/pull/4323 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
James M Snell authored
* Use single quotes consistently * Modernize examples to use template strings and arrow funcs * Fix a few typos * Example edits for consistency PR-URL: https://github.com/nodejs/node/pull/4282 Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Dec 17, 2015
-
-
chrisjohn404 authored
The buffer's write function is documented below the buf.toString function and all of the docs reference "buf" instead of "buffer". PR-URL: https://github.com/nodejs/node/pull/4324 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Nicholas Young authored
Update link from github.com/rvagg to github.com/nodejs PR-URL: https://github.com/nodejs/node/pull/4331 Reviewed-By:
James M Snell <jasnell@gmail.com>
-