- Apr 21, 2016
-
-
Ben Noordhuis authored
The BaseObject constructor and destructor should not have external linkage because BaseObject is a header-only construct. Add the necessary 'inline' keywords. PR-URL: https://github.com/nodejs/node/pull/6056 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
A handful of tests in `test/pummel` were failing due to undefined variables. The tests in pummel are not run in CI or otherwise exercised regularly so these failures can go unnoticed for a long time. PR-URL: https://github.com/nodejs/node/pull/6012 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Apr 16, 2016
-
-
Colin Ihrig authored
This commit adds support for passing DNS lookup hints to createConnection(). PR-URL: https://github.com/nodejs/node/pull/6000 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Conflicts: test/parallel/test-net-create-connection.js
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/5881 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Conflicts: lib/internal/bootstrap_node.js src/node.cc
-
- Apr 15, 2016
-
-
Anna Henningsen authored
Make sure that, even if an `inflate()` call only sees the first few bytes of a following gzip member, all members are decompressed and part of the full output. Adds tests for the special case that the first `inflate()` call receives only the first few bytes of a second gzip member but not the whole header (or even just the magic bytes). This is a backport of #5883 and contains additional changes to make sure that the behaviour on encountering trailing garbage remains the same (namely to silently discard it if one full member has already been decompressed). PR-URL: https://github.com/nodejs/node/pull/5973 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ben Noordhuis authored
Make the `num_values_` and `num_fields_` unsigned and remove an erroneous comment. PR-URL: https://github.com/nodejs/node/pull/5969 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ben Noordhuis authored
To prevent `ARRAY_SIZE(&arg)` (i.e., taking the array size of a pointer) from happening again. PR-URL: https://github.com/nodejs/node/pull/5969 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Apr 08, 2016
-
-
Vladimir Varankin authored
PR-URL: https://github.com/nodejs/node/pull/6076 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Klauke <romaaan.git@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Apr 06, 2016
-
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/6060
-
Myles Borins authored
Notable changes: http: * Enclose IPv6 Host header in square brackets. This will enable proper seperation of the host adress from any port reference (Mihai Potra) https://github.com/nodejs/node/pull/5314 path: * Make win32.isAbsolute more consistent (Brian White) https://github.com/nodejs/node/pull/6028 PR-URL: https://github.com/nodejs/node/pull/6060 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Robert Jefe Lindstaedt authored
this adds an example of a long running node process that actually executes node code. Also it mentions the not to harmonic detach behaviours of the different platforms, whereas detaching on unix requires ignoring the child_process' stdio explicitely. PR-URL: https://github.com/nodejs/node/pull/5330 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Matteo Collina authored
In the WORKING_GROUPS.md documentation, it is described how to start a wg, but not how to join an existing wg. This commit addresses that issue. Fixes: https://github.com/nodejs/node/issues/5448 PR-URL: https://github.com/nodejs/node/pull/5488 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
All JS files have been moved out of the `src` directory so the `.eslintrc` file in that directory can also be removed. PR-URL: https://github.com/nodejs/node/pull/5959 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Klauke <romankl@users.noreply.github.com>
-
Anna Henningsen authored
Do not convert typed arrays to `Buffer` for deepEqual since their values may not be accurately represented by 8-bit ints. Instead perform binary comparison of underlying `ArrayBuffer`s, but only when the array types match. Never apply any kind of optimization for floating-point typed arrays since bit pattern equality is not the right kind of check for them. PR-URL: https://github.com/nodejs/node/pull/5910 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Fixes: https://github.com/nodejs/node/issues/5907
-
Rich Trott authored
Use `global` to be explicit that a global variable is intended. PR-URL: https://github.com/nodejs/node/pull/6014 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
There was a comment in `test-domain-crypto.js` indicating that the pollution of the `global` object with a `domain` property was intentional. Provide more information in the comment so someone may easily determine why. Use `global.domain` rather than declaring `domain` without the `var` keyword to more clearly signal that the pollution is intentional. PR-URL: https://github.com/nodejs/node/pull/6017 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Santiago Gimeno authored
The value is retrieved from `process.arch` in node itself. PR-URL: https://github.com/nodejs/node/pull/5997 Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Rich Trott authored
The test intentionally assigns a global. Use `global` namespace to make it clear that it is intentional and not an accidental leak. PR-URL: https://github.com/nodejs/node/pull/6026 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Brian White authored
This commit fixes an inconsistency in absolute path checking compared to the absolute path detection used by the other path.win32 functions. Fixes: https://github.com/nodejs/node/issues/6027 PR-URL: https://github.com/nodejs/node/pull/6028 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Provide encrypted links to freenode IRC. PR-URL: https://github.com/nodejs/node/pull/6019 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Klauke <romaaan.git@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Rich Trott authored
Throw immediately on socket timeout rather than checking boolean in exit handler. PR-URL: https://github.com/nodejs/node/pull/6003 Fixes: https://github.com/nodejs/node/issues/5128 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/6029 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Use empty string instead of `www.google.com` for tests where we are just doing parameter evaluation. This will avoid DNS lookups which appear to be causing flakiness on Raspberry Pi devices in CI. PR-URL: https://github.com/nodejs/node/pull/5996 Fixes: https://github.com/nodejs/node/issues/5554 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/5986 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
James M Snell authored
Per https://github.com/nodejs/node/issues/1161, when the buf.write*() methods are given anything other than what they expect, indicate that the behavior is unspecified. Fixes: https://github.com/nodejs/node/issues/1161 PR-URL: https://github.com/nodejs/node/pull/5925 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com>
-
James M Snell authored
Clarify that the arguments to child_process.execFile and child_process.exec callback can be Buffer or strings. Fixes: https://github.com/nodejs/node/issues/3389 PR-URL: https://github.com/nodejs/node/pull/6015 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
firedfox authored
Includes cli.markdown in all.markdown PR-URL: https://github.com/nodejs/node/pull/6011 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rich Trott authored
`require-buffer` is only enabled in the `lib` directory. There is no need to disable it in `test`. PR-URL: https://github.com/nodejs/node/pull/6013 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/4350 PR-URL: https://github.com/nodejs/node/pull/6016 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Roman Klauke <romaaan.git@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/5525 PR-URL: https://github.com/nodejs/node/pull/6018 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Roman Klauke <romaaan.git@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Bryan English authored
Rather than attempting to keep two versions of docs for timers up to date, keep them in timers.markdown, and leave references to them in globals.markdown. Add setImmediate and clearImmediate to globals.markdown. Change "To schedule" to "Schedules" in timers.markdown. PR-URL: https://github.com/nodejs/node/pull/5837 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Santiago Gimeno authored
Remove timer to avoid the test timing out occasionally. PR-URL: https://github.com/nodejs/node/pull/5676 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com>
-
Johan Bergström authored
Introduce two new targets we will populate with actions once merged into all branches we need to support through CI. PR-URL: https://github.com/nodejs/node/pull/5921 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Mihai Potra authored
IPv6 addresses in Host header (URI), must be enclosed within square brackets, in order to properly separate the host address from any port reference. PR-URL: https://github.com/nodejs/node/pull/5314 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Rich Trott authored
`test-stdtout-close-unref.js` will fail if `process.stdin._handle` does not exist. On UNIX-like operating systems, you can see this failure this way: ./node test/parallel/test-stdout-close-unref.js < /dev/null This issue has been experienced by @bengl and @drewfish in a Docker container. I'm not sure why they are experiencing it in their environment, but since it is possible that the `_handle` property does not exist, let's use `child_process.spawn()` to make sure it exists. PR-URL: https://github.com/nodejs/node/pull/5916 Reviewed-By:Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Sakthipriyan Vairamani authored
Refer: https://github.com/nodejs/node/pull/5935 PR-URL: https://github.com/nodejs/node/pull/5980 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Phillip Johnsen <johphi@gmail.com>
-
Jeremiah Senkpiel authored
`<`-ing a file into stdin actually results in a `fs.ReadStream`, rather than a `tty.ReadStream`, and as such does not inherit from net.Socket, unlike the other possible stdin options. Refs: https://github.com/nodejs/node/pull/5916 PR-URL: https://github.com/nodejs/node/pull/5935 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
João Reis authored
Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/5936
-
Benjamin Gruenbaum authored
Refactor unused self=this code to code without without this pattern making it more consistent with the rest of our code. PR-URL: https://github.com/nodejs/node/pull/5857 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Roman Klauke <romankl@users.noreply.github.com>
-
- Apr 02, 2016
-
-
Vladimir Kurchatkin authored
If `kNoZeroFill` is set here, it won't be reset in case of pooled allocation. In case of "slow" allocation it will be set later anyway. Fixes: https://github.com/nodejs/node/issues/6006 PR-URL: https://github.com/nodejs/node/pull/6007 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-