- Aug 20, 2020
-
-
Frank Lemanschik authored
PR-URL: https://github.com/nodejs/node/pull/34786 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Denys Otrishko authored
Refs: https://github.com/nodejs/node/issues/34765 PR-URL: https://github.com/nodejs/node/pull/34795 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/34829 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Hilla Shahrabani authored
PR-URL: https://github.com/nodejs/node/pull/34800 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
There doesn't seem to be a reason for this test to have to stay in sequential. It appears to have been placed there out of caution. PR-URL: https://github.com/nodejs/node/pull/34755 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Michaël Zasso authored
Running outside of the main Node.js context prevents us from upgrading the WPT harness because new versions more aggressively check the identity of globals like error constructors. Instead of exposing globals used by the tests on vm sandboxes, use worker threads to run everything. PR-URL: https://github.com/nodejs/node/pull/34796 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Rich Trott authored
Documentation-only: Recommend people use the static methods on crypto.Certificate() and not the legacy API constructor. PR-URL: https://github.com/nodejs/node/pull/34697 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
-
Rich Trott authored
The text for the legacy API sends mixed signals. It's legacy, but still supported, so not deprecated, but not recommended. Let's begin to clarify this by removing "not recommended". If we want to not-recommend it, let's doc-deprecate it properly, or at least include an explanation as to why it's not recommended. PR-URL: https://github.com/nodejs/node/pull/34697 Reviewed-By:
-
Rich Trott authored
In test-http-destroyed-socket-write2, the assert.strictEqual() in the default case of the switch statement will always fail because it checks for a value that is already accounted for in one of the switch cases. Convert it to assert.fail(). PR-URL: https://github.com/nodejs/node/pull/34793 Reviewed-By:
-
Rich Trott authored
As best as I can tell, ERR_V8BREAKITERATOR is unused anywhere in our code base and dependencies. Move to legacy errors. PR-URL: https://github.com/nodejs/node/pull/34792 Reviewed-By:
-
- Aug 18, 2020
-
-
Anna Henningsen authored
The `set_abort_on_uncaught_exception(false)` line was supposed to prevent aborting when running Workers in `--abort-on-uncaught-exception` mode, but it was incorrectly set and not checked properly in the should-abort callback. PR-URL: https://github.com/nodejs/node/pull/34724 Backport-PR-URL: https://github.com/nodejs/node/pull/34815 Reviewed-By:
Mary Marchini <oss@mmarchini.me>
-
Anna Henningsen authored
This can currently be triggered when posting a closing FileHandle. Refs: https://github.com/nodejs/node/pull/34746#issuecomment-673675333 PR-URL: https://github.com/nodejs/node/pull/34766 Backport-PR-URL: https://github.com/nodejs/node/pull/34814 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/34070 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34782 Reviewed-By:
-
Mary Marchini authored
s/docs/doc/g Signed-off-by:
Mary Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/34811 Reviewed-By:
-
Mary Marchini authored
PR-URL: https://github.com/nodejs/node/pull/34739 Reviewed-By:
-
Luigi Pinca authored
Fixes: https://github.com/nodejs/node/issues/34787 PR-URL: https://github.com/nodejs/node/pull/34789 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Rich Trott authored
The three tests that use common.rootDir do not need the root dir. They just need an arbitrary directory that will exist. Use tmpdir.path instead. PR-URL: https://github.com/nodejs/node/pull/34772 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34769 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/node/pull/34727#issuecomment-672862034 PR-URL: https://github.com/nodejs/node/pull/34769 Reviewed-By:
-
davkor authored
Refs: https://github.com/google/oss-fuzz/pull/3860 Fixes: https://github.com/nodejs/node/issues/33724 PR-URL: https://github.com/nodejs/node/pull/34761 Fixes: https://github.com/nodejs/node/issues/33724 Reviewed-By:
-
Voltra authored
Reference format: `RFC <rfc id> <section path>` PR-URL: https://github.com/nodejs/node/pull/33671 Reviewed-By:
Pranshu Srivastava <rexagod@gmail.com> Reviewed-By:
-
Denys Otrishko authored
* use util.inspect for value presentation * allow to optionally specify error reason PR-URL: https://github.com/nodejs/node/pull/34671 Reviewed-By:
-
Derek Lewis authored
This patch converts the "read package scope" algorithm's while loop into a do-while loop enabling items at the filesystem root dir to be considered within the scope of a sibling package.json also at the filesystem root dir. Fixes: https://github.com/nodejs/node/issues/33438 Co-authored-by:
-
Mary Marchini authored
PR-URL: https://github.com/nodejs/node/pull/34737 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
João Reis authored
PR-URL: https://github.com/nodejs/node/pull/34721 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ash Cripps <ashley.cripps@ibm.com> Reviewed-By:
-
cjihrig authored
libuv 1.39.0 will begin requiring uv_setup_args() to be called before attempting to access the process title. This commit adds uv_setup_args() calls that were missing in order for the test suite to pass (and updates the documentation). PR-URL: https://github.com/nodejs/node/pull/34751 Reviewed-By:
-
Rich Trott authored
Many style guides (including Microsoft's) suggest avoiding _may_ because it can be unclear. Using _can_ or _might_ tends to increase clarity. An example in this change: > They may not change to a Runtime Deprecation until the next major > release. It's not clear if that means "They can not change until the next major release" or "They might not change until the next major release but also might change before then". Using _can_ or _might_ instead of _may_ clears up the ambiguity. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may PR-URL: https://github.com/nodejs/node/pull/34749 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Tobias Nießen authored
The previous code changed the private key of the ECDH object, but removed the public key if deriving it from the private key failed. Instead, if deriving the public key fails, neither the private nor the public key stored in the ECDH object should be updated. PR-URL: https://github.com/nodejs/node/pull/34302 Reviewed-By:
-
Anna Henningsen authored
Co-authored-by:
Jérémy Lal <kapouer@melix.org> Fixes: https://github.com/nodejs/node/issues/34699 PR-URL: https://github.com/nodejs/node/pull/34700 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Robert Nagy authored
Calling close on a file description which is currently in use is undefined behavior due to implementation details in libuv. Add a guard against this when using FileHandle. PR-URL: https://github.com/nodejs/node/pull/34746 Reviewed-By:
-
Anna Henningsen authored
It’s *so* hard to remember that it’s `UintXArray` but not `(write|read)UintX`. Let’s fix that by just providing aliases.
😊 PR-URL: https://github.com/nodejs/node/pull/34729 Reviewed-By: -
Matthew McEachen authored
Fixes: https://github.com/nodejs/node/issues/34736 PR-URL: https://github.com/nodejs/node/pull/34743 Reviewed-By:
-
Rich Trott authored
Let the check for the error code suffice and don't check for a particular string in the message. PR-URL: https://github.com/nodejs/node/pull/34727 Reviewed-By:
-
Mary Marchini authored
This is a (still experimental) implementation of a Commit Queue on GitHub Actions, using labels and the scheduler event to land Pull Requests. It uses `node-core-utils` to validate Pull Requests and to prepare the commit message, and then it uses a GitHub personal token to push changes back to the repository. If the Queue fails to land a Pull Request, that PR will be removed from the queue and the `node-core-utils` output will be pasted in the Pull Request. An overview of the implementation is provided in doc/guides/commit-queue.md, as well as current limitations. Ref: https://github.com/mmarchini-oss/automated-merge-test Ref: https://github.com/nodejs/build/issues/2201 PR-URL: https://github.com/nodejs/node/pull/34112 Refs: https://github.com/mmarchini-oss/automated-merge-test Refs: https://github.com/nodejs/build/issues/2201 Reviewed-By:
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/34414 Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/34744 Reviewed-By:
-
Yash Ladha authored
Added a benchmark script for process method to benchmark the method resourceUsage. PR-URL: https://github.com/nodejs/node/pull/34691 Reviewed-By:
-
Rich Trott authored
The collaborator guide uses both sentence case and headline case for headings. Use sentence case to conform with our style guide. PR-URL: https://github.com/nodejs/node/pull/34713 Reviewed-By:
-
Rich Trott authored
Use consistent capitalization in Consensus Seeking section, replace some _should_ usage with imperative, etc. PR-URL: https://github.com/nodejs/node/pull/34712 Reviewed-By:
-
