- Jan 12, 2017
-
-
Anna Henningsen authored
Add the nodejs/url github team to the table of people to /cc for reviews on the WHATWG URL code. PR-URL: https://github.com/nodejs/node/pull/10652 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/10616 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com>
-
Matteo Collina authored
The doc specified that writable.write() was advisory only. However, ignoring that value might lead to memory leaks. This PR specifies that behavior. Moreover, it adds an example on how to listen for the 'drain' event correctly. See: https://github.com/nodejs/node/commit/f347dad0b7b1787092cca88789b77eb3def2d319 PR-URL: https://github.com/nodejs/node/pull/10631 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
- Jan 11, 2017
-
-
Gibson Fahnestock authored
Extend no-restricted-properties to catch use of assert.equal() and assert.notEqual() and require assert.strictEqual() or assert.notStrictEqual() instead. Also update the eslint-ignore in lib/assert.js to avoid assert.equal/notEqual linter errors in their definitions. PR-URL: https://github.com/nodejs/node/pull/10698 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Teddy Katz <teddy.katz@gmail.com>
-
Gibson Fahnestock authored
Use assert.strictEqual instead of assert.equal in tests, manually convert types where necessary. PR-URL: https://github.com/nodejs/node/pull/10698 Reviewed-By:
-
Gibson Fahnestock authored
PR-URL: https://github.com/nodejs/node/pull/10685 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Gibson Fahnestock authored
Manually fix issues that eslint --fix couldn't do automatically. PR-URL: https://github.com/nodejs/node/pull/10685 Reviewed-By:
-
Kirill Fomichev authored
PR-URL: https://github.com/nodejs/node/pull/9395 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Andreas Lind authored
Refs: https://github.com/nodejs/node/issues/9324 PR-URL: https://github.com/nodejs/node/pull/9452 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
abouthiroppy authored
PR-URL: https://github.com/nodejs/node/pull/10701 Reviewed-By:
Italo A. Casas <me@italoacasas.com>
-
Rich Trott authored
The guide for writing tests is missing information on how tests are named. This adds that information. There is also some copy-editing done on the first paragraph of the guide. PR-URL: https://github.com/nodejs/node/pull/10584 Reviewed-By:
-
Johannes Rieken authored
Changing `..can result in expected` to `..can result in unexpected` Fixes: https://github.com/nodejs/node/issues/10710 PR-URL: https://github.com/nodejs/node/pull/10712 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
adelmann authored
* replace var with const/let * replace assert.equal() with assert.strictEqual() PR-URL: https://github.com/nodejs/node/pull/10622 Reviewed-By:
-
Anna Henningsen authored
Support `Uint8Array` input to all the synchronous methods. PR-URL: https://github.com/nodejs/node/pull/10653 Reviewed-By:
-
Myles Borins authored
git apply does not preserve the original commit message. These updated instructions offer a simpler flow for backporting. PR-URL: https://github.com/nodejs/node/pull/10665 Reviewed-By:
-
sivaprasanna authored
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions * removed console.log statements PR-URL: https://github.com/nodejs/node/pull/10684 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/10664 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/10664 Reviewed-By:
-
Rich Trott authored
* refactor internal util.filterDuplicateStrings() to eliminate unused code paths * `.indexOf()` -> `.includes()` in test * more concise arrow functions PR-URL: https://github.com/nodejs/node/pull/10682 Reviewed-By:
-
Evan Lucas authored
The COLLABORATOR_GUIDE was still listing v0.10 and v0.12 as LTS when they are EOL now. PR-URL: https://github.com/nodejs/node/pull/10720 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Jonathan Boarman authored
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: https://github.com/nodejs/node/pull/10686 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com>
-
Nathan Friedly authored
instead of silently overwriting invalid values with the default PR-URL: https://github.com/nodejs/node/pull/10692 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Nathan Friedly authored
This fixes a misplaced parenthesis in each of the tests in test/parallel/test-http-response-statuscodes.js, causing the tests to pass as long as any error was thrown, without validating the error message. PR-URL: https://github.com/nodejs/node/pull/10692 Reviewed-By:
-
abouthiroppy authored
PR-URL: https://github.com/nodejs/node/pull/10696 Reviewed-By:
-
Adrian Estrada authored
* use const and let instead of var * use assert.strictEqual or assert.strictDeepEqual instead of assert.equal * use arrow functions * swap assertions arguments to match the standard * validate the error for assert.throws PR-URL: https://github.com/nodejs/node/pull/10681 Reviewed-By:
-
- Jan 10, 2017
-
-
Sam Roberts authored
And allow anchor links to the various sections, to more easily reference them when reviewing PRs. PR-URL: https://github.com/nodejs/node/pull/10716 Reviewed-By:
-
Nikolai Vavilov authored
It is a maintenance burden that was removed from the docs in 2010 (c93e0aaf) and runtime-deprecated in v6.0 (1124de2d). PR-URL: https://github.com/nodejs/node/pull/9683 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Adrian Estrada authored
* use const instead of var * use assert.strictEqual instead of assert.equal and plain assert * use arrow functions * swap assertions arguments to match the standard * validate the error for assert.throws PR-URL: https://github.com/nodejs/node/pull/10667 Reviewed-By:
-
Lukasz Gasior authored
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: https://github.com/nodejs/node/pull/10669 Reviewed-By:
-
Gibson Fahnestock authored
Standardise on Refs: PR-URL: https://github.com/nodejs/node/pull/10670 Reviewed-By:
Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By:
-
sivaprasanna authored
* use const and let instead of var * use arrow function * removed console.log statements PR-URL: https://github.com/nodejs/node/pull/10679 Reviewed-By:
-
vitkarpov authored
Adding all used properties in the constructor makes the hidden class stable and heap snapshots more verbose. Refs: https://github.com/nodejs/node/issues/8912 PR-URL: https://github.com/nodejs/node/pull/9116 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
-
Rich Trott authored
Add test to cover setter for deprecated cluster Worker property. Previously, the setter was not being exercised in tests. PR-URL: https://github.com/nodejs/node/pull/10675 Reviewed-By:
-
Michael Lefkowitz authored
* use assert.strictEqual instead of assert.equal * add RegExp in second argument of assert.throws * validate error message and code PR-URL: https://github.com/nodejs/node/pull/10674 Reviewed-By:
-
sivaprasanna authored
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: https://github.com/nodejs/node/pull/10605 Reviewed-By:
-
cjihrig authored
This commit lets the uid and gid options of spawn() to be tested independently of one another based on the user's uid and gid. Fixes: https://github.com/nodejs/node/issues/10646 PR-URL: https://github.com/nodejs/node/pull/10647 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/10638 Reviewed-By:
-
Adrian Estrada authored
* use let and const instead of var * use assert.strictEqual instead of assert.equal * remove unused var PR-URL: https://github.com/nodejs/node/pull/10648 Reviewed-By:
-
Teddy Katz authored
This adds an ESLint rule to enforce the use of `assert.ifError(err)` instead of `if (err) throw err;` in tests. PR-URL: https://github.com/nodejs/node/pull/10671 Ref: https://github.com/nodejs/node/pull/10543 Reviewed-By:
-
cjihrig authored
Refs: https://github.com/nodejs/node/pull/10606 PR-URL: https://github.com/nodejs/node/pull/10636 Reviewed-By:
-
