- Sep 26, 2018
-
-
Rich Trott authored
Remove an unecessary string literal from assert.strictEqual() call in test-inspector.js. The string literal is printed instead of the value that causes an error. Removing the string literal allows the value that caused the error to be printed. This improves the troubleshooting experience when the test fails due to that assertion. Backport-PR-URL: https://github.com/nodejs/node/pull/22888 PR-URL: https://github.com/nodejs/node/pull/22849 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Vse Mozhet Byt authored
Conform return statements to the style guide and tool parsers. Also bring back a description fragment that seems to be erroneously deleted in https://github.com/nodejs/node/commit/1e07acd476309e7ddc4981160b89731b61a31179 Backport-PR-URL: https://github.com/nodejs/node/pull/22870 PR-URL: https://github.com/nodejs/node/pull/19853 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/22803 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
- Sep 13, 2018
-
-
cjihrig authored
This commit moves the printErr() function, used by the tick profiler processer, into the code string passed to vm.runInThisContext(). PR-URL: https://github.com/nodejs/node/pull/19285 Fixes: https://github.com/nodejs/node/issues/19260 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
- Sep 11, 2018
-
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/21593
-
Myles Borins authored
Notable Changes: * async_hooks: - rename PromiseWrap.parentId (Ali Ijaz Sheikh) https://github.com/nodejs/node/pull/18633 - remove runtime deprecation (Ali Ijaz Sheikh) https://github.com/nodejs/node/pull/19517 - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) https://github.com/nodejs/node/pull/18513 * cluster: - add cwd to cluster.settings (cjihrig) https://github.com/nodejs/node/pull/18399 - support windowsHide option for workers (Todd Wong) https://github.com/nodejs/node/pull/17412 * crypto: - allow passing null as IV unless required (Tobias Nießen) https://github.com/nodejs/node/pull/18644 * deps: - upgrade npm to 6.2.0 (Kat Marchán) https://github.com/nodejs/node/pull/21592 - upgrade libuv to 1.19.2 (cjihrig) https://github.com/nodejs/node/pull/18918 - Upgrade node-inspect to 1.11.5 (Jan Krems) https://github.com/nodejs/node/pull/21055 * fs,net: - support as and as+ flags in stringToFlags() (Sa...
-
- Sep 07, 2018
-
-
Anna Henningsen authored
This adds pairs of methods to the `Environment` class and to public APIs which can add and remove cleanup handlers. Unlike `AtExit`, this API targets addon developers rather than embedders, giving them (and Node\u2019s internals) the ability to register per-`Environment` cleanup work. We may want to replace `AtExit` with this API at some point. Many thanks for Stephen Belanger for reviewing the original version of this commit in the Ayo.js project. Refs: https://github.com/ayojs/ayo/pull/82 Backport-PR-URL: https://github.com/nodejs/node/pull/22435 PR-URL: https://github.com/nodejs/node/pull/19377 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Vse Mozhet Byt authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22388 PR-URL: https://github.com/nodejs/node/pull/19737 Reviewed-By:
-
Vse Mozhet Byt authored
We have two notes in API docs about Android support: the first has no links, the second links to the table of supported OSs where Android is not mentioned which may be confusing. This PR makes both notes link to dedicated Android part of BUILDING.md. Backport-PR-URL: https://github.com/nodejs/node/pull/22386 PR-URL: https://github.com/nodejs/node/pull/19004 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com>
-
Yihong Wang authored
When using shared lib build, the binary path in the stack frames points to shared lib. Change the checking criteria in the test case to match that. Refs: https://github.com/nodejs/node/issues/18535 Signed-off-by:
Yihong Wang <yh.wang@ibm.com> Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19213 Refs: https://github.com/nodejs/node/issues/18535 Reviewed-By:
-
Piotr Grzesik authored
This commit improves asserion messages in parallel/test-crypto-hash.js. Instead of just simple string literal, messages are changed to also include values used in assertion, which should improve debugging in case of errors. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18984 Reviewed-By:
-
Prince J Wesley authored
Below syntax errors are handled without force .break/clear - Unexpected Token (prefix errors) - missing ) after argument list In the multiline expression, recoverable errors are truly recoverable, otherwise syntax error will be thrown. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18915 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
Using `assert.doesNotThrow()` has no benefit over adding a comment next to some code that should not throw. Therefore it is from now on discouraged to use it. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18699 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rich Trott authored
In test-tls-wrap-event-emitter, the text of a TypeError is checked as part of the test. However, this text is generated by the JavaScript engine (V8) and not Node.js. Thus, we should not check the text as JS engine error messages can change without it being considered a breaking change for Node.js. A side effect is that node-chakracore will no longer need to patch this test to pass. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19215 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Rich Trott authored
test-performance can fail due to resource constraints. Move it from parallel to sequential so it does not compete with other tests for resources. Fixes: https://github.com/nodejs/node/issues/19197 Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19228 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
-
Ken Lin authored
Use arrow functions. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19130 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Tobias Nießen authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19238 Reviewed-By:
-
Rich Trott authored
Remove suggestion to avoid `readable` event and `readabe.read()` method. No explanation was provided for this suggestion. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19193 Reviewed-By:
Chen Gang <gangc.cxy@foxmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
-
Ali Ijaz Sheikh authored
Add a simple example showing how to use the inspector API to access the CPU profiler. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19172 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Joyee Cheung authored
On Windows with msys installation, `nm` is available but it is not able to grab symbols from the Windows build. Skipping the test if nm outputs anything to stderr fixes that. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19107 Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
-
Rich Trott authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19124 Reviewed-By:
-
Ujjwal Sharma authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19162 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Timothy Gu authored
Fixes: https://github.com/nodejs/node/issues/17892 Fixes: https://github.com/nodejs/node/issues/17893 Fixes: https://github.com/nodejs/node/issues/18992 Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18993 Reviewed-By:
-
Steven R. Loomis authored
iculslocs uses stdio, but didn't include the header. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19150 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
Currently test-http2-client-write-empty-string.js will throw "Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto support" when configured --without-ssl. This commit moves the require of http2 to after the crypto check to avoid this error. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19111 Reviewed-By:
-
Rich Trott authored
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19125 Reviewed-By:
-
Rich Trott authored
There are some uses of "in general" that are unnecessary. (We don't need to be tentative about the fact that tests should pass, for example.) Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19123 Reviewed-By:
-
punteek authored
Added a simple example showing how to rename a file. Refs: https://github.com/nodejs/node/issues11135 Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18812 Reviewed-By:
-
Zeke Sikelianos authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18888 Fixes: https://github.com/nodejs/node/issues/18887 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Richard Lau authored
libuv and zlib symbols are also purposefully re-exported by Node.js for use in Addons. Refs: https://github.com/nodejs/node/issues/17444 Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19013 Reviewed-By:
-
George Sapkin authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18080 Reviewed-By:
-
Vse Mozhet Byt authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19052 Reviewed-By:
-
Kyle Farnung authored
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19049 Reviewed-By:
-
Andrew Johnston authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18999 Reviewed-By:
-
Andrew Johnston authored
Tests in progress to reproduce issue consistently. Fixes: https://github.com/nodejs/node/issues/18756 Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18999 Reviewed-By:
-
Andrew Johnston authored
When socket is closed on a response for a request that is being piped to a stream there is a condition where aborted event will be fired to http client when socket is closing and the incomingMessage stream is still set to readable. We need a check for request being complete and to only raise the 'aborted' event on the http client if we have not yet completed reading the response from the server. Fixes: https://github.com/nodejs/node/issues/18756 Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18999 Reviewed-By:
-
Daniel Bevenius authored
There are two minor issues in the AsyncHook constructor, if the object passed in has an after and/or destroy property that are not functions the errors thrown will still be: TypeError [ERR_ASYNC_CALLBACK]: before must be a function This commit updates the code and adds a unit test. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/19000 Reviewed-By:
-
Wilson authored
Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18928 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By:
-
flickz authored
Fixes: https://github.com/nodejs/node/issues/18639 Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18716 Refs: https://github.com/nodejs/node/issues/18639 Reviewed-By:
-
陈刚 authored
`readable.push()` supports `undefined` in non-object mode, but it was not previously documented. Backport-PR-URL: https://github.com/nodejs/node/pull/22380 PR-URL: https://github.com/nodejs/node/pull/18283 Reviewed-By:
-
