- Apr 21, 2016
-
-
Brian White authored
This commit switches from the eslint command-line tool to a custom tool that uses eslint programmatically in order to perform linting in parallel and to display linting results incrementally instead of buffering them until the end. Fixes: https://github.com/nodejs/node/issues/5596 PR-URL: https://github.com/nodejs/node/pull/5638 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
Rich Trott authored
Enforce alignment/indentation on variable assignments that span multiple lines. PR-URL: https://github.com/nodejs/node/pull/6242 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Correct alignment on variable assignments that span multiple lines in preparation for lint rule to enforce such alignment. PR-URL: https://github.com/nodejs/node/pull/6242 Reviewed-By:
-
silverwind authored
PR-URL: https://github.com/nodejs/node/pull/6132 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
thefourtheye <thechargingvolcano@gmail.com>
-
silverwind authored
PR-URL: https://github.com/nodejs/node/pull/6132 Reviewed-By:
-
Santiago Gimeno authored
Make the servers listen on a free port number picked by the OS to avoid rare `EADDRINUSE` errors on `SmartOS`. Fixes: https://github.com/nodejs/node/issues/6197 PR-URL: https://github.com/nodejs/node/pull/6248 Reviewed-By:
-
Santiago Gimeno authored
Wait for the data to be received by the socket before creating the clean-up timer. This way, a possible (though unlikely) `ECONNRESET` error can be avoided. PR-URL: https://github.com/nodejs/node/pull/6166 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Ilya Shaisultanov authored
Special handling to detect when user has supplied a custom message. Added a test for user message. When testing if `actual` value is an error use `util.isError` instead of `instanceof`. Fixes: https://github.com/nodejs/node/issues/2385 PR-URL: https://github.com/nodejs/node/pull/2407 Reviewed-By:
-
abouthiroppy authored
PR-URL: https://github.com/nodejs/node/pull/6203 Reviewed-By:
-
William Kapke authored
PR-URL: https://github.com/nodejs/node/pull/6257 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Matthew Douglass authored
Removes the options block from the http 'response' event and attaches it to Agent#getName where it belongs. Removes socketPath and documents localAddress option. PR-URL: https://github.com/nodejs/node/pull/5993 Reviewed-By:
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/6020 Reviewed-By:
-
Steven R. Loomis authored
* Modify tools/license-builder.sh to support ICU 57.1's plain text license. (Separate issue to add ICU 57.1 in #6058) * Update/regenerate LICENSE to include ICU 57.1's license * Note that because the tool was rerun, the change in #6065 is already included here. PR-URL: https://github.com/nodejs/node/pull/6068 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
-
Mike Kaufman authored
This is created by vs 2015 for user & machine-specific files and should be ignored by git. PR-URL: https://github.com/nodejs/node/pull/6070 Reviewed-By:
-
Mike Kaufman authored
These files are created by VS 2015 and should be ignored by git. PR-URL: https://github.com/nodejs/node/pull/6070 Reviewed-By:
-
James M Snell authored
Provide an example for implementing browser like behavior for console.assert. This "fixes" https://github.com/nodejs/node/issues/5340 by providing an alternative to changing Node.js' implemented behavior. Instead, we document the differences and show how to work around them if browser like semantics are desired. Fixes: https://github.com/nodejs/node/issues/5340 PR-URL: https://github.com/nodejs/node/pull/6169 Reviewed-By:
Robert Jefe Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By: Jeff Harris <@techjeffharris>
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/6196 Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com>
-
Bryan English authored
Clarify in docs for require.cache that reloading native modules isn't supported. Related: #6160 PR-URL: https://github.com/nodejs/node/pull/6168 Reviewed-By:
-
Rich Trott authored
The message argument for `assert.fail()` is the third argument, not the first. Correct minor misuse in internal module. PR-URL: https://github.com/nodejs/node/pull/6211 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Alexander Makarenko authored
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`, `TypeError`, `URIError` to list of global types. Fix errors.markdown copy accordingly. Fixes: https://github.com/nodejs/node/issues/5325. PR-URL: https://github.com/nodejs/node/pull/5329 Reviewed-By:
-
Joran Dirk Greef authored
On Linux and OS X systems, `fs.watch()` resolves the watched path to an inode. This clarifies that `fs.watch()` watches the inode and not the path. If the inode of the path subsequently changes, `fs.watch()` will continue watching the original inode and events for the path will no longer be emitted. This is expected behavior. Fixes: https://github.com/nodejs/node/issues/5039 PR-URL: https://github.com/nodejs/node/pull/6099 Reviewed-By:
-
Rich Trott authored
Some vm tests are not in strict mode because they need to create and use global variables. By using `global.foo` instead of just `foo`, we can still enable strict mode. PR-URL: https://github.com/nodejs/node/pull/6209 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
Trevor Norris authored
Do to various reasons, outlined in the committed document, domains were only in core for 2 years before being deprecated. This outline explains why they received criticism from the community and never gained traction with module authors. Also included is an example script that accompanies the postmortem analysis. PR-URL: https://github.com/nodejs/node/pull/6159 Reviewed-By:
Kelvin Knighton <keltheceo@gmail.com> Reviewed-By:
-
Stefan Budeanu authored
PR-URL: https://github.com/nodejs/node/pull/6227 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Imran Iqbal authored
PR-URL: https://github.com/nodejs/node/pull/6226 Reviewed-By:
-
Santiago Gimeno authored
PR-URL: https://github.com/nodejs/node/pull/6225 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/6224 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/5172 Reviewed-By:
-
Kat Marchán authored
Upstream PR: https://github.com/npm/npm/pull/12310 PR-URL: https://github.com/nodejs/node/pull/6153 Reviewed-By:
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/6153 Reviewed-By:
-
Amery authored
PR-URL: https://github.com/nodejs/node/pull/6194 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Anna Henningsen authored
Change the regular expression that recognizes “simple” JS expressions to requiring that the full line needs to match it. Previously, in terms like `a().b.`, `b.` would be a partial match. This meant that completion would evaluate `b` and either fail with a `ReferenceError` or, if `b` was some global, return the properties of the global `b` object. PR-URL: https://github.com/nodejs/node/pull/6192 Reviewed-By:
-
Matteo Collina authored
net streams can request multiple chunks to be written in a synchronous fashion. If this is combined with cork/uncork, en error is currently thrown because of a regression introduced in: https://github.com/nodejs/node/commit/89aeab901ac9e34c79be3854f1aa41f2a4fb6888 (https://github.com/nodejs/node/pull/4354). Fixes: https://github.com/nodejs/node/issues/6154 PR-URL: https://github.com/nodejs/node/pull/6164 Reviewed-By:
Mathias Buus <mathiasbuus@gmail.com> Reviewed-By:
-
Fedor Indutny authored
Original commit message: tools: fix tickprocessor Cpp symbols on mac Despite man page documentation: -f Display the symbol table of a dynamic library flat (as one file not separate modules). `nm` on mac treats `-f` as a shorthand for `-format`. The `-f` argument does not seem to be required, so just remove it completely. (For `-format` documentation - see `nm --help` on mac). BUG= Review URL: https://codereview.chromium.org/1840633002 Cr-Commit-Position: refs/heads/master@{#35445} Fix: #5903 PR-URL: https://github.com/nodejs/node/pull/6179 Reviewed-By: -
Rich Trott authored
Reduce client connections from 10 to 4 in a test that is causing issues on Raspberry Pi 2 devices in CI. Fixes: https://github.com/nodejs/node/issues/5122 PR-URL: https://github.com/nodejs/node/pull/6138 Reviewed-By:
-
Sakthipriyan Vairamani authored
As Node.js expects either Python 2.6 or 2.7 installed to work properly, simplejson module is no longer necessary. It was included in Python 2.6 as the json module. PR-URL: https://github.com/nodejs/node/pull/6101 Reviewed-By:
-
Anna Henningsen authored
In 68990948 (https://github.com/nodejs/node/pull/2325), the conditions for increasing `readableState.awaitDrain` when writing to a piping destination returns false were changed so that they could not actually be met, effectively leaving `readableState.awaitDrain` with a constant value of 0. This patch changes the conditions to testing whether the stream for which `.write()` returned false is still a piping destination, which was likely the intention of the original patch. Fixes: https://github.com/nodejs/node/issues/5820 Fixes: https://github.com/nodejs/node/issues/5257 PR-URL: https://github.com/nodejs/node/pull/6023 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Myles Borins authored
Currently we include instructions on how to check the sha of a downloaded tar-ball, but do not include instruction on how to get the `SHA256.txt` file. This has led to confusion with people thinking that the SHA256.txt is included in that tarball. This commit includes instructions on how to use curl to download the `SHA256.txt` prior to the instructions on how to verify the sha. Refs: https://github.com/nodejs/help/issues/113 Refs: https://github.com/nodejs/help/issues/137 PR-URL: https://github.com/nodejs/node/pull/6120 Reviewed-By:
-
James M Snell authored
Clarify caveats on `maxBuffer` with regards to Unicode output. Refs: https://github.com/nodejs/node/issues/1901 PR-URL: https://github.com/nodejs/node/pull/6030 Reviewed-By:
-
Robert Jefe Lindstaedt authored
This commit refines the documentation around child.kill(), where kill attempts against shells will lead to unexpected results. Namely, on linux the child process of a child process will not terminate, when its parent gets terminated. This is different across the the platforms. PR-URL: https://github.com/nodejs/node/issues/2098 Reviewed-By:
-
