- Jan 22, 2016
-
-
Ali Ijaz Sheikh authored
Pick up V8 4.8 branch-head. This branch brings in @@isConcatSpreadable, @@toPrimitive and ToLength ES6 changes. For full details see: http://v8project.blogspot.de/2015/11/v8-release-48.html https://github.com/v8/v8/commit/fa163e2 Ref: https://github.com/nodejs/node/pull/4399 PR-URL: https://github.com/nodejs/node/pull/4785 Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Tom Atkinson authored
Parsers hold a reference to the socket associated with the request through onParserExecute. This must be removed when the parser is freed so that the socket can be garbage collected when destroyed. Regression introduced in commit 59b91f1 ("http_parser: consume StreamBase instance"). PR-URL: https://github.com/nodejs/node/pull/4773 Reviewed-By:Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
Rich Trott authored
* Exchange 20 millisecond timers for setImmediate(). * Do not attempt to unlink path that will have been guaranteed to be removed by `common.refreshTmpDir()` * Do not swallow errors thrown by failed creation of needed test subdirectory. If that happens, we want to know about it. * Use `common.isSunOS` in one place where it is applicable PR-URL: https://github.com/nodejs/node/pull/4776 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
José Moreira authored
Added a listening property into net.Server.prototype indicating if the server is listening or not for connections. Other Server constructors that rely on net.Server should also gain access to this property. Also included tests for net and http subsystems. PR-URL: https://github.com/nodejs/node/pull/4743 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Myles Borins authored
Notable changes: * Fix regression in debugger and profiler functionality PR-URL: https://github.com/nodejs/node/pull/4788 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
Rich Trott authored
Two cluster tests have recently changed so that they are no longer resource intensive. Move them back to parallel. Ref: https://github.com/nodejs/node/pull/4736 Ref: https://github.com/nodejs/node/pull/4739 PR-URL: https://github.com/nodejs/node/pull/4774 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
cjihrig authored
Event emitters support symbols as event names. The process object assumes that the event name is a string, and examines the first three characters to check for signals. This causes an exception if the event name is a symbol. This commit ensures that the event name is a string before trying to slice() it. PR-URL: https://github.com/nodejs/node/pull/4798 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Wyatt Preul <wpreul@gmail.com>
-
Robert Jefe Lindstaedt authored
This changes the code blocks from 4-space indentation to ``` fences for better syntax highlighting and future linting support. Minor On-the-fly changes for typos and highlight breaking markdown have been made. JSON-Style objects have been changed so their closing bracket is on the same line as the opening one. Known issues: * Not every JSON / object notation has been improved. Should make another run for this. * Some example functions break hightlighting due to various combinations of brackets. However changing them means leaving the code style. Fixes: https://github.com/nodejs/node/issues/4726 PR-URL: https://github.com/nodejs/node/pull/4733 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Jan 21, 2016
-
-
Stefan Budeanu authored
If the VARIATION variable is present, then make binary will produce archives named node-$(FULLVERSION)-$(PLATFORM)-$(ARCH)-$(VARIATION). PR-URL: https://github.com/nodejs/node/pull/4631 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Evan Lucas authored
Notable changes: * events: make sure console functions exist (Dave) https://github.com/nodejs/node/pull/4479 * fs: add autoClose option to fs.createWriteStream (Saquib) https://github.com/nodejs/node/pull/3679 * http: improves expect header handling (Daniel Sellers) https://github.com/nodejs/node/pull/4501 * node: allow preload modules with -i (Evan Lucas) https://github.com/nodejs/node/pull/4696 * v8,src: expose statistics about heap spaces (`v8.getHeapSpaceStatistics()`) (Ben Ripkens) https://github.com/nodejs/node/pull/4463 * Minor performance improvements: - lib: Use arrow functions instead of bind where possible (Minwoo Jung) https://github.com/nodejs/node/pull/3622 - module: cache stat() results more aggressively (Ben Noordhuis) https://github.com/nodejs/node/pull/4575 - querystring: improve parse() performance (Brian White) https://github.com/nodejs/node/pull/4675 PR-URL: https://github.com/nodejs/node/pull/4742
-
Ben Noordhuis authored
Fix a regression introduced in commit 89f056bd ("node: improve performance of hrtime()") where the nanosecond field sometimes had a negative value when calculating the difference between two timestamps. Fixes: https://github.com/nodejs/node/issues/4751 PR-URL: https://github.com/nodejs/node/pull/4757 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
Myles Borins authored
Notable changes: * assert - accommodate ES6 classes that extend Error (Rich Trott) https://github.com/nodejs/node/pull/4166 * build - add "--partly-static" build options (Super Zheng) https://github.com/nodejs/node/pull/4152 * deps - backport 066747e from upstream V8 (Ali Ijaz Sheikh) https://github.com/nodejs/node/pull/4655 - backport 200315c from V8 upstream (Vladimir Kurchatkin) https://github.com/nodejs/node/pull/4128 - upgrade libuv to 1.8.0 (Saúl Ibarra Corretgé) * docs - various updates landed in 70 different commits! * repl - attach location info to syntax errors (cjihrig) https://github.com/nodejs/node/pull/4013 - display error message when loading directory (Prince J Wesley) https://github.com/nodejs/node/pull/4170 * tests - various updates landed in over 50 commits * util - allow lookup of hidden values (cjihrig) https://github.com/nodejs/node/pull/3988 PR-URL: https://github.com/nodejs/node/pull/4768
-
- Jan 20, 2016
-
-
Richard Lau authored
PR-URL: https://github.com/nodejs/node/pull/4762 Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Richard Lau authored
Modify tools/license-builder.sh to restore the Third-Party Software licenses for ICU. Also fix arguments to tail to work on Linux. rvagg: modified sed command for ICU to replace tabs with spaces and remove whitespace at the end of lines PR-URL: https://github.com/nodejs/node/pull/4762 Reviewed-By:Rod Vagg <rod@vagg.org>
-
Rich Trott authored
Previously, test-cluster-disconnect-suicide-race had two issues: * Magic numbers: How many times to spawn a worker was determined through empirical experimentation. This means that as new platforms and new CPU/RAM configurations are tested, the magic numbers require more and more refinement. This brings us to... * Non-determinism: The test seems to fail all the time when the bug it tests for is present, but it's really a judgment based on sampling. "Oh, with 8 workers per CPU, it fails about 80% of the time. Let's try 16..." This revised version of the test takes a different approach. The fix for the bug that the test was written for means that the disconnect event will fire on a subsequent tick. So we check for that and the test still fails when the fix is not in the code base and succeeds when it is. Advantages of this approach include: * The test runs much faster. * The test should be reliable on any new platform regardless of CPU and RAM. PR-URL: https://github.com/nodejs/node/pull/4739 Ref: https://github.com/nodejs/node/pull/4674 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Evan Lucas authored
ReadableState has the resumeScheduled property that helps determine if a stream should be resumed. It was not assigned in the constructor. When stream.resume is called on a readable stream that is not flowing, it is set to true. This changes the property map of the ReadableState which can cause a deopt in onEofChunk and needMoreData. PR-URL: https://github.com/nodejs/node/pull/4761 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
- Jan 19, 2016
-
-
Roman Reiss authored
PR-URL: https://github.com/nodejs/node/pull/4753 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Roman Reiss authored
Ref: http://eslint.org/docs/rules/space-in-parens.html PR-URL: https://github.com/nodejs/node/pull/4753 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Rich Trott authored
Previously, test-cluster-disconnect-leak had two issues: * Magic numbers: How many times to spawn a worker was determined through empirical experimentation. This means that as new platforms and new CPU/RAM configurations are tested, the magic numbers require more and more refinement. This brings us to... * Non-determinism: The test *seems* to fail all the time when the bug it tests for is present, but it's really a judgment based on sampling. "Oh, with 8 workers per CPU, it fails about 80% of the time. Let's try 16..." This revised version of the test takes a different approach. The fix for the bug that the test was written for means that the `disconnect` event will fire reliably for a single worker. So we check for that and the test still fails when the fix is not in the code base and succeeds when it is. Advantages of this approach include: * The test runs much faster. * The test now works on Windows. The previous version skipped Windows. * The test should be reliable on any new platform regardless of CPU and RAM. Ref: https://github.com/nodejs/node/pull/4674 PR-URL: https://github.com/nodejs/node/pull/4736 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu>
-
cjihrig authored
This reverts commit bfb2cd0b. The bytesRead property, as implemented, tracks characters instead of bytes when using an identity encoding. Refs: https://github.com/nodejs/node/pull/4372 PR-URL: https://github.com/nodejs/node/pull/4746 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Evan Lucas authored
This gives us the ability to preload when using the node repl. This can be useful for doing things like creating aliases. Fixes: https://github.com/nodejs/node/issues/4661 PR-URL: https://github.com/nodejs/node/pull/4696 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Jackson Tian authored
Make the byteLength work correctly when input is Buffer. e.g: ```js // The incomplete unicode string Buffer.byteLength(new Buffer([0xe4, 0xb8, 0xad, 0xe6, 0x96])) ``` The old output: 9 The new output: 5 PR-URL: https://github.com/nodejs/node/pull/4738 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Ben Ripkens authored
Provide means to inspect information about the separate heap spaces via a callable API. This is helpful to analyze memory issues. Fixes: https://github.com/nodejs/node/issues/2079 PR-URL: https://github.com/nodejs/node/pull/4463 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Santiago Gimeno authored
In some conditions it can happen that the client-side socket is destroyed before the server-side socket has gracefully closed, thus causing a 'ECONNRESET' error in this socket. To solve this, also close gracefully in the client side. PR-URL: https://github.com/nodejs/node/pull/3966 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Jan 18, 2016
-
-
Kohei TAKATA authored
Remove a comment that has a word 'XXX'. And add a line to output debuglog of error. PR-URL: https://github.com/nodejs/node/pull/4690 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
cjihrig authored
AfterGetAddrInfo() can potentially return an empty array of results without setting an error value. The JavaScript layer expects the array to have at least one value if an error is not returned. This commit sets a UV_EAI_NODATA error when an empty result array is detected. Fixes: https://github.com/nodejs/node/issues/4545 PR-URL: https://github.com/nodejs/node/pull/4715 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Saúl Ibarra Corretgé <saghul@gmail.com>
-
Ben Noordhuis authored
It's possible there is already an existing error on OpenSSL's error stack that is unrelated to the EVP_DigestInit_ex() operation we just executed. Fixes: https://github.com/nodejs/node/issues/4221 PR-URL: https://github.com/nodejs/node/pull/4731 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Jan 17, 2016
-
-
Peter Geiss authored
Refs: https://github.com/nodejs/node/issues/4642 PR-URL: https://github.com/nodejs/node/pull/4719 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Evan Lucas authored
If one were to set NODE_REPL_HISTORY to a string that contains only a space (" "), then the history file would be created with that name which can cause problems are certain systems. PR-URL: https://github.com/nodejs/node/pull/4539 Reviewed-By:Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/2205 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/2205 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Jan 16, 2016
-
-
Rich Trott authored
Some variables are declared with var more than once in the same scope. This change reduces the declarations to one per scope. PR-URL: https://github.com/nodejs/node/pull/4633 Reviewed-By:
jasnell - James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
This reverts commit 7c603280. It is causing CI failures on Windows. Ref: https://github.com/nodejs/node/pull/4575 PR-URL: https://github.com/nodejs/node/pull/4679 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Rich Trott authored
This reverts commit 809bf5e3 ("change statSync to accessSync in realpathSync"). It was causing tests to fail on Windows CI. Ref: https://github.com/nodejs/node/pull/4575 PR-URL: https://github.com/nodejs/node/pull/4679 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ali Ijaz Sheikh authored
Pick up the latest fixes on the V8 4.7 branch https://github.com/v8/v8/compare/4.7.80.25...4.7.80.32 PR-URL: https://github.com/nodejs/node/pull/4699 Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By:
jasnell - James M Snell <jasnell@gmail.com> Reviewed-By:
targos - Michaël Zasso <mic.besace@gmail.com>
-
cjihrig authored
The previously listed default of 'http' is incorrect, and causes an error to be thrown. This commit changes it to the correct value of 'http:' Fixes: https://github.com/nodejs/node/issues/4712 PR-URL: https://github.com/nodejs/node/pull/4714 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Jan 15, 2016
-
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/4691 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Michael Theriot authored
PR-URL: https://github.com/nodejs/node/pull/4708 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Dave authored
If there's no global console cached, initialize it. Fixes: https://github.com/nodejs/node/issues/4467 PR-URL: https://github.com/nodejs/node/pull/4479 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Brian White authored
These changes improve parse() performance from ~11-30% on all of the existing querystring benchmarks. PR-URL: https://github.com/nodejs/node/pull/4675 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-