- Mar 03, 2018
-
-
Ruben Bridgewater authored
There are a lot of changes in this commit: 1) Remove the `noAssert` argument from all read and write functions. 2) Improve the performance of all read floating point functions significantly. This is done by switching to TypedArrays as the write floating point write functions. 3) No implicit type coercion for offset and byteLength anymore. 4) Adds a lot of tests. 5) Moves the read and write functions to the internal buffer file to split the files in smaller chunks. 6) Reworked a lot of existing tests. 7) Improve the performane of all all read write functions by using a faster input validation and by improving function logic. 8) Significantly improved the performance of all read int functions. This is done by using a implementation without a loop. 9) Improved error handling. 10) Rename test file to use the correct subsystem. PR-URL: https://github.com/nodejs/node/pull/18395 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18395 Reviewed-By:
-
Ruben Bridgewater authored
This ports the Buffer#write(Double|Float)(B|L)E functions to JS. This fixes a security issue concerning type confusion and fixes another possible crash in combination with `noAssert`. In addition to that it will also significantly improve the write performance. Fixes: https://github.com/nodejs/node/issues/12179 Fixes: https://github.com/nodejs/node/issues/8724 PR-URL: https://github.com/nodejs/node/pull/18395 Reviewed-By:
-
Ruben Bridgewater authored
The FIXME is obsolete as it was meant about a indentation issue that got fixed a long time ago. PR-URL: https://github.com/nodejs/node/pull/18395 Reviewed-By:
-
- Mar 02, 2018
-
-
Richard Lau authored
libuv and zlib symbols are also purposefully re-exported by Node.js for use in Addons. Refs: https://github.com/nodejs/node/issues/17444 PR-URL: https://github.com/nodejs/node/pull/19013 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
George Sapkin authored
PR-URL: https://github.com/nodejs/node/pull/18080 Reviewed-By:
-
Gabriel Schulhof authored
Passing a pointer to a static integer is sufficient for the test. PR-URL: https://github.com/nodejs/node/pull/19039 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Hitesh Kanwathirtha <hiteshk@microsoft.com>
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/19041 Reviewed-By:
-
Anna Henningsen authored
`async` and `bytes` are only interesting when the write is coming from JS, and unnecessary otherwise. Also, make all of the stream `Write*()` bindings use the same code for setting these, and upgrade to the non-deprecated versions. PR-URL: https://github.com/nodejs/node/pull/18963 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
XadillaX authored
Refs: https://github.com/nodejs/node/pull/18673 PR-URL: https://github.com/nodejs/node/pull/18924 Refs: https://github.com/nodejs/node/pull/18673 Refs: https://github.com/nodejs/node/blob/v9.5.0/src/node_http2.cc#L1481-L1484 Refs: https://github.com/nodejs/node/blob/v9.5.0/lib/_http_outgoing.js#L659-L661 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/18924 Fixes: https://github.com/nodejs/node/issues/18169 Refs: https://github.com/nodejs/node/pull/18673 Refs: https://github.com/nodejs/node/blob/v9.5.0/src/node_http2.cc#L1481-L1484 Refs: https://github.com/nodejs/node/blob/v9.5.0/lib/_http_outgoing.js#L659-L661 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
-
Anna Henningsen authored
Previously, if `session.destroy()` was called with an error object, the information contained in it would be discarded and a generic `ERR_HTTP2_STREAM_CANCEL` would be used for all pending streams. Instead, make the information from the original error object available. PR-URL: https://github.com/nodejs/node/pull/18988 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Make the test for pending deprecations work when the env var is set during the whole test suite run. PR-URL: https://github.com/nodejs/node/pull/18991 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Send a human-readable HTTP/1 response in case of an unexpected ALPN protocol. This helps with debugging this condition, since previously the only result of it would be a closed socket. PR-URL: https://github.com/nodejs/node/pull/18986 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/19053 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Rod Vagg authored
No additional commits. New version published due to a bad node-v9.7.0.pkg file that was published to nodejs.org in the previous release. Ref: https://github.com/nodejs/node/issues/19074 PR-URL: https://github.com/nodejs/node/pull/19081
-
Ruben Bridgewater authored
Due to code consolidation in https://github.com/nodejs/node/pull/7207 the isEncoding function got less strict. This commit makes sure isEncoding returns false for empty strings as before the consolidation. PR-URL: https://github.com/nodejs/node/pull/18790 Refs: https://github.com/nodejs/node/pull/7207 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
This focuses on the common case by making sure they are prioritized. It also changes some typeof checks to test for undefined since that is faster and it adds a benchmark. PR-URL: https://github.com/nodejs/node/pull/18790 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18790 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18790 Reviewed-By:
-
Ruben Bridgewater authored
1) This improves the performance for Buffer#fill by using shortcuts. 2) It also ports throwing errors to JS. That way they contain the proper error code. 3) Using negative `end` values will from now on result in an error instead of just doing nothing. 4) Passing in `null` as encoding is from now on accepted as 'utf8'. PR-URL: https://github.com/nodejs/node/pull/18790 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/19052 Reviewed-By:
-
Kyle Farnung authored
Directory symlinks in Windows require the 'dir' flag to be passed to create the symlink correctly. PR-URL: https://github.com/nodejs/node/pull/19049 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Glen Keane authored
PR-URL: https://github.com/nodejs/node/pull/18982 Refs: https://github.com/nodejs/node/issues/18971 Refs: https://github.com/nodejs/node/pull/18975 Refs: https://github.com/nodejs/node/pull/18945 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Jackson Tian <shyvo1987@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Glen Keane authored
This cleans up and removes lttng support completely. Recent discussion on a PR to deprecate lttng suggested that we remove it completely pending feedback from the TSC. This should be considered a non breaking change, as a recent PR reveals that compiling with this system has been broken for nearly two years. Refs: https://github.com/nodejs/node/issues/18971 Refs: https://github.com/nodejs/node/pull/18975 Refs: https://github.com/nodejs/node/pull/18945 PR-URL: https://github.com/nodejs/node/pull/18982 Reviewed-By:
-
Andrew Johnston authored
PR-URL: https://github.com/nodejs/node/pull/18999 Reviewed-By:
Shingo Inoue <leko.noor@gmail.com> Reviewed-By:
-
Andrew Johnston authored
Tests in progress to reproduce issue consistently. Fixes: https://github.com/nodejs/node/issues/18756 PR-URL: https://github.com/nodejs/node/pull/18999 Reviewed-By:
-
Andrew Johnston authored
When socket is closed on a response for a request that is being piped to a stream there is a condition where aborted event will be fired to http client when socket is closing and the incomingMessage stream is still set to readable. We need a check for request being complete and to only raise the 'aborted' event on the http client if we have not yet completed reading the response from the server. Fixes: https://github.com/nodejs/node/issues/18756 PR-URL: https://github.com/nodejs/node/pull/18999 Reviewed-By:
-
- Mar 01, 2018
-
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/18949 Fixes: https://github.com/nodejs/node/issues/18948 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
Ben Noordhuis authored
Look for symbol `node_register_module_v${NODE_MODULE_VERSION}` if the add-on didn't self-register. This can be used to create add-ons that support multiple Node.js versions from a single shared object. PR-URL: https://github.com/nodejs/node/pull/18934 Reviewed-By:Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Ben Noordhuis authored
Move some code around and clean up the DLib helper class as prep work for a follow-up commit. PR-URL: https://github.com/nodejs/node/pull/18934 Reviewed-By:
-
Rod Vagg authored
Notable Changes: * **libuv**: - Updated to libuv 1.19.2 (Colin Ihrig) [#18918](https://github.com/nodejs/node/pull/18918) * **src**: - Add initial support for Node.js-specific post-mortem metadata (Matheus Marchini) [#14901](https://github.com/nodejs/node/pull/14901) * **timers**: - The return value of `setImmediate()` now has `ref()` and `unref()` methods (Anatoli Papirovski) [#18139](https://github.com/nodejs/node/pull/18139) * **util**: - It is now possible to get the name for a numerical platform-specific error code as a string (Joyee Cheung) [#18186](https://github.com/nodejs/node/pull/18186) PR-URL: https://github.com/nodejs/node/pull/19040 Prepared-By:
-
killagu authored
PR-URL: https://github.com/nodejs/node/pull/18958 Fixes: https://github.com/nodejs/node/issues/18938 Ref: https://github.com/nodejs/build/pull/1145 Reviewed-By:
-
- Feb 28, 2018
-
-
Daniel Bevenius authored
There are two minor issues in the AsyncHook constructor, if the object passed in has an after and/or destroy property that are not functions the errors thrown will still be: TypeError [ERR_ASYNC_CALLBACK]: before must be a function This commit updates the code and adds a unit test. PR-URL: https://github.com/nodejs/node/pull/19000 Reviewed-By:
-
