- Jun 06, 2018
-
-
Mathias Buus authored
PR-URL: https://github.com/nodejs/node/pull/20998 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
"across version of Node.js" -> "across versions of Node.js" PR-URL: https://github.com/nodejs/node/pull/21137 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
ErnestoSalazar authored
PR-URL: https://github.com/nodejs/node/pull/21069 Reviewed-By:
Kyle Farnung <kfarnung@microsoft.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
-
ErnestoSalazar authored
PR-URL: https://github.com/nodejs/node/pull/21069 Reviewed-By:
-
Anatoli Papirovski authored
This test uses hardcoded ports, it should not be located in parallel. PR-URL: https://github.com/nodejs/node/pull/21144 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Rich Trott authored
Add minimal document for what to do when a Collaborator moves to Collaborator Emeritus or leaves the project. PR-URL: https://github.com/nodejs/node/pull/21103 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Lance Ball <lball@redhat.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com>
-
Eugene Ostroukhov authored
Remove some unused code from the WS server implementation and switch to smart pointers where possible. PR-URL: https://github.com/nodejs/node/pull/21070 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Jun 05, 2018
-
-
Anatoli Papirovski authored
To avoid a potential segfault when inside WeakCallback, store a reference to Environment inside DestroyParam. PR-URL: https://github.com/nodejs/node/pull/21099 Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Rich Trott authored
Split test-child-process-fork-net into test-child-process-fork-net-server and test-child-process-fork-net-socket. Rename test-child-process-fork-net2.js to test-child-process-fork-net.js. Refs: https://github.com/nodejs/node/pull/21012 PR-URL: https://github.com/nodejs/node/pull/21095 Reviewed-By:
-
Matheus Marchini authored
test-trace-events-fs-sync has been failing ocasinally on FreeBSD. While we don't have a fix, it should be marked as flaky. Ref: https://github.com/nodejs/node/issues/21038 PR-URL: https://github.com/nodejs/node/pull/21039 Refs: https://github.com/nodejs/node/issues/21038 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
- Jun 04, 2018
-
-
Masashi Hirano authored
Added tests buffer.js methods to write 48 bit value to improve test coverage. PR-URL: https://github.com/nodejs/node/pull/21061 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Masashi Hirano authored
Added test for string-decorater.lastChar to improve coverage. PR-URL: https://github.com/nodejs/node/pull/21084 Reviewed-By:
-
Tobias Nießen authored
This change requires all expected warnings to be specified along with their respective code and will raise an error if the code does not match. This also kind of fixes the behavior when the expected warning code was noWarnCode and there is an actual warning code. PR-URL: https://github.com/nodejs/node/pull/21075 Reviewed-By:
-
Anatoli Papirovski authored
Prevent an infinite loop if it's not possible to call into JS. PR-URL: https://github.com/nodejs/node/pull/21057 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Daniel Bevenius authored
The original commit 74e7a4a0 ("test: add basic WebAssembly test") references the source for test.wasm and while there are tools to go from wasm to wat but having the source viewable is helpful I think. PR-URL: https://github.com/nodejs/node/pull/21082 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
John-David Dalton <john.david.dalton@gmail.com>
-
Rich Trott authored
test-dns is in the internet suite and therefore is rarely run. (That will change soon. We will run internet tests nightly in CI.) Because it is infrequently run, it was not noticed that it no longer passes. (An error message has changed to provide more information.) This change fixes the test so it passes. PR-URL: https://github.com/nodejs/node/pull/21116 Reviewed-By:
-
Masashi Hirano authored
PR-URL: https://github.com/nodejs/node/pull/21115 Reviewed-By:
-
- Jun 03, 2018
-
-
Joyee Cheung authored
Before this commit, when the user calls methods on a closed or errored fs event watcher, they could hit a crash since the FSEventWrap in C++ land may have already been destroyed with the internal pointer set to nullptr. This commit makes sure that the user cannot hit crashes like that, instead the methods calling on a closed watcher will be noops. Also explicitly documents that the watchers should not be used in `close` and `error` event handlers. PR-URL: https://github.com/nodejs/node/pull/20985 Fixes: https://github.com/nodejs/node/issues/20738 Fixes: https://github.com/nodejs/node/issues/20297 Reviewed-By:
Ron Korving <ron@ronkorving.nl> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
It transpires that the extra bookkeeping in debug builds sometimes makes the increase in RSS go _just_ over the 5 MB limit, by fewer than 100 kB. Double the limit so we hopefully don't run into it any time again soon. The memory leak it tests for was one where RSS grew by hundreds of megabytes over the lifetime of the test; 5 vs. 10 MB is insignificant. Fixes: https://github.com/nodejs/node/issues/21076 PR-URL: https://github.com/nodejs/node/pull/21080 Refs: https://github.com/nodejs/node/issues/21076 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
-
Ben Noordhuis authored
Refs: https://github.com/nodejs/node/issues/21076 PR-URL: https://github.com/nodejs/node/pull/21080 Reviewed-By:
-
Anatoli Papirovski authored
Check stream._writableState.finished instead of stream.writable as the latter can lead to premature calls to destroy and dropped writes on busy processes. PR-URL: https://github.com/nodejs/node/pull/21051 Fixes: https://github.com/nodejs/node/issues/20750 Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/21109 Reviewed-By:
-
- Jun 02, 2018
-
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/21098 Reviewed-By:
-
Anna Henningsen authored
Previously, the typed arrays used in this test would not automatically be kept alive by the native handle when it’s using them, so the V8 garbage collector could collect them while they are still in use by the zlib module, leading to memory corruption. Fixes: https://github.com/nodejs/node/issues/20907 PR-URL: https://github.com/nodejs/node/pull/21077 Reviewed-By:
-
Miklos Suveges authored
Inline the needMoreData function since it has only one call place. Update the related comment. Add a test for the edge case where HWM=0 and state.length=0. Add a test for ReadableStream.read(n) method's edge case where n, HWM and state.length are all zero. This proves that there is no easy way to simplify the check at https://github.com/nodejs/node/blob/master/lib/_stream_readable.js#L440 Fixes: https://github.com/nodejs/node/issues/19893 Refs: https://github.com/nodejs/node/pull/19896 PR-URL: https://github.com/nodejs/node/pull/21009 Reviewed-By:
-
Rich Trott authored
This is a minor refactor of benchmark/assert/throws.js to reduce exceptions that need to be made for lint compliance. PR-URL: https://github.com/nodejs/node/pull/21030 Reviewed-By:
-
Rich Trott authored
This is a minor refactor of benchmark/assert/deepequal-typedarrays.js to reduce exceptions that need to be made for lint compliance. PR-URL: https://github.com/nodejs/node/pull/21030 Reviewed-By:
-
Rich Trott authored
This is a minor refactor of benchmark/assert/deepequal-set.js to reduce exceptions that need to be made for lint compliance. PR-URL: https://github.com/nodejs/node/pull/21030 Reviewed-By:
-
Rich Trott authored
This is a minor refactor of benchmark/assert/deepequal-prims-and-objs-big-loop.js to reduce exceptions that need to be made for lint compliance. PR-URL: https://github.com/nodejs/node/pull/21030 Reviewed-By:
-
Rich Trott authored
This is a minor refactor of benchmark/assert/deepequal-prims-and-objs-big-array-set.js to reduce exceptions that need to be made for lint compliance. PR-URL: https://github.com/nodejs/node/pull/21030 Reviewed-By:
-
Rich Trott authored
This is a minor refactor of benchmark/assert/deepequal-object.js to reduce exceptions that need to be made for lint compliance. PR-URL: https://github.com/nodejs/node/pull/21030 Reviewed-By:
-
Rich Trott authored
This is a minor refactor of benchmark/assert/deepequal-map.js to reduce exceptions that need to be made for lint compliance. PR-URL: https://github.com/nodejs/node/pull/21030 Reviewed-By:
-
Rich Trott authored
This is a minor refactor of benchmark/assert/deepequal-buffer.js to reduce exceptions that need to be made for lint compliance. PR-URL: https://github.com/nodejs/node/pull/21030 Reviewed-By:
-
Rich Trott authored
Prevent crypto benchmark files from running more than one benchmark during tests. PR-URL: https://github.com/nodejs/node/pull/21032 Reviewed-By:
-
Rich Trott authored
Add option to test-benchmark-timers such that all benchmark files return only a single set of results. (This helps prevent benchmark tests from taking a long time to run.) Alphabetize options in the file. PR-URL: https://github.com/nodejs/node/pull/21032 Reviewed-By:
-
Rich Trott authored
Pull requests that add new Collaborators should be labeled `notable-change`. Make a note of this in onboarding.md. PR-URL: https://github.com/nodejs/node/pull/21040 Reviewed-By:
-
Yuta Hiroto authored
PR-URL: https://github.com/nodejs/node/pull/21085 Reviewed-By:
-
Rich Trott authored
Remove promise to eventually link an example document to show level-one heading. The style guide has been fine without the example doc for a long time. The statement is already clear. And the style guide itself is an example. We don't link to examples of wrapping at 80 characters, for example. There's no need to link just to show what a level-one heading is. (And if level-one heading is unclear, then it may be preferable to improve the terminology rather than to link to an example.) PR-URL: https://github.com/nodejs/node/pull/21031 Reviewed-By:
-
Rich Trott authored
Instead of disabling all ESLint rules for two lines that require a violation of no-control-regex, disable only the no-control-regex rule. PR-URL: https://github.com/nodejs/node/pull/21041 Reviewed-By:
-
Rich Trott authored
POST_STATUS_TO_PR is checked/enabled by default so there is no longer a need to mention that it should be checked in onboarding.md. There is almost never a situation when it should be unchecked. PR-URL: https://github.com/nodejs/node/pull/21042 Reviewed-By:
-
