- Feb 26, 2016
-
-
Santiago Gimeno authored
This test was sometimes timing out in `OS X`. Remove the timeout and clean up the code. Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/5339
-
Andreas Madsen authored
PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Andreas Madsen authored
The benchmark runner spawns new processes for each configuration. The specific configuration is transfered by process.argv. This means that the values have to be parsed. As of right now only numbers and strings are parsed correctly. However other values such as objects where used. This fixes the benchmarks that used non-string/number values and prevents future issues by asserting the type. PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Andreas Madsen authored
url.js was broken since it didn't use the common.js runner. This fixes that issue by merging it with url-resolve.js, which also benchmarks url.resolve. PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Andreas Madsen authored
PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Phillip Johnsen authored
`vcbuild.bat` already supports both Visual Studio 2013 and 2015. PR-URL: https://github.com/nodejs/node/pull/5406 Reviewed-By:
Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Rich Trott authored
Remove out-of-date stability index material from `tools/doc/README.md`. The stability index is documented in `doc/api/documentation.markdown`. PR-URL: https://github.com/nodejs/node/pull/5421 Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Rich Trott authored
Add verbs to make sentence fragments less fragmentary. PR-URL: https://github.com/nodejs/node/pull/5399 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Stefan Budeanu authored
Default to FIPS off even in FIPS builds. Add JS API to check and control FIPS mode. Add command line arguments to force FIPS on/off. Respect OPENSSL_CONF variable and read the config. Add testing for new features. Fixes: https://github.com/nodejs/node/issues/3819 PR-URL: https://github.com/nodejs/node/pull/5181 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-by:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Stefan Budeanu authored
Add --node-args option that will pass arguments. PR-URL: https://github.com/nodejs/node/pull/5376 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Marc Cuva authored
Function name in code sample had the wrong capitalization. PR-URL: https://github.com/nodejs/node/pull/5306 Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Chinedu Francis Nwafili authored
Previous example didn't account for the 1 byte offset PR-URL: https://github.com/nodejs/node/pull/5282 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
- Feb 25, 2016
-
-
cjihrig authored
Currently, there is a check to ensure that the user either provides an object or a string to repl.start(). The string case is used to set a REPL prompt. However, a default of '> ' already exists, so forcing the user to specify a prompt is a bit redundant. This commit removes this restriction. Fixes: https://github.com/nodejs/node/issues/5385 PR-URL: https://github.com/nodejs/node/pull/5388 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Julian Duque <julianduquej@gmail.com>
-
cjihrig authored
util.isError() is the only remaining util.is*() method that depends on Object.prototype.toString() behavior. This commit notes the limitations of isError() related to @@toStringTag. Refs: https://github.com/nodejs/node/pull/2201 PR-URL: https://github.com/nodejs/node/pull/5414 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/5418 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/5418 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/5418 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Dirceu Pereira Tiegs authored
Remove indications that an error argument is sent to the `listen()` callback. Fixes: https://github.com/nodejs/node/issues/5345 PR-URL: https://github.com/nodejs/node/pull/5353 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ron Korving authored
The APIs are implemented but currently not documented. PR-URL: https://github.com/nodejs/node/pull/5402 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rod Vagg <rod@vagg.org>
-
Ben Noordhuis authored
It's documented as such but didn't actually behave that way. Bug introduced in commit 66fc8ca2 ("cluster: emit 'message' event on cluster master"), which is the commit that introduced the event. Fixes: https://github.com/nodejs/node/issues/5126 PR-URL: https://github.com/nodejs/node/pull/5361 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rod Vagg authored
Approved at CTC meeting https://github.com/nodejs/node/issues/5409 Reviewers are CTC members who voted for this. PR-URL: https://github.com/nodejs/node/pull/5275 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Chris Dickinson <chris@neversaw.us>
-
Rod Vagg authored
Approved at CTC meeting https://github.com/nodejs/node/issues/5409 Reviewers are CTC members who voted for this. PR-URL: https://github.com/nodejs/node/pull/5276 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Chris Dickinson <chris@neversaw.us>
-
Rod Vagg authored
Approved at CTC meeting https://github.com/nodejs/node/issues/5409 Reviewers are CTC members who voted for this. PR-URL: https://github.com/nodejs/node/pull/5277 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Chris Dickinson <chris@neversaw.us>
-
Rod Vagg authored
Approved at CTC meeting https://github.com/nodejs/node/issues/5409 Reviewers are CTC members who voted for this. PR-URL: https://github.com/nodejs/node/pull/5278 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Chris Dickinson <chris@neversaw.us>
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/4404 PR-URL: https://github.com/nodejs/node/pull/5379 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Rich Trott authored
The lint rule is there to avoid a circular-dependency issue that only applies to `/lib`. In preparation for linting `/benchmark`, apply that rule to `/lib` only to avoid churn in `/benchmark`. Refs: https://github.com/nodejs/node/issues/3983#issuecomment-158956113 PR-URL: https://github.com/nodejs/node/pull/5371 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
Rich Trott authored
Enable additional likely-uncontroversial lint rules: * `comma-dangle` set to prohibit dangling commas on objects and arrays that are defined on a single line. Multi-line definitions can use or omit a trailing comma. * `no-unused-labels` Prohibits defining a label that is not used. * `no-path-concat` Prohibits string-concatenation using i`__dirname` and `__filename`. Use `path.join()`, `path.resolve()`, or template strings instead. * `no-new-symbol` disallow use of `new` operator with `Symbol` object. Violating this rule would result in a `TypeError` at runtime.` PR-URL: https://github.com/nodejs/node/pull/5357 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
- Feb 24, 2016
-
-
Rod Vagg authored
* buffer: - You can now supply an encoding argument when filling a Buffer Buffer#fill(string[, start[, end]][, encoding]), supplying an existing Buffer will also work with Buffer#fill(buffer[, start[, end]]). See the API documentation for details on how this works. (Trevor Norris) #4935 - Buffer#indexOf() no longer requires a byteOffset argument if you also wish to specify an encoding: Buffer#indexOf(val[, byteOffset][, encoding]). (Trevor Norris) #4803 * child_process: spawn() and spawnSync() now support a 'shell' option to allow for optional execution of the given command inside a shell. If set to true, cmd.exe will be used on Windows and /bin/sh elsewhere. A path to a custom shell can also be passed to override these defaults. On Windows, this option allows .bat. and .cmd files to be executed with spawn() and spawnSync(). (Colin Ihrig) #4598 * http_parser: Update to http-parser 2.6.2 to fix an unintentionally strict limitation of allowable header characters. (James M Snell) #5237 * dgram: socket.send() now supports accepts an array of Buffers or Strings as the first argument. See the API docs for details on how this works. (Matteo Collina) #4374 * http: Fix a bug where handling headers will mistakenly trigger an 'upgrade' event where the server is just advertising its protocols. This bug can prevent HTTP clients from communicating with HTTP/2 enabled servers. (Fedor Indutny) #4337 * net: Added a listening Boolean property to net and http servers to indicate whether the server is listening for connections. (José Moreira) #4743 * node: The C++ node::MakeCallback() API is now reentrant and calling it from inside another MakeCallback() call no longer causes the nextTick queue or Promises microtask queue to be processed out of order. (Trevor Norris) #4507 * tls: Add a new tlsSocket.getProtocol() method to get the negotiated TLS protocol version of the current connection. (Brian White) #4995 * vm: Introduce new 'produceCachedData' and 'cachedData' options to new vm.Script() to interact with V8's code cache. When a new vm.Script object is created with the 'produceCachedData' set to true a Buffer with V8's code cache data will be produced and stored in cachedData property of the returned object. This data in turn may be supplied back to another vm.Script() object with a 'cachedData' option if the supplied source is the same. Successfully executing a script from cached data can speed up instantiation time. See the API docs for details. (Fedor Indutny) #4777 * performance: Improvements in: - process.nextTick() (Ruben Bridgewater) #5092 - path module (Brian White) #5123 - querystring module (Brian White) #5012 - streams module when processing small chunks (Matteo Collina) #4354 PR-URL: https://github.com/nodejs/node/pull/5295 -
Fedor Indutny authored
It looks like github appends commit log right after the template contents. Seeing this it does not look logical to ask for details first. This commit puts `Description of change` part to the end of the template. PR-URL: https://github.com/nodejs/node/pull/5378 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/4767 Refs: https://github.com/nodejs/docs/pull/38 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
Stephan Belanger <admin@stephenbelanger.com>
-
- Feb 23, 2016
-
-
cjihrig authored
The docs for assert.deepStrictEqual() do not currently mention that prototypes are compared for objects. This commit adds that information to the documentation. Fixes: https://github.com/nodejs/node/issues/5365 PR-URL: https://github.com/nodejs/node/pull/5367 Reviewed-By:
Robert Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By:
Benjamin Gruenbaum <inglor@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Fedor Indutny authored
Fix: #5246 PR-URL: https://github.com/nodejs/node/pull/5291 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Rich Trott authored
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to exhibit flakiness around 22 or so clients. Fixes: https://github.com/nodejs/node/issues/5184 PR-URL: https://github.com/nodejs/node/pull/5346 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Apply strict mode to benchmark code. PR-URL: https://github.com/nodejs/node/pull/5336 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Jeremiah Senkpiel authored
Fix: https://github.com/nodejs/node/issues/5351 Refs: https://github.com/nodejs/node/pull/4561 PR-URL: https://github.com/nodejs/node/pull/5352 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com>
-
cjihrig authored
This option allows an instance of net.Socket to be kept open in the sending process. Fixes: https://github.com/nodejs/node/issues/4271 PR-URL: https://github.com/nodejs/node/pull/5283 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
cjihrig authored
This commit adds an options object to process.send(). The same object is propagated to process._send(), the _handleQueue, and the send() and postSend() functions of the handle converter. Fixes: https://github.com/nodejs/node/issues/4271 PR-URL: https://github.com/nodejs/node/pull/5283 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Feb 22, 2016
-
-
Alexis Campailla authored
PR-URL: https://github.com/nodejs/node/pull/5304 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/5356 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Rich Trott authored
Add these rules: * no-restricted-modules: See http://eslint.org/docs/rules/no-restricted-modules. It has been configured to prohibit the use of the deprecated `sys` and `_linklist` modules. * no-new-require: See http://eslint.org/docs/rules/no-new-require * no-mixed-requires: http://eslint.org/docs/rules/no-mixed-requires PR-URL: https://github.com/nodejs/node/pull/5320 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-