- Oct 26, 2020
-
-
Rich Trott authored
The kbd element has already been added in the keybindings table, but we missed it in one line in the prose. PR-URL: https://github.com/nodejs/node/pull/35737 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
-
Shubham Parihar authored
PR-URL: https://github.com/nodejs/node/pull/35786 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Ricky Zhou <0x19951125@gmail.com>
-
- Oct 25, 2020
-
-
bcoe authored
Cleanup logic in Makefile for coverage. Update BUILDING.md accordingly. PR-URL: https://github.com/nodejs/node/pull/35767 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
ax1 authored
Indentation for #fs_fs_promises_api is level 2 but it should be level 3. PR-URL: https://github.com/nodejs/node/pull/35771 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
-
Rich Trott authored
Remove note indicating that the APIs can change at any time. This module migrated from Experimental to Stable 6 years ago (in io.js 1.4.2). PR-URL: https://github.com/nodejs/node/pull/35774 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Vse Mozhe Buty authored
PR-URL: https://github.com/nodejs/node/pull/35764 Reviewed-By:
-
Yash Ladha authored
Using the variable name in the comment and justifying the type seems redundant to me and instead it should defined the entity which it is acting, like in our case it is acting as a flag to control the flow in streams. PR-URL: https://github.com/nodejs/node/pull/35728 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Turner Jabbour authored
PR-URL: https://github.com/nodejs/node/pull/35437 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Pooja D.P authored
example code added to the process.setgroups() API doc property in process.md PR-URL: https://github.com/nodejs/node/pull/35738 Reviewed-By:
-
Momtchil Momtchev authored
We reinject when the sockets has already waiting data, remarked by @mildsunrise Co-authored-by:
Alba Mendez <me@alba.sh> PR-URL: https://github.com/nodejs/node/pull/35678 Reviewed-By:
-
Momtchil Momtchev authored
Reinject the data already received from the TLS socket when the HTTP2 client is attached with a delay Fixes: https://github.com/nodejs/node/issues/35475 PR-URL: https://github.com/nodejs/node/pull/35678 Reviewed-By:
-
Vincent Boivin authored
Allow the user to update the server settings after using http2.createSecureServer() or after using http2.createServer(). Fixes: https://github.com/nodejs/node/issues/35353 PR-URL: https://github.com/nodejs/node/pull/35383 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
ExE Boss authored
Fixes: https://github.com/nodejs/node/issues/35740 Refs: https://github.com/nodejs/node/pull/31553 Refs: https://github.com/nodejs/node/pull/32953 Refs: https://github.com/nodejs/node/pull/33991 Refs: https://github.com/nodejs/node/pull/34001 Refs: https://github.com/nodejs/node/pull/34055 Refs: https://github.com/nodejs/node/pull/34962 Co-authored-by:
Trivikram Kamat <trivikr.dev@gmail.com> Co-authored-by:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Pranshu Srivastava <rexagod@gmail.com> Reviewed-By:
-
Josh Dague authored
Fixes: https://github.com/nodejs/node/issues/34818 PR-URL: https://github.com/nodejs/node/pull/34824 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
- Oct 24, 2020
-
-
Momtchil Momtchev authored
The debug sprintf doesn't support %.* specifiers Fixes: https://github.com/nodejs/node/issues/35688 PR-URL: https://github.com/nodejs/node/pull/35694 Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Ian Sutherland authored
PR-URL: https://github.com/nodejs/node/pull/35683 Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
-
Lee, Bonggi authored
Signed-off-by:
Lee, Bonggi <iyabong@gmail.com> PR-URL: https://github.com/nodejs/node/pull/34964 Reviewed-By:
-
Antoine du Hamel authored
Refs: https://github.com/nodejs/node/pull/35525 PR-URL: https://github.com/nodejs/node/pull/35782 Reviewed-By:
-
Rich Trott authored
* Make the 7 instances of breakOnSigint text blocks consistent. * Use present tense. * Use kbd element for keystrokes. * Minor style edits. PR-URL: https://github.com/nodejs/node/pull/35692 Reviewed-By:
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35515 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
-
Yash Ladha authored
Fix duplicate logic in stream destroy as the same logic is being shared across methods and thus can be encapsulated into a single method. PR-URL: https://github.com/nodejs/node/pull/35727 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/35745 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
Myles Borins authored
Only imports has the experimental status right now but technically all ESM related features are currently experimental. The list also doesn't appear to be in any specific order so I've grouped the experimental features together. PR-URL: https://github.com/nodejs/node/pull/35741 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By:
-
- Oct 23, 2020
-
-
Rich Trott authored
Cherry-pick 12c8b4d1 Original commit message: This commit is a suggestion for adding a rule for NULL usages in the code base. This will currently report a number of errors which could be ignored using // NOLINT (readability/null_usage) PR-URL: https://github.com/nodejs/node/pull/17373 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Refs: https://github.com/nodejs/node/commit/12c8b4d15471cb6211b39c3a2ca5b10fa4b9f12b Cherry-pick fc81e801 Original commit message: Update cpplint.py to check for inline headers when the corresponding header is al...
-
Rich Trott authored
https://github.com/cpplint/cpplint/releases/tag/1.5.0 PR-URL: https://github.com/nodejs/node/pull/35719 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/35719 Reviewed-By:
-
- Oct 22, 2020
-
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/35750 Reviewed-By:
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35710 Reviewed-By:
-
Tierney Cyren authored
PR-URL: https://github.com/nodejs/node/pull/35712 Reviewed-By:
-
Joyee Cheung authored
Add a v8.stopCoverage() API to stop the coverage collection started by NODE_V8_COVERAGE - this would be useful in conjunction with v8.takeCoverage() if the user don't want to emit the coverage at the process exit but still want to collect it on demand at some point. PR-URL: https://github.com/nodejs/node/pull/33807 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Joyee Cheung authored
Add an v8.takeCoverage() API that allows the user to write the coverage started by NODE_V8_COVERAGE to disk on demand. The coverage can be written multiple times during the lifetime of the process, each time the execution counter will be reset. When the process is about to exit, one last coverage will still be written to disk. Also refactors the internal profiler connection code so that we use the inspector response id to identify the profile response instead of using an ad-hoc flag in C++. PR-URL: https://github.com/nodejs/node/pull/33807 Reviewed-By:
-
Benjamin Coe authored
Collect Windows and C++ coverage. Configure codecov so that comments are more concise and are only left when coverage varies. PR-URL: https://github.com/nodejs/node/pull/35670 Fixes: https://github.com/nodejs/node/issues/35696 Refs: https://github.com/nodejs/node/pull/35653 Refs: https://github.com/nodejs/node/issues/35646 Reviewed-By:
-
Brian 'bdougie' Douglas authored
Original commit message: parser: better error message for await+tla Bug: v8:9344, v8:6513 Change-Id: I1854e483515e7da99192367b6764a0ec7c8b41d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2411687 Reviewed-by:Marja Hölttä <marja@chromium.org> Commit-Queue: Gus Caplan <snek@chromium.org> Cr-Commit-Position: refs/heads/master@{#70099} Refs: https://github.com/v8/v8/commit/4263f8a5e8e04a766aeb7cde0081da3ac6c12a9e PR-URL: https://github.com/nodejs/node/pull/35650 Reviewed-By:
-
Beth Griggs authored
Notable changes: - **crypto**: fix regression on randomFillSync (James M Snell) (https://github.com/nodejs/node/pull/35723) - This fixes issue https://github.com/nodejs/node/issues/35722. - **deps**: upgrade npm to 7.0.3 (Ruy Adorno) (https://github.com/nodejs/node/pull/35724) - **doc**: add release key for Danielle Adams (Danielle Adams) (https://github.com/nodejs/node/pull/35545) PR-URL: https://github.com/nodejs/node/pull/35736
-
Joyee Cheung authored
This patch adds a --heapsnapshot-near-heap-limit CLI option that takes heap snapshots when the V8 heap is approaching the heap size limit. It will try to write the snapshots to disk before the program crashes due to OOM. PR-URL: https://github.com/nodejs/node/pull/33010 Refs: https://github.com/nodejs/node/issues/27552 Reviewed-By:
-
- Oct 21, 2020
-
-
Ruy Adorno authored
PR-URL: https://github.com/nodejs/node/pull/35724 Reviewed-By:
-
Michaël Zasso authored
The update to V8 8.6 already included the changes from that version, but it wasn't tagged yet. Having the wrong version in tree breaks node-core-utils. PR-URL: https://github.com/nodejs/node/pull/35732 Reviewed-By:
Beth Griggs <bgriggs@redhat.com>
-
Daniel Bevenius authored
This commit sets the OpenSSL error mark before calling X509_STORE_load_locations and pops the error mark afterwards. The motivation for this is that it is possible that X509_STORE_load_locations can produce errors if the configuration option --openssl-system-ca-path file does not exist. Later if a different function is called which calls an OpenSSL function it could fail because these errors might still be on the OpenSSL error stack. Currently, all functions that call NewRootCertStore clear the OpenSSL error queue upon returning, but this was not the case for example in v12.18.0. PR-URL: https://github.com/nodejs/node/pull/35514 Fixes: https://github.com/nodejs/node/issues/35456 Reviewed-By:
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/35707 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/35698 Reviewed-By:
-
