- Dec 15, 2012
- Dec 14, 2012
-
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
Significant performance impact
-
isaacs authored
It's too slow, unfortunately.
-
isaacs authored
The Array.forEach call is too expensive.
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
Also, organize the numeric settings a bit on the ReadableState class
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
-
isaacs authored
It was testing the length *before* adding the current chunk, which is the opposite of correct. Also, the return value was flipped.
-
isaacs authored
-
isaacs authored
-
isaacs authored
That is, the transform is triggered by a _read, not by a _write. This way, backpressure works properly.
-
isaacs authored
-