- Jun 16, 2018
-
-
Joseph Gordon authored
This change places the links to Writable stream and Readble stream in the order these sections appear when scrolling down the screen. PR-URL: https://github.com/nodejs/node/pull/21333 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
James M Snell authored
Set the thread name for workers in trace events. Also, use uint64_t for thread_id_ because there's really no reason for those to be doubles PR-URL: https://github.com/nodejs/node/pull/21246 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
James M Snell authored
While `perf_hooks` is still in experimental, remove less useful bootstrap milestones. PR-URL: https://github.com/nodejs/node/pull/21247 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/21247 Reviewed-By:
-
- Jun 15, 2018
-
-
Tobias Nießen authored
The old implementation silently failed in EVP_CipherInit_ex in EVP_CIPH_WRAP_MODE, this commit should fix that. PR-URL: https://github.com/nodejs/node/pull/21287 Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/21265 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Lance Ball <lball@redhat.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Rod Vagg authored
Pending OpenSSL 1.1.0i release. PR-URL: https://github.com/nodejs/node/pull/21282 Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By:
Guido Vranken <guidovranken@gmail.com> (cherry picked from commit 91f7361f47b082ae61ffe1a7b17bb2adf213c7fe) Reviewed-by:
Tim Hudson <tjh@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/6457)
-
Rich Trott authored
The Deprecation cycle explanation in the COLLABORATOR_GUIDE.md file is now more concise. PR-URL: https://github.com/nodejs/node/pull/21303 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Eugene Ostroukhov authored
It is now easily accessible from the Environment Reviewed-By:
-
James M Snell authored
Begin moving `process` object function definitions out of `node.cc` ... continuing the process of making `node.cc` smaller and easier to maintain. PR-URL: https://github.com/nodejs/node/pull/21105 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Michael Dawson authored
Clarify that calls to N-API should be avoided in the 'execute' callback. PR-URL: https://github.com/nodejs/node/pull/21217 Refs: https://github.com/nodejs/help/issues/1318 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/21255 Refs: https://github.com/nodejs/node/pull/21237 Reviewed-By:
-
Masashi Hirano authored
PR-URL: https://github.com/nodejs/node/pull/21248 Reviewed-By:
-
Jan Krems authored
Removes the prompt to report a bug when trying to launch the debugger using a port that is already in use. Changeset generated via: ``` rm -rf deps/node-inspect node-inspect-* && \ curl -sSL "https://github.com/nodejs/node-inspect/archive/v1.11.5.tar.gz" | \ tar -xzvf - && mv node-inspect-* deps/node-inspect ``` PR-URL: https://github.com/nodejs/node/pull/21055 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Rich Trott authored
Move 5 Collaborators to emeritus status. These particular five Collaborators have done some great stuff, but have been relatively inactive during the last two years or so. (They have been asked via email if they would like to remain Collaborators or more to Emeritus. This isn't a suddent thing.) PR-URL: https://github.com/nodejs/node/pull/21272 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
- Jun 14, 2018
-
-
djmgit authored
Removed unnecessary parameter from assert call in test/parallel/test-stream2-basic.js. Fixes: https://github.com/nodejs/node/issues/21305 PR-URL: https://github.com/nodejs/node/pull/21307 Reviewed-By:
-
Anna Henningsen authored
Wrapping libuv handles is what `HandleWrap` is there for. This allows a decent reduction of state tracking machinery by moving active-ness tracking to JS, and removing all interaction with garbage collection. Refs: https://github.com/nodejs/node/pull/21093 PR-URL: https://github.com/nodejs/node/pull/21244 Reviewed-By:
-
Anna Henningsen authored
Modify the `fs.watchFile()` async hooks test to be more accurate; currently, it relies on undocumented methods and the fact that they use `MakeCallback()` even though there is always a JS stack below. PR-URL: https://github.com/nodejs/node/pull/21244 Reviewed-By:
-
Anna Henningsen authored
Use field names rather than indices. Refs: https://github.com/nodejs/node/pull/21072 PR-URL: https://github.com/nodejs/node/pull/21240 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/21229 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
Anna Henningsen authored
This fixes a compiler warning on Windows. PR-URL: https://github.com/nodejs/node/pull/21323 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com>
-
Ujjwal Sharma authored
Replace the Buffer constructor with a FastBuffer in v8.deserialize in order to avoid calling the Buffer constructor and thus triggering a deprecation warning from code inside the core. Fixes: https://github.com/nodejs/node/issues/21181 PR-URL: https://github.com/nodejs/node/pull/21196 Fixes: https://github.com/nodejs/node/issues/21181 Reviewed-By:
-
Jon Moss authored
PR-URL: https://github.com/nodejs/node/pull/21275 Reviewed-By:
-
Anna Henningsen authored
At least one method on a native object is added as a getter, namely `MessagePort.prototype.onmessage`. When a MessagePort attempts to call this method from C++ in response to receiving data, it will first invoke that getter and then call the function. Since `worker.terminate()` interrupts execution, this means that the getter may fail (without being faulty code on its own). This means that at least one test exercising these methods in combination has been flaky and could have crashed, because we did not actually check that the getter returns a value so far, resulting in dereferencing an empty `Local`. The proper fix for this is to use the non-deprecated overload of `Get()` and check the result like we should be doing. Also, as a (related) fix, don’t crash if the method is not a function but rather something else, like a getter could provide. Example test failure: https://ci.nodejs.org/job/node-test-commit-linux-containered/4976/nodes=ubuntu1604_sharedlibs_zlib_x64/console 17:56:56 not ok 1955 parallel/test-worker-dns-terminate 17:56:56 --- 17:56:56 duration_ms: 1.237 17:56:56 severity: crashed 17:56:56 exitcode: -11 17:56:56 stack: |- PR-URL: https://github.com/nodejs/node/pull/21189 Reviewed-By:
-
Myles Borins authored
Have confirmed 1:1 that they are ok with this. PR-URL: https://github.com/nodejs/node/pull/21315 Reviewed-By:
Italo A. Casas <me@italoacasas.com> Reviewed-By:
-
- Jun 13, 2018
-
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/21150 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/21260 Refs: https://github.com/v8/v8/compare/6.7.288.45...6.7.288.46 Reviewed-By:
-
Ben Noordhuis authored
Rename it to validateArrayBufferView() to align with validateInt32() and friends. Swap the name and the value in the argument list for consistency, although any reasonable person will agree it's a crime against humanity to put the value before the name. PR-URL: https://github.com/nodejs/node/pull/20816 Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/20816 Reviewed-By:
-
Ben Noordhuis authored
Add scrypt functions to the list of exported openssl symbols. PR-URL: https://github.com/nodejs/node/pull/20816 Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/20816 Reviewed-By:
-
Ben Noordhuis authored
Use the scrypt() infrastructure to reimplement randomBytes() and randomFill() in a simpler manner. PR-URL: https://github.com/nodejs/node/pull/20816 Reviewed-By:
-
Ben Noordhuis authored
Use the scrypt() infrastructure to reimplement pbkdf2() in a simpler manner. PR-URL: https://github.com/nodejs/node/pull/20816 Reviewed-By:
-
Ben Noordhuis authored
Scrypt is a password-based key derivation function that is designed to be expensive both computationally and memory-wise in order to make brute-force attacks unrewarding. OpenSSL has had support for the scrypt algorithm since v1.1.0. Add a Node.js API modeled after `crypto.pbkdf2()` and `crypto.pbkdf2Sync()`. Changes: * Introduce helpers for copying buffers, collecting openssl errors, etc. * Add new infrastructure for offloading crypto to a worker thread. * Add a `AsyncWrap` JS class to simplify pbkdf2(), randomBytes() and scrypt(). Fixes: https://github.com/nodejs/node/issues/8417 PR-URL: https://github.com/nodejs/node/pull/20816 Reviewed-By:
-
Ben Noordhuis authored
Factor out some common code. The `checkUint()` function will also be used in a follow-up commit that adds scrypt support to core. PR-URL: https://github.com/nodejs/node/pull/20816 Reviewed-By:
-
Anna Henningsen authored
Right now, we crash the process if there are handles remaining on the event loop when we exit (except for the main thread). This does not provide a lot of information about causes, though; in particular, we don’t show which handles are pending and who own them. This patch adds debug output to these cases to help with the situation. PR-URL: https://github.com/nodejs/node/pull/21238 Reviewed-By:
-
Anna Henningsen authored
Use a single file, and a single interface, for inspecting symbols in the current process for debugging. PR-URL: https://github.com/nodejs/node/pull/21238 Reviewed-By:
-
Rich Trott authored
The CODEOWNERS file is not working out. It is not pinging any groups other than TSC (and more-or-less can't), and it pings TSC mostly for all the wrong things. It was a valiant effort, and possible worth revisiting at a future date when functionality is closer to what we need. But for now, let us bid it adieu. PR-URL: https://github.com/nodejs/node/pull/21161 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Rich Trott authored
Provide more concise explanations of the deprecation levels in COLLABORATOR_GUIDE.md. PR-URL: https://github.com/nodejs/node/pull/21241 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs-private/node-private/pull/117 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
