- Feb 25, 2018
-
-
Joyee Cheung authored
- Use assert to check mode in the Zlib constructor since it should only be passed by us. - Introduce checkRangesOrGetDefault() and checkFiniteNumber() to simplify type and range checking for numeric arguments - Instead of `ERR_INVALID_OPT_VALUE`, throw `ERR_OUT_OF_RANGE` and `ERR_INVALID_ARG_TYPE` with descriptions of the expected ranges or types to make the errors more user-friendly. - Add message tests for the changed errors PR-URL: https://github.com/nodejs/node/pull/18675 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
- Feb 24, 2018
-
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/18952 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Kyle Farnung authored
The root cause is that `req_wrap` is created in `StreamBase::Write` and passed to `TLSWrap::DoWrite`. In the TLS case the object gets disposed and replaced with a new instance, but the caller's pointer is never updated. When the `StreamBase::Write` method returns, it returns a pointer to the freed object to the caller. In some cases when the object memory has already been reused an assert is hit in `WriteWrap::SetAllocatedStorage` because the pointer is non-null. PR-URL: https://github.com/nodejs/node/pull/18860 Refs: https://github.com/nodejs/node/pull/18676 Reviewed-By:
-
estrada9166 authored
Add 80 characters limit to docs. Change docs to fit 80 characters per row. PR-URL: https://github.com/nodejs/node/pull/18726 Fixes: https://github.com/nodejs/node/issues/18703 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
- Feb 23, 2018
-
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/18918 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/18613 Reviewed-By:
-
Myles Borins authored
Notable changes: * events: - `events.usingDomains` being set to false by default was removed in 9.6.0 which was a change in behavior compared to 9.5.0. This behavior change has been reverted and the `events` object now has `usingDomains` preset to `false`, which is the behavior in 9.x prior to 9.6.0 (Myles Borins) https://github.com/nodejs/node/pull/18944 PR-URL: https://github.com/nodejs/node/pull/18946 -
Myles Borins authored
The line setting this was removed in a previous commit. This potentially breaks code in the wild using this property. Refs: https://github.com/nodejs/node/pull/17403#issuecomment-367814130 PR-URL: https://github.com/nodejs/node/pull/18944 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Rich Trott authored
No need to announce obvious example code as being example code. Remove unneeded "for example" text as one small way to try to keep the docs more concise.. PR-URL: https://github.com/nodejs/node/pull/18890 Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Luigi Pinca authored
Default behavior is to send a '400 Bad Request' response if the socket is writable. PR-URL: https://github.com/nodejs/node/pull/18885 Refs: https://github.com/nodejs/node/pull/15324 Reviewed-By:
-
Justin Lee authored
Remove link to the outdated members team PR-URL: https://github.com/nodejs/node/pull/18878 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
Fixes: https://github.com/nodejs/node/issues/18940 PR-URL: https://github.com/nodejs/node/pull/18941 Reviewed-By:
-
Jeremiah Senkpiel authored
Follow-up from https://github.com/nodejs/node/pull/18800 Code that tries to exercise tty fds must be placed in `/pseudo-tty/`. PR-URL: https://github.com/nodejs/node/pull/18886 Reviewed-By:
-
Myles Borins authored
Notable changes: * async_hooks: - deprecate unsafe emit{Before,After} (Ali Ijaz Sheikh) https://github.com/nodejs/node/pull/18513 - rename PromiseWrap.parentId to PromiseWrap.isChainedPromise (Ali Ijaz Sheikh) https://github.com/nodejs/node/pull/18633 * deps: - update node-inspect to 1.11.3 (Jan Krems) https://github.com/nodejs/node/pull/18354 - ICU 60.2 bump (Steven R. Loomis) https://github.com/nodejs/node/pull/17687 - Introduce ScriptOrModule and HostDefinedOptions to V8 (Jan Krems) https://github.com/nodejs/node/pull/16889 * http: - add options to http.createServer() for `IncomingMessage` and `ServerReponse` (Peter Marton) https://github.com/nodejs/node/pull/15752 * http2: - add http fallback options to .createServer (Peter Marton) https://github.com/nodejs/node/pull/15752 * https: - Adds the remaining options from tls.createSecureContext() to the string generated by Agent#getName(). This allows https.request() to accept the options and generate unique sockets appropriately. (Jeff Principe) https://github.com/nodejs/node/pull/16402 * inspector: - --inspect-brk for es modules (Guy Bedford) https://github.com/nodejs/node/pull/18194 * lib: - allow process kill by signal number (Sam Roberts) https://github.com/nodejs/node/pull/16944 * module: - enable dynamic import (Myles Borins) https://github.com/nodejs/node/pull/18387 - dynamic import is now supported (Jan Krems) https://github.com/nodejs/node/pull/15713 * napi: - add methods to open/close callback scope (Michael Dawson) https://github.com/nodejs/node/pull/18089 * src: - allow --perf-(basic-)?prof in NODE_OPTIONS (Leko) https://github.com/nodejs/node/pull/17600 * vm: - add support for es modules (Gus Caplan) https://github.com/nodejs/node/pull/17560 PR-URL: https://github.com/nodejs/node/pull/18902
-
- Feb 22, 2018
-
-
Luigi Pinca authored
Ensure that the default `'drain'` listener is removed before the `'connect'` or `'upgrade'` event is emitted. PR-URL: https://github.com/nodejs/node/pull/18866 Reviewed-By:
-
Ben Noordhuis authored
Remove an erroneous CHECK that asserted the persistent object's internal field pointer still pointed to a valid object. If ClearWrap() has been called, the field pointer equals nullptr and that is expected behavior. PR-URL: https://github.com/nodejs/node/pull/18898 Fixes: https://github.com/nodejs/node/issues/18256 Reviewed-By:
-
Sergey Golovin authored
- add new constants - replace numbers by constants PR-URL: https://github.com/nodejs/node/pull/18869 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Ben Noordhuis authored
Original commit message: Use wider types for max_old_space_size and co. Make --max_old_space_size and friends work with values >= 2**31. Such values did not work reliably (or sometimes not all) due to signed integer overflow in size computations, which is UB. Fixes https://github.com/nodejs/node/issues/18786. Bug: chromium:814138 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ibe23cef2417fd5b4a727022b8b0d4b50f1417182 Reviewed-on: https://chromium-review.googlesource.com/927063 Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#51433} PR-URL: https://github.com/nodejs/node/pull/18920 Fixes: https://github.com/nodejs/node/issues/18786 Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
-
killagu authored
When create a nest repl, will register `Runtime.executionContextCreated` listener to the inspector session.This patch will fix listener repeatedly register. PR-URL: https://github.com/nodejs/node/pull/18881 Fixes: https://github.com/nodejs/node/issues/18284 Reviewed-By:
-
Luigi Pinca authored
Remove the default `'error'` listener when the socket is freed. This is consistent with the client and prevents spurious `'clientError'` events from being emitted on the server. PR-URL: https://github.com/nodejs/node/pull/18868 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Ruben Bridgewater authored
The former notation was deprecated. This updates it as recommended. PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Ruben Bridgewater authored
This also fixes the three entries that did not pass. PR-URL: https://github.com/nodejs/node/pull/18831 Reviewed-By:
-
Trivikram authored
PR-URL: https://github.com/nodejs/node/pull/18859 Reviewed-By:
-
Trivikram authored
PR-URL: https://github.com/nodejs/node/pull/18861 Reviewed-By:
-
Luigi Pinca authored
Set `socket._httpMessage` to `null` before emitting the `'connect'` or `'upgrade'` event. PR-URL: https://github.com/nodejs/node/pull/18865 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18864 Fixes: https://github.com/nodejs/node/issues/18820 Reviewed-By:
-
Joyee Cheung authored
This provides a more reliable way to get a fd that can be used to tirgger EBADF. PR-URL: https://github.com/nodejs/node/pull/18864 Fixes: https://github.com/nodejs/node/issues/18820 Reviewed-By:
-
Ruben Bridgewater authored
This adds the eslint rules back in that were falsely removed while landing https://github.com/nodejs/node/pull/18566. PR-URL: https://github.com/nodejs/node/pull/18933 Refs: https://github.com/nodejs/node/pull/18566 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18857 Reviewed-By:
-
Ruben Bridgewater authored
Some error types are not properly set. This adds comments which ones are probably falty and to what they should be set instead. PR-URL: https://github.com/nodejs/node/pull/18857 Reviewed-By:
-
Ruben Bridgewater authored
This ports the errors to the new error system. PR-URL: https://github.com/nodejs/node/pull/18857 Reviewed-By:
-
Ruben Bridgewater authored
This updates all internal errors to the new error type. While doing so it removes unused errors. A few errors currently seem to have the wrong type. To identify them later, comments were added next to the error type. PR-URL: https://github.com/nodejs/node/pull/18857 Reviewed-By:
-
Ruben Bridgewater authored
This implements a function based system. Instead of passing in the error code as first argument, the error code itself is a error class. It already contains the correct error type, so while adding a new error no one has to think about the error type anymore. In case a single error code has more than one error type, the error class has properties for the non default error types. Those can be used as fallback. This prevents typos, makes the implementation easier and it is less verbose when writing the code for a new error. The implementation itself does not interfere with the old implementation. So the old and the new system can co-exist and it is possible to slowly migrate the old ones to the new system. PR-URL: https://github.com/nodejs/node/pull/18857 Reviewed-By:
-
Bartosz Sosnowski authored
Removes extra erroor messages when Python is not installed. Removes "vswhere not found" message when no VS2017 installation is found. Adds support for DEBUG_HELPER to vcbuild.bat. Fixes: https://github.com/nodejs/node/issues/16864 PR-URL: https://github.com/nodejs/node/pull/17015 Reviewed-By:
-
Bartosz Sosnowski authored
Uses fs.access to implement fs.exists functionality. Fixes a issue, when a file exists but user does not have privileges to do stat on the file. Fixes: https://github.com/nodejs/node/issues/17921 PR-URL: https://github.com/nodejs/node/pull/18618 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Sarat Addepalli authored
PR-URL: https://github.com/nodejs/node/pull/18801 Reviewed-By:
-
