- Feb 27, 2018
-
-
Leko authored
PR-URL: https://github.com/nodejs/node/pull/18236 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18245 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Mars Wong authored
PR-URL: https://github.com/nodejs/node/pull/18057 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/18165 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By:
-
Jon Moss authored
Use common's mustCall (for some reason was implementing its own?), and other small fixes. PR-URL: https://github.com/nodejs/node/pull/18219 Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/17803 Refs: https://github.com/nodejs/code-and-learn/issues/72 Reviewed-By:
-
Franziska Hinkelmann authored
Add 8.x to the LTS versions that use a V8 branch that is not active anymore. PR-URL: https://github.com/nodejs/node/pull/18155 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Stephen Belanger authored
Add meta information to async_hooks documentation informing that executionAsyncId was renamed from currentId at Node.js 8.2.0. PR-URL: https://github.com/nodejs/node/pull/17813 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
Suixinlei authored
Fixes: https://github.com/nodejs/node/issues/12516 Refs: https://github.com/nodejs/node/pull/2497 PR-URL: https://github.com/nodejs/node/pull/17705 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Matheus Marchini authored
The build breaks if there's a non-ASCII character on the path to the building directory. PR-URL: https://github.com/nodejs/node/pull/16735 Refs: https://github.com/nodejs/node/issues/16278 Refs: https://github.com/nodejs/node/issues/14336 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Rich Trott authored
Change many instances of "x is considered to be y" to "x is y". PR-URL: https://github.com/nodejs/node/pull/18095 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
陈刚 authored
Fixes: https://github.com/nodejs/node/issues/18116 PR-URL: https://github.com/nodejs/node/pull/18121 Reviewed-By:
Weijia Wang <starkwang@126.com>
-
Michael Dawson authored
Update so that it includes some of the more recent additions. PR-URL: https://github.com/nodejs/node/pull/18167 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Yosuke Furukawa authored
PR-URL: https://github.com/nodejs/node/pull/18201 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
sreepurnajasti authored
Refs: #13836 PR-URL: https://github.com/nodejs/node/pull/18034 Refs: https://github.com/nodejs/node/issues/13836 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/18105 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/18103 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Ben Noordhuis authored
Ensure `common.tmpDir` exists before trying to chdir into it. Fixes a "ENOENT: no such file or directory, uv_chdir" error when the temporary directory is removed before running the test. PR-URL: https://github.com/nodejs/node/pull/18263 Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
-
laino authored
Relative unix sockets paths were previously interpreted relative to the master's CWD, which was inconsistent with non-cluster behavior. A test case has been added as well. PR-URL: https://github.com/nodejs/node/pull/16749 Fixes: https://github.com/nodejs/node/issues/16387 Reviewed-By:
-
Kyle Farnung authored
* Added a `lint-cpp` argument * Updated `findstr` calls to output to `nul` * Updated `findstr` calls to only use `/r` when the input is a regex PR-URL: https://github.com/nodejs/node/pull/18012 Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/18097 Reviewed-By:
-
Joyee Cheung authored
Also provide an example on how to use internal/errors to handle errors in C++. PR-URL: https://github.com/nodejs/node/pull/18149 Refs: https://github.com/nodejs/node/issues/18106 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Sho Miyamoto authored
PR-URL: https://github.com/nodejs/node/pull/18076 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Jon Moss authored
PR-URL: https://github.com/nodejs/node/pull/16539 Fixes: https://github.com/nodejs/node/issues/16394 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/18061 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Leko authored
PR-URL: https://github.com/nodejs/node/pull/18117 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/18110 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
Rich Trott authored
In the documentation for the buffer module, change instances of "the result is considered undefined behavior" to "the resulting behavior is undefined". It's less ambiguous in meaning and less awkward stylistically. PR-URL: https://github.com/nodejs/node/pull/18091 Reviewed-By:
-
Yang Guo authored
Not all shells set PWD, so use CURDIR instead. `which node` may return the empty string, so guard against that too. Consider: if [ -x `which velociraptor` ] && [ -e `which velociprator` ];\ then echo "run"; else echo "keep calm"; fi; PR-URL: https://github.com/nodejs/node/pull/18040 Reviewed-By:
-
Weijia Wang authored
After slicing, the `lastSegmentLength` should be calculated again, instead of assigning value `j`. PR-URL: https://github.com/nodejs/node/pull/17974 Fixes: https://github.com/nodejs/node/issues/17928 Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/15268 PR-URL: https://github.com/nodejs/node/pull/18044 Fixes: https://github.com/nodejs/node/issues/15268 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/17379 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17988 Fixes: https://github.com/nodejs/node/issues/17986 Reviewed-By:
-
Rich Trott authored
* use serial comma in child_process.md * use American spelling of unsanitized in child_process.md * hyphenate general-purpose in child_process.md * remove errant commas in child_process.md PR-URL: https://github.com/nodejs/node/pull/17990 Reviewed-By:
-
Qingyan Li authored
Currently the cctest target build will fail if configured with --enable-static $ ./configure --enable-static $ make There're some function multiple definition errors such as: out/Release/obj.target/node/src/node_crypto.o: In function `node::crypto::RandomBytesWork(uv_work_s*)': node_crypto.cc:(.text+0x60): multiple definition of `node::crypto::RandomBytesWork(uv_work_s*)' out/Release/obj.target/node/src/node_crypto.o:node_crypto.cc:(.text+0x60): first defined here It's caused by repetition objects in libraries and libnode.a. This CL makes those libraries guarded by 'node_target_type!="static_library"'. PR-URL: https://github.com/nodejs/node/pull/17992 Reviewed-By:
-
Rich Trott authored
common.fires() is specific to the inspector tests so move it to inspector-helper.js. The one REPL test that used common.fires() does not seem to need it. It provided a 1 second timeout for operations, but that timeout appears both arbitrary and ineffective as the test passes if it is reduced to even 1 millisecond. Backport-PR-URL: https://github.com/nodejs/node/pull/18096 PR-URL: https://github.com/nodejs/node/pull/17401 Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/18007 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
Anna Henningsen authored
Document and test the existing support for generic Duplex streams in the TLS module. PR-URL: https://github.com/nodejs/node/pull/17599 Reviewed-By:
-
Myles Borins authored
We've added a number of tests that hook into ESLint which can error when running the test suite with the distributed tarball. This PR adds a new test helper `common.skipIfEslintMissing` and will skip remaining tests in a file when `ESLint` is not available at `tools/node_modules/eslint` PR-URL: https://github.com/nodejs/node/pull/18807 Reviewed-By:
-
- Feb 21, 2018
-
-
David Benjamin authored
There is a perfectly serviceable ERR_get_error function which avoids having to sniff through the OpenSSL ring buffer like that. It does return the errors in the opposite order, but that's easily fixed with std::reverse. Note this behavior is slightly different in that an ERR_get_error loop will ultimately clear the error queue, but this is desirable. Leaving the error queue uncleared means errors in subsequent operations may get mixed up and cause issues. PR-URL: https://github.com/nodejs/node/pull/16701 Backport-PR-URL: https://github.com/nodejs/node/pull/18327 Reviewed-By:
-
