- Dec 02, 2017
-
-
Rich Trott authored
There is no need to hedge bets on the serial comma. Simply instruct people to use it. PR-URL: https://github.com/nodejs/node/pull/17384 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Jose M. Palacios Diaz authored
changes in c++ are in the computeSecret function, but the thrown exception that was moved to JS land was in BufferToPoint function, here i let the allocation error be thrown so the only value returned is the nullptr that i use later to catch the error in computeSecret, to then construct the exception in JS land. an ERR_CRYPTO_ECDH_INVALID_PUBLIC_KEY error was added to errors.js and with that, subsequent changes to docs and tests were made. PR-URL: https://github.com/nodejs/node/pull/16849 Refs: https://www.iacr.org/archive/pkc2003/25670211/25670211.pdf Fixes: https://github.com/nodejs/node/issues/16625 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Gus Caplan authored
uses @@toStringTag when creating the "tag" for an inspected value PR-URL: https://github.com/nodejs/node/pull/16956 Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Mithun Sasidharan authored
PR-URL: https://github.com/nodejs/node/pull/17211 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
ChungNgoops authored
PR-URL: https://github.com/nodejs/node/pull/17346 Reviewed-By:
-
Mithun Sasidharan authored
PR-URL: https://github.com/nodejs/node/pull/17348 Reviewed-By:
-
NiveditN authored
Added assertions to verify that console.time() coerces labels to strings correctly, by comparing against the expected output values of console.timeEnd(). This helps resolve https://github.com/nodejs/node/issues/14544 but will not address the whole thing. PR-URL: https://github.com/nodejs/node/pull/17368 Refs: https://github.com/nodejs/node/pull/14643 Reviewed-By:
-
Hannes Magnusson authored
The funciton was added in eb2ca104 PR-URL: https://github.com/nodejs/node/pull/17203 Reviewed-By:
-
Hannes Magnusson authored
PR-URL: https://github.com/nodejs/node/pull/17203 Reviewed-By:
-
Jon Moss authored
PR-URL: https://github.com/nodejs/node/pull/17408 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Leko authored
PR-URL: https://github.com/nodejs/node/pull/17343 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Leko authored
It failed with `FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal`. PR-URL: https://github.com/nodejs/node/pull/17343 Reviewed-By:
-
Leko authored
Squashed from multiple commits: - src: replace ->To*(isolate) with ->To*(context).ToLocalChecked() - test: use .As<Object> on Exception::Error > Exception::Error always returns an object, so e.As<Object>() should also work fine See https://github.com/nodejs/node/pull/17343#discussion_r153232027 - test: use .As<Object> instead of ->ToObject we already checked that its a buffer - src: use FromMaybe instead of ToLocalChecked It fixed this test case: 19a1b2e414 - src: pass context to Get() Dont pass Local<Context> is deprecated soon. So we migrate to maybe version. - src: return if Get or ToObject return an empty before call ToLocalChecked Refs: https://github.com/nodejs/node/issues/17244 PR-URL: https://github.com/nodejs/node/pull/17343 Reviewed-By:
-
- Dec 01, 2017
-
-
Tom Hallam authored
PR-URL: https://github.com/nodejs/node/pull/17388 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/17282 Reviewed-By:
-
Rich Trott authored
Enable lint rule that prohibits unnecessary use of `await` with `return`. PR-URL: https://github.com/nodejs/node/pull/17265 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
Rich Trott authored
Remove unnecessary `await` in combination with `return` in preparation for enabling lint rule. PR-URL: https://github.com/nodejs/node/pull/17265 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/17366 Reviewed-By:
-
Daniel Bevenius authored
This commit updates the node_test_fixture to use v8::ArrayBuffer::Allocator::NewDefaultAllocator() and removes the custom allocator. PR-URL: https://github.com/nodejs/node/pull/17366 Reviewed-By:
-
Daniel Bevenius authored
This commit is a suggestion for adding a rule for NULL usages in the code base. This will currently report a number of errors which could be ignored using // NOLINT (readability/null_usage) PR-URL: https://github.com/nodejs/node/pull/17373 Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/17373 Reviewed-By:
-
Jon Moss authored
I had a little trouble understanding what the rule was trying to say, so am documenting what would pass/fail. PR-URL: https://github.com/nodejs/node/pull/17376 Reviewed-By:
-
- Nov 30, 2017
-
-
Evan Lucas authored
The whitelist of allowed cli flags that can be passed in the NODE_OPTIONS environment variable had --trace-events-categories, but the cli flag is actually --trace-event-categories. PR-URL: https://github.com/nodejs/node/pull/17369 Reviewed-By:
-
Bartosz Sosnowski authored
Adds a Boxstarter script for easy Node.js building prerequisites installation PR-URL: https://github.com/nodejs/node/pull/17046 Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
-
Refael Ackermann authored
subprocess.check_output is a python2.7 only feature. Using Execute allows keeping python2.6 compatibility PR-URL: https://github.com/nodejs/node/pull/17381 Reviewed-By:
-
Myles Borins authored
Original commit message: Fix map constructor to correctly throw. We need to throw before rethrowing, otherwise the exception does not trigger a debugger event and is not reported if uncaught. R=gsathya@chromium.org, jgruber@chromium.org Bug: v8:7047 Change-Id: I7ce0253883a21d6059e4e0ed0fc56dc55a0dcba6 Reviewed-on: https://chromium-review.googlesource.com/758372 Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#49237} Fixes: https://github.com/nodejs/node/issues/17270 PR-URL: https://github.com/nodejs/node/pull/17383 Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By: Michael Dawson <mi...
-
Myles Borins authored
This reverts commit e7f30db1. The original commit included tests for AsyncIterator that broke on 6.2 PR-URL: https://github.com/nodejs/node/pull/17383 Reviewed-By:
-
Myles Borins authored
This is based on the guide found on their wiki refs: https://github.com/npm/npm/wiki/CLI-Team-Process#submitting-the-new-latest-x-to-nodejs PR-URL: https://github.com/nodejs/node/pull/16541 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Matheus Marchini authored
cctest guide example wasn't working because of a few typos. PR-URL: https://github.com/nodejs/node/pull/17355 Reviewed-By:
-
Jon Moss authored
PR-URL: https://github.com/nodejs/node/pull/14998 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
-
Jan Krems authored
This is an initial implementation to support dynamic import in both scripts and modules. It's off by default since support for dynamic import is still flagged in V8. Without setting the V8 flag, this code won't be executed. This initial version does not support importing into vm contexts. PR-URL: https://github.com/nodejs/node/pull/15713 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com>
-
Timothy Gu authored
Original commit message: [coverage] Correctly free DebugInfo in the absence of breakpoints It's quite possible for DebugInfos to exist without the presence of a bytecode array, since DebugInfos are created for all functions for which we have a CoverageInfo. Free such objects properly. Also move the corresponding deletion of CoverageInfos on unload up before the early exit. Bug: v8:6000 Change-Id: Idde45b222290aa8b6828b61ff2251918b8ed2aed Reviewed-on: https://chromium-review.googlesource.com/664811 Reviewed-by:
-
- Nov 29, 2017
-
-
Anna Henningsen authored
Introduce `process.shouldAbortOnUncaughtException` to control `--abort-on-uncaught-exception` behaviour, and implement some of the domains functionality on top of it. PR-URL: https://github.com/nodejs/node/pull/17159 Refs: https://github.com/nodejs/node/issues/17143 Reviewed-By:
Andreas Madsen <amwebdk@gmail.com>
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/17333 Reviewed-By:
-
Anna Henningsen authored
At its call sites, `ClearFatalExceptionHandlers()` was used to make the process crash as soon as possible once an exception occurred, without giving JS land a chance to interfere. `ClearFatalExceptionHandlers()` awkwardly removed the current domain and any `uncaughtException` handlers, whereas a clearer way is to execute the relevant reporting (and `exit()`) code directly. PR-URL: https://github.com/nodejs/node/pull/17333 Refs: https://github.com/nodejs/node/pull/17159 Refs: https://github.com/nodejs/node/pull/17324 Reviewed-By:
-
Leko authored
1. Among the list of Code and Learn, I solved the unfinished task of replacing function with arrow function: https://github.com/nodejs/code-and-learn/issues/72#issuecomment-345667395 2. Replace arrow function with shorter property syntax Arrow function makes `this` lexical scope. But toString expects evaluate `this` in runtime. 3. Replace this with null makeBlock does not need `this`. update `this` with `null` to clarify the intent. PR-URL: https://github.com/nodejs/node/pull/17345 Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com>
-
Ben Noordhuis authored
Include the offending line in the output and underline the bad token. Before this commit, it printed "SyntaxError: Unexpected reserved word" without indicating where the syntax error is. Now it prints the line and underlines the offending token, like it does for syntax errors in CJS scripts. Minor changes are made to the test runner in order to support `*.mjs` files in test/message. Fixes: https://github.com/nodejs/node/issues/17277 PR-URL: https://github.com/nodejs/node/pull/17281 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Michaël Zasso authored
Clean the deps/v8 directory before rebuilding node for the hash seed test. It is necessary to avoid the script added in [1] to use ignored files while generating `node-debug-support.cc`. [1]: https://github.com/nodejs/node/pull/14901 PR-URL: https://github.com/nodejs/node/pull/17269 Fixes: https://github.com/nodejs/node-v8/issues/26 Reviewed-By:
-
Hativ authored
For best out-of-the-box compatibility there should not be one default `ecdhCurve` for the tls client, OpenSSL should choose them automatically. See https://wiki.openssl.org/index.php/Manual:SSL_CTX_set1_curves(3) PR-URL: https://github.com/nodejs/node/pull/16853 Refs: https://github.com/nodejs/node/issues/16196 Refs: https://github.com/nodejs/node/issues/1495 Refs: https://github.com/nodejs/node/pull/15206 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
João Reis authored
PR-URL: https://github.com/nodejs/node/pull/17101 Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com>
-
