- Oct 28, 2017
-
-
Michaël Zasso authored
Original commit message: [heap] Fix threshold for delayed chunks after 2c7561. Bug: chromium:771966 Change-Id: Iac5ee55c0d31de477f21f091f4be015a1ca8d00c Reviewed-on: https://chromium-review.googlesource.com/702382 Reviewed-by:Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#48316} Refs: https://github.com/v8/v8/commit/676c41321a948c08d6a43de43fe9b1d60ae81c00 Refs: https://github.com/nodejs/help/issues/917#issuecomment-339292642 Refs: https://bugs.chromium.org/p/chromium/issues/detail?id=771966 PR-URL: https://github.com/nodejs/node/pull/16490 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Michaël Zasso authored
Original commit message: [heap] Ensure progress in unmapping memory chunks. If sweeping is not making progress and there are many young generation GCs happening, then this can lead to accumulation of memory chunks in the unmapper queue. Bug: chromium:771966 Change-Id: Ief73ada0d17198a80b668850c6d2e7ea413113e7 Reviewed-on: https://chromium-review.googlesource.com/702479 Reviewed-by: -
sharkfisher authored
PR-URL: https://github.com/nodejs/node/pull/16047 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Anatoli Papirovski authored
Adjust stream buffer size to allow full 4 default-sized frames including their frame headers to allow more efficient sending of data to the socket. PR-URL: https://github.com/nodejs/node/pull/16445 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Rich Trott authored
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: https://github.com/nodejs/node/pull/16537 Ref: https://github.com/nodejs/node/pull/4431#issuecomment-173663527 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Rich Trott authored
use `common.buildType` instead of `process.config.target_defaults.default_configuration` in repl-domain-abort addon test. PR-URL: https://github.com/nodejs/node/pull/16538 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
- Oct 27, 2017
-
-
Gibson Fahnestock authored
If you run the tests in a different machine to the one you built on, this test will fail. Avoid this by skipping if the file doesn't exist. We shouldn't need to check that the file exists in this test, as the build won't pass without a config.gypi anyway. Also adds console.logs, so you can see what the actual difference between the objects was, as `assert.deepStrictEqual()` only shows you the first three lines. PR-URL: https://github.com/nodejs/node/pull/16436 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
James M Snell authored
With the exception of ThrowCryptoError, use internal/errors to report fips unavailable or forced PR-URL: https://github.com/nodejs/node/pull/16428 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Sebastiaan Deckers authored
The PRIORITY field is only supported by HTTP/2 in a HEADERS frame initiated by the client, not in a push request sent by the server. Documents the recommended approach to set a silent priority as used internally by nghttp2. PR-URL: https://github.com/nodejs/node/pull/16451 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com>
-
Mark Walker authored
PR-URL: https://github.com/nodejs/node/pull/15939 Reviewed-By:
-
Michaël Zasso authored
Currently, `Reflect.ownKeys(this)`, `Object.getOwnPropertyNames(this)` and `Object.getOwnPropertySymbols(this)` when run in a sandbox, fails to retrieve Symbol and non-enumerable values. PR-URL: https://github.com/nodejs/node/pull/16410 Reviewed-By:
-
Franziska Hinkelmann authored
This patch fixes the problem with variables that are declared only on the sandbox but not on the global proxy. PR-URL: https://github.com/nodejs/node/pull/16487 Fixes: https://github.com/nodejs/node/issues/12300 Reviewed-By:
-
erwinwahyura authored
PR-URL: https://github.com/nodejs/node/pull/16542 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Peter Marton authored
PR-URL: https://github.com/nodejs/node/pull/16142 Reviewed-By:
-
Bryan English authored
Rather than using `http`, use `_http_client`, etc. directly. Also moving all the exports to the bottom, in line with most of the rest of the codebase. PR-URL: https://github.com/nodejs/node/pull/16395 Reviewed-By:
-
Refael Ackermann authored
also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: https://github.com/nodejs/node/pull/16372 Refs: https://github.com/nodejs/node/pull/16010 Refs: https://github.com/nodejs/node/issues/16278 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Refael Ackermann authored
`.tmp` prefix allows easier exclusion PR-URL: https://github.com/nodejs/node/pull/16372 Refs: https://github.com/nodejs/node/pull/16010 Refs: https://github.com/nodejs/node/issues/16278 Reviewed-By:
-
Refael Ackermann authored
Makes eslint exclude directories without enumerating their content PR-URL: https://github.com/nodejs/node/pull/16372 Refs: https://github.com/nodejs/node/pull/16010 Refs: https://github.com/nodejs/node/issues/16278 Reviewed-By:
-
Hitesh Kanwathirtha authored
PR-URL: https://github.com/nodejs/node/pull/16460 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Joyee Cheung authored
Make node_crypto_clienthello-inl.h self-contained. PR-URL: https://github.com/nodejs/node/pull/16518 Reviewed-By:
-
James M Snell authored
The previous throws should never happen, and if they do, they signal a larger issue in core. Make these checks rather than throws. PR-URL: https://github.com/nodejs/node/pull/16453 Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Bartosz Sosnowski authored
Libuv 1.15.0 improved console resize detection on Windows. This note is no longer needed. PR-URL: https://github.com/nodejs/node/pull/16320 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
- Oct 26, 2017
-
-
Jinwoo Lee authored
This is for issue 16452. When 'set-cookie' header is set with an array that has only one string value, it's split into its individual characters. Fix by resetting `isArray` to false when the value is converted from an array to a string. Fixes: https://github.com/nodejs/node/issues/16452 PR-URL: https://github.com/nodejs/node/pull/16458 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/16454 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/16450 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/16450 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/16448 Reviewed-By:
-
Michaël Zasso authored
This reverts commit d4033c15. The commit broke cross-compilation and it was missed. PR-URL: https://github.com/nodejs/node/pull/16513 Refs: https://github.com/nodejs/node/pull/16412 Reviewed-By:
-
Ashish Kaila authored
PR-URL: https://github.com/nodejs/node/pull/16356 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/16408 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/16409 Refs: https://github.com/nodejs/node/pull/16293 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/compare/6.2.414.32...6.2.414.33 PR-URL: https://github.com/nodejs/node/pull/16412 Reviewed-By:
-
Daniel Bevenius authored
Currently when running the test without an internet connection there are two JavaScript test failures and one cctest. The cctest only fails on Mac as far as I know. (I've only tested using Mac and Linux thus far). This commit moves the two JavaScript tests to test/internet. The details for test_inspector_socket_server.cc: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost make[1]: *** [cctest] Segmentation fault: 11 make: *** [test] Error 2 lldb output: [ RUN ] InspectorSocketServerTest.FailsToBindToNodejsHost Process 63058 stopped * thread #1: tid = 0x7b175, 0x00007fff96d04384 * libsystem_info.dylib`_gai_simple + 87, queue = * 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=1, * address=0x0) frame #0: 0x00007fff96d04384 libsystem_info.dylib`_gai_simple + 87 libsystem_info.dylib`_gai_simple: -> 0x7fff96d04384 <+87>: movw (%rdx), %ax 0x7fff96d04387 <+90>: movw %ax, -0x2a(%rbp) 0x7fff96d0438b <+94>: movq %r13, -0... -
Rich Trott authored
Provide `util.isDeepStrictEqual()` that works like `assert.deepStrictEqual()` but returns a boolean rather than throwing an error. Several userland modules have needed this functionality and implemented it independently. This functionality already exists in Node.js core, so this exposes it for use by modules. Modules that have needed this functionality include `lodash`, `concordance` (used by `ava`), and `qunit`. PR-URL: https://github.com/nodejs/node/pull/16084 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Ali Ijaz Sheikh authored
The inspector_agent depends on the context still being accessible during the destructor execution. PR-URL: https://github.com/nodejs/node/pull/16472 Fixes: https://github.com/nodejs/node/issues/15558 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
cjihrig authored
Notable changes: * net: - Fix timeout with null handle issue. This is a regression in Node 8.8.0. https://github.com/nodejs/node/pull/16489 -
Ben Noordhuis authored
The npm install rules had a hidden dependency on the `node` binary install rule creating the `$PREFIX/bin` directory. Because with `./configure --shared` no binary is created, the rule subsequently failed. Fix that by creating the directory before creating the symlinks to the npm and npx scripts. (Whether it makes sense to install npm without a `node` binary is a separate question. This commit is not taking positions. :-)) Regression introduced in commit ed8c89a0 ("build: fix shared installing target") which, as the commit log indicates, was itself a bug fix for the `./configure --shared` install. PR-URL: https://github.com/nodejs/node/pull/16438 Fixes: https://github.com/nodejs/node/issues/16437 Ref: https://github.com/nodejs/node/pull/15148 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/12756 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/12756 Reviewed-By:
-
Daijiro Wachi authored
PR-URL: https://github.com/nodejs/node/pull/12756 Reviewed-By:
-
