- Jun 11, 2019
-
-
Ruben Bridgewater authored
This activates the following recommended eslint rules: - no-async-promise-executor - no-shadow-restricted-names PR-URL: https://github.com/nodejs/node/pull/27670 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Refael Ackermann (רפאל פלחי) <refack@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com>
-
Ruben Bridgewater authored
This makes sure the eslint config is up to date for eslint 6.0.0. PR-URL: https://github.com/nodejs/node/pull/27670 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/27670 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure the "good" and "bad" examples are split into two. Otherwise it'll result in an parse error. PR-URL: https://github.com/nodejs/node/pull/27670 Reviewed-By:
-
Michael Dawson authored
I was asked by a community member if they needed to recompile for v12.x based on the version matrix. Add additional context to help ensure it is clear that this is not the case. PR-URL: https://github.com/nodejs/node/pull/27942 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Christopher Hiller <boneskull@boneskull.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ruben Bridgewater authored
Using the `util.inspect` `compact` mode set to something else than `true` resulted in breaking long lines in case the line would exceed the `breakLength` option and if it contained whitespace and or new lines. It turned out that this behavior was less useful than originally expected and it is now changed to only break on line breaks if the `breakLength` option is exceeded for the inspected string. This should be align better with the user expectation than the former behavior. PR-URL: https://github.com/nodejs/node/pull/28055 Fixes: https://github.com/nodejs/node/issues/27690 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Geoffrey Booth authored
PR-URL: https://github.com/nodejs/node/pull/27957 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com>
-
murgatroid99 authored
PR-URL: https://github.com/nodejs/node/pull/28074 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Sam Roberts authored
It was intended, according to in-test comments and common behaviour, that callbacks be either `undefined` or a function, but falsy values were being accepted as meaning "no callback". PR-URL: https://github.com/nodejs/node/pull/28109 Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/28123 Reviewed-By:
-
Rich Trott authored
test-gc-http-client is no longer believed to be unreliable. Remove it's entry indicating it's flaky from the status file. Closes: https://github.com/nodejs/node/issues/22336 PR-URL: https://github.com/nodejs/node/pull/28130 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Rich Trott authored
The test is believed to no longer be unreliable on AIX. Remove the flaky designation from the appropriate status file. Closes: https://github.com/nodejs/node/issues/9728 PR-URL: https://github.com/nodejs/node/pull/28129 Fixes: https://github.com/nodejs/node/issues/9728 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
Converts the whitespace to spaces in the all: ... target for consistency. The other whitespace has to remain tabs due to how Makefiles work. PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
Lots of changes, but mostly just search/replace of fixtures.readSync(...) to fixtures.readKey([new key]...) Benchmarks modified to use fixtures.readKey(...): benchmark/tls/throughput.js benchmark/tls/tls-connect.js benchmark/tls/secure-pair.js Also be sure to review the change to L16 of test/parallel/test-crypto-sign-verify.js PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
Also adds make'd signatures for use in tests of signing/verification. All of the moved keys can be regenerated at will without breaking tests now. PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Alex Aubuchon authored
PR-URL: https://github.com/nodejs/node/pull/27962 Reviewed-By:
-
Sam Roberts authored
Workaround added in d9b9229d is no longer needed, since OpenSSL versions lower than 1.1.1 are unsupported. PR-URL: https://github.com/nodejs/node/pull/28085 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Sam Roberts authored
Versions of OpenSSL lower than 1.1.1 are no longer supported, so remove ifdefs for previous versions. PR-URL: https://github.com/nodejs/node/pull/28085 Reviewed-By:
-
cjihrig authored
This commit fixes a C++ abort for connected dgram sockets by improving input validation in the JS layer. Fixes: https://github.com/nodejs/node/issues/28126 PR-URL: https://github.com/nodejs/node/pull/28135 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
- Jun 10, 2019
-
-
Antonio Kukas authored
PR-URL: https://github.com/nodejs/node/pull/27987 Reviewed-By:
-
Anna Henningsen authored
If the transfer list argument is present, it should be an array. This commit adds typechecking to that effect. This aligns behaviour with browsers. PR-URL: https://github.com/nodejs/node/pull/28033 Reviewed-By:
-
Anna Henningsen authored
This aligns the behaviour better with the web. PR-URL: https://github.com/nodejs/node/pull/28025 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Anna Henningsen authored
When implementing a pool for Worker threads, the correlation between posting tasks and getting their results may get lost, depending on the implementation. The `AsyncResource` API is the primary way to solve that issue, so link it from the recommendation in the worker docs. (This was brought up at the collaborator summit in Berlin.) PR-URL: https://github.com/nodejs/node/pull/28023 Reviewed-By:
-
Anatoli Papirovski authored
Optimize the hot code paths of queueMicrotask by not creating unnecessary objects, not looking up properties on frozen primordials, etc. PR-URL: https://github.com/nodejs/node/pull/28093 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Daniel Bevenius authored
Currently, when debugging a TLS connection there might be multiple debug statements 'client emit secureConnect' for the 'secureConnect` event when using NODE_DEBUG='tls'. While it is possible to step through this with a debugger that is not always the fastest/easiest to do if debugging remote code. This commit adds some additional information to the debug statements to make it easier to distinguish where the debug statements are coming from. PR-URL: https://github.com/nodejs/node/pull/28067 Reviewed-By:
-
rexagod authored
Correct "Github" to "GitHub" in compliance to the linting standards. PR-URL: https://github.com/nodejs/node/pull/28127 Reviewed-By:
-
Anna Henningsen authored
These methods may fail if execution is terminating. PR-URL: https://github.com/nodejs/node/pull/28019 Reviewed-By:
-
