- Oct 14, 2017
-
-
Justin Beckwith authored
PR-URL: https://github.com/nodejs/node/pull/15987 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com>
-
Teddy Katz authored
This adds tests for the custom eslint rules in this repository, using the `RuleTester` test utility bundled with eslint. PR-URL: https://github.com/nodejs/node/pull/16138 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Alessandro Vergani authored
socket.getRecvBufferSize() and socket.getSendBufferSize() do not take any parameter PR-URL: https://github.com/nodejs/node/pull/16183 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Christina Chan authored
Remove redundant error messages for assert.strictEqual() PR-URL: https://github.com/nodejs/node/pull/16043 Reviewed-By:
-
Fadi Asfour authored
PR-URL: https://github.com/nodejs/node/pull/16022 Reviewed-By:
-
Michael Pal authored
PR-URL: https://github.com/nodejs/node/pull/15980 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/15623 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Tim Chon authored
PR-URL: https://github.com/nodejs/node/pull/15846 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Cheyenne Arrowsmith authored
PR-URL: https://github.com/nodejs/node/pull/15844 Reviewed-By:
-
Roger Jiang authored
code and learn 2017 first task is to switch from common.fixturesDir to common.fixtures.fixturesDir in test-https-strict.js PR-URL: https://github.com/nodejs/node/pull/15814 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Shiya Luo authored
PR-URL: https://github.com/nodejs/node/pull/16134 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Chi-chi Wang authored
Use common.fixtures module in test-https-agent-session-eviction PR-URL: https://github.com/nodejs/node/pull/16012 Reviewed-By:
-
Bradley Farias authored
This should be done every time a collaborator pushes a commit. PR-URL: https://github.com/nodejs/node/pull/16162 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
-
Eugene Ostroukhov authored
PR-URL: https://github.com/nodejs/node/pull/16056 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
-
Bartosz Sosnowski authored
Escape backslashes in script filename on Windows in a CLI test. PR-URL: https://github.com/nodejs/node/pull/16124 Fixes: https://github.com/nodejs/node/issues/16057 and #16023 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This should help clarify what kind of resource a `StreamWrap` represents. PR-URL: https://github.com/nodejs/node/pull/16157 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
shaohui.liu2000@gmail.com authored
PR-URL: https://github.com/nodejs/node/pull/15816 Reviewed-By:
-
shaohui.liu2000@gmail.com authored
PR-URL: https://github.com/nodejs/node/pull/15816 Reviewed-By:
-
Mabry Cervin authored
PR-URL: https://github.com/nodejs/node/pull/15912 Reviewed-By:
-
Eric Freiberg authored
PR-URL: https://github.com/nodejs/node/pull/15922 Reviewed-By:
-
Kat Rosario authored
Replaced common.fixturesDir with common.fixtures in test-process-redirect-warnings-env PR-URL: https://github.com/nodejs/node/pull/15930 Reviewed-By:
-
Chad Zezula authored
Change all assert.strictEqual() to have actual value 1st and expected value 2nd. PR-URL: https://github.com/nodejs/node/pull/16008 Reviewed-By:
-
Rich Trott authored
As discussed in TSC email, I contacted 8 Collaborators whose last activity appears to be quite some time ago to suggest that they be moved to emeritus status until such a time as they will be active again. There were no objections from the 8 Collaborators or the TSC. PR-URL: https://github.com/nodejs/node/pull/16173 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Matthew Meyer authored
Updated parallel/test-require-resolve.js to use the fixtures module. PR-URL: https://github.com/nodejs/node/pull/15984 Reviewed-By:
-
Rich Trott authored
Move test-esm-addons to test/addons/hello-world-esm. Test should now work properly on CI machines where `addons` are not always built at the expected relative path from the es-modules tests. Test should now work in Debug builds. PR-URL: https://github.com/nodejs/node/pull/16174 Fixes: https://github.com/nodejs/node/issues/16155 Reviewed-By:
-
- Oct 13, 2017
-
-
Gibson Fahnestock authored
Use `Commit:` for the V8 commit, and `PR-URL:` for the Node PR URL. Refs: https://github.com/nodejs/node/pull/16053#issuecomment-334868621 PR-URL: https://github.com/nodejs/node/pull/16054 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
szhang351 authored
PR-URL: https://github.com/nodejs/node/pull/15841/ Reviewed-By:
-
Dolapo Toki authored
PR-URL: https://github.com/nodejs/node/pull/15836 Reviewed-By:
Lance Ball <lball@redhat.com> Reviewed-By:
-
Gene Wu authored
PR-URL: https://github.com/nodejs/node/pull/15822 Reviewed-By:
-
Christian Murphy authored
PR-URL: https://github.com/nodejs/node/pull/15817 Reviewed-By:
Ryan Graham <r.m.graham@gmail.com> Reviewed-By:
-
Cristian Peñarrieta authored
PR-URL: https://github.com/nodejs/node/pull/15833 Reviewed-By:
-
Gabriel Schulhof authored
test_constructor_name.c should use NODE_GYP_MODULE_NAME. PR-URL: https://github.com/nodejs/node/pull/16146 Reviewed-By:
-
Tom Boutell authored
PR-URL: https://github.com/nodejs/node/pull/15805 Reviewed-By:
-
Nicolas Chaulet authored
In test/parallel/test-process-redirect-warning.js replace usage of common.fixture by common.fixturesDir PR-URL: https://github.com/nodejs/node/pull/15917 Reviewed-By:
-
Raj Parekh authored
removed string literal argument to function call strictEqual so that default error message is printed PR-URL: https://github.com/nodejs/node/pull/16011 Reviewed-By:
-
kysnm authored
PR-URL: https://github.com/nodejs/node/pull/15878 Reviewed-By:
-
Bob Clewell authored
Task to replace the common.fixturesDir with the usage of the common.fixtures module. At Node.js Interactive. First PR to Node.js. Yay! PR-URL: https://github.com/nodejs/node/pull/15886 Reviewed-By:
-
Jem Bezooyen authored
The common/fixtures module provides convenience methods for working with files in the test/fixtures directory. Make use of the `fixturesDir` value from module rather than value from common. - Replace `common.fixtures` with `fixtures.fixturesDir` PR-URL: https://github.com/nodejs/node/pull/15815 Reviewed-By:
-
Alberto Lopez de Lara authored
PR-URL: https://github.com/nodejs/node/pull/15870 Reviewed-By:
-
Suresh Srinivas authored
PR-URL: https://github.com/nodejs/node/pull/15869 Reviewed-By:
-
