- Dec 30, 2016
-
-
Rich Trott authored
* replace `process.on('exit', ...)` checks with `common.mustCall()` * assert.equal() -> assert.strictEqual() * provide duration of 1ms to timer without a duration * remove unused function argument PR-URL: https://github.com/nodejs/node/pull/10483 Reviewed-By:James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Italo A. Casas <me@italoacasas.com>
-
Joyee Cheung authored
* Set exposed attributes of the interface enumerable and configurable, as required by the spec. See: https://heycam.github.io/webidl/#es-attributes * Make sure `URL#searchParams` returns `[[SameObject]]` * Add the missing `URL#href` setter * Reorder the properties to match https://url.spec.whatwg.org/#api * Add tests for the ECMAScript property attributes PR-URL: https://github.com/nodejs/node/pull/10408 Fixes: https://github.com/nodejs/node/issues/10376 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/10408 Fixes: https://github.com/nodejs/node/issues/10376 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Steven R. Loomis authored
Bump configure download path for ICU from 58.1 to 58.2 * This commit just changes the download URL. PR-URL: https://github.com/nodejs/node/pull/10206 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Steven R. Loomis authored
Bump ICU from 58.1 to 58.2 No feature changes. Bug fixes. * This commit contains the actual ICU source code and data. * CLDR 30.0.3 ( was 30.0.2) * Timezone 2016j ( was 2016g ) ICU Details: http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2 PR-URL: https://github.com/nodejs/node/pull/10206 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Sam Roberts authored
Use of abort() was added in 34febfbf, and changed to ABORT() in 21826ef2, but conditional+ABORT() is better expressesed using a CHECK_xxx() macro. See: https://github.com/nodejs/node/pull/9409#discussion_r93575328 PR-URL: https://github.com/nodejs/node/pull/10413 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Fabrice Tatieze authored
PR-URL: https://github.com/nodejs/node/pull/10478 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Italo A. Casas <me@italoacasas.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Brian White authored
This commit uses instanceof instead of Array.isArray() for faster type checking and avoids calling Object.keys() when the headers are stored as a 2D array instead of a plain object. PR-URL: https://github.com/nodejs/node/pull/6533 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/6533 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/6533 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Brian White authored
Since at least V8 5.4, using function.bind() is now fast enough to use to avoid recompiling/reoptimizing the same anonymous functions. These changes especially impact http servers. PR-URL: https://github.com/nodejs/node/pull/6533 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Brian White authored
The new table-based lookups perform significantly better for the common cases (checking latin1 characters). PR-URL: https://github.com/nodejs/node/pull/6533 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/6533 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/6533 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/6533 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Matt Loring authored
PR-URL: https://github.com/nodejs/node/pull/10507 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
The GitHub interface for new pull requests has started prepending commit messages for single-commit pull requests. It had previously been appending them. Modify the GitHub template to accommodate the new behavior. PR-URL: https://github.com/nodejs/node/pull/10484 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
- Dec 29, 2016
-
-
Stewart X Addison authored
To ease the use of the AIX binaries, add /opt/freeware/lib/pthread{/ppc64} into the search path encoded into the library, so that any version the user has installed from the common download locations will work out of the box without having to explicitly set LIBPATH in their environment. PR-URL: https://github.com/nodejs/node/pull/10128 Reviewed-By:Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
* Simplify regular expressions (see below) * Remove unneeded `parseYAML()` wrapper * Remove unused callback argument Regular expression simplifications include: * Changing trailing `*?$/` to `*$/` because non-greedy matching to the end of a line will not change behavior * Change regexp beginnings like `/^(?:property:?\s*)?[^.\[]+` to the equivalent `/[^.\]]+` * For regular expressions changed per the above, remove case-insensitivity if it no longer affects the regexp PR-URL: https://github.com/nodejs/node/pull/10442 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Italo A. Casas <me@italoacasas.com>
-
Rob Adelmann authored
Remove console.log statement. Replace error check with assert.ifError(). PR-URL: https://github.com/nodejs/node/pull/10331 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Italo A. Casas <me@italoacasas.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Brian White authored
This commit takes advantage of the performance improvements V8 has made to function.bind() in V8 5.4 and uses it to avoid constant recompilation/reoptimization of the wrapper closure used in once(). This change results in ~27% performance increase for once(). PR-URL: https://github.com/nodejs/node/pull/10445 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Chris Story authored
- Change var to const - Remove dependency crypto PR-URL: https://github.com/nodejs/node/pull/10033 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/10330 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Adrian Estrada authored
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: https://github.com/nodejs/node/pull/10200 Reviewed-By:
Italo A. Casas <me@italoacasas.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/10419 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Refs: https://github.com/nodejs/node/pull/9901#discussion_r93575704
-
- Dec 28, 2016
-
-
Santiago Gimeno authored
Remove `external_buffer_` from `InternalTraceBuffer` as it seems not to be used anywhere. PR-URL: https://github.com/nodejs/node/pull/10416 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Santiago Gimeno authored
Initialize `InternalTraceBuffer::id_` the last. PR-URL: https://github.com/nodejs/node/pull/10416 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
William Kapke authored
PR-URL: https://github.com/nodejs/node/pull/9656 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Nate authored
PR-URL: https://github.com/nodejs/node/pull/10020 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Matt Crummey authored
Provide details for fields of rinfo object of UDP message event. PR-URL: https://github.com/nodejs/node/pull/10050 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Sarah Meyer authored
PR-URL: https://github.com/nodejs/node/pull/10063 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Adrian Estrada authored
* use const and let instead of var * use common.mustCall to control functions executions * use assert.strictEqual instead of assert.equal * use assert.ifError to handle errors * use arrow functions * remove unnecessary variables PR-URL: https://github.com/nodejs/node/pull/10440 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Brian White authored
assertSize() is adjusted to be inlineable according to V8's default function size limits when determining inlineability. This results in up to 11% performance gains when allocating any kind of Buffer. Avoid avoids use of in, resulting in ~50% improvement when creating a Buffer from an array-like object. PR-URL: https://github.com/nodejs/node/pull/10443 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Christopher J. Brody authored
This is to resolve an unused result warning in node_url.cc. Resolve macro redefinition warning on Windows PR-URL: https://github.com/nodejs/node/pull/10141 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Christopher J. Brody authored
Resolve build warnings on Windows with the following pattern: warning C4244: '=': conversion from 'int64_t' to 'int32_t', possible loss of data PR-URL: https://github.com/nodejs/node/pull/10143 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Paul Graham authored
Swap var for let/const throughout the common.js module. Change a snake case variable to camel case starting on line 168. PR-URL: https://github.com/nodejs/node/pull/10177 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
jBarz authored
PR-URL: https://github.com/nodejs/node/pull/10245 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Sam Roberts authored
A user can change the default curve for ECDH key agreement by using tls.DEFAULT_ECDH_CURVE. PR-URL: https://github.com/nodejs/node/pull/10264 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Italo A. Casas <me@italoacasas.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp>
-
Jesús Leganés-Combarro 'piranna authored
Adds --cross-compiling and --no-cross-compiling flags Fixes: https://github.com/nodejs/node/issues/10271 PR-URL: https://github.com/nodejs/node/pull/10287 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Fumiya KARASAWA authored
When decodeStrings is false and given data is string, _write() function receives the string data not `Buffer`. PR-URL: https://github.com/nodejs/node/pull/10411 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-