- Oct 17, 2019
-
-
Richard Lau authored
Build the addons for benchmarks in the same way that the addons for tests are built. PR-URL: https://github.com/nodejs/node/pull/29995 Fixes: https://github.com/nodejs/build/issues/1961 Refs: https://github.com/nodejs/node/commit/53ca0b9ae145c430842bf78e553e3b6cbd2823aa#commitcomment-35494896 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Myles Borins authored
Currently `--es-module-specifier-resolution=node` has an alternative resolution order than the default in common.js, this causes inconsistencies. As discussed in @nodejs/modules we want to preserve resolution order between implementations. PR-URL: https://github.com/nodejs/node/pull/29974 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/29937 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Lucas Pardue authored
This adds RFC 4607 support for IPv4 and IPv6. Co-Authored-By:
Nicolas Thumann <46975855+n-thumann@users.noreply.github.com> Co-Authored-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/29950 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Gabriel Schulhof authored
Multiple sections may be marked as "r-xp" and with the executable's path. We use the location of the `__nodetext` symbol added by the linker script to ensure that the range we retrieve from the maps file does indeed contain the Node.js text section. Thanks to Suresh Srinivas <suresh.srinivas@intel.com>! PR-URL: https://github.com/nodejs/node/pull/29973 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Ben Noordhuis authored
Make it possible to clone the internal state of a Hash object into a new Hash object, i.e., to fork the state of the object. Fixes: https://github.com/nodejs/node/issues/29903 PR-URL: https://github.com/nodejs/node/pull/29910 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Matteo Rossi authored
Provides some missing test coverage. PR-URL: https://github.com/nodejs/node/pull/29970 Reviewed-By:
-
- Oct 16, 2019
-
-
Nick Schonning authored
PR-URL: https://github.com/nodejs/node/pull/29961 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Nick Schonning authored
PR-URL: https://github.com/nodejs/node/pull/29961 Reviewed-By:
-
Huachao Mao authored
PR-URL: https://github.com/nodejs/node/pull/29962 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
cjihrig authored
Refs: https://github.com/nodejs/node/pull/29061 PR-URL: https://github.com/nodejs/node/pull/29969 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/28685 Refs: https://github.com/nodejs/node/issues/28684 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Rich Trott authored
This includes better link linting, improved prohibited string linting, and a more maintainable code base by using remark-preset-int-recommended (thanks nschonni!). Update other dependencies while at it. PR-URL: https://github.com/nodejs/node/pull/29982 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Rich Trott authored
Update vm.md for link linting rules that are about to be applied. Define an undefined link reference. Escape non-link text that uses `[` and `]`. PR-URL: https://github.com/nodejs/node/pull/29982 Reviewed-By:
-
Rich Trott authored
Doctool tests have been failing a lot in CI on Win2008 R2. It appears async functions and callback-based functions are being used in combination such that the callback-based function cannot guarantee that it will invoke its callback. Convert the callback-based functions to async functions so we have one paradigm and reliable results. PR-URL: https://github.com/nodejs/node/pull/29979 Reviewed-By:
-
isaacs authored
Update npm to 6.12.0 Now `npm ci` runs prepare scripts for git dependencies, and respects the `--no-optional` argument. Warnings for `engine` mismatches are printed again. Various other fixes and cleanups. PR-URL: https://github.com/nodejs/node/pull/29885 Reviewed-By:
Christian Clauss <cclauss@me.com>
-
- Oct 15, 2019
-
-
Rich Trott authored
Prepare the final few documents that haven't been updated to always use `[]` with reference links and to escape `[` and `]` for things that aren't links in markdown files. PR-URL: https://github.com/nodejs/node/pull/29963 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
-
legendecas authored
As ArrayBuffer#detach is an ecma spec operation ([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)), it might be good to have it in N-API. Fixes https://github.com/nodejs/node/issues/29674 PR-URL: https://github.com/nodejs/node/pull/29768 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
Gus Caplan authored
- Refactor vm.SourceTextModule (again) - Add vm.Module abstract superclass - Add vm.SyntheticModule Refs: https://heycam.github.io/webidl/#synthetic-module-records PR-URL: https://github.com/nodejs/node/pull/29864 Reviewed-By:
-
- Oct 14, 2019
-
-
Rich Trott authored
Add missing option "mode". Alphabetize options for easier maintenance. PR-URL: https://github.com/nodejs/node/pull/29967 Reviewed-By:
-
Unlocked authored
Corrects "--source-map-support" to "--enable-source-maps". Fixes: https://github.com/nodejs/node/issues/29959 PR-URL: https://github.com/nodejs/node/pull/29960 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Robert Nagy authored
IncomingMessage will no longer emit end after aborted. PR-URL: https://github.com/nodejs/node/pull/27984 Reviewed-By:
-
bcoe authored
Without the line lengths of in-memory transpiled source, it's not possible to convert from byte ofsets to line/column offsets. PR-URL: https://github.com/nodejs/node/pull/29863 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Robert Nagy authored
If autoDestroy then we should still throw on unhandled errors. PR-URL: https://github.com/nodejs/node/pull/29806 Reviewed-By:
-
Robert Nagy authored
'finish' could previously be emitted before the file has been created when ending a write stream without having written any data. Refs: https://github.com/expressjs/multer/issues/238 PR-URL: https://github.com/nodejs/node/pull/29930 Reviewed-By:
-
Ben Noordhuis authored
Make `distutils.version.StrictVersion` available as a helper to gyp expressions so they can do proper version checks and update the gyp files accordingly. Caveat emptor: `StrictVersion` does *not* like empty strings so this commit adds truthiness guards. The helper could deal with those but I felt it better to make it explicit. Fixes: https://github.com/nodejs/node/issues/29927 PR-URL: https://github.com/nodejs/node/pull/29931 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/29874 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/29956 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/29897 Reviewed-By:
-
Michaël Zasso authored
If GYP finds a string variable that can be converted to an integer, it will do it when the variable is expanded. Use "0.0" instead of "0" to force strings and be able to use comparison operations such as `gas_version >= "2.26"` in Python 3. PR-URL: https://github.com/nodejs/node/pull/29897 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/nodejs/node-gyp/pull/1820 Refs: https://github.com/nodejs/node-gyp/pull/1843 PR-URL: https://github.com/nodejs/node/pull/29897 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/compare/7.8.279.15...7.8.279.17 PR-URL: https://github.com/nodejs/node/pull/29928 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
- Oct 13, 2019
-
-
Gabriel Schulhof authored
Since worker threads are complete Node.js environments, including the ability to load native addons, and since those native addons can allocate resources to be freed when objects go out of scope, and since, upon worker thread exit, the engine does not invoke the weak callbacks responsible for freeing resources which still have references, this modification introduces tracking for weak references such that a list of outstanding weak references is maintained. This list is traversed during environment teardown. The callbacks for the remaining weak references are called. This change is also relevant for Node.js embedder scenarios, because in those cases the process also outlives the `node::Environment` and therefore weak callbacks should also be rendered as environment cleanup hooks to ensure proper cleanup after native addons. This changes introduces the means by which this can be accomplished. A benchmark is included which measures the time it takes to execute the weak reference callback for a given number of weak references. Re: https://github.com/tc39/proposal-weakrefs/issues/125#issuecomment-535832130 PR-URL: https://github.com/nodejs/node/pull/28428 Reviewed-By:
-
Ruben Bridgewater authored
This removes `require('util')` from the `domain` module. There was only a single simple type check used from the `util` module which is now inlined instead. PR-URL: https://github.com/nodejs/node/pull/29825 Reviewed-By:Yongsheng Zhang <zyszys98@gmail.com>
-
Maria Paktiti authored
Update tests to create more nested folders and files, like rimraf package tests do. Each test will create 28 nested directories and 210 files. It will also create different types of files, like symlinks. PR-URL: https://github.com/nodejs/node/pull/29815 Reviewed-By:
Ben Coe <bencoe@gmail.com>
-
Lucas Holmquist authored
* This is a semver-major change to rename the FSWatcher.start function to FSWatcher._start to make it private The motivation here is that it serves no purpose to the end user. An instance of FSWatcher is returned when a user calls fs.watch, which will call the start method. A user can't create an instance of a FSWatcher directly. If the start method is called by a user it is a noop since the watcher has already started. Calling start after a watcher has closed is also a noop PR-URL: https://github.com/nodejs/node/pull/29905 Reviewed-By:
-
Nick Schonning authored
When it isn't nested, a new unordered list is created for the next item PR-URL: https://github.com/nodejs/node/pull/29915 Reviewed-By:
-
Nick Schonning authored
PR-URL: https://github.com/nodejs/node/pull/29915 Reviewed-By:
-
Luigi Pinca authored
Using `process.exit()` in these tests is unnecessary and may mask other problems. Refs: https://github.com/nodejs/node/pull/29873#pullrequestreview-298851847 PR-URL: https://github.com/nodejs/node/pull/29923 Reviewed-By:
-
