- Feb 17, 2018
-
-
Sergey Golovin authored
- add new constants - replace "magic" numbers in "module" by constants PR-URL: https://github.com/nodejs/node/pull/18785 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
juggernaut451 authored
PR-URL: https://github.com/nodejs/node/pull/18784 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Seth Brenith authored
In the spirit of [17399](https://github.com/nodejs/node/pull/17399), we can also simplify checkInvalidHeaderChar to use regex matching instead of a loop. This makes it faster on long matches and slower on short matches or non-matches. This change also includes some sample data from an AcmeAir benchmark run, as a rough proxy for real-world data. PR-URL: https://github.com/nodejs/node/pull/18381 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Benedikt Meurer <benedikt.meurer@gmail.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Ben Noordhuis authored
* exit naturally, don't use process.exit() * ensure callbacks are actually called PR-URL: https://github.com/nodejs/node/pull/18792 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
juggernaut451 authored
The `millions` argument was missing. PR-URL: https://github.com/nodejs/node/pull/18787 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Leko authored
PR-URL: https://github.com/nodejs/node/pull/18257 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Santiago Gimeno authored
`readable` and `writable` properties can be passed directly to the `net.Socket` constructor. This change also avoids an unnecessary call to `read(0)` on the `stdin` socket. This behavior was disclosed when trying to merge `libuv@1.19.0` and specifically this commit: https://github.com/libuv/libuv/commit/fd049399aa4ed8495928e375466970d98cb42e17. PR-URL: https://github.com/nodejs/node/pull/18701 Refs: https://github.com/libuv/libuv/pull/1655 Reviewed-By:
-
Matheus Marchini authored
PR-URL: https://github.com/nodejs/node/pull/18822 Reviewed-By:
-
Bamieh authored
This adds a implicit common.mustCall to the callback provided to the countdown. PR-URL: https://github.com/nodejs/node/pull/18506 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
Number.isNaN is now as fast as `val !== val`. Switch to the more readable version. Also switch all `isNaN` to `Number.isNaN`. PR-URL: https://github.com/nodejs/node/pull/18744 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Ruben Bridgewater authored
These two NaN entries are not necessary and we can safely remove them. PR-URL: https://github.com/nodejs/node/pull/18744 Reviewed-By:
-
Aaron Bieber authored
PR-URL: https://github.com/nodejs/node/pull/18543 Reviewed-By:
-
Aaron Bieber authored
PR-URL: https://github.com/nodejs/node/pull/18543 Reviewed-By:
-
Jose M. Palacios Diaz authored
Wrap SafeGetenv() in util binding with the purpose of protecting the cases when env vars are accessed with the privileges of another user in jsland. PR-URL: https://github.com/nodejs/node/pull/18511 Fixes: https://github.com/nodejs/node/issues/9160 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Yihong Wang authored
When building the node with `--shared` option, the major output is the shared library. However, we still build a node executable which links to the shared lib. It's for testing purpose. When testing with the executable, some test cases move/copy the executable, change the relative path to the shared library and fail. Using lib path env would solve the issue. However, in macOS, need to change the install name for the shared library and use rpath in the executable. In AIX, `-brtl` linker option rebinds the symbols in the executable and addon modules could use them. Signed-off-by:
Yihong Wang <yh.wang@ibm.com> PR-URL: https://github.com/nodejs/node/pull/18626 Refs: https://github.com/nodejs/node/issues/18535 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/18650 Reviewed-By:
Kyle Farnung <kfarnung@microsoft.com> Reviewed-By:
-
Ruben Bridgewater authored
This was never documented and the `assert` module should be used instead. PR-URL: https://github.com/nodejs/node/pull/18666 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
- Feb 16, 2018
-
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/18818 Refs: https://github.com/nodejs/node/commit/efb32592e1b78ec2559e1a409faa049e756a9501 Reviewed-By:
-
Ruben Bridgewater authored
Prohibit the usage of `assert.doesNotThrow()`. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By:
-
Ruben Bridgewater authored
Add punctuation and comments about code that should not throw. Also remove a obsolete test and refactor some tests. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By:
-
Ruben Bridgewater authored
There is actually no reason to use `assert.doesNotThrow()` in the tests. If a test throws, just let the error bubble up right away instead of first catching it and then rethrowing it. PR-URL: https://github.com/nodejs/node/pull/18669 Reviewed-By:
-
Ruben Bridgewater authored
This enables the `no-unsafe-finally` eslint rule to make sure we have a proper control flow in try / catch. PR-URL: https://github.com/nodejs/node/pull/18745 Reviewed-By:
-
Sergey Golovin authored
PR-URL: https://github.com/nodejs/node/pull/18757 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com>
-
Ruben Bridgewater authored
Move the print statements below a console.log call. PR-URL: https://github.com/nodejs/node/pull/18758 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Daniel Bevenius authored
This commit set the Environment as a thread local when CreateEnvironment is called which is currently not being done. This would lead to a segment fault if later node::AtExit is called without specifying the environment parameter. This specific issue was reported by Electron. If I recall correctly, back when this was implemented the motivation was that if embedders have multiple environments per isolate they should be using the AtExit functions that take an environment. This is not the case with Electron which only create a single environment (as far as I know), and if a native module calls AtExit this would lead to the segment fault. I was able to reproduce Electron issue and the provided test simulates it. I was also able to use this patch and verify that it works for the Electron issue as well. PR-URL: https://github.com/nodejs/node/pull/18573 Refs: https://github.com/nodejs/node/pull/9163 Refs: https://github.com/electron/electron/issues/11299 Reviewed...
-
Ali Ijaz Sheikh authored
The legacy MakeCallback functions do not provide a mechanism to propagate async context. This means that any native modules using these directly is likely breaking async debugging & tracing tools. For example it is possible that such a module will cause incorrect async stack traces to be reported (even when the module is not on the stack). The new MakeCallback allow the user to specify the async context in which the callback is to be executed. Ref: https://github.com/nodejs/node/issues/13254 PR-URL: https://github.com/nodejs/node/pull/18632 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Andreas Madsen <amwebdk@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com>
-
Rich Trott authored
Remove unnecessary condition in lib/module.js. Refs: https://github.com/nodejs/node/pull/18593#issuecomment-364927965 PR-URL: https://github.com/nodejs/node/pull/18768 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
- Feb 15, 2018
-
-
Michaël Zasso authored
SetAutorunMicrotasks is deprecated and a warning will be emitted starting from V8 6.5. Use the non-deprecated SetMicrotasksPolicy API instead. PR-URL: https://github.com/nodejs/node/pull/18753 Reviewed-By:
Yang Guo <yangguo@chromium.org>
-
陈刚 authored
PR-URL: https://github.com/nodejs/node/pull/18211 Reviewed-By:
-
Miles Elam authored
Adding ServerResponse.writeProcessing to send 102 status codes. Added an `'information'` event to ClientRequest to handle 1xx status codes except 101 Upgrade. 101 Upgrade is excluded due to its non-informational processing according to RFC7231, Section 6.2.2. This affects several modules downstream that use the http module, e.g., node-fetch, all of whom violate HTTP RFCs due to this module. As such, this could introduce a breaking change for downstream if HTTP standards were ignored in an ad-hoc fashion. See also RFC2518 RFC8297. PR-URL: https://github.com/nodejs/node/pull/18033 Reviewed-By:
-
Nikolai Vavilov authored
A subroutine does not work as a replacement for the `python` command since one cannot use a subroutine call in a `for /F` loop. PR-URL: https://github.com/nodejs/node/pull/18621 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
Sho Miyamoto authored
PR-URL: https://github.com/nodejs/node/pull/18783 Reviewed-By:
-
Antoine AMARA authored
Update the dead link to <keygen> documentation. Add a link to mozilla developper documentation because W3C deleted the reference to this element. Add a note to inform <keygen> element is deprecated since HTML 5.2. PR-URL: https://github.com/nodejs/node/pull/18721 Fixes: https://github.com/nodejs/node/issues/18662 Reviewed-By:
-
Kelvin Jin authored
PR-URL: https://github.com/nodejs/node/pull/17640 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Myles Borins authored
In a conversation Fedor requested that this PR be made. They plan to continue working on core as a Collaborator. It is this committers belief that if Fedor would like to join the TSC again in the future there is no reason that could not be made possible. Thanks for all the hard work! PR-URL: https://github.com/nodejs/node/pull/18752 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
cjihrig authored
This commit adds a regression test for de848ac1, which broke multiline input in the REPL. PR-URL: https://github.com/nodejs/node/pull/18718 Refs: https://github.com/nodejs/node/pull/17828 Refs: https://github.com/nodejs/node/pull/18715 Reviewed-By:
-
- Feb 14, 2018
-
-
cjihrig authored
The timer in NAPI's test_callback_scope/test-resolve-async.js can be removed. If the test fails, it will timeout on its own. The extra timer increases the chances of the test being flaky. PR-URL: https://github.com/nodejs/node/pull/18719 Fixes: https://github.com/nodejs/node/issues/18702 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
Guy Bedford authored
This adds support for ensuring that the top-level main into Node is supported loading when it has no extension for backwards-compat with NodeJS bin workflows. In addition package.json caching is implemented in the module lookup process. PR-URL: https://github.com/nodejs/node/pull/18728 Reviewed-By:
-
Anna Henningsen authored
Encapsulate stream requests more: - `WriteWrap` and `ShutdownWrap` classes are now tailored to the streams on which they are used. In particular, for most streams these are now plain `AsyncWrap`s and do not carry the overhead of unused libuv request data. - Provide generic `Write()` and `Shutdown()` methods that wrap around the actual implementations, and make *usage* of streams easier, rather than implementing; for example, wrap objects don’t need to be provided by callers anymore. - Use `EmitAfterWrite()` and `EmitAfterShutdown()` handlers to call the corresponding JS handlers, rather than always trying to call them. This makes usage of streams by other C++ code easier and leaner. Also fix up some tests that were previously not actually testing asynchronicity when the comments indicated that they would. PR-URL: https://github.com/nodejs/node/pull/18676 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/18676 Reviewed-By:
-
