- Aug 28, 2015
-
-
João Reis authored
This is a port of 14db6294. Original commit message: Since install is per machine only, installation path should be stored in local machine instead of current user. The registry stores HKLM in different places for 32 and 64 bit applications, so the installer will not suggest the old path when upgrading from 32 to 64 bit version. Fixes joyent/node#5592 Fixes joyent/node#25087 PR-URL: https://github.com/joyent/node/pull/25640 Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Bert Belder <bertbelder@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2565 Reviewed-By:
Alexis Campailla <alexis@janeasystems.com>
-
João Reis authored
This is an adaptation of 8e805284. Original commit message: The MSI install scope was set to the WiX default, which is per-user. However, with UAC, it could not be installed by a standard user because InstallPrivileges is elevated by default, hence the install scope should be set to per-machine. Furthermore, the default install path is a per-machine location and setting the system path requires administrator privileges. By changing the InstallScope to perMachine, Start Menu shortcuts are placed in ProgramData and not the installing user's AppData folder, making the shortcuts available to other users. This also fixes the installation when AppData is a network folder. The custom action is necessary to allow upgrades. Since a per-machine MSI cannot upgrade an application installed per-user, the custom action checks if there is going to be an upgrade to a previous version installed per-user and sets the installation as per-user to allow upgrading. Hence, the advantages of installing per-machine will only apply in fresh installations. Fixes joyent/node#5849 Fixes joyent/node#7629 PR-URL: https://github.com/joyent/node/pull/25640 Reviewed-By:
Alexis Campailla <alexis@janeasystems.com> Reviewed-By:
Bert Belder <bertbelder@gmail.com> The original commit was adapted to search all upgrade codes listed in the upgrade table, as the current installer tries to upgrade from two different upgrade codes. PR-URL: https://github.com/nodejs/node/pull/2565 Reviewed-By:
Alexis Campailla <alexis@janeasystems.com>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/2482 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Sakthipriyan Vairamani authored
This test was using fixturesDir to create temp files to test. This patch replaces that with tmpDir and uses `assert` module to test. Also, this test has been moved to `parallel`, from `sequential` mode. PR-URL: https://github.com/nodejs/node/pull/2583 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Ben Noordhuis authored
This reverts commit 6cd0e266. This reverts commit 7a999a13. This reverts commit f3375954. It turns out that on Windows, uv_pipe_getsockname() is a no-op for client sockets. It slipped through testing because of a CI snafu. PR-URL: https://github.com/nodejs/node/pull/2584 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Ben Noordhuis authored
Commit f3375954 ("lib,src: add unix socket getsockname/getpeername") accidentally left in a reference to io.js v1.5.0 in the documentation. Update it to say "Node.js v4.0.0", the upcoming release. PR-URL: https://github.com/nodejs/node/pull/2580 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
- Aug 27, 2015
-
-
Ben Noordhuis authored
Complements the existing net.Socket#remoteFamily property. PR-URL: https://github.com/nodejs/node/pull/956 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
The implementation is a minor API change in that socket.address() now returns a `{ address: '/path/to/socket' }` object, like it does for TCP and UDP sockets. Before this commit, it returned `socket._pipeName`, which is a string when present. Change common.PIPE on Windows from '\\\\.\\pipe\\libuv-test' to '\\\\?\\pipe\\libuv-test'. Windows converts the '.' to a '?' when creating a named pipe, meaning that common.PIPE didn't match the result from NtQueryInformationFile(). Fixes: https://github.com/nodejs/node/issues/954 PR-URL: https://github.com/nodejs/node/pull/956 Reviewed-By:Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
Extract the common logic into a template function. No functional changes, just code cleanup. PR-URL: https://github.com/nodejs/node/pull/956 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Сковорода Никита Андреевич authored
Replaced "contents is" with "contents are". Added a note that initial Buffer contents could contain sensitive data. PR-URL: https://github.com/nodejs/node/pull/2574 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Сковорода Никита Андреевич authored
memset() is not useful here, it's efficiently a noop. PR-URL: https://github.com/nodejs/node/pull/2575 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
Sakthipriyan Vairamani authored
Refer: https://github.com/nodejs/io.js/issues/1543 When this test fails, it leaves dead processes in the system. This patch makes sure that the child processes exit first, in case of errors. PR-URL: https://github.com/nodejs/node/pull/2206 Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Alexis Campailla authored
This poplulates the lists of flaky tests with tests that failed recently in Jenkins. PR-URL: https://github.com/nodejs/node/pull/2424 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Alexis Campailla authored
PR-URL: https://github.com/nodejs/node/pull/2424 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Alexis Campailla authored
Adding support for specifying flaky test mode to the test runner: - via an environment variable FLAKY_TESTS for Makefile - via an argument ignore-flaky for vcbuild.bat Ported from https://github.com/joyent/node/commit/2d2494cf140c38327218a087593ff2177a9d0ec9 PR-URL: https://github.com/nodejs/node/pull/2424 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Alexis Campailla authored
Template configuration files for marking tests as flaky. PR-URL: https://github.com/nodejs/node/pull/2424 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Alexis Campailla authored
Make the test runner return a 0 exit code when only flaky tests fail and --flaky-tests=dontcare is specified. Ported from https://github.com/joyent/node/commit/a9b642cf5b539e1b86698465d3d0b941d84c5352 PR-URL: https://github.com/nodejs/node/pull/2424 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Alexis Campailla authored
Adding --flaky-tests option, to allow regarding flaky tests failures as non-fatal. Currently only observed by the TapProgressIndicator, which will add a # TODO directive to tests classified as flaky. According to the TAP specification, the test harness is supposed to treat failures that have a # TODO directive as non-fatal. Ported from https://github.com/joyent/node/commit/df3a2b2cf21274fe7afc19d14ec0259b964e13f7 PR-URL: https://github.com/nodejs/node/pull/2424 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Minwoo Jung authored
There is no type-conversion to be done. Therefore, use the === operator. PR-URL: https://github.com/nodejs/node/pull/2558 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Fedor Indutny authored
Consume StreamBase instance and operate on incoming data directly without allocating Buffer instances. Improves performance. PR-URL: https://github.com/nodejs/node/pull/2355 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Fedor Indutny authored
There might be a need to "kick off" the next tick queue and execute events on it. Normally it is done through the `MakeCallback` interface, but in case when it is not - we need a way to "kick them off" manually. PR-URL: https://github.com/nodejs/node/pull/2355 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Rich Trott authored
Remove use of STDERR to avoid test flakiness on CentOS 5. Use parent process exit event for assertion rather than child exit event. PR-URL: https://github.com/nodejs/node/pull/2541 Fixes: https://github.com/nodejs/node/issues/2477 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
- Aug 26, 2015
-
-
Jeremiah Senkpiel authored
Fixes: 75adde07 PR-URL: https://github.com/nodejs/node/pull/2550 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Rod Vagg authored
Fixes: https://github.com/nodejs/node/issues/2416 PR-URL: https://github.com/nodejs/node/pull/2455 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rod Vagg authored
included: * commands to run to import all active keys * list of previous Node.js releasers key details PR-URL: https://github.com/nodejs/node/pull/2455 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
James M Snell authored
My previous commit landed a bad merge on modules.markdown. This fixes it.
-
James M Snell authored
Per feedback from @thefourtheye: (a) improve word on the description of the `close` event in stream.markdown and (b) remove `[module section]: modules.html` from globals.markdown Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
Per: https://github.com/joyent/node/pull/8878 Originally submitted by @jacksonhoose Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
Per: https://github.com/joyent/node/pull/9009 Originally submitted by @peerwit Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
Per: https://github.com/joyent/node/pull/25102 Originally reported by @kuldipem Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
per: https://github.com/joyent/node/pull/25572#discussion_r33197896 Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
per: https://github.com/joyent/node/pull/25826 originally submitted by: @ClimbsRocks Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
per: https://github.com/joyent/node/pull/25459 originally submitted by @sonnyp Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
per: https://github.com/joyent/node/pull/25356 originally submitted by @dcousens Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
per: https://github.com/joyent/node/pull/7431 originally submitted by @linclark Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
per: https://github.com/joyent/node/pull/7112 originally submitted by @Peekmo Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
per: https://github.com/joyent/node/pull/7715 originally submitted by @tonylukasavage Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
per: https://github.com/joyent/node/pull/7930 originally submitted by @pbrewczynski Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
per: https://github.com/joyent/node/pull/7944 originally submitted by @oconnore Minor update to the description in `fs.exists()` Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-
James M Snell authored
per: https://github.com/joyent/node/pull/8209 originally submitted by @jeromew Reviewed By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> PR-URL: https://github.com/nodejs/node/pull/2378
-