- Apr 06, 2020
-
-
Anna Henningsen authored
Moves state that is specific to the `v8` binding into the `v8` binding implementation as a cleanup. PR-URL: https://github.com/nodejs/node/pull/32538 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Anna Henningsen authored
Moves state that is specific to HTTP/2 into the HTTP/2 implementation as a cleanup. PR-URL: https://github.com/nodejs/node/pull/32538 Reviewed-By:
-
Anna Henningsen authored
Enable the state associated with the individual bindings, e.g. fs or http2, to be moved out of the Environment class, in order for these to be more modular and for Environment to be come less of a collection of random data fields. Do this by using a BaseObject as the data for callbacks, which can hold the per-binding state. By default, no per-binding state is available, although that can be configured when setting up the binding. PR-URL: https://github.com/nodejs/node/pull/32538 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32509 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/32635 Reviewed-By:
-
Harshitha KP authored
Cover the scenario fixed through https://github.com/nodejs/node/pull/31621 Unfortunately there is no easy way to test this, in a cross-platform manner. So the approach is: - open a child process with ulimit restriction on file descriptors - in the child process, start few workers - more than the fd limit - make sure some workers fail, with the expected error type. - skip the test in windows, as there is no ulimit there. Refs: https://github.com/nodejs/node/pull/31621 PR-URL: https://github.com/nodejs/node/pull/31929 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Richard Lau authored
Path to the versions tool tested by test-doctool-versions.js would be incorrect if the test temporary directory was redirected (e.g. via NODE_TEST_DIR) outside of `test/`. Signed-off-by:
Richard Lau <riclau@uk.ibm.com> PR-URL: https://github.com/nodejs/node/pull/32645 Refs: https://github.com/nodejs/node/pull/32518 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Dave Vandyke authored
PR-URL: https://github.com/nodejs/node/pull/32639 Reviewed-By:
-
Anna Henningsen authored
`cp test/addons/.gitignore test/abort/.gitignore`, because the new addon test in there leaves a build/ folder lying around and somebody is bound to use `git add .` earlier or later. Refs: https://github.com/nodejs/node/pull/31740 PR-URL: https://github.com/nodejs/node/pull/32624 Reviewed-By:
-
Sam Roberts authored
The current commit message is wrapped at 80 columns, but commit message descriptions should wrap at 72, so the maintainer has to fix the message up instead of just copying it in. They might not notice that requirement, in which case it has to be fixed during landing because `git node land` notices. To prevent that, make the message template wrap before 72 to keep the landing process as simple as possible. PR-URL: https://github.com/nodejs/node/pull/32602 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32599 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Hassaan Pasha authored
The path for the crypto files in the `deps/openssl/openssl/` after running `cd deps/openssl/config && make` has been changed. The original path `deps/openssl/openssl/crypto/includes/internal/` now maps to `deps/openssl/openssl/includes/crypto`for the files that need to be added for the commit. PR-URL: https://github.com/nodejs/node/pull/32593 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Juan José Arboleda authored
Fixes: https://github.com/nodejs/node/issues/29894 PR-URL: https://github.com/nodejs/node/pull/32513 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32364 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32299 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Harshitha KP authored
`buffer.write` documentation has an incaccuracy w.r.t the `length` parameter: It says default number of bytes written is `buf.length - offset`. Change it to: If the buffer has sufficient space from the offset, the string is written upto `length`. If the buffer is short in space, only `buf.length - offset` bytes are written. Refs: https://github.com/nodejs/node/pull/32104#discussion_r388524733 PR-URL: https://github.com/nodejs/node/pull/32119 Reviewed-By:
-
- Apr 05, 2020
-
-
Rich Trott authored
Remove seemlingly misplaced and/or extraneous comment. Replace countdown with Promise.all. PR-URL: https://github.com/nodejs/node/pull/32540 Reviewed-By:
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/32519 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
- Apr 04, 2020
-
-
Ben Noordhuis authored
The Raspberry Pis are too slow to run this computationally expensive test in a timely manner, it times out after 240 seconds. PR-URL: https://github.com/nodejs/node/pull/32636 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Matheus Marchini authored
Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32521 Refs: https://github.com/v8/v8/compare/8.1.307.20...8.1.307.26 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Matheus Marchini authored
Refs: https://github.com/v8/v8/compare/8.1.307.20...8.1.307.26 PR-URL: https://github.com/nodejs/node/pull/32521 Reviewed-By:
-
Matheus Marchini authored
This reverts commit 75da64c0. PR-URL: https://github.com/nodejs/node/pull/32521 Refs: https://github.com/v8/v8/compare/8.1.307.20...8.1.307.26 Reviewed-By:
-
Robert Nagy authored
The stream will be destroyed upstream through the proper error flow. PR-URL: https://github.com/nodejs/node/pull/29179 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
- Apr 03, 2020
-
-
Richard Lau authored
Document that the return type of `crypto.getFips()` may change in a future semver-major release from a `number` to a `boolean`. PR-URL: https://github.com/nodejs/node/pull/32580 Reviewed-By:
-
Richard Lau authored
`crypto.getFips()` returns a number, not a boolean. PR-URL: https://github.com/nodejs/node/pull/32580 Reviewed-By:
-
Rich Trott authored
Somehow thought I did this in 8905be2c but clearly did not. PR-URL: https://github.com/nodejs/node/pull/32588 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
Anna Henningsen authored
This adds a regression test for terminating a Worker inside which another Worker is running. PR-URL: https://github.com/nodejs/node/pull/32623 Refs: https://github.com/nodejs/node/pull/32531 Reviewed-By:
-
Anna Henningsen authored
This reverts commit 037ac99e. As flaky CI failures have revealed, this feature was implemented incorrectly. `stop_sub_worker_contexts()` needs to be called on the thread on which the `Environment` is currently running, it’s not thread-safe. The current API requires `Stop()` to be thread-safe, though. We could add a new API for this, but unless there’s demand, that’s probably not necessary as `FreeEnvironment()` will also stop Workers, which is commonly the next action on an `Environment` instance after having `Stop()` called on it. Refs: https://github.com/nodejs/node/pull/32531 PR-URL: https://github.com/nodejs/node/pull/32623 Reviewed-By:
-
Harshitha KP authored
Fixes: https://github.com/nodejs/node/issues/32409 PR-URL: https://github.com/nodejs/node/pull/32514 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com>
-
Moni authored
PR-URL: https://github.com/nodejs/node/pull/32567 Reviewed-By:
-
Jan Krems authored
PR-URL: https://github.com/nodejs/node/pull/31303 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
Myles Borins authored
s/PYTHON\_VERSION/python-version Refs: https://github.com/actions/setup-python PR-URL: https://github.com/nodejs/node/pull/32609 Reviewed-By:
-
Nick Kreeger authored
Due to how the Environment class is used throughout the codebase, there are a log of includes referencing eitehr env.h or env-inl.h. This commit cleans up the remaining extra includes of 'env.h' or 'env-inl.h' and adds forward declarations of the Environment class. PR-URL: https://github.com/nodejs/node/pull/32293 Refs: https://github.com/nodejs/node/issues/27531 Fixes: https://github.com/nodejs/node/issues/27531 Reviewed-By:
-
Harshitha KP authored
PR-URL: https://github.com/nodejs/node/pull/32305 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32541 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32278 Fixes: https://github.com/nodejs/node/issues/32250 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32550 Refs: https://github.com/nodejs/node/pull/32541 Reviewed-By:
-
Andrés M. Gómez authored
PR-URL: https://github.com/nodejs/node/pull/32573 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/32183 PR-URL: https://github.com/nodejs/node/pull/32617 Reviewed-By:
-
Robert Nagy authored
Refactors net.Socket into using autoDestroy functionality of streams. PR-URL: https://github.com/nodejs/node/pull/31806 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
