- Mar 06, 2019
-
-
Anna Henningsen authored
Do not require an explicit `HandleScope`, or the ability to create one, when using `Environment::GetCurrent()`. `isolate->InContext()` is used as an indicator that it is probably okay to create a `HandleScope`, see also the short discussion in https://github.com/nodejs/node/pull/25775#pullrequestreview-197371049. PR-URL: https://github.com/nodejs/node/pull/26376 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
cjihrig authored
Reduce the number of emitExperimentalWarning() call sites by making process.report emit a warning on access instead of each individual report function. PR-URL: https://github.com/nodejs/node/pull/26414 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Wyatt Preul <wpreul@gmail.com>
-
cjihrig authored
This commit removes process.report.setOptions(). Instead of using complex configuration synchronization between C++ and JS, this commit introduces individual getters and setters. PR-URL: https://github.com/nodejs/node/pull/26414 Reviewed-By:
-
Benjamin authored
Original commit message: [coverage] Extend SourceRangeAstVisitor for throw statements The SourceRangeAstVisitor has custom logic for blocks ending with a statement that has a continuation range. In these cases, the trailing continuation is removed which makes the reported coverage ranges a bit nicer. throw Error('foo') consists of an ExpressionStatement, with a Throw expression stored within the statement. The source range itself is stored with the Throw, not the statement. We now properly extract the correct AST node for trailing throw statements. R=jgruber@chromium.org, neis@chromium.org, yangguo@chromium.org Bug: v8:8691 Change-Id: Ibcbab79fbe54719a8993045040349c863b139011 Reviewed-on: https://chromium-review.googlesource.com/c/1480632 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59936} Refs: https://github.com/v8/v8/commit/2d08967d4a4b9a43aa2b11781421e09bff3b89ad PR-URL: https://github.com/nodejs/node/pull/26413 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Ruben Bridgewater authored
This adds a small wrapper around the `getColorDepth` function to check if the stream supports at least a specific amount of colors. This is convenient as the other API is not as straight forward and most use cases likely only want to know if a specific amount of colors is supported or not. PR-URL: https://github.com/nodejs/node/pull/26247 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Beth Griggs authored
Notable Changes * **doc** * add antsmartian to collaborators (Anto Aravinth) [#24655](https://github.com/nodejs/node/pull/24655) * **http** * fix error check in Execute() (Brian White) [#25863](https://github.com/nodejs/node/pull/25863) * **stream** * fix end-of-stream for HTTP/2 (Anna Henningsen) [#24926](https://github.com/nodejs/node/pull/24926) PR-URL: https://github.com/nodejs/node/pull/26063 -
Sam Roberts authored
Particularly, ensure that the commit messages are self-explanatory so that reviewers can understand that the large commits are the result of a simple repeatable process. This should make them easier to review. See: https://github.com/nodejs/node/pull/26327#issuecomment-468745161 PR-URL: https://github.com/nodejs/node/pull/26378 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Sam Roberts authored
Since its not packaged, we don't have to delete it, and the Makefile and update can become a (tiny) bit simpler. PR-URL: https://github.com/nodejs/node/pull/26327 Reviewed-By:
-
Sam Roberts authored
`cd deps/openssl/config; make` updates all archs dependant files. PR-URL: https://github.com/nodejs/node/pull/26327 Reviewed-By:
-
Shigeki Ohtsu authored
This is a floating patch against OpenSSL-1.1.1 to generate asm files with Makefile rules. PR-URL: https://github.com/nodejs/node/pull/26327 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
-
Sam Roberts authored
This updates all sources in deps/openssl/openssl with openssl-1.1.1b. PR-URL: https://github.com/nodejs/node/pull/26327 Reviewed-By:
-
Sam Roberts authored
This reverts commit f395a4a4. As of openssl-1.1.1b, the dot-files are no longer distributed, so this is no longer necessary. PR-URL: https://github.com/nodejs/node/pull/26327 Reviewed-By:
-
- Mar 05, 2019
-
-
Tobias Nießen authored
This change allows passing private key objects to crypto.createPublicKey, resulting in a key object that represents a valid public key for the given private key. The returned public key object can be used and exported safely without revealing information about the private key. PR-URL: https://github.com/nodejs/node/pull/26278 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
cjihrig authored
This commit adds support for the resourceUsage report section on Windows by using uv_getrusage() instead of getrusage(). PR-URL: https://github.com/nodejs/node/pull/26406 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26336 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26354 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Jeremy Apthorp authored
PR-URL: https://github.com/nodejs/node/pull/26365 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26396 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
-
leeight authored
In `_tls_wrap.js` while calling `socket.connect` the `localPort` was missing, restore it. PR-URL: https://github.com/nodejs/node/pull/24554 Fixes: https://github.com/nodejs/node/issues/24543 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/25818 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26275 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26284 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/26310 Reviewed-By:
-
Aymen Naghmouchi authored
PR-URL: https://github.com/nodejs/node/pull/26318 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
So far the benchmarks created a highly specialized function which would inline exactly to the input. This changes it to provide a more realistic view to actual input by changing the input on each iteration. That prevents the function to be to specific. It also reduces the number of iterations the benchmarks are run to reduce the overall runtime. A microbenchmark should already show a significant difference with lower iterations, otherwise the significance for real world applications is only limited. PR-URL: https://github.com/nodejs/node/pull/26359 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Use a `v8::Object` with an internal field, rather than a `v8::External`. On a `GetReturnValue().Set(Environment::GetCurrent(args) == nullptr)` noop function, this benchmarks as a ~60 % speedup, as calls to `obj->GetAlignedPointerFromInternalField()` can be inlined and the field is stored with one level of indirection less. This also makes breaking up some pieces of the `Environment` class into per-native-binding data easier, if we want to pursue that path in the future. PR-URL: https://github.com/nodejs/node/pull/26382 Reviewed-By:
-
Michael Dawson authored
The support matrix was out of date. Update with current status. Fixes: https://github.com/nodejs/node/issues/25801 PR-URL: https://github.com/nodejs/node/pull/26377 Reviewed-By:
-
Rich Trott authored
The test_threadsafe_function doesn't seem to be flaky anymore on Windows. Optimistically removing the flaky designation in the relevant status file. Refs: https://github.com/nodejs/node/issues/23621#issuecomment-468938980 PR-URL: https://github.com/nodejs/node/pull/26403 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Rich Trott authored
Enable ESLint rules for trailing commas and arrow callbacks in tools directory. These rules are also in place in the benchmark directory. PR-URL: https://github.com/nodejs/node/pull/26394 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Rich Trott authored
* standardize on arrow functions for callbacks * standaradize on trailing commas for multiline arrays PR-URL: https://github.com/nodejs/node/pull/26394 Reviewed-By:
-
Sam Roberts authored
Its unused by node, and doesn't have a reasonable use outside of node. See: https://github.com/nodejs/node/pull/25153 See: https://github.com/nodejs/node/pull/16158 PR-URL: https://github.com/nodejs/node/pull/26245 Reviewed-By:
-
Sam Roberts authored
Clarify how it must behave for both synchronous and asynchronous completion. PR-URL: https://github.com/nodejs/node/pull/26339 Reviewed-By:
-
Pavel Feldman authored
Fixes: https://github.com/nodejs/node/issues/25808 PR-URL: https://github.com/nodejs/node/pull/26303 Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
- Mar 04, 2019
-
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/25685 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
-
Jon Kunkee authored
PR-URL: https://github.com/nodejs/node/pull/25995 Reviewed-By:
João Reis <reis@janeasystems.com>
-
Jon Kunkee authored
PR-URL: https://github.com/nodejs/node/pull/25995 Reviewed-By:
-
Jon Kunkee authored
PR-URL: https://github.com/nodejs/node/pull/25995 Reviewed-By:
-
Jon Kunkee authored
PR-URL: https://github.com/nodejs/node/pull/25995 Reviewed-By:
-
Jon Kunkee authored
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used to pass arbitrary flags to MSBuild. It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to enable binary logging to `%config%\node.binlog`. This is especially convenient when debugging changes to the build system. In the process of developing this change, the idea of adding 'setlocal' to the beginning of the script was rejected since other scripts in this repo rely on the exported environment variables. This change adds a note describing this. PR-URL: https://github.com/nodejs/node/pull/25994 Reviewed-By:
-
Rich Trott authored
Update lint-md.js from updated rollup modules. PR-URL: https://github.com/nodejs/node/pull/26393 Reviewed-By:
-
