- Jan 20, 2019
-
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/25547 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Jan 19, 2019
-
-
Myles Borins authored
v11.6.0 ended up shipping with an npm version `6.5.0-next.0`. This test should avoid it happening in the future. PR-URL: https://github.com/nodejs/node/pull/25538 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com>
-
- Jan 18, 2019
-
-
Michael Dawson authored
Coverage report for src/node_i18n.cc shows that the Has() method is not covered. This test adds coverage for that method. PR-URL: https://github.com/nodejs/node/pull/25428 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/25562 Reviewed-By:
-
Ruben Bridgewater authored
Notable Changes * compression / zlib: * Added brotli support (Anna Henningsen and Zach Vacura) https://github.com/nodejs/node/pull/24938 * console: * Added `inspectOptions` option (Ruben Bridgewater) https://github.com/nodejs/node/pull/24978 * crypto: * Always accept private keys as public keys (Tobias Nießen) https://github.com/nodejs/node/pull/25217 * deps: * Upgrade npm to v6.5.0 (Jordan Harband) https://github.com/nodejs/node/pull/25234 * fs: * Use internalBinding('fs') internally instead of process.binding('fs') (Masashi Hirano) https://github.com/nodejs/node/pull/22478 * http(s): * Support overriding http\\s.globalAgent (Roy Sommer) https://github.com/nodejs/node/pull/25170 * util: * Inspect ArrayBuffers contents closely (Ruben Bridgewater) https://github.com/nodejs/node/pull/25006 * worker: * Expose workers by default and remove `--experimental-worker` flag (Anna Henningsen) https://github.com/nodejs/node/pull/25361 PR-URL: https://github.com/nodejs/node/pull/25537 -
Daniel Bevenius authored
Currently the following compiler warnings is generated: ../src/node_report.cc:778:43: warning: format specifies type 'unsigned long' but the argument has type 'rlim_t' (aka 'unsigned long long') [-Wformat] snprintf(buf, sizeof(buf), "%lu", limit.rlim_max); ~~~ ^~~~~~~~~~~~~~ %llu 1 warning generated. This commit changes the format specifier to $llu. PR-URL: https://github.com/nodejs/node/pull/25557 Reviewed-By:Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Daniel Bevenius authored
Currently, test-cli-node-print-help uses common.hasFipsCrypto to determine if the test should check for the existence of FIPS related options (--enable-fips, and --force-fips). The FIPS options are available when node has been compiled against an OpenSSL library with FIPS support in which case the test would verify that these options are available. But by using crypto.fips (which uses crypto.getFips()) this would only be checked when fips has been enabled, but these options are available regardless if FIPS is enabled or disabled. This commit updates the test to use fipsMode from config to determine if the FIPS options existence should be checked. PR-URL: https://github.com/nodejs/node/pull/25510 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Ruben Bridgewater authored
The fallback should only be taken for a null prototype. If an iterable data type (e.g., Array) has a prototype without `Symbol.iterator`, just try the best to visualize it as object. PR-URL: https://github.com/nodejs/node/pull/25457 Fixes: https://github.com/nodejs/node/issues/25451 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Anna Henningsen authored
Only use the amount of data that was actually read from the test file. Otherwise, there is a small risk of getting false positives, and generally reading uninitialized memory makes using automated memory error detection tools harder. PR-URL: https://github.com/nodejs/node/pull/25475 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
LakshmiSwethaG authored
One test per each API, so that additional tests in future are modular. test/common/report.js contain common functions that tests leverage. PR-URL: https://github.com/nodejs/node/pull/22712 Reviewed-By:
Michael Dawson <Michael_Dawson@ca.ibm.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com>
-
Vipin Menon authored
a separate section added for node-report at top level main documentation added to doc/api/report.md API documentation added to doc/api/process.md PR-URL: https://github.com/nodejs/node/pull/22712 Reviewed-By:
-
Gireesh Punathil authored
Make node-report part of core runtime because: 1. When enabled, node-report significantly helps root cause various types of problems, including support issues sent to the various repos of the Node.js organization. 2. The requirement of explicitly adding the dependency to node-report in user applications often represents a blocker to adoption. Major deviation from the module version of the node-report is that the report is generated in JSON format, as opposed to human readable text. No new functionalities have been added, changes that are required for melding it as a built-in capability has been affected on the module version of node-report (https://github.com/nodejs/node-report ) Co-authored-by:
Bidisha Pyne <bidipyne@in.ibm.com> Co-authored-by:
Howard Hellyer <hhellyer@uk.ibm.com> Co-authored-by:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Co-authored-by:
Julian Alimin <dmastag@yahoo.com> Co-authored-by:
Lakshmi Swetha Gopireddy <lakshmigopireddy@in.ibm.com> Co-authored-by:
Manusaporn Treerungroj <m.treerungroj@gmail.com> Co-authored-by:
Richard Chamberlain <richard_chamberlain@uk.ibm.com> Co-authored-by:
Vipin Menon <vipinmv1@in.ibm.com> PR-URL: https://github.com/nodejs/node/pull/22712 Reviewed-By:
-
Yael Hermon authored
This PR adds the ability to provide Workers with their own execArgv flags in replacement of the main thread's execArgv. Only per-Isolate/per-Environment options are allowed. Per-Process options and V8 flags are not allowed. Passing an empty execArgv array will reset per-Isolate and per-Environment options of the Worker to their defaults. If execArgv option is not passed, the Worker will get the same flags as the main thread. Usage example: ``` const worker = new Worker(__filename, { execArgv: ['--trace-warnings'], }); ``` PR-URL: https://github.com/nodejs/node/pull/25467 Reviewed-By:Joyee Cheung <joyeec9h3@gmail.com>
-
H1Gdev authored
PR-URL: https://github.com/nodejs/node/pull/25544 Reviewed-By:
-
Rich Trott authored
Reduce the time it takes to run test/pummel/test-hash-seed by switching from spawnSync() to spawn(). On my computer, this reduces the runtime from about 80 seconds to about 40 seconds. This test is not (yet) run regularly on CI, but when it was run recently, it timed out. PR-URL: https://github.com/nodejs/node/pull/25522 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
-
Rich Trott authored
Replace min() function with Math.min(...). PR-URL: https://github.com/nodejs/node/pull/25522 Reviewed-By:
-
Rich Trott authored
test/pummel/test-keep-alive.js requires `wrk` to be installed. Check if it is, and skip the test if it isn't. This is yet another step in preparation for running pummel tests in CI daily. PR-URL: https://github.com/nodejs/node/pull/25516 Reviewed-By:
-
Michael Dawson authored
Fixes: https://github.com/nodejs/TSC/issues/650 PR-URL: https://github.com/nodejs/node/pull/25535 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
cjihrig authored
Refs: https://github.com/nodejs/node/issues/25448 PR-URL: https://github.com/nodejs/node/pull/25526 Reviewed-By:
-
Michael Dawson authored
This reverts commit f216d5bb. Seems like it breaks the nightly job so reverting until we figure that out. PR-URL: https://github.com/nodejs/node/pull/25543 Reviewed-By:
-
- Jan 17, 2019
-
-
Bradley Farias authored
This enables code loaded via the module system to be checked for integrity to ensure the code loaded matches expectations. PR-URL: https://github.com/nodejs/node/pull/23834 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/25425 Reviewed-By:
-
Sam Roberts authored
- DEFAULT_ECDH_CURVE default changed to 'auto' for 10.0.0 - ecdhCurve parameter allowed multiple values and 'auto' from 9.0.0 PR-URL: https://github.com/nodejs/node/pull/25502 Reviewed-By:
-
Daniel Bevenius authored
Currently, while FIPS is not supported yet for this release there might be an option to dynamically link against a FIPS compatible OpenSSL version. This commit fixes the compiler errors. PR-URL: https://github.com/nodejs/node/pull/25412 Reviewed-By:
-
Daniel Bevenius authored
This commit introduces a new configuration flag named --openssl-is-fips which is intended to be used when linking against an OpenSSL library that is FIPS compatible. The motivation for this is that Red Hat Enterprise Linux 8 (RHEL8) comes with OpenSSL 1.1.1 and includes FIPS support, and we would like to be able to dynamically link against this version and also have FIPS features enabled in node, like would be done when statically linking and using the --openssl-fips flag. The suggestion here is to introduce a new flag: $ ./configure --help ... --openssl-is-fips specifies that the shared OpenSSL version is FIPS compatible This flag could be used in combination with the shared-openssl flag: $ ./configure --shared-openssl ---openssl-is-fips This will enable FIPS support in node and the runtime flags will be availalbe to enable FIPS (--enable-fips, --force-fips). PR-URL: https://github.com/nodejs/node/pull/25412 Reviewed-By: -
Benjamin Coe authored
Original commit message 9365d09: [coverage] Rework continuation counter handling This changes a few bits about how continuation counters are handled. It introduces a new mechanism that allows removal of a continuation range after it has been created. If coverage is enabled, we run a first post-processing pass on the AST immediately after parsing, which removes problematic continuation ranges in two situations: 1. nested continuation counters - only the outermost stays alive. 2. trailing continuation counters within a block-like structure are removed if the containing structure itself has a continuation. R=bmeurer@chromium.org, jgruber@chromium.org, yangguo@chromium.org Bug: v8:8381, v8:8539 Change-Id: I6bcaea5060d8c481d7bae099f6db9f993cc30ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1339119 Reviewed-by:Yang Guo <yangguo@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#58443} Refs: v8/v8@9365d09 Original commit message aac2f8c: [coverage] Filter out singleton ranges that alias full ranges Block coverage is based on a system of ranges that can either have both a start and end position, or only a start position (so-called singleton ranges). When formatting coverage information, singletons are expanded until the end of the immediate full parent range. E.g. in: {0, 10} // Full range. {5, -1} // Singleton range. the singleton range is expanded to {5, 10}. Singletons are produced mostly for continuation counters that track whether we execute past a specific language construct. Unfortunately, continuation counters can turn up in spots that confuse our post-processing. For example: if (true) { ... block1 ... } else { ... block2 ... } If block1 produces a continuation counter, it could end up with the same start position as the else-branch counter. Since we merge identical blocks, the else-branch could incorrectly end up with an execution count of one. We need to avoid merging such cases. A full range should always take precedence over a singleton range; a singleton range should never expand to completely fill a full range. An additional post-processing pass ensures this. Bug: v8:8237 Change-Id: Idb3ec7b2feddc0585313810b9c8be1e9f4ec64bf Reviewed-on: https://chromium-review.googlesource.com/c/1273095 Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
- Jan 16, 2019
-
-
Anna Henningsen authored
Call `Environment::Exit()` rather than the process-wide `exit()` function, since JS exceptions generally only affect the current JS engine instance. PR-URL: https://github.com/nodejs/node/pull/25472 Reviewed-By:
-
Anna Henningsen authored
This makes sure that `StopTracingAgent()` is always called before tearing down the `tracing::Agent`, since previously its destructor might have tried to access the agent, which would be destroyed by the (earlier) `Dispose()` call. PR-URL: https://github.com/nodejs/node/pull/25472 Reviewed-By:
-
Rich Trott authored
* Use port 0 instead of `common.PORT`. * Use `//` for comments, capitalize comments, and add punctuation. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By:
-
Rich Trott authored
* Use port 0 instead of `common.PORT`. * Reduce `concurrent` from 100 to 50 and `connections_per_client` from 5 to 3. This is to avoid side effects from other tests. Prior to this change, running this along with test-keep-alive would result in failures on my local setup, apparently due to network throttling. * Remove unnecessary `console.log()` and improve remaining `console.log()` to provide clearer information. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By:
-
Rich Trott authored
* Reduce ROUNDS and ATTEMPTS_PER_ROUND by half to avoid spurious test failures as a result of side effects from other tests. (For my local setup, test-keep-alive seems to cause this test to fail with ETIMEDOUT and/or EADDRNOTAVAIL. It would seem to be a result of throttling. Reducing the pummel-iness of that test and this one seems to solve the problem.) * Apply capitalization and punctuation to comment. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By:
-
Rich Trott authored
* Reduce concurrent and duration options by half so as to avoid interference with other tests. (Excessive TCP activity in this test resulted in throttling that caused subsequent tests to fail on my local setup.) * Use an OS-provided port rather than `common.PORT`. This possibly reduces side-effects on other tests (that may also be using `common.PORT`). * Add punctuation in comments. PR-URL: https://github.com/nodejs/node/pull/25485 Reviewed-By:
-
Joyee Cheung authored
Remove the following properties: - `preserveSymlinks` - `preserveSymlinksMain` - `experimentalModules` - `userLoader` - `experimentalVMModules` - `experimentalREPLAwait` - `exposeInternals` We used to use them to pass cli option values from C++ into JS, but now the values are obtained in JS land using `require('internal/options').getOptionValue` instead so they are unused. Also removes `test/parallel/test-internal-modules-expose.js` which tests `--expose-internals`. We already have hundreds of tests depending on `--expose-internals`, they are more than enough to test the functionality of the flag. PR-URL: https://github.com/nodejs/node/pull/25463 Reviewed-By: -
Joyee Cheung authored
Instead of using `internalBinding('config')` which should be used to carry information about build-time options, directly pass the run-time cli options into bootstrap/loaders.js lexically via function arguments. PR-URL: https://github.com/nodejs/node/pull/25463 Reviewed-By: -
Joyee Cheung authored
So it's easier to tell the side effects of this setup. PR-URL: https://github.com/nodejs/node/pull/25443 Reviewed-By:
-
Eugene Ostroukhov authored
Many Inspector protocol clients rely on the top frame reported for the console messages. This test makes sure correct location is reported. PR-URL: https://github.com/nodejs/node/pull/25455 Reviewed-By:
-
Joyee Cheung authored
- Renamed `internal/process/write-coverage.js` to `internal/coverage-gen/with_instrumentation.js`, `internal/process/coverage.js` to `internal/coverage-gen/with_profiler.js` to distinguish the two better and added comments. - Separate the coverage directory setup and the connection setup, moves the directory setup into `node.js` and closer to the exit hooks because that's where it's used. - Moves the `process.reallyExit` overwrite and `process.on('exit')` hooks setup into bootstrap/node.js for clarity, and move them to a later stage of bootstrap since they do not have to happen that early. PR-URL: https://github.com/nodejs/node/pull/25398 Reviewed-By:Ben Coe <bencoe@gmail.com>
-
Minwoo Jung authored
For an unsupported OS, a call to os.cpus() throws an error within os.cpus() itself where it tries to get the length of it. This fixes the issue by adding fallback for undefined CPUs. Fixes: https://github.com/nodejs/node/issues/25483 PR-URL: https://github.com/nodejs/node/pull/25493 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/25481 Reviewed-By:
-
Joyee Cheung authored
The idea is to allow the C++ layer to run arbitrary scripts as the main script. This paves the way for - cctest of the execution of Node.js instances - Earlier handling of per-process CLI options that affect execution modes (those usually do not make sense for the embedders). - Targets like mkcodecache or mksnapshot. Also moves the handling of `_third_party_main.js` into C++. PR-URL: https://github.com/nodejs/node/pull/25474 Reviewed-By:
-
