- Aug 07, 2020
-
-
Anna Henningsen authored
Fix linter failures when running the linter on all source files. PR-URL: https://github.com/nodejs/node/pull/34582 Refs: https://github.com/nodejs/node/pull/34565 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
The test is timing out once in a very long while on Windows CI. It is unclear where the test gets stuck, so add more debugging statements to try to locate it. Refs: https://github.com/nodejs/node/issues/24397 PR-URL: https://github.com/nodejs/node/pull/34603 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Rich Trott authored
The test is timing out once in a very long while on Windows CI. It is unclear where the test gets stuck, so add more debugging statements to try to locate it. Refs: https://github.com/nodejs/node/issues/24397 PR-URL: https://github.com/nodejs/node/pull/34603 Reviewed-By:
-
iandrc authored
Add a line that IBM i does not support `fs.watch()`. Fixes: https://github.com/nodejs/node/issues/34607 Refs: https://nodejs.org/docs/latest/api/fs.html#fs_availability PR-URL: https://github.com/nodejs/node/pull/34611 Reviewed-By:
-
aetheryx authored
PR-URL: https://github.com/nodejs/node/pull/34550 Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Mateusz Krawczuk authored
PR-URL: https://github.com/nodejs/node/pull/33929 Reviewed-By:
Alba Mendez <me@alba.sh> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Mary Marchini authored
It's possible to annotate failures in Actions by printing "::error file={},line={},col={}::{message}". This methos is preferrable over using a problem matcher because problem matchers only allow single-line messages, whereas ::error allows multi-line messages. PR-URL: https://github.com/nodejs/node/pull/34590 Reviewed-By:Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34534 Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Rich Trott authored
We use _Class Method_ rather than _static_ in documentation headers in buffer.md and crypto.md. We use _static_ in one place in async_hooks.md. Change to _Class Method_ for consistency. PR-URL: https://github.com/nodejs/node/pull/34626 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
Anna Henningsen authored
Sometimes addons need to perform cleanup actions, for example closing libuv handles or waiting for requests to finish, that cannot be performed synchronously. Add C++ API and N-API functions that allow providing such asynchronous cleanup hooks. Fixes: https://github.com/nodejs/node/issues/34567 PR-URL: https://github.com/nodejs/node/pull/34572 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
Gerhard Stoebich authored
Only call executionAsyncResource() in getStore() if the ALS instance is enabled because the resource is not needed otherwise. PR-URL: https://github.com/nodejs/node/pull/34617 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Gerhard Stoebich authored
Inspired by the callstack at https://github.com/nodejs/node/issues/34556#issuecomment-666743528 If the wanted store is equal to the active store it's not needed to create an AsyncResource. Refs: https://github.com/nodejs/node/issues/34556#issuecomment-666743528 PR-URL: https://github.com/nodejs/node/pull/34616 Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com>
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/34649 Reviewed-By:
Mary Marchini <oss@mmarchini.me>
-
- Aug 06, 2020
-
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/34634 Reviewed-By:
-
Gabriel Schulhof authored
* Prefix functions with `static` to make them local * Remove anonymous namespaces * `nullptr` -> `NULL` * .cc -> .c and update binding.gyp * `static_cast<x>()` -> `(x)()` * Replace `new`/`delete` with `malloc()`/`free()` (only in test_callback_scope) * Move lambda out and convert to local function (only in test_callback_scope) * Remove superfluous `#include <vector>` (only in test_callback_scope_recurse) Some tests are best left as C++. ```bash ls -l test/{node-api,js-native-api}/*/*.cc ``` for those remaining as C++ tests. Signed-off-by:Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/34404 Reviewed-By:
-
Mary Marchini authored
Ref: https://github.com/nodejs/node/issues/34594#issuecomment-669245839 PR-URL: https://github.com/nodejs/node/pull/34635 Reviewed-By:
-
- Aug 05, 2020
-
-
Myles Borins authored
Currently the error is rather ambiguous and does not inform folks that static import is not supported in the repl. This overrides the default error message with one that is more informative. Closes: https://github.com/nodejs/node/issues/33576 PR-URL: https://github.com/nodejs/node/pull/33588 Fixes: https://github.com/nodejs/node/issues/33576 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Ruy Adorno authored
Add Ruy Adorno and his Release key. Refs: https://github.com/nodejs/Release/pull/597 PR-URL: https://github.com/nodejs/node/pull/34628 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Corey Butler authored
Many users assume the act of assigning a value to `process.title` will update the name of their application in apps like macOS Activity Monitor or Windows Services Manager. This has worked in the past, but fails in some versions of Node.js. Ultimately developers are left confused, especially when it works in one version of Node.js and not another. Given the recurring nature and complexity of the underlying problem, it does not seem like a resolvable problem. This note clarifies the source of the problem, sets developer expectations. Refs: https://github.com/nodejs/node/issues/28945 PR-URL: https://github.com/nodejs/node/pull/34557 Fixes: https://github.com/nodejs/node/issues/34280 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Rich Trott authored
Per Microsoft style guide: > When ability is what you need to express, it's OK to use _can_ to > describe actions or tasks that the reader or program is able to do. > Use _might_ to express possibility. Don't use _may_, which might be > interpreted as providing permission. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may Refs: https://github.com/nodejs/node/pull/34353#issuecomment-659169228 PR-URL: https://github.com/nodejs/node/pull/34613 Reviewed-By:
-
Rich Trott authored
Per Microsoft style guide: > When ability is what you need to express, it's OK to use _can_ to > describe actions or tasks that the reader or program is able to do. > Use _might_ to express possibility. Don't use _may_, which might be > interpreted as providing permission. Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/c/can-may Refs: https://github.com/nodejs/node/pull/34353#issuecomment-659169228 PR-URL: https://github.com/nodejs/node/pull/34613 Reviewed-By:
-
Gerhard Stoebich authored
The length property should be non enumerable to match behavior of normal functions. The asyncResource property is enumerable and therefore it should be also writable to avoid issues like there: https://github.com/nodejs/node/pull/30932#discussion_r379679982 Both properties should be configurable. Refs: https://github.com/nodejs/node/pull/34574 PR-URL: https://github.com/nodejs/node/pull/34620 Reviewed-By:
-
- Aug 04, 2020
-
-
Anna Henningsen authored
These tests were written a long time ago, and use the allocation of large amounts of unused memory as a way to detect use-after-free problems with Buffers. As a result, the tests are resource-intensive and may crash because of that. Replace them with a more modern test. We don’t explicitly try to *detect* use-after-free conditions, and instead rely on e.g. ASAN (or the process just crashing hard) to do that for us. Fixes: https://github.com/nodejs/node/issues/34527 PR-URL: https://github.com/nodejs/node/pull/34530 Reviewed-By:
-
James M Snell authored
Creates an internal AsyncResource and binds a function to it, ensuring that the function is invoked within execution context in which bind was called. PR-URL: https://github.com/nodejs/node/pull/34574 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34416 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Bradley Farias authored
This is a workaround for the REPL for a problem when multiple of the entries have the same source text Fixes: https://github.com/nodejs/node/issues/1337 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10284 PR-URL: https://github.com/nodejs/node/pull/34372 Reviewed-By:
-
Myles Borins authored
This unflags Top-Level await so it can be used by default in the module goal. This is accomplished by manually setting the --harmony-top-level-await flag. We are allowing this as a one of approval based on circumstances. It is not a precedent that future harmony features will be manually enabled. Refs: https://github.com/nodejs/node/issues/34551 PR-URL: https://github.com/nodejs/node/pull/34558 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Robert Nagy authored
Refs: https://github.com/nodejs/node/pull/34578#issuecomment-667941698 PR-URL: https://github.com/nodejs/node/pull/34609 Reviewed-By:
-
- Aug 03, 2020
-
-
cjihrig authored
Update ESLint to 7.6.0 PR-URL: https://github.com/nodejs/node/pull/34589 Reviewed-By:
-
cjihrig authored
This commit adds the meta.fixable property to all fixable ESLint rules. This is required as of ESLint 7.6.0. PR-URL: https://github.com/nodejs/node/pull/34589 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34541 Reviewed-By:
-
James M Snell authored
Alternative to `CallbackScope` that handles destroying the `QuicSession` in the try_catch cleanup. PR-URL: https://github.com/nodejs/node/pull/34541 Reviewed-By:
-
James M Snell authored
Refactor the `'clientHello'` event into a `clientHelloHandler` configuration option and async function. Remove the addContext API as it's not needed. PR-URL: https://github.com/nodejs/node/pull/34541 Reviewed-By:
-
Tim Perry authored
PR-URL: https://github.com/nodejs/node/pull/34531 Reviewed-By:
-
Andrey Pechkurov authored
Native side of fast-path promise hook was not calling JS fastPromiseHook function when there were no async ids previously assigned to the promise. Because of that already created promises could not get id assigned in situations when an async hook without a before listener function is enabled after their creation. As the result executionAsyncId could return wrong id when called within promise's .then(). Refs: https://github.com/nodejs/node/pull/34512 PR-URL: https://github.com/nodejs/node/pull/34548 Reviewed-By:
-
Anna Henningsen authored
460c81dc introduced a bug where the execution resource was not stored properly if we needed to call into C++ to extend the stack size. Fix that bug by always storing the resource. Refs: https://github.com/nodejs/node/pull/34319 Fixes: https://github.com/nodejs/node/issues/34556 PR-URL: https://github.com/nodejs/node/pull/34573 Reviewed-By:
-
Rich Trott authored
The buffer-as-path test for fs.symlinkSync() is a bit unusual and potentially error-prone embedded in the general fs.symlink() test. Move it to its own test file. Refs: https://github.com/nodejs/node/pull/34540/files#r463168354 PR-URL: https://github.com/nodejs/node/pull/34569 Reviewed-By:
Pranshu Srivastava <rexagod@gmail.com> Reviewed-By:
-
Gerhard Stoebich authored
Use a microtask to call destroy hooks in case there are a lot queued as immediate may be scheduled late in case of long running promise chains. Queuing a mircrotasks in GC context is not allowed therefore an interrupt is triggered to do this in JS context as fast as possible. fixes: https://github.com/nodejs/node/issues/34328 refs: https://github.com/nodejs/node/issues/33896 PR-URL: https://github.com/nodejs/node/pull/34342 Fixes: https://github.com/nodejs/node/issues/34328 Refs: https://github.com/nodejs/node/issues/33896 Reviewed-By:
-
Renée Kooi authored
The documentation said `napi_typeof` is similar to the `typeof` operator, but the `typeof null` detects `'object'` while `napi_typeof(a_null_value)` detects `napi_null`. PR-URL: https://github.com/nodejs/node/pull/34577 Reviewed-By:
-
