- Oct 20, 2017
-
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/16268 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
mog422 authored
A web server such as nginx assumes that upstream is dead if upstream closes the socket without any response. PR-URL: https://github.com/nodejs/node/pull/15324 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Rich Trott authored
Use `make doc-only` instead of `make doc` where applicable. PR-URL: https://github.com/nodejs/node/pull/16309 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
`test-make-doc` fails in CI on Raspberry Pi devices where `test-ci-js` runs the test but does not build the docs. We do not want to build the docs in these cases. Move the test to the `doctool` suite and add that suite to `IGNORED_SUITES` in `test.py`. Specify `doctool` as a test suite to run with `make test` or `make test-ci` but not with the `make test-ci-js` job run on cross-compiled fanned CI tests like we do with Raspberry Pi devices in CI. PR-URL: https://github.com/nodejs/node/pull/16301 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/16158 Reviewed-By:
-
Anna Henningsen authored
This makes a subsequent possible deprecation easier. PR-URL: https://github.com/nodejs/node/pull/16158 Reviewed-By:
-
elisa lee authored
PR-URL: https://github.com/nodejs/node/pull/16095 Reviewed-By:
-
- Oct 19, 2017
-
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/16311 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Nicu Micleușanu <micnic90@gmail.com> Reviewed-By:
-
jBarz authored
The test requires a file size limit that is greater than the string size limit. Some aix machines might not meet this criteria so in which case we should skip the test. PR-URL: https://github.com/nodejs/node/pull/16273 Fixes: https://github.com/nodejs/node/issues/16319 Reviewed-By:
MichaëZasso <targos@protonmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/16199 Reviewed-By:
-
Anatoli Papirovski authored
An extra space was not caught by the linter due to what appears to be a bug in eslint 4.3.0 — remove it. PR-URL: https://github.com/nodejs/node/pull/16199 Reviewed-By:
-
Trivikram Kamat authored
This simplifies validation of te header and adds a test case in which array with two values is passed to param value in isIllegalConnectionSpecificHeader PR-URL: https://github.com/nodejs/node/pull/16246 Refs: https://github.com/nodejs/node/issues/14985 Reviewed-By:
-
Gibson Fahnestock authored
Deletes the old test-npm.sh script. PR-URL: https://github.com/nodejs/node/pull/11540 Refs: https://github.com/nodejs/node/pull/7867 Reviewed-By:
-
Andreas Madsen authored
PR-URL: https://github.com/nodejs/node/pull/15454 Ref: https://github.com/nodejs/node/pull/14387 Ref: https://github.com/nodejs/node/pull/14722 Ref: https://github.com/nodejs/node/issues/14717 Ref: https://github.com/nodejs/node/issues/15448 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/16307 Reviewed-By:
-
Nikolai Vavilov authored
PR-URL: https://github.com/nodejs/node/pull/16289 Fixes: https://github.com/nodejs/node/issues/16288 Reviewed-By:
-
Gabriel Schulhof authored
* namespaced functions such as v8impl::JsHandleScopeFromV8HandleScope become part of Node's public symbols unless they are declared static. * the class uvimpl::Work needs to be enclosed in an anonymous namespace else it, too becomes part of Node's public symbols. * remove references to EXTERNAL_NAPI. PR-URL: https://github.com/nodejs/node/pull/16234 Reviewed-By:
-
Bartosz Sosnowski authored
PR-URL: https://github.com/nodejs/node/pull/15409 Fixes: https://github.com/nodejs/node/issues/14553 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By:
-
Daniel Abrão authored
PR-URL: https://github.com/nodejs/node/pull/15873 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/16219 Refs: https://github.com/nodejs/node/pull/15362 Reviewed-By:
-
Nikhil Komawar authored
The 'Main' function in tools/test.py file was using a variable named ``all_outcomes`` to store a value not being used. It is a best practice to name unused variables, often return values of functions/methods (as in this case) as ``_`` [1]. This just helps keep the code a bit cleaner and avoid any silly mistakes. PR-URL: https://github.com/nodejs/node/pull/16171 Refs: [1] https://stackoverflow.com/a/5477153 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By:
-
Braden Whitten authored
PR-URL: https://github.com/nodejs/node/pull/15867 Reviewed-By:
-
Supamic authored
PR-URL: https://github.com/nodejs/node/pull/16040 Reviewed-By:
-
Omar Gonzalez authored
PR-URL: https://github.com/nodejs/node/pull/16035 Reviewed-By:
-
Braden Whitten authored
Fixes a line of uncovered code in the AsyncWrap class's constructor. Specifically this covers validtion of the 'promiseResolve' argument. PR-URL: https://github.com/nodejs/node/pull/16025 Reviewed-By:
-
Martin Michaelis authored
The `net`, `tls`, `http` and `https` module have the same `server.listen()` method, but have a different documenation. Changed to a consistent link to the documentation of the `net` module. PR-URL: https://github.com/nodejs/node/pull/16020 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Jack Wang authored
PR-URL: https://github.com/nodejs/node/pull/15983 Reviewed-By:
-
Stefania Sharp authored
PR-URL: https://github.com/nodejs/node/pull/15991 Reviewed-By:
Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-By:
-
Kanika Shah authored
PR-URL: https://github.com/nodejs/node/pull/15959 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Oscar Funes authored
PR-URL: https://github.com/nodejs/node/pull/15938 Reviewed-By:
-
Oscar Funes authored
PR-URL: https://github.com/nodejs/node/pull/15938 Reviewed-By:
-
Oscar Funes authored
PR-URL: https://github.com/nodejs/node/pull/15938 Reviewed-By:
-
Jean-Philippe Blais authored
PR-URL: https://github.com/nodejs/node/pull/15924 Reviewed-By:
-
Jean-Philippe Blais authored
PR-URL: https://github.com/nodejs/node/pull/15924 Reviewed-By:
-
Gene Wu authored
PR-URL: https://github.com/nodejs/node/pull/15875 Reviewed-By:
-
Alvaro Cruz authored
PR-URL: https://github.com/nodejs/node/pull/15874 Reviewed-By:
-
Lance Barlaan authored
PR-URL: https://github.com/nodejs/node/pull/15872 Reviewed-By:
-
Thomas Karsten authored
PR-URL: https://github.com/nodejs/node/pull/15840 Reviewed-By:
-
hwaisiu authored
PR-URL: https://github.com/nodejs/node/pull/15970 Reviewed-By:
-
Tobias Tebbi authored
Original commit message: avoid constructor inheritance due to compilation issues Constructor inheritance of a templated constructor is causing compilation issues for node.js: https: //github.com/nodejs/node/pull/15362#issue-257007421 Change-Id: I7d099ff5a1a2fd5b19c11112ddef8fe824e509f7 Reviewed-on: https://chromium-review.googlesource.com/707008 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#48445} Refs: https://github.com/v8/v8/commit/0f1dfae0501ffa5086c34412e0cb3b229bd570de PR-URL: https://github.com/nodejs/node/pull/15362 Reviewed-By:
-
