- Oct 08, 2014
-
-
Trevor Norris authored
Continuation of 4809c7aa to update the use of v8::ExternalArrayType. Signed-off-by:
Trevor Norris <trev.norris@gmail.com>
-
Refael Ackermann authored
Windows doesn't resolve ".." the way we expect it for symlinks and junctions. PR-URL: https://github.com/joyent/node/pull/8489 Reviewed-by:
Trevor Norris <trev.norris@gmail.com> Reviewed-by:
Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
Signed-off-by:Trevor Norris <trev.norris@gmail.com>
-
Trevor Norris authored
The constants in enum v8::ExternalArrayType have been changed. The old values are there for legacy reasons, but it's best to update anyway. Signed-off-by:Trevor Norris <trev.norris@gmail.com>
-
Steve Mao authored
PR-URL: https://github.com/joyent/node/pull/8498 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Johnny Ray authored
Add API Writable#setDefaultEncoding(). PR-URL: https://github.com/joyent/node/pull/8483 Fixes: https://github.com/joyent/node/issues/7159 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Steven R. Loomis authored
Move from argparse to optparse for dependency management. Fixes: https://github.com/joyent/node/pull/7719#issuecomment-56868172 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Steven R. Loomis authored
Fixes: https://github.com/joyent/node/issues/7676#issuecomment-57535890 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
- Oct 07, 2014
-
-
Evan Rutledge Borden authored
Fixes: https://github.com/joyent/node/issues/8458 Reviewed-by:
Trevor Norris <trev.norris@gmail.com> Reviewed-by:
Chris Dickinson <christopher.s.dickinson@gmail.com>
-
Victor Widell authored
The docs for readLine.pause are misleading. I seriously spent hours on this. If it isn't a bug, at least it should be well documented. Someone else stumbled on this too: http://stackoverflow.com/questions/21341050/pausing-readline-in-node-js Reviewed-by:
Trevor Norris <trev.norris@gmail.com> Reviewed-by:
Chris Dickinson <christopher.s.dickinson@gmail.com>
-
Steve Sharp authored
Associates link to dns.lookup() with proper URL. Fixes: https://github.com/joyent/node/issues/8018 Reviewed-by:
Trevor Norris <trev.norris@gmail.com> Reviewed-by:
Chris Dickinson <christopher.s.dickinson@gmail.com>
-
- Oct 04, 2014
-
-
gyson authored
* `util.inspect` cannot accept es6 symbol primitive * It will throw exception if do `util.inspect(Symbol())` * This also affects repl, console.log, etc. Reviewed-by:
Trevor Norris <trev.norris@gmail.com> Reviewed-by:
Chris Dickinson <christopher.s.dickinson@gmail.com>
-
- Oct 03, 2014
-
-
Yazhong Liu authored
Add generic functions for (U)Int read/write operations on Buffers. These support up to and including 48 bit reads and writes. Include documentation and tests. Additional work done by Trevor Norris to include 40 and 48 bit write support. Because bitwise operations cannot be used on values greater than 32 bits, the operations have been replaced with mathematical calculations. Regardless, they are still faster than floating point operations. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
- Oct 02, 2014
-
-
Trevor Norris authored
Performance improvement by moving checks for floating point operations to JS and doing the operation on a protected internal function that assumes all arguments are correct. Still abort if the operation overflows memory. This can only be caused if the Buffer's length property isn't the same as the actual internal length. Signed-off-by:Trevor Norris <trev.norris@gmail.com>
-
Julien Gilli authored
Passing null as the output stream to readline.Interface()'s constructor is now supported. Any output written by readline is just discarded. It makes it easier to use readline just as a line parser. Fixes: https://github.com/joyent/node/issues/4408 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Vladimir Kurchatkin authored
Since we are taking control of the microtask queue it makes sense to disable autorun and only run microtasks when necessary. Just setting isolate->SetAutorunMicrotasks(false) would cause _tickCallback() not to be called. Automatically running the microtask queue will cause it to run: * After callback invocation * Inside _tickCallback() * After _tickCallback() invocation The third one is unnecessary as the microtask queue is guaranteed to be empty at this point. The first only needs to be run manually when _tickCallback() isn't going to be called by MakeCallback(). Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
Gabriel Wicke authored
Match the behavior of the slow path by setting url.query to an empty object when the url contains no query, but query parsing is requested. Also add a test for this case, and update the documents to clearly reflect this behavior. Fixes: https://github.com/joyent/node/issues/8332 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Steven R. Loomis authored
The two main goals of this change are: - To make it easier to build the Intl option using ICU (particularly, using a newer ICU than v8/Chromium's version) - To enable a much smaller ICU build with only English support The goal here is to get node.js binaries built this way by default so that the Intl API can be used. Additional data can be added at execution time (see Readme and wiki) More details are at https://github.com/joyent/node/pull/7719 In particular, this change adds the "--with-intl=" configure option to provide more ways of building "Intl": - "full-icu" picks up an ICU from deps/icu - "small-icu" is similar, but builds only English - "system-icu" uses pkg-config to find an installed ICU - "none" does nothing (no Intl) For Windows builds, the "full-icu" or "small-icu" options are added to vcbuild.bat. Note that the existing "--with-icu-path" option is not removed from configure, but may not be used alongside the new option. Wiki changes have already been made on https://github.com/joyent/node/wiki/Installation and a new page created at https://github.com/joyent/node/wiki/Intl (marked as provisional until this change lands.) Summary of changes: * README.md : doc updates * .gitignore : added "deps/icu" as this is the location where ICU is unpacked to. * Makefile : added the tools/icu/* files to cpplint, but excluded a problematic file. * configure : added the "--with-intl" option mentioned above. Calculate at config time the list of ICU source files to use and data packaging options. * node.gyp : add the new files src/node_i18n.cc/.h as well as ICU linkage. * src/node.cc : add call into node::i18n::InitializeICUDirectory(icu_data_dir) as well as new --icu-data-dir option and NODE_ICU_DATA env variable to configure ICU data loading. This loading is only relevant in the "small" configuration. * src/node_i18n.cc : new source file for the above Initialize.. function, to setup ICU as needed. * tools/icu : new directory with some tools needed for this build. * tools/icu/icu-generic.gyp : new .gyp file that builds ICU in some new ways, both on unix/mac and windows. * tools/icu/icu-system.gyp : new .gyp file to build node against a pkg-config detected ICU. * tools/icu/icu_small.json : new config file for the "English-only" small build. * tools/icu/icutrim.py : new tool for trimming down ICU data. Reads the above .json file. * tools/icu/iculslocs.cc : new tool for repairing ICU data manifests after trim operation. * tools/icu/no-op.cc : dummy file to force .gyp into using a C++ linker. * vcbuild.bat : added small-icu and full-icu options, to call into configure. * Fixed toolset dependencies, see https://github.com/joyent/node/pull/7719#issuecomment-54641687 Note that because of a bug in gyp {CC,CXX}_host must also be set. Otherwise gcc/g++ will be used by default for part of the build. Reviewed-by:
Trevor Norris <trev.norris@gmail.com> Reviewed-by:
Fedor Indutny <fedor@indutny.com>
-
Julien Fontanet authored
Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com>
-
- Oct 01, 2014
-
-
Jackson Tian authored
Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
- Sep 30, 2014
-
-
Trevor Norris authored
Running fill() with an empty string would cause Node to hang indefinitely. Now it will return without having operated on the buffer. User facing function has been pulled into JS to perform all initial value checks and coercions. The C++ method has been placed on the "internal" object. Coerced non-string values to numbers to match v0.10 support. Simplified logic and changed a couple variable names. Added tests for fill() and moved them all to the beginning of buffer-test.js since many other tests depend on fill() working properly. Fixes: https://github.com/joyent/node/issues/8469 Signed-off-by:
Trevor Norris <trev.norris@gmail.com>
-
Trevor Norris authored
The parameter parser specifically looked for the old bracket syntax. This generated a lot of warnings when building the docs. Those warnings have been fixed by changing the parsing logic. Signed-off-by:Trevor Norris <trev.norris@gmail.com>
-
Rasmus Christian Pedersen authored
Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
James Ferguson authored
Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
Trevor Norris authored
Several fields on OutgoingMessage were set after instantiation. These have been included in the constructor to prevent mutation of the object map after instantiation. "name" is now explicitly checked to be a string. Where before if a non-string was passed the following cryptic error was thrown: _http_outgoing.js:334 var key = name.toLowerCase(); ^ TypeError: undefined is not a function Signed-off-by:Trevor Norris <trev.norris@gmail.com>
-
Trevor Norris authored
Calls from JS to C++ have an implicit HandleScope. So there is no need to instantiate a new HandleScope in these basic cases. Check if the returned int64_t is an SMI and cast the return value to uint32_t instead of a double. Prevents needing to box the return value, and saves a small amount of execution time. Signed-off-by:Trevor Norris <trev.norris@gmail.com>
-
- Sep 26, 2014
-
-
Fedor Indutny authored
Don't allocate any BIO buffers initially, do this on a first read from the TCP connection. Allocate different amount of data for initial read and for consequent reads: small buffer for hello+certificate, big buffer for better throughput. see #8416
-
cjihrig authored
Add stricter argument type checking to normalizeSpawnArguments(). Removes a number of extraneous checks in spawn(). Fix regression in handling of the optional args argument. Add more thorough testing of spawn() arguments. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
Jicheng Li authored
Only run lineEnding.test() on the newly acquired chunk of string instead of on the entire line buffer. Reviewed-by:Trevor Norris <trev.norris@gmail.com>
-
Trevor Norris authored
Documentation incorrectly used bracket notation for optional parameters. This caused inconsistencies in usage because of examples like the following: fs.write(fd, data[, position[, encoding]], callback) This simply fixes all uses of bracket notation in documentation. Signed-off-by:Trevor Norris <trev.norris@gmail.com> Reviewed-by:
Fedor Indutny <fedor@indutny.com>
-
- Sep 25, 2014
-
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
* uv: Upgrade to v1.0.0-rc1 * http_parser: Upgrade to v2.3.0 * npm: Upgrade to v2.0.0 * openssl: Upgrade to v1.0.1i * v8: Upgrade to 3.26.33 * Add fast path for simple URL parsing (Gabriel Wicke) * Added support for options parameter in console.dir() (Xavi Magrinyà) * Cluster: fix shared handles on Windows (Alexis Campailla) * buffer: Fix incorrect Buffer.compare behavior (Feross Aboukhadijeh) * buffer: construct new buffer from buffer toJSON() output (cjihrig) * buffer: improve Buffer constructor (Kang-Hao Kenny) * build: linking CoreFoundation framework for OSX (Thorsten Lorenz) * child_process: accept uid/gid everywhere (Fedor Indutny) * child_process: add path to spawn ENOENT Error (Ryan Cole) * child_process: copy spawnSync() cwd option to proper buffer (cjihrig) * child_process: do not access stderr when stdio set to 'ignore' (cjihrig) * child_process: don't throw on EAGAIN (Charles) * child_process: don't throw on EMFILE/ENFILE (Ben Noordhuis) * child_process: use full path for cmd.exe on Win32 (Ed Morley) * cluster: allow multiple calls to setupMaster() (Ryan Graham) * cluster: centralize removal from workers list. (Julien Gilli) * cluster: enable error/message events using .worker (cjihrig) * cluster: include settings object in 'setup' event (Ryan Graham) * cluster: restore v0.10.x setupMaster() behaviour (Ryan Graham) * cluster: support options in Worker constructor (cjihrig) * cluster: test events emit on cluster.worker (Sam Roberts) * console: console.dir() accepts options object (Xavi Magrinyà) * crypto: add `honorCipherOrder` argument (Fedor Indutny) * crypto: allow padding in RSA methods (Fedor Indutny) * crypto: clarify RandomBytes() error msg (Mickael van der Beek) * crypto: never store pointer to conn in SSL_CTX (Fedor Indutny) * crypto: unsigned value can't be negative (Brian White) * dgram: remove new keyword from errnoException (Jackson Tian) * dns: always set variable family in lookup() (cjihrig) * dns: include host name in error message if available (Maciej Małecki) * dns: introduce lookupService function (Saúl Ibarra Corretgé) * dns: send lookup c-ares errors to callback (Chris Dickinson) * dns: throw if hostname is not string or falsey (cjihrig) * events: Output the event that is leaking (Arnout Kazemier) * fs: close file if fstat() fails in readFile() (cjihrig) * fs: fs.readFile should not throw uncaughtException (Jackson Tian) * http: add 308 status_code, see RFC7238 (Yazhong Liu) * http: don't default OPTIONS to chunked encoding (Nick Muerdter) * http: fix bailout for writeHead (Alex Kocharin) * http: remove unused code block (Fedor Indutny) * http: write() after end() emits an error. (Julien Gilli) * lib, src: add vm.runInDebugContext() (Ben Noordhuis) * lib: noisy deprecation of child_process customFds (Ryan Graham) * module: don't require fs several times (Robert Kowalski) * net,dgram: workers can listen on exclusive ports (cjihrig) * net,stream: add isPaused, don't read() when paused (Chris Dickinson) * net: Ensure consistent binding to IPV6 if address is absent (Raymond Feng) * net: add remoteFamily for socket (Jackson Tian) * net: don't emit listening if handle is closed (Eli Skeggs) * net: don't prefer IPv4 addresses during resolution (cjihrig) * net: don't throw on net.Server.close() (cjihrig) * net: reset `errorEmitted` on reconnect (Ed Umansky) * node: set names for prototype methods (Trevor Norris) * node: support v8 microtask queue (Vladimir Kurchatkin) * path: fix slice OOB in trim (Lucio M. Tato) * path: isAbsolute() should always return boolean (Herman Lee) * process: throw TypeError if kill pid not a number (Sam Roberts) * querystring: custom encode and decode (fengmk2) * querystring: do not add sep for empty array (cjihrig) * querystring: remove prepended ? from query field (Ezequiel Rabinovich) * readline: fix close event of readline.Interface() (Yazhong Liu) * readline: fixes scoping bug (Dan Kaplun) * readline: implements keypress buffering (Dan Kaplun) * repl: fix multi-line input (Fedor Indutny) * repl: fix overwrite for this._prompt (Yazhong Liu) * repl: proper `setPrompt()` and `multiline` support (Fedor Indutny) * stream: don't try to finish if buffer is not empty (Vladimir Kurchatkin) * stream: only end reading on null, not undefined (Jonathan Reem) * streams: set default hwm properly for Duplex (Andrew Oppenlander) * string_bytes: ucs2 support big endian (Andrew Low) * tls, crypto: add DHE support (Shigeki Ohtsu) * tls: `checkServerIdentity` option (Trevor Livingston) * tls: add DHE-RSA-AES128-SHA256 to the def ciphers (Shigeki Ohtsu) * tls: better error reporting at cert validation (Fedor Indutny) * tls: support multiple keys/certs (Fedor Indutny) * tls: throw an error, not string (Jackson Tian) * udp: make it possible to receive empty udp packets (Andrius Bentkus) * url: treat the same as / (isaacs)
-
Timothy J Fontaine authored
-
Patrick Mooney authored
The property server.connections should no longer be enumerable because it has been deprecated. This will prevent deprecation warnings when server objects are accessed by functions such as JSON.stringify. Fixes: https://github.com/joyent/node/issues/8373 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Robert Kowalski authored
Adds a test for benchmarking the module loader, needed for benchmarking changes / refacortings in the module loader. Reviewed-by:
Trevor Norris <trev.norris@gmail.com> Reviewed-by:
Timothy J Fontaine <tjfontaine@gmail.com>
-
Timothy J Fontaine authored
Windows currently doesn't support clustered dgram sockets, when it does re-enable this test
-
Julien Gilli authored
4c9b30db introduced a regression in buffer.slice that 7c3c51b8 fixed, but no test had been added to make sure that a similar regression is caught by the tests suite in the future.
-
- Sep 24, 2014
-
-
Fedor Indutny authored
Call `MakeWeak()` to destruct TLSCallbacks when the js-object dies. fix #8416 Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Trevor Norris authored
In 4c9b30db removal of the prototype attributes meant NativeBuffer() no longer had the same object map as Buffer(). By now setting the same properties in the same order both constructors will produce the same map. The same commit changed "parent" from undefined to null. This caused a failure in Buffer#slice() where it was checked if parent === undefined. Causing the incorrect parent to be set. Signed-off-by:
Trevor Norris <trev.norris@gmail.com>
-
Fedor Indutny authored
-