- Apr 28, 2020
-
-
Thomas authored
The previous error was wrongly redirecting users to the ICU installation steps, which is unrelated to missing Visual Studio. PR-URL: https://github.com/nodejs/node/pull/32658 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Sam Roberts authored
It used to have some `cd` commands that if done literally would invalidate the subsequent commands. Modify them to be more accurate, which also simplifies pasting them directly into the console from the guide while doing an update. PR-URL: https://github.com/nodejs/node/pull/32977 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/32989 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com>
-
Michaël Zasso authored
Extract the "Cherry-pick the Release Commit to master" part to its own section and be more precise about what should be done to handle conflicts. PR-URL: https://github.com/nodejs/node/pull/33042 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Stephen Belanger authored
PR-URL: https://github.com/nodejs/node/pull/33051 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com>
-
Robert Nagy authored
Added description of semver-major changes to finished in v14. PR-URL: https://github.com/nodejs/node/pull/33065 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/33063 Reviewed-By:
-
Anna Henningsen authored
The assumption here is that decomposed characters render like their composed character equivalents, and that working with the former comes with a risk of over-estimating string widths given that we compute them on a per-code-point basis. The regression test added here (한글 vs 한글) is an example of that happening. PR-URL: https://github.com/nodejs/node/pull/33052 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Yash Ladha authored
When intializing the constructor for cluster master we are heavily using a generic structure, but the effect of passing arguments that are related to shared_handle is that there is a stale argument passed. We can avoid such scenarios as all the remaining entities are being destructured from the message object. PR-URL: https://github.com/nodejs/node/pull/32963 Reviewed-By:
-
Christopher Beeson authored
PR-URL: https://github.com/nodejs/node/pull/32921 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
Christopher Beeson authored
Setting an environment variable with an empty name on Windows resulted in an assertion failure, because it was checked for an '=' sign at the beginning without verifying the length was greater than 0. Fixes: https://github.com/nodejs/node/issues/32920 Refs: https://github.com/nodejs/node/pull/27310 PR-URL: https://github.com/nodejs/node/pull/32921 Reviewed-By:
-
Christopher Beeson authored
PR-URL: https://github.com/nodejs/node/pull/32921 Reviewed-By:
-
Juan José Arboleda authored
Ref: https://github.com/nodejs/node/pull/32278 PR-URL: https://github.com/nodejs/node/pull/32881 Refs: https://github.com/nodejs/node/pull/32278 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Hassaan Pasha authored
After an OpenSSL source update, all the config files need to be regenerated and committed by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/32971 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com>
-
Hassaan Pasha authored
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1g.tar.gz $ mv openssl-1.1.1g openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/32971 Reviewed-By: -
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32786 Fixes: https://github.com/nodejs/node/issues/32781 Reviewed-By:
-
Ujjwal Sharma authored
Original commit message: [intl] Remove soon-to-be removed getAllFieldPositions Needed to land ICU67.1 soon. Bug: v8:10393 Change-Id: I3c7737ca600d6ccfdc46ffaddfb318ce60bc7618 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2136489 Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#67027} Refs: https://github.com/v8/v8/commit/3f8dc4b2e5baf77b463334c769af85b79d8c1463 PR-URL: https://github.com/nodejs/node/pull/32993 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
-
Anna Henningsen authored
These calls could fail if the `ArrayBuffer` had already been explicitly detached at some point in the past. The necessary test changes already came with 4f523c2c and could be ported back to v12.x with a backport of this PR. Fixes: https://github.com/nodejs/node/issues/33022 Refs: https://github.com/nodejs/node/pull/30551 PR-URL: https://github.com/nodejs/node/pull/33039 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
Ishaan Jain authored
Changed "UTC time" on Line 82 to "UTC" as it created a tautology. PR-URL: https://github.com/nodejs/node/pull/33005 Reviewed-By:
Robert Nagy <ronagy@icloud.com>
-
Jeremiah Senkpiel authored
If the bug this test is intented to catch is reintroduced, or if 5aac4c42 is effectively reverted, many (50+) tests time out, rendering this test redundant and unnecessary. in particular, the following timer tests catch an effective revert of 5aac4c42: not ok 21 parallel/test-timers-api-refs not ok 22 parallel/test-timers-args not ok 23 parallel/test-timers-destroyed not ok 25 parallel/test-timers-nested not ok 26 parallel/test-timers-interval-throw not ok 28 parallel/test-timers-non-integer-delay not ok 32 parallel/test-timers-ordering not ok 33 parallel/test-timers-refresh not ok 34 parallel/test-timers-refresh-in-callback not ok 35 parallel/test-timers-reset-process-domain-on-throw not ok 40 parallel/test-timers-timeout-to-interval not ok 41 parallel/test-timers-uncaught-exception not ok 42 parallel/test-timers-timeout-with-non-integer not ok 43 parallel/test-timers-unenroll-unref-interval not ok 44 parallel/test-timers-unref not ok 45 parallel/test-timers-unref-active not ok 46 parallel/test-timers-unrefd-interval-still-fires not ok 47 parallel/test-timers-unrefed-in-callback not ok 48 parallel/test-timers-user-call not ok 49 parallel/test-timers-zero-timeout Refs: https://github.com/nodejs/node/issues/21781 PR-URL: https://github.com/nodejs/node/pull/32870 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Yash Ladha authored
We are converting the argument to a uint32_t value but the lvalue is not consistent with the casting. PR-URL: https://github.com/nodejs/node/pull/32879 Reviewed-By:
-
Gus Caplan authored
Fixes: https://github.com/nodejs/node/issues/31860 PR-URL: https://github.com/nodejs/node/pull/32985 Reviewed-By:
-
Joyee Cheung authored
The NODE_V8_COVERAGE folder and the source map computation are setup during pre-execution since they rely on environment variables as well as JS states. Therefore, we need to give up serialization of JS coverage profiles for Environments that have not go through pre-execution. Currently this is only possible for Environments created using the embedder API CreateEnvironment(). As a result we won't have JS coverage data for most cctests, but if that proves to be necessary we could just run lib/internal/main/environment.js for these Environments created for cctests. Fixes: https://github.com/nodejs/node/issues/32912 Refs: https://github.com/nodejs/node/commit/65e18a8e9f912dfa04a804124b6a19514bb45165 Refs: https://github.com/nodejs/node/commit/5bf43729a403b992cc90b5cdbbaaf505769d1107 https://github.com/nodejs/node/commit/8aa7ef7840ef5f7161f3195e51a3fa6783290160 PR-URL: https://github.com/nodejs/node/pull/32960 Refs: https://github.com/nodejs/node/commit/8aa7ef7840ef5f7161f3195e51a3fa6783290160 Reviewed-By:
-
Yash Ladha authored
PR-URL: https://github.com/nodejs/node/pull/32962 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32853 Reviewed-By:
-
Adrian Estrada authored
PR-URL: https://github.com/nodejs/node/pull/32771 Reviewed-By:
-
Eileen authored
Fixes: https://github.com/nodejs/node/issues/25595 subdirectory updated def PR-URL: https://github.com/nodejs/node/pull/32791 Reviewed-By:
-
Adrian Estrada authored
PR-URL: https://github.com/nodejs/node/pull/32769 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32992 Reviewed-By:
-
Nick Schonning authored
Membership lists are currently formatted in a specific way for tooling PR-URL: https://github.com/nodejs/node/pull/32676 Reviewed-By:
-
Nick Schonning authored
reflowed for line length after increased url size PR-URL: https://github.com/nodejs/node/pull/32676 Reviewed-By:
-
Nick Schonning authored
PR-URL: https://github.com/nodejs/node/pull/32676 Reviewed-By:
-
Nick Schonning authored
PR-URL: https://github.com/nodejs/node/pull/32676 Reviewed-By:
-
Daniel Estiven Rico Posada authored
PR-URL: https://github.com/nodejs/node/pull/32631 Reviewed-By:
-
Milad Farazmand authored
Original commit message: Fix compilation error with devtoolset-8 We are compiling V8 using devtoolset-8 and it is generating a new compilation error related to String Truncation: error: ‘char* strncpy(char*, const char*, size_t)’ output truncated copying between 1 and 15 bytes from a string of length 15 [-Werror=stringop-truncation] strncpy(buffer, unicode_utf8, i); Which basically means the null terminating character was not added to the end of the buffer: https://developers.redhat.com/blog/2018/05/24/detecting-string-truncation-with-gcc-8/ This CL will changes 2 uses of "strncpy" to "memcpy" as strings are being copied partially and `\n` being added at a later stage. Change-Id: I3656afb00463d70ddb8700a487a1978b793e1d09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2155038 Reviewed-by:Andreas Haas <ahaas@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#67277} Refs: https://github.com/v8/v8/commit/e1eac1b16c966879102c2310d7649637227eaa02 PR-URL: https://github.com/nodejs/node/pull/32974 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org>
-
Prosper Opara authored
PR-URL: https://github.com/nodejs/node/pull/32931 Reviewed-By:
-
Gireesh Punathil authored
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such. PR-URL: https://github.com/nodejs/node/pull/32732 Refs: https://github.com/nodejs/diagnostics/issues/369 Reviewed-By:
-
Rich Trott authored
tools/doc/html.js includes code that looks for comments with `start-include` and `end-include` for file inclusion. This seems to be legacy code that is no longer used. The code only appears in the table-of-contents generation function. The strings `start-include` and `end-include` appear nowhere else in our tools and nowhere at all in our docs. PR-URL: https://github.com/nodejs/node/pull/32913 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32843 Reviewed-By:
-
daemon1024 authored
PR-URL: https://github.com/nodejs/node/pull/32896 Fixes: https://github.com/nodejs/node/issues/32871 Reviewed-By:
-
