1. Aug 07, 2013
  2. Aug 06, 2013
  3. Aug 05, 2013
  4. Aug 04, 2013
    • Fedor Indutny's avatar
      tls: fix handling of `SNICallback` server option · ea7b8172
      Fedor Indutny authored
      It shouldn't ignore it!
      
      There're two possibile cases, which should be handled properly:
      
      1. Having a default `SNICallback` which is using contexts, added with
        `server.addContext(...)` routine
      2. Having a custom `SNICallback`.
      
      In first case we may want to opt-out setting `.onsniselect` method (and
      thus save some CPU time), if there're no contexts added. But, if custom
      `SNICallback` is used, `.onsniselect` should always be set, because
      server contexts don't affect it.
      ea7b8172
    • Ben Noordhuis's avatar
      src: use static_cast for void-to-T casts · 5383e758
      Ben Noordhuis authored
      Code cleanup, replace a few uses of reinterpret_cast<T*>(void_ptr) with
      static_cast<T*>(void_ptr).
      5383e758
    • Ben Noordhuis's avatar
      src: use PersistentToLocal() in a few more places · d4cc30f1
      Ben Noordhuis authored
      Update a few more `Local<T>::New(isolate, persistent)` call sites to
      `PersistentToLocal(isolate, persistent)` - the latter has a fast path
      for non-weak persistent references.
      d4cc30f1
  5. Aug 03, 2013
  6. Aug 02, 2013
  7. Aug 01, 2013
    • Ben Noordhuis's avatar
      test: future-proof simple/test-event-emitter-memory-leak · 9e1eb361
      Ben Noordhuis authored
      Run the garbage collector before running the actual test. It doesn't
      matter now but if in the future something in node.js core creates a lot
      of reclaimable garbage, that will break the test's expectation.
      9e1eb361
    • Ben Noordhuis's avatar
      test: fix pummel/test-net-connect-memleak · 98db7bab
      Ben Noordhuis authored
      * Run the garbage collector before creating the big array. It doesn't
        matter now but if in the future something in node.js core creates
        a lot of reclaimable garbage, that will break the test's expectation.
      
      * The first RSS check was being done too late. The garbage collector
        might have run before the check, throwing off the 'reclaimed memory'
        calculation.
      
      * Due to changes in how V8 represents the big array internally, the
        actual memory usage is just below 256 MB on x64. Update the test's
        expectation.
      98db7bab
    • Ben Noordhuis's avatar
      events: fix memory leak, don't leak event names · fc6f8a69
      Ben Noordhuis authored
      Before this commit, events were set to undefined rather than deleted
      from the EventEmitter's backing dictionary for performance reasons:
      `delete obj.key` causes a transition of the dictionary's hidden class
      and that can be costly.
      
      Unfortunately, that introduces a memory leak when many events are added
      and then removed again. The strings containing the event names are never
      reclaimed by the garbage collector because they remain part of the
      dictionary.
      
      That's why this commit makes EventEmitter delete events again. This
      effectively reverts commit 0397223a.
      
      Fixes #5970.
      fc6f8a69
    • Fedor Indutny's avatar
      tls_wrap: parse tls session ticket extension · dda22a52
      Fedor Indutny authored
      And, if present and non-empty, don't invoke `resumeSession` callback.
      
      fix #5872
      dda22a52
    • Brian White's avatar
      30701d6e
    • Ben Noordhuis's avatar
      cpplint: exclude src/node_win32_perfctr_provider.cc · a622bde9
      Ben Noordhuis authored
      It's forced to violate the build/include_order rule because it includes
      a header file generated with ctrpp.exe that doesn't include perflib.h
      itself.
      a622bde9