- Aug 07, 2013
-
-
Timothy J Fontaine authored
Conflicts: deps/v8/test/cctest/test-api.cc lib/events.js lib/http.js
-
- Aug 06, 2013
-
-
Ben Noordhuis authored
Don't create a superfluous Number object, just use the version of v8::Object::Get() that takes an unsigned int. Convert the index to unsigned int while we're here.
-
Eran Hammer authored
If an error listener is added to a stream using once() before it is piped, it is invoked and removed during pipe() but before pipe() sees it which causes it to be emitted again. Fixes #4155 #4978
-
Ben Noordhuis authored
The handle object was checked against the wrong constructor template. Put another way, it was unwrapped as the wrong StreamWrap type.
-
Ben Noordhuis authored
The type of the expression `(uint16_t) server_names_len + 2` gets implicitly widened to int. Change the type of server_names_len to uint32_t to avoid the following warnings: ../../src/node_crypto_clienthello.cc:144: warning: comparison between signed and unsigned integer expressions ../../src/node_crypto_clienthello.cc:146: warning: comparison between signed and unsigned integer expressions -
Fedor Indutny authored
Make ClientHelloParser handle SNI extension, and extend `_tls_wrap.js` to support loading SNI Context from both hello, and resumed session. fix #5967
-
Fedor Indutny authored
Share ClientHelloParser code between `tls_wrap.cc` and `node_crypto.cc`. fix #5959
-
isaacs authored
-
Evan Solomon authored
Ignore encoding *if* chunk is a buffer
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
This builds and includes the mdb_v8.so in the binary of node so mdb can be sure to always use the latest version
-
isaacs authored
-
isaacs authored
-
Koichi Kobayashi authored
https.get('https://github.com/') should use port 443, not 80. -
isaacs authored
Noticed by @bnoordhuis in https://github.com/joyent/node/pull/5991#discussion_r5575946
-
mstarzinger@chromium.org authored
Quoting the CVE: Google V8, as used in Google Chrome before 28.0.1500.95, allows remote attackers to cause a denial of service or possibly have unspecified other impact via vectors that leverage "type confusion." Likely has zero impact on node.js because it only runs local, trusted code but let's apply it anyway. This is a back-port of upstream commit r15665. Original commit log: Use internal array as API function cache. R=yangguo@chromium.org BUG=chromium:260106 TEST=cctest/test-api/Regress260106 Review URL: https://codereview.chromium.org/19159003 Fixes #5973.
-
- Aug 05, 2013
-
-
Forrest L Norvell authored
Adds the documentation requested in #5017.
-
Sam Roberts authored
Flags and modes aren't the same, symlinks are followed in all of the path but the last component, docs should say something about what the mode argument is for and when its used, fs.openSync should point to the function that contains the docs for its args, as fs.writeSync does.
-
Ben Noordhuis authored
This is [1] applied ahead of time. Summary: OpenBSD doesn't have <ucontext.h>. ucontext_t lives in <signal.h> and is a typedef for struct sigcontext. There is no uc_mcontext. [1] https://codereview.chromium.org/21705003/
-
- Aug 04, 2013
-
-
Fedor Indutny authored
It shouldn't ignore it! There're two possibile cases, which should be handled properly: 1. Having a default `SNICallback` which is using contexts, added with `server.addContext(...)` routine 2. Having a custom `SNICallback`. In first case we may want to opt-out setting `.onsniselect` method (and thus save some CPU time), if there're no contexts added. But, if custom `SNICallback` is used, `.onsniselect` should always be set, because server contexts don't affect it.
-
Ben Noordhuis authored
Code cleanup, replace a few uses of reinterpret_cast<T*>(void_ptr) with static_cast<T*>(void_ptr).
-
Ben Noordhuis authored
Update a few more `Local<T>::New(isolate, persistent)` call sites to `PersistentToLocal(isolate, persistent)` - the latter has a fast path for non-weak persistent references.
-
- Aug 03, 2013
-
-
Fedor Indutny authored
When doing `FreeEmpty`, `NodeBIO` skips pre-allocated `head_` buffer. However this might lead to double-freeing buffers since in `~NodeBIO()` we're starting deallocation from `head_` buffer.
-
Ben Noordhuis authored
Commit 78d90945 updated src/*.cc to use the version of PersistentToLocal that takes a v8::Isolate* as its first argument. This commit removes the non-isolate version.
-
isaacs authored
-
Trevor Norris authored
-
Ben Noordhuis authored
There is no need for it and it's a tiny bit slower than the version of PersistentToLocal() that takes a v8::Isolate* as its first argument.
-
Trevor Norris authored
Now that values are checks in JS, no need for them to be checked in C++.
-
Trevor Norris authored
* Numeric values passed to alloc were converted to int32, not uint32 before the range check, which allows wrap around on ToUint32. This would cause massive malloc calls and v8 fatal errors. * dispose would not check if value was an Object, causing segfault if a Primitive was passed. * kMaxLength was not enumerable.
-
Trevor Norris authored
-
- Aug 02, 2013
-
-
Ben Noordhuis authored
Build breakage accidentally introduced in 8e29ce9f during code cleanup. HAVE_OPENSSL is always defined (as either 0 or 1) so use #if rather than #ifdef. Fixes #5979.
-
isaacs authored
-
Trevor Norris authored
-
Trevor Norris authored
Fix test from 30701d6e.
-
- Aug 01, 2013
-
-
Ben Noordhuis authored
Run the garbage collector before running the actual test. It doesn't matter now but if in the future something in node.js core creates a lot of reclaimable garbage, that will break the test's expectation.
-
Ben Noordhuis authored
* Run the garbage collector before creating the big array. It doesn't matter now but if in the future something in node.js core creates a lot of reclaimable garbage, that will break the test's expectation. * The first RSS check was being done too late. The garbage collector might have run before the check, throwing off the 'reclaimed memory' calculation. * Due to changes in how V8 represents the big array internally, the actual memory usage is just below 256 MB on x64. Update the test's expectation.
-
Ben Noordhuis authored
Before this commit, events were set to undefined rather than deleted from the EventEmitter's backing dictionary for performance reasons: `delete obj.key` causes a transition of the dictionary's hidden class and that can be costly. Unfortunately, that introduces a memory leak when many events are added and then removed again. The strings containing the event names are never reclaimed by the garbage collector because they remain part of the dictionary. That's why this commit makes EventEmitter delete events again. This effectively reverts commit 0397223a. Fixes #5970.
-
Fedor Indutny authored
And, if present and non-empty, don't invoke `resumeSession` callback. fix #5872
-
Brian White authored
-
Ben Noordhuis authored
It's forced to violate the build/include_order rule because it includes a header file generated with ctrpp.exe that doesn't include perflib.h itself.
-