Commits · b0b204571b69ebf69be06ed5f2bb10da90f18c0e · github.com / v8-riscv / node

Feb 01, 2018

lib: extract validation functions · b0b20457

Timothy O. Peters authored Jan 28, 2018

PR-URL: https://github.com/nodejs/node/pull/18421


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

b0b20457

test: speed up parallel/test-tls-session-cache · 3206e20a

Anna Henningsen authored Jan 29, 2018

This test had some unnecessary timeouts that made it run for a
much longer time than necessary (about 9 s rather than 0.2 s).

PR-URL: https://github.com/nodejs/node/pull/18424


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

3206e20a

doc: improve stream documentation · 3ca79350

陈刚 authored Jan 25, 2018

PR-URL: https://github.com/nodejs/node/pull/18375


Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

3ca79350

benchmark: cut down http benchmark run time · 54b3a685

Joyee Cheung authored Jan 26, 2018

PR-URL: https://github.com/nodejs/node/pull/18379


Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

54b3a685

tools: auto fix custom eslint rule · 2d6912a4

Shobhit Chittora authored Nov 01, 2017

1. Extends tests
2. Refactors code
3. Adds fixer

Refs: #16636

PR-URL: https://github.com/nodejs/node/pull/16652
Refs: https://github.com/nodejs/node/issues/16636


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

2d6912a4

doc: deprecate top-level `this` · 300f5ce3

Hackzzila authored Nov 08, 2017

PR-URL: https://github.com/nodejs/node/pull/16878
Fixes: https://github.com/nodejs/node/issues/9623


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

300f5ce3

fs: partition readFile against pool exhaustion · 67a4ce1c

Jamie Davis authored Nov 15, 2017

Problem:

Node implements fs.readFile as:
- a call to stat, then
- a C++ -> libuv request to read the entire file using the stat size

Why is this bad?
The effect is to place on the libuv threadpool a potentially-large
read request, occupying the libuv thread until it completes.
While readFile certainly requires buffering the entire file contents,
it can partition the read into smaller buffers
(as is done on other read paths)
along the way to avoid threadpool exhaustion.

If the file is relatively large or stored on a slow medium, reading
the entire file in one shot seems particularly harmful,
and presents a possible DoS vector.

Solution:

Partition the read into multiple smaller requests.

Considerations:

1. Correctness

I don't think partitioning the read like this raises
any additional risk of read-write races on the FS.
If the application is concurrently readFile'ing and modifying the file,
it will already see funny behavior. Though libuv uses preadv where
available, this doesn't guarantee read atomicity in the presence of
concurrent writes.

2. Performance

Downside: Partitioning means that a single large readFile will
  require into many "out and back" requests to libuv,
  introducing overhead.
Upside: In between each "out and back", other work pending on the
  threadpool can take a turn.

In short, although partitioning will slow down a large request,
it will lead to better throughput if the threadpool is handling
more than one type of request.

Fixes: https://github.com/nodejs/node/issues/17047

PR-URL: https://github.com/nodejs/node/pull/17054


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

67a4ce1c

src: free memory before re-setting URLHost value · 36fd25fa

Ivan Filenko authored Jan 24, 2018

Fixes: https://github.com/nodejs/node/issues/18302

PR-URL: https://github.com/nodejs/node/pull/18357


Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

36fd25fa

stream: augment BufferList.prototype · ccf64e5f

Luigi Pinca authored Jan 24, 2018

Move functions that deal with `BufferList` to `BufferList.prototype`.

PR-URL: https://github.com/nodejs/node/pull/18353


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

ccf64e5f

src: simplify handles for libuv streams · 5898dc3d

Anna Henningsen authored Jan 25, 2018

Instead of passing along the handle object, just set it as a
property on the stream handle object and let the read handler
grab it from there.

PR-URL: https://github.com/nodejs/node/pull/18334


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

5898dc3d

src: refactor stream callbacks and ownership · 7c4b09b2

Anna Henningsen authored Jan 08, 2018

Instead of setting individual callbacks on streams and tracking
stream ownership through a boolean `consume_` flag, always have
one specific listener object in charge of a stream, and call
methods on that object rather than generic C-style callbacks.

PR-URL: https://github.com/nodejs/node/pull/18334


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

7c4b09b2

benchmark: refactor · 1b6cb947

Ruben Bridgewater authored Jan 23, 2018

PR-URL: https://github.com/nodejs/node/pull/18320


Reviewed-By: James M Snell <jasnell@gmail.com>

1b6cb947

benchmark: (timers) refactor · c713f079

Ruben Bridgewater authored Jan 23, 2018

PR-URL: https://github.com/nodejs/node/pull/18320


Reviewed-By: James M Snell <jasnell@gmail.com>

c713f079

benchmark: (http(2)) refactor · 1178670c

Ruben Bridgewater authored Jan 23, 2018

PR-URL: https://github.com/nodejs/node/pull/18320


Reviewed-By: James M Snell <jasnell@gmail.com>

1178670c

benchmark: (es) refactor · 2072f343

Ruben Bridgewater authored Jan 23, 2018

PR-URL: https://github.com/nodejs/node/pull/18320


Reviewed-By: James M Snell <jasnell@gmail.com>

2072f343

benchmark: (url) refactor · 1a8ed225

Ruben Bridgewater authored Jan 23, 2018

PR-URL: https://github.com/nodejs/node/pull/18320


Reviewed-By: James M Snell <jasnell@gmail.com>

1a8ed225

benchmark: (crypto) refactor · 39ae0b98

Ruben Bridgewater authored Jan 23, 2018

PR-URL: https://github.com/nodejs/node/pull/18320


Reviewed-By: James M Snell <jasnell@gmail.com>

39ae0b98

benchmark: (buffer) refactor · 794e489e

Ruben Bridgewater authored Jan 23, 2018

PR-URL: https://github.com/nodejs/node/pull/18320


Reviewed-By: James M Snell <jasnell@gmail.com>

794e489e

benchmark: (assert) refactor · cd7b2c43

Ruben Bridgewater authored Jan 23, 2018

PR-URL: https://github.com/nodejs/node/pull/18320


Reviewed-By: James M Snell <jasnell@gmail.com>

cd7b2c43

benchmark: fix variables not being set · f951c9a9

Ruben Bridgewater authored Jan 23, 2018

Due to the destructuring the outer variables were not set anymore.

PR-URL: https://github.com/nodejs/node/pull/18320


Reviewed-By: James M Snell <jasnell@gmail.com>

f951c9a9

benchmark: fix platform in basename-win32 · d4015b89

Ruben Bridgewater authored Jan 23, 2018

It should say `win32` and not `posix`.

PR-URL: https://github.com/nodejs/node/pull/18320


Reviewed-By: James M Snell <jasnell@gmail.com>

d4015b89

crypto: use non-deprecated v8::Object::Set · ff21fb16

Daniel Bevenius authored Dec 06, 2017

This commit updates node_crypto to use the non-deprecated Set functions
that return a v8::Maybe<bool>.

PR-URL: https://github.com/nodejs/node/pull/17482


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

ff21fb16

http: process headers after setting up agent · 4404c761

Rod Vagg authored Oct 24, 2017

Added tests to clarify the implicit behaviour of array header setting vs
object header setting

PR-URL: https://github.com/nodejs/node/pull/16568


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

4404c761

test: fix flaky test-http-dns-error · 7d4b7724

Bryan English authored Oct 26, 2017

Under some conditions, the error received from getaddrinfo might
actually be EAGAIN, meaning the request should be retried. Allowing for
5 retries before erroring out.

Also replace one-off function with common.mustNotCall().

PR-URL: https://github.com/nodejs/node/pull/16534


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

7d4b7724

build: make gyp user defined variables lowercase · ac7f1e33

Daniel Bevenius authored Oct 16, 2017

I mistakenly introduced user defined variables using uppercase
characters, reading the gyp documentation they state:
"Predefined variables. By convention, these are named with
CAPITAL_LETTERS. Predefined variables are set automatically by GYP"
and also "By convention, user-defined variables are named with
lowercase_letters."

This commit renames the user defined variables to lowercase to follow
the above mentioned convention.

PR-URL: https://github.com/nodejs/node/pull/16238


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

ac7f1e33

doc: document asserts Weak(Map|Set) behavior · 936eea50

Ruben Bridgewater authored Jan 19, 2018

Right now it is not documentated that WeakMap entries are not
compared. This might result in some confusion. This adds a note
about the behavior in `assert.deepStrictEqual`. This documentation
is also references in `util.isDeepStrictEqual`, so we do not have
to document it again for that function as the underlying algorithm
is the same.

PR-URL: https://github.com/nodejs/node/pull/18248
Fixes: https://github.com/nodejs/node/issues/18228
Refs: https://github.com/nodejs/node/pull/18228


Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

936eea50

src, lib: return promises from link · edbcf7c8

Gus Caplan authored Jan 26, 2018

Returns the promises created by link so that they can be awaited to get
rid of race conditions while resolving and loading modules.

PR-URL: https://github.com/nodejs/node/pull/18394


Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>

edbcf7c8

assert: use a default message in assert · 3cd7977a

Ruben Bridgewater authored Jan 23, 2018

In case no arguments are passed to `assert.ok` it should just
use a default message. Otherwise `assert.ok` can not be used as
a callback.

PR-URL: https://github.com/nodejs/node/pull/18319


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

3cd7977a

fs: throw errors from fs.unlinkSync in JS · 776f6cdf

Joyee Cheung authored Jan 24, 2018

PR-URL: https://github.com/nodejs/node/pull/18348
Refs: https://github.com/nodejs/node/issues/18106


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

776f6cdf

fs: throw errors from fs.fsyncSync in JS · eca93e63

Joyee Cheung authored Jan 24, 2018

PR-URL: https://github.com/nodejs/node/pull/18348
Refs: https://github.com/nodejs/node/issues/18106


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

eca93e63

fs: throw errors from fs.fdatasyncSync in JS · f5e287ba

Joyee Cheung authored Jan 24, 2018

PR-URL: https://github.com/nodejs/node/pull/18348
Refs: https://github.com/nodejs/node/issues/18106


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

f5e287ba

fs: throw errors from fs.ftruncateSync in JS · b3a7df7c

Joyee Cheung authored Jan 24, 2018

PR-URL: https://github.com/nodejs/node/pull/18348
Refs: https://github.com/nodejs/node/issues/18106


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

b3a7df7c

fs: throw errors from fs.renameSync in JS · 5583981c

Joyee Cheung authored Jan 24, 2018

PR-URL: https://github.com/nodejs/node/pull/18348
Refs: https://github.com/nodejs/node/issues/18106


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

5583981c

fs: throw errors from fs.readlinkSync in JS · 09da11e5

Joyee Cheung authored Jan 24, 2018

PR-URL: https://github.com/nodejs/node/pull/18348
Refs: https://github.com/nodejs/node/issues/18106


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

09da11e5

fs: throw errors from fs.linkSync in JS · 167e2293

Joyee Cheung authored Jan 24, 2018

PR-URL: https://github.com/nodejs/node/pull/18348
Refs: https://github.com/nodejs/node/issues/18106


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

167e2293

fs: throw errors from fs.symlinkSync in JS · 32bf0f6c

Joyee Cheung authored Jan 24, 2018

PR-URL: https://github.com/nodejs/node/pull/18348
Refs: https://github.com/nodejs/node/issues/18106


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

32bf0f6c

test: move tmpdir to submodule of common · bf6ce472

Rich Trott authored Dec 24, 2017

Move tmpdir functionality to its own module (common/tmpdir).

PR-URL: https://github.com/nodejs/node/pull/17856


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

bf6ce472

crypto: runtime deprecate DEFAULT_ENCODING · 6035beea

James M Snell authored Jan 23, 2018

Runtime deprecate the crypto.DEFAULT_ENCODING property.

This is specifically in preparation for eventual ESM support
Refs: https://github.com/nodejs/node/pull/18131

PR-URL: https://github.com/nodejs/node/pull/18333


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

6035beea

doc: linkify missing types · fd3a0cfb

Vse Mozhet Byt authored Jan 30, 2018

Also, alphabetize all types in type-parser.js
and fix some nits in type formats.

PR-URL: https://github.com/nodejs/node/pull/18444


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

fd3a0cfb

2018-01-31, Version 9.5.0 (Current) · 83d0f4c9

Evan Lucas authored Jan 30, 2018

Notable changes:

* cluster
  - add cwd to cluster.settings (cjihrig) [#18399](https://github.com/nodejs/node/pull/18399)
* deps
  - upgrade libuv to 1.19.1 (cjihrig) [#18260](https://github.com/nodejs/node/pull/18260)
* meta
  - add Leko to collaborators (Leko) [#18117](https://github.com/nodejs/node/pull/18117)
  - add vdeturckheim as collaborator (vdeturckheim) [#18432](https://github.com/nodejs/node/pull/18432)
* n-api
  - expose n-api version in process.versions (Michael Dawson) [#18067](https://github.com/nodejs/node/pull/18067)
* perf_hooks
  - add performance.clear() (James M Snell) [#18046](https://github.com/nodejs/node/pull/18046)
* stream
  - avoid writeAfterEnd() while ending (陈刚) [#18170](https://github.com/nodejs/node/pull/18170)

PR-URL: https://github.com/nodejs/node/pull/18464

83d0f4c9