- Jul 23, 2020
-
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34351 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34351 Reviewed-By:
-
James M Snell authored
This one was a bit of a rabbit hole... but, with this set of changes, `QuicStream` should now work with autoDestroy, supports a promisified `close()`, and fixes a number of other internal bugs that were spotted trying to get it to work. PR-URL: https://github.com/nodejs/node/pull/34351 Reviewed-By:
-
James M Snell authored
qlog files are diagnostic files that are being used to verify the quic implementation. Make sure they don't get checked in. PR-URL: https://github.com/nodejs/node/pull/34351 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34351 Reviewed-By:
-
James M Snell authored
Removing no longer needed code PR-URL: https://github.com/nodejs/node/pull/34351 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34351 Reviewed-By:
-
James M Snell authored
Although most of the time openStream will be able to create the stream immediately, when a stream is opened before the handshake is complete we have to wait for the handshake to be complete before continuing. PR-URL: https://github.com/nodejs/node/pull/34351 Reviewed-By:
-
Rich Trott authored
The index ToC says "About these docs" but the document itself says "About this documentation" which I think is better. Use that. PR-URL: https://github.com/nodejs/node/pull/34449 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
AshCripps authored
PR-URL: https://github.com/nodejs/node/pull/34494 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Rich Trott authored
Move benchmark CI to native suite since it requires building an addon. Refs: https://github.com/nodejs/node/issues/34427#issuecomment-660760789 PR-URL: https://github.com/nodejs/node/pull/34433 Reviewed-By:
-
Rich Trott authored
For consistency with the rest of our docs and our style guide, use sentence-case rather than headline-case in the headers in quic.md. PR-URL: https://github.com/nodejs/node/pull/34453 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Use `NodeEventTarget` to provide a mixed `EventEmitter`/`EventTarget` API interface. PR-URL: https://github.com/nodejs/node/pull/34057 Refs: https://twitter.com/addaleax/status/1276289101671608320 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Anna Henningsen authored
Enable `NodeEventTarget` as a base class for `MessagePort`, by enabling special processing of events for Node.js listeners, and removing implicit constructors/private properties so that classes can be made subclasses of `NodeEventTarget` after they are created. PR-URL: https://github.com/nodejs/node/pull/34057 Refs: https://twitter.com/addaleax/status/1276289101671608320 Reviewed-By:
-
Anna Henningsen authored
This test has not been working correctly since at least a555be2e. Since it tests internals, any replacement test might become invalid in a similar way. Refs: https://github.com/nodejs/node/pull/34057 PR-URL: https://github.com/nodejs/node/pull/34445 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Anna Henningsen authored
The messaging code uses `Object.defineProperty()`, which accesses `value` on `Object.prototype` by default, so some calls to the getter here would actually be expected. Instead, make the list of accessed properties more specific to the tested source map code to avoid flakiness. Refs: https://twitter.com/addaleax/status/1276289101671608320 Refs: https://github.com/nodejs/node/pull/34057 PR-URL: https://github.com/nodejs/node/pull/34446 Reviewed-By:
-
cjihrig authored
In the GitHub Actions CI, test-macos-app-sandbox.js can fail due to the application already being signed. This commit updates the test to handle that condition. Refs: https://github.com/nodejs/node/pull/33944 PR-URL: https://github.com/nodejs/node/pull/34331 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/34427 PR-URL: https://github.com/nodejs/node/pull/34434 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Shelley Vohr authored
Notable changes: deps: * upgrade npm to 6.14.6 (claudiahdz) [#34246](https://github.com/nodejs/node/pull/34246) * update node-inspect to v2.0.0 (Jan Krems) [#33447](https://github.com/nodejs/node/pull/33447) * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [#33521](https://github.com/nodejs/node/pull/33521) PR-URL: https://github.com/nodejs/node/pull/34343
-
- Jul 22, 2020
-
-
Ruy Adorno authored
The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: https://github.com/nodejs/node/pull/34381 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Anna Henningsen authored
This prevents accidental resource leaks when terminating or exiting Worker that own FDs opened through `fs.open()`. Refs: https://github.com/nodejs/node/pull/34303 PR-URL: https://github.com/nodejs/node/pull/34394 Reviewed-By:
-
Joyee Cheung authored
Otherwise the build would fail with `./configure --experimental-quic --ninja` as the list of per-Environment values would not match and the code cache builder would not generate code cache for the quic JS sources. This is more or less a band-aid - a proper fix would be to aggregate these flags into something that can be included by all these different binary targets. See https://github.com/nodejs/node/issues/31074. PR-URL: https://github.com/nodejs/node/pull/34454 Fixes: https://github.com/nodejs/node/issues/34435 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Harshitha K P authored
Fixes: https://github.com/nodejs/node/issues/34242 PR-URL: https://github.com/nodejs/node/pull/34417 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/34048 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34420 Reviewed-By:
-
Anna Henningsen authored
In the termination case, we should not crash. There’s also no harm being done by ignoring the termination exception here, since the thread is about to be torn down anyway. Also, add a guard against running this during shutdown. That is the likely cause of https://github.com/nodejs/node/issues/34361. Fixes: https://github.com/nodejs/node/issues/34361 PR-URL: https://github.com/nodejs/node/pull/34362 Fixes: https://github.com/nodejs/node/issues/27261 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Creating a new function each time the property descriptor is set comes with performance overhead, since these functions have different identities, even if they contain the same code. Refs: https://twitter.com/tverwaes/status/1285496612618473472 PR-URL: https://github.com/nodejs/node/pull/34459 Reviewed-By:
-
Myles Borins authored
Notable changes: deps: * upgrade npm to 6.14.6 (claudiahdz) https://github.com/nodejs/node/pull/34246 * upgrade to libuv 1.38.1 (Colin Ihrig) https://github.com/nodejs/node/pull/34187 * (SEMVER-MINOR) update V8 to 8.4.371.19 (Michaël Zasso) [#33579](https://github.com/nodejs/node/pull/33579) module: * (SEMVER-MINOR) deprecate module.parent (Antoine du HAMEL) https://github.com/nodejs/node/pull/32217 * (SEMVER-MINOR) package "imports" field (Guy Bedford) https://github.com/nodejs/node/pull/34117 src: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) https://github.com/nodejs/node/pull/34303 * (SEMVER-MINOR) allow embedders to disable esm loader (Shelley Vohr) https://github.com/nodejs/node/pull/34060 tls: * (SEMVER-MINOR) make 'createSecureContext' honor more options (Mateusz Krawczuk) https://github.com/nodejs/node/pull/33974 vm: * (SEMVER-MINOR) add run-after-evaluate microtask mode (Anna Henningsen) https://github.com/nodejs/node/pull/34023 worker: * (SEMVER-MINOR) add option to track unmanaged file descriptors (Anna Henningsen) https://github.com/nodejs/node/pull/34303 New Collaborators: * add danielleadams to collaborators (Danielle Adams) https://github.com/nodejs/node/pull/34360 * add sxa as collaborator (Stewart X Addison) https://github.com/nodejs/node/pull/34338 * add ruyadorno to collaborators (Ruy Adorno) https://github.com/nodejs/node/pull/34297 PR-URL: https://github.com/nodejs/node/pull/34371
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/34454 PR-URL: https://github.com/nodejs/node/pull/34460 Reviewed-By:
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/34464 Reviewed-By:
-
Robert Nagy authored
Ensures that _construct has finished before invoking _destroy. The 'constructed' property was not properly set to false for both writable and readable state. Fixes: https://github.com/nodejs/node/issues/34448 PR-URL: https://github.com/nodejs/node/pull/34456 Reviewed-By:
-
- Jul 21, 2020
-
-
Richard Lau authored
Notable changes: - deps: - upgrade npm to 6.14.6 (claudiahdz) https://github.com/nodejs/node/pull/34246 - upgrade openssl sources to 1.1.1g (Hassaan Pasha) https://github.com/nodejs/node/pull/32982 - n-api: - add `napi_detach_arraybuffer` (legendecas) https://github.com/nodejs/node/pull/29768 PR-URL: https://github.com/nodejs/node/pull/34170 -
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/34387 Reviewed-By:
-
Pranshu Srivastava authored
Fixes: https://github.com/nodejs/node/issues/34121 PR-URL: https://github.com/nodejs/node/pull/34457 Reviewed-By:
-
Pekka Nikander authored
Add IPv6 link local scope ID suffix to the rinfo address in those received upd6 datagrams whose source address is a link local address. Add a new test case, test-dgram-udp6-link-local-address, to verify that IPv6 UDP datagrams received from a link-local source address do contain the scope ID suffix in the rinfo address field. When a packet is received from a link-local source address, if the address does not contain the scope ID suffix, it is impossible to reply back to the sender, as the kernel is not able to determine the right network interface to send the packet through and returns with an error. Ref: https://github.com/nodejs/node/issues/1649 PR-URL: https://github.com/nodejs/node/pull/14500 Refs: https://github.com/nodejs/node/issues/1649 Reviewed-By:
Stewart X Addison <sxa@uk.ibm.com>
-
cjihrig authored
Update ESLint to 7.5.0 PR-URL: https://github.com/nodejs/node/pull/34423 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34424 Reviewed-By:
-
Anna Henningsen authored
This ensures that microtasks scheduled by native immediates are run after the tasks are done. In particular, this affects the inspector integration since 6f9f5464. Fixes: https://github.com/nodejs/node/issues/33002 Refs: https://github.com/nodejs/node/pull/32523 PR-URL: https://github.com/nodejs/node/pull/34366 Reviewed-By:
-
Antoine du Hamel authored
Remove the "Current" label for Node.js 13 in the CHANGELOG. PR-URL: https://github.com/nodejs/node/pull/34436 Reviewed-By:
-
Jucke authored
PR-URL: https://github.com/nodejs/node/pull/34419 Reviewed-By:
-
