- Oct 30, 2014
-
-
Mikeal Rogers authored
-
Mikeal Rogers authored
PR-URL: https://github.com/node-forward/node/pull/41 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Mikeal Rogers authored
Fixes https://github.com/node-forward/node/issues/4 PR-URL: https://github.com/node-forward/node/pull/9 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Oct 29, 2014
-
-
Ben Noordhuis authored
Conflicts: src/node_version.h vcbuild.bat
-
Ben Noordhuis authored
-
Ben Noordhuis authored
Conflicts: lib/path.js
-
Ben Noordhuis authored
Remove the dependency on the 'sysconfig' module, it breaks the build when $(PYTHON) is python 2.6. PR-URL: https://github.com/node-forward/node/pull/39 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Fedor Indutny authored
Reviewed-By:
Fedor Indutny <fedor@indutny.com> PR-URL: local://fedors.head/pull/1
-
Fedor Indutny authored
Ignore cases where the handle is already gone, like we do in `handle_wrap.cc`. It should be safe to close handle and then call some binding methods on it, since the internal handle may be shared between `_tls_wrap.js` and `net.js` modules. Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/node-forward/node/pull/37
-
- Oct 28, 2014
-
-
Nikolai Vavilov authored
It's not supported in VS2013. PR-URL: https://github.com/node-forward/node/pull/38 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ben Noordhuis authored
This commit drops the semaphore in exchange for a second condition variable and makes the task ring an array member instead of allocating it on the heap. That in turn makes size calculations a little easier because of the array's fixed size. PR-URL: https://github.com/node-forward/node/pull/34 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Ben Noordhuis authored
The elements of the heap-allocated TaskQueue::ring_ array in src/node_v8_platform.cc were compared against without being initialized first. Fixes node-forward/node#33. PR-URL: https://github.com/node-forward/node/pull/34 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
cjihrig authored
Currently when a server receives a new connection the underlying socket handle begins reading data immediately. This causes problems when sockets are passed between processes, as data can be read by the first process and thus never read by the second process. This commit allows sockets that are constructed with a handle to be paused initially. PR-URL: https://github.com/joyent/node/pull/8576 Fixes: https://github.com/joyent/node/issues/7905 Fixes: https://github.com/joyent/node/issues/7784 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Vladimir Kurchatkin authored
Also couple of additions about dispose and limitations of smalloc'ed objects. Fixes: https://github.com/joyent/node/pull/8625 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Ben Noordhuis authored
The latest V8 upgrade and the C++11-ification of the source code in src/ requires a recent compiler. Update the requirements in the README. Fixes node-forward/node#35. PR-URL: https://github.com/node-forward/node/pull/36 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Oct 26, 2014
-
-
Trevor Norris authored
Fixes: f6e57401 "path: resolve normalize drive letter to lower case" Signed-off-by:
Trevor Norris <trev.norris@gmail.com>
-
- Oct 25, 2014
-
-
Nikolai Vavilov authored
PR-URL: https://github.com/node-forward/node/pull/32 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Oct 24, 2014
-
-
Fedor Indutny authored
Conflicts: src/cares_wrap.cc src/env-inl.h src/env.h src/node.cc src/node.h src/node_crypto.cc
-
Ben Noordhuis authored
The previous commits fixed oversights in destructors that should have been marked virtual but weren't. This commit marks destructors from derived classes with the override keyword.
-
Ben Noordhuis authored
Like the previous commit but this time for the SSLWrap destructor.
-
Ben Noordhuis authored
Like the previous commit but this time for the BaseObject destructor.
-
Ben Noordhuis authored
Make AsyncWrap::~AsyncWrap() virtual, otherwise it is unsafe to delete a derived class through a pointer to AsyncWrap. Fortunately, we don't do that anywhere right now; this commit is merely a preemptive bug fix.
-
Ben Noordhuis authored
Mark empty destructors as having a default no-op implementation. Remove a few unused constructors and destructors while we are here.
-
Ben Noordhuis authored
Mark the matrix of copy/move constructor/assignment operator as deleted. Prevents the object from being copied around (the macro already did that pre-C++11), but also from being moved out.
-
Ben Noordhuis authored
Add `override` keywords where appropriate. Makes maintenance easier because the compiler will shout at you when a base class changes in an incompatible way.
-
Ben Noordhuis authored
This macro does not not rightfully belong in node.h, remove it. Replace the one use site with a C++11 `static_assert` construct.
-
Ben Noordhuis authored
Now that we are building with C++11 features enabled, replace use of NULL with nullptr. The benefit of using nullptr is that it can never be confused for an integral type because it does not support implicit conversions to integral types except boolean - unlike NULL, which is defined as a literal `0`.
-
- Oct 21, 2014
-
-
dead-horse authored
make path.resolve work the same as path.normalize
-
- Oct 18, 2014
-
-
Rod Vagg authored
PR-URL: https://github.com/node-forward/node/pull/27 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Rod Vagg authored
Add optional env var $NODE_COMMON_PIPE for setting common.PIPE to manually deal with maximum path lengths for unix sockets. PR-URL: https://github.com/node-forward/node/pull/26 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Oct 17, 2014
-
-
Ben Noordhuis authored
Now that V8 requires a compiler with decent C++11 support, there is no reason to keep supporting old versions of gcc. Remove workarounds for bugs in gcc 4.4 and older. This coincidentally makes it easier to build with clang 3.3 + address sanitizer because clang no longer chokes on the `-fno-tree-vrp` switch. PR-URL: https://github.com/node-forward/node/pull/24 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Ben Noordhuis authored
Make it possible to build node against Address Sanitizer. Enable with: $ make -f Makefile.build asan=clang++ CC=clang CC_host=clang PR-URL: https://github.com/node-forward/node/pull/24 Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Ben Noordhuis authored
Make `python tools/test.py --arch=ia32,x64 --mode=debug,release` work. The test runner looks for the `node` binary in `out/${arch}.${mode}/`. Running tools/test.py without --arch makes it use `out/Release/node` or `out/Debug/node` like before. This commit removes `test/simple/test-executable-path.js` because the assumptions it makes about the locations of the debug and release binaries are now outdated. PR-URL: https://github.com/node-forward/node/pull/24 Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Ben Noordhuis authored
Make `make -f Makefile.build ia32.release x64.debug` work. It's not perfect yet: it requires running `./configure` first and the generated `config.gypi` is shared across builds. PR-URL: https://github.com/node-forward/node/pull/24 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Ben Noordhuis authored
Will be used as the template for a multi-arch, multi-mode build system. PR-URL: https://github.com/node-forward/node/pull/24 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Ben Noordhuis authored
This commit adds preliminary x32 support. Configure with: $ ./configure --dest-cpu=x32 PR-URL: https://github.com/node-forward/node/pull/24 Reviewed-By:Fedor Indutny <fedor@indutny.com>
-
Ben Noordhuis authored
Fix double definition errors in the libv8_base.a library target by compiling out stub functions when building for x32. This fix is incomplete because, although V8 now builds, it makes a number of bad assumptions about the size of stack slots, see https://code.google.com/p/v8/issues/detail?id=3630. PR-URL: https://github.com/node-forward/node/pull/24 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
- Oct 16, 2014
-
-
Ben Noordhuis authored
The test implicitly assumed that crypto operations complete in the same order as they are started but, because they go round-trip through the thread pool, there is no such guarantee. Enforce proper sequencing. Fixes node-forward/node#22. PR-URL: https://github.com/node-forward/node/pull/23 Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
Rod Vagg authored
Like libuv does. PR-URL: https://github.com/node-forward/node/pull/21 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Jeremiah Senkpiel authored
Clarifies a more definite two-thirds Quorum. Formally allows 2 out of 6 members of the TC to be associated with a single employer. PR-URL: https://github.com/node-forward/node/pull/14 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-