- Feb 13, 2018
-
-
Evan Lucas authored
Previously, test/parallel/test-cli-syntax.js was spawning a lot of child processes, but using spawnSync, which made the test run each child process serially. This switches most of the test cases to use exec so that they are asynchronous. Locally, the test went from > 5 seconds to under 2 seconds. PR-URL: https://github.com/nodejs/node/pull/14187 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Tobias Nießen authored
Backport-PR-URL: https://github.com/nodejs/node/pull/18347 PR-URL: https://github.com/nodejs/node/pull/17566 Refs: https://github.com/nodejs/node/issues/17523 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Tobias Nießen authored
Using authentication tags of invalid length does not conform to NIST standards. Backport-PR-URL: https://github.com/nodejs/node/pull/18347 PR-URL: https://github.com/nodejs/node/pull/17566 Refs: https://github.com/nodejs/node/issues/17523 Reviewed-By:
-
Myles Borins authored
This test is consistently failing and making CI red. PR-URL: https://github.com/nodejs/node/pull/18491 Refs: https://github.com/nodejs/node/issues/16772 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Rich Trott authored
Find an invalid file descriptor rather than assuming 42 will be invalid. PR-URL: https://github.com/nodejs/node/pull/17797 Fixes: https://github.com/nodejs/node/issues/17762 Reviewed-By:
Khaidi Chu <i@2333.moe> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Rich Trott authored
The test runs two test cases at a time. This is not relevant to what the test is actually testing. Not sure why doing it that way causes a deadlock on some Windows servers, but running one at a time fixes it. Fixes: https://github.com/nodejs/node/issues/18269 PR-URL: https://github.com/nodejs/node/pull/18382 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This would require C++11 features that would otherwise not be available on clang + OS X on Node 6.x. PR-URL: https://github.com/nodejs/node/pull/18324 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Anna Henningsen authored
`last_piece` pointed to the end of the 8×16 bit array, so `piece_pointer == last_piece` already means that the pointer is not writable any longer. Previously, this still worked most of the time but could result in an out-of-bounds-write. Also, rename `last_piece` to `buffer_end` to avoid this pitfall. Backport-PR-URL: https://github.com/nodejs/node/pull/18324 PR-URL: https://github.com/nodejs/node/pull/17470 Reviewed-By:
-
Anna Henningsen authored
- Gives `URLHost` a proper destructor that clears memory depending on the type of the host (This fixes a memory leak) - Hide the host type enums and class layout as implementation details - Make the `Parse` methods members of `URLHost` - Turn `WriteHost` into a `ToString()` method on the `URLHost` class - Verify that at the beginning of a parse attempt, the type is set to “failed” - Remove a lot of `goto`s from the source code
🐢 🚀 Backport-PR-URL: https://github.com/nodejs/node/pull/18324 PR-URL: https://github.com/nodejs/node/pull/17470 Fixes: https://github.com/nodejs/node/issues/17448 Reviewed-By: -
Anna Henningsen authored
This helps because `static` doesn’t work for C++ classes, but refactoring `url_host` into a proper C++ class seems the most reasonable soluation for the memory leak fixed by the next commit. Backport-PR-URL: https://github.com/nodejs/node/pull/18324 PR-URL: https://github.com/nodejs/node/pull/17470 Reviewed-By:
-
Anna Henningsen authored
- Remove pointless pointers - Make `WriteHost` take a const argument so that it’s functionality is clear from the signature - Make `FindLongestZeroSequence` templated to accommodate the constness in `WriteHost` and because using `uint16_t` is an articifial, unnecessary restriction - Remove string copying when no copies are needed - Make `PercentDecode` just return its return value - Make `ParseHost` (string-only version) take its constant argument as a constant reference Backport-PR-URL: https://github.com/nodejs/node/pull/18324 PR-URL: https://github.com/nodejs/node/pull/17470 Reviewed-By:
-
Gibson Fahnestock authored
It is not possible for `process.arch` (which comes from V8's `target_arch`) to be `x86`. Also updates `process.arch` to have the same information. PR-URL: https://github.com/nodejs/node/pull/17899 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com>
-
Yang Guo authored
The root .gitignore contains "node", which causes all of deps/v8/tools/node to be ignored. That is somewhat inconvenient when updating V8. PR-URL: https://github.com/nodejs/node/pull/18010 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
Matt is not an active collaborator at this time. Moved to the Collaborator Emeriti section. PR-URL: https://github.com/nodejs/node/pull/17998 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
Matthew Loring <mattloring@google.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17955 Refs: https://github.com/nodejs/node/issues/16317 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17948 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17950 Fixes: https://github.com/nodejs/node/issues/16875 Reviewed-By:
-
Tobias Nießen authored
The callback would have errored out anyway due to the incorrect encoding, and that error is not the point of this test case. PR-URL: https://github.com/nodejs/node/pull/17956 Reviewed-By:
-
Weijia Wang authored
Use forEach loop to reduce some redundant codes. PR-URL: https://github.com/nodejs/node/pull/17962 Reviewed-By:
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17958 Fixes: https://github.com/nodejs/node/issues/17901 Reviewed-By:
-
Rich Trott authored
Josh is focusing on other technologies these days and has moved to the TSC Emeritus role. He already opened a pull request in the TSC repository to make this change. This makes the same change in the main repository. PR-URL: https://github.com/nodejs/node/pull/17953 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Rich Trott authored
* Remove fluff text and get to the point: Report security flaws to security@nodejs.org. Please do not disclose security flaws publicly until they have been handled by the security team. * Fix somewhat confusing paragraph that says there are no "hard and fast rules" but then uses _must_ in the context of a "general rule". Easiest solution seems to be to change _must_ to _should_. * Minor style change (_you will_ instead of _you'll_) PR-URL: https://github.com/nodejs/node/pull/17929 Reviewed-By:
-
Rich Trott authored
Apply various style and punctuation fixes. PR-URL: https://github.com/nodejs/node/pull/17922 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Rich Trott authored
Current alt text results in "GitHub badge badge". Change to intended use of alt text so that it reads "GitHub First-time contributor badge". (The alt text is supposed to replace the image in the event that the image cannot be rendered.) PR-URL: https://github.com/nodejs/node/pull/17922 Reviewed-By:
-
Rich Trott authored
Change instances of "contributiors" to "contributors". PR-URL: https://github.com/nodejs/node/pull/17922 Reviewed-By:
-
Salame William authored
Added some references to PR communication articles in Helpful Ressources inside COLLABORATOR_GUIDE.md PR-URL: https://github.com/nodejs/node/pull/17902 Fixes: https://github.com/nodejs/node/issues/16359 Reviewed-By:
Weijia Wang <starkwang@126.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17898 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/17895 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17900 Reviewed-By:
-
Timothy Gu authored
Just so that it's documented. Feel free to call me anything you want though: Timothy, Tim, 顾天骋. PR-URL: https://github.com/nodejs/node/pull/17894 Reviewed-By:
-
Anna Henningsen authored
`parallel/test-tls-invoke-queued` previously used the internal `_write()` API to hook into the internals more directly, but this invalidates the general assumption made by streams APIs that only a single write is active at a time, and which is enforced through the public API. PR-URL: https://github.com/nodejs/node/pull/17864 Reviewed-By:
-
Daniel Bevenius authored
I noticed that ocsp_request is not being reset in ClientHelloParser::Reset. I've not been able to figure out the the reason for this and wanted to bring this up just in case this was overlooked and should be reset. PR-URL: https://github.com/nodejs/node/pull/17753 Reviewed-By:
-
Anna Henningsen authored
Assert the server name directly in the `SNICallback`, since `common.mustCall()` already guarantees that the callback is called exactly once, making `process.on('exit')` unnecessary. PR-URL: https://github.com/nodejs/node/pull/17836 Reviewed-By: -
Dmitriy Kasyanov authored
Error occurs while dealing with Tar archives PR-URL: https://github.com/nodejs/node/pull/17663 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com> Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/17722 Reviewed-By:
-
Ruben Bridgewater authored
PR-URL: https://github.com/nodejs/node/pull/17805 Reviewed-By:
-
Shobhit Chittora authored
PR-URL: https://github.com/nodejs/node/pull/17715 Refs: https://github.com/nodejs/node/issues/16636 Reviewed-By:
-
Rich Trott authored
`common.fail()` no longer exists as its functionality is now in `assert.fail()`. Replace only two instances in the code base with `assert.fail()`. PR-URL: https://github.com/nodejs/node/pull/17845 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com>
-
Weijia Wang authored
PR-URL: https://github.com/nodejs/node/pull/17847 Reviewed-By:
-
sreepurnajasti authored
PR-URL: https://github.com/nodejs/node/pull/17751 Reviewed-By:
-
