- Feb 01, 2017
-
-
Evan Lucas authored
Notable changes: * crypto: * ability to select cert store at runtime (Adam Majer) #8334 * Use system CAs instead of using bundled ones (Adam Majer) #8334 * deps: * upgrade npm to 4.1.2 (Kat Marchán) #11020 * upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) #11021 * doc: add basic documentation for WHATWG URL API (James M Snell) #10620 * process: add NODE_NO_WARNINGS environment variable (cjihrig) #10842 * url: allow use of URL with http.request and https.request (James M Snell) #10638 PR-URL: https://github.com/nodejs/node/pull/11062
-
Myles Borins authored
This is a security release of the 'Boron' release line to upgrade OpenSSL to version 1.0.2k Although the OpenSSL team have determined a maximum severity rating of "moderate", the Node.js crypto team (Ben Noordhuis, Shigeki Ohtsu and Fedor Indutny) have determined the impact to Node users is "low". Details on this determination can be found on the Nodejs.org website https://nodejs.org/en/blog/vulnerability/openssl-january-2017/ Notable Changes: * deps: - upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) https://github.com/nodejs/node/pull/11021 PR-URL: https://github.com/nodejs/node/pull/11083
-
Myles Borins authored
This is a security release of the 'Boron' release line to upgrade OpenSSL to version 1.0.2k Although the OpenSSL team have determined a maximum severity rating of "moderate", the Node.js crypto team (Ben Noordhuis, Shigeki Ohtsu and Fedor Indutny) have determined the impact to Node users is "low". Details on this determination can be found on the Nodejs.org website https://nodejs.org/en/blog/vulnerability/openssl-january-2017/ Notable Changes: * deps: - upgrade openssl sources to 1.0.2k (Shigeki Ohtsu) https://github.com/nodejs/node/pull/11021 PR-URL: https://github.com/nodejs/node/pull/11081
-
Vse Mozhet Byt authored
Currently, the example throws 'Error: getHostByAddr ENOTFOUND' The previous example is edited for consistency. PR-URL: https://github.com/nodejs/node/pull/11022 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Alex Jordan authored
`port` was listed as required, but as described in the following paragraphs, it's actually not. Also, note that setting `port` to `0` will also cause the OS to assign a a random port and sync up the docs of both forms. PR-URL: https://github.com/nodejs/node/pull/11025 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Marlena Compton authored
PR-URL: https://github.com/nodejs/node/pull/11061 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
Use `common.mustCall()` to guarantee that the wrapped `_refreshSize()` functions are invoked. PR-URL: https://github.com/nodejs/node/pull/11068 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michal Zasso <targos@protonmail.com>
-
João Reis authored
PR-URL: https://github.com/nodejs/node/pull/11085 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Jackson Tian authored
When parameter count is fixed, use literal Array instance is more simply and avoid arguments leak also. PR-URL: https://github.com/nodejs/node/pull/10833 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/11057 Fixes: https://github.com/nodejs/node/issues/10799 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
- Jan 31, 2017
-
-
Yuta Hiroto authored
PR-URL: https://github.com/nodejs/node/pull/11080 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/11020 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
James M Snell authored
Assigns a static identifier code to all runtime and documentation only deprecations. The identifier code is included in the emitted DeprecationWarning. Also adds a deprecations.md to the API docs to provide a central location where deprecation codes can be referenced and explained. PR-URL: https://github.com/nodejs/node/pull/10116 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Michal Zasso <targos@protonmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
James M Snell authored
The --redirect-warnings command line argument allows process warnings to be written to a specified file rather than printed to stderr. Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable. If the specified file cannot be opened or written to for any reason, the argument is ignored and the warning is printed to stderr. If the file already exists, it will be appended to. PR-URL: https://github.com/nodejs/node/pull/10116 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Michal Zasso <targos@protonmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
James M Snell authored
Add the ability to assign an optional code to process warnings + add additional type checking to ensure that names and codes can only be strings. PR-URL: https://github.com/nodejs/node/pull/10116 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Michal Zasso <targos@protonmail.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
Joyee Cheung authored
* Print the progress bar and the current benchmark to stderr when stderr is TTY and stdout is not. * Allow cli arguments without values via setting.boolArgs * Add --no-progress option PR-URL: https://github.com/nodejs/node/pull/10823 Fixes: https://github.com/nodejs/node/issues/8659 Reviewed-By:
Andreas Madsen <amwebdk@gmail.com>
-
John Maguire authored
removed unneccessary curly braces and return statement from inspect arrow function updated `assert.throws` regex to look for exact match at start of string PR-URL: https://github.com/nodejs/node/pull/11039 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/11049 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/11049 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Yuta Hiroto authored
* Add an exception test. * Add `common.mustCall()`. * Make use of Arrow function. PR-URL: https://github.com/nodejs/node/pull/11034 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Anna Henningsen authored
Calling `.As<Object>()` on a non-object aborts in debug mode, but `node_url.cc` relied on it. Address that by using `Local<Value>` until it has been confirmed that the handle actually is an object. PR-URL: https://github.com/nodejs/node/pull/11064 Reviewed-By:
Michal Zasso <targos@protonmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
DavidCai authored
PR-URL: https://github.com/nodejs/node/pull/10964 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
cjihrig authored
When send() triggers an implicit bind, the send operation is added to an internal queue. If a DNS error occurs during the bind, there is currently no mechanism for clearing the queue other than sending more data. If DNS errors keep occurring, the queue will continue to grow with no upper bound. This commit reports errors with implicit binds, and clears the queue. This should be fine, given the nature of UDP. Refs: https://github.com/nodejs/node-v0.x-archive/pull/8705 Refs: https://github.com/nodejs/node/pull/10902 PR-URL: https://github.com/nodejs/node/pull/11036 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Joshua Colvin authored
PR-URL: https://github.com/nodejs/node/pull/11010 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/11045 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Michal Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Jan 30, 2017
-
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/11035 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
As the failures suggest, this test expects the uncaught exception to be thrown within 100 milliseconds, but on some of the test machines it takes longer than that limit to notify the exception. Thats why the test was failing. This patch polls every 10 ms to see if the exception is received. PR-URL: https://github.com/nodejs/node/pull/10822 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com>
-
The `hints` value will be a number. To specify more than one hints, their corresponding bits have to be set. So bitwise OR should be used instead of logical OR. PR-URL: https://github.com/nodejs/node/pull/11037 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Peter Mescalchin authored
A small document update, all other instances of HTTP header on this page are written as 'Content-Length'. This also matches casing used with RFC 2616. PR-URL: https://github.com/nodejs/node/pull/10975 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
AnnaMag authored
PR-URL: https://github.com/nodejs/node/pull/11024 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Rich Trott authored
Use common.mustCall() to guarantee that test functions (created by a factory function) are run. PR-URL: https://github.com/nodejs/node/pull/11023 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Gibson Fahnestock authored
Even if the --shared-zlib flag was used, the bundled deps/zlib was still being compiled into the binary as it was required by the C++ test suite. PR-URL: https://github.com/nodejs/node/pull/10657 Fixes: https://github.com/nodejs/node/issues/10649 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
- Jan 29, 2017
-
-
Alex Ling authored
PR-URL: https://github.com/nodejs/node/pull/10943 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
abouthiroppy authored
PR-URL: https://github.com/nodejs/node/pull/10952 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Luigi Pinca authored
`request.abort()` did not destroy the socket if it was called before a socket was assigned to the request and the request did not use an `Agent` or a Unix Domain Socket was used. Fixes: https://github.com/nodejs/node/issues/10812 PR-URL: https://github.com/nodejs/node/pull/10818 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Timothy Gu authored
Even though this is not fully Web IDL spec-compliant, it is arguably the best we can do. Following the spec would mean non-trivial performance deterioration (10% when parsing a medium-length URL), while the current getter behavior is not adopted by any implementer, and it causes some spec ambiguity when the getter is called with !(this instanceof URL). This commit adopts Chrome's behavior, and is consistent with ECMAScript-defined classes while providing reasonable behaviors for corner cases as well. Until the Web IDL spec is changed one way or another, this is the way to go. PR-URL: https://github.com/nodejs/node/pull/10906 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/10906 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
- Jan 28, 2017
-
-
Joyee Cheung authored
* Pull out the tests for buffer.toJSON from test-buffer-alloc * Add tests for serializing a 0-length buffer PR-URL: https://github.com/nodejs/node/pull/10979 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Ben Noordhuis authored
The last release Chris did was v1.8.1 from April 2015. PR-URL: https://github.com/nodejs/node/pull/11011 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
Aashil Patel authored
The alignment of the argument descriptions in the "node --help" text is off. This commit fixes the issue by adding two spaces before each of the argument description. PR-URL: https://github.com/nodejs/node/pull/10948 Fixes: https://github.com/nodejs/node/issues/10935 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Josh Gavant <josh.gavant@outlook.com>
-