- Aug 11, 2020
-
-
aetheryx authored
PR-URL: https://github.com/nodejs/node/pull/34550 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Harshitha K P <harshitha014@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Mateusz Krawczuk authored
PR-URL: https://github.com/nodejs/node/pull/33929 Reviewed-By:
Alba Mendez <me@alba.sh> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34534 Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Gerhard Stoebich authored
Only call executionAsyncResource() in getStore() if the ALS instance is enabled because the resource is not needed otherwise. PR-URL: https://github.com/nodejs/node/pull/34617 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/34649 Reviewed-By:
Mary Marchini <oss@mmarchini.me>
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/34634 Reviewed-By:
-
Anna Henningsen authored
Handle situations in which the main `Promise` from a TLA module is not fulfilled better: - When not resolving the `Promise` at all, set a non-zero exit code (unless another one has been requested explicitly) to distinguish the result from a successful completion. - When rejecting the `Promise`, always treat it like an uncaught exception. In particular, this also ensures a non-zero exit code. Refs: https://github.com/nodejs/node/pull/34558 PR-URL: https://github.com/nodejs/node/pull/34640 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
Myles Borins authored
This unflags Top-Level await so it can be used by default in the module goal. This is accomplished by manually setting the --harmony-top-level-await flag. We are allowing this as a one of approval based on circumstances. It is not a precedent that future harmony features will be manually enabled. Refs: https://github.com/nodejs/node/issues/34551 PR-URL: https://github.com/nodejs/node/pull/34558 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
Gabriel Schulhof authored
* Prefix functions with `static` to make them local * Remove anonymous namespaces * `nullptr` -> `NULL` * .cc -> .c and update binding.gyp * `static_cast<x>()` -> `(x)()` * Replace `new`/`delete` with `malloc()`/`free()` (only in test_callback_scope) * Move lambda out and convert to local function (only in test_callback_scope) * Remove superfluous `#include <vector>` (only in test_callback_scope_recurse) Some tests are best left as C++. ```bash ls -l test/{node-api,js-native-api}/*/*.cc ``` for those remaining as C++ tests. Signed-off-by:Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/34615 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/34404 Reviewed-By:
-
Mary Marchini authored
Ref: https://github.com/nodejs/node/issues/34594#issuecomment-669245839 PR-URL: https://github.com/nodejs/node/pull/34635 Reviewed-By:
-
Myles Borins authored
Currently the error is rather ambiguous and does not inform folks that static import is not supported in the repl. This overrides the default error message with one that is more informative. Closes: https://github.com/nodejs/node/issues/33576 PR-URL: https://github.com/nodejs/node/pull/33588 Fixes: https://github.com/nodejs/node/issues/33576 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Ruy Adorno authored
Add Ruy Adorno and his Release key. Refs: https://github.com/nodejs/Release/pull/597 PR-URL: https://github.com/nodejs/node/pull/34628 Reviewed-By:
-
Corey Butler authored
Many users assume the act of assigning a value to `process.title` will update the name of their application in apps like macOS Activity Monitor or Windows Services Manager. This has worked in the past, but fails in some versions of Node.js. Ultimately developers are left confused, especially when it works in one version of Node.js and not another. Given the recurring nature and complexity of the underlying problem, it does not seem like a resolvable problem. This note clarifies the source of the problem, sets developer expectations. Refs: https://github.com/nodejs/node/issues/28945 PR-URL: https://github.com/nodejs/node/pull/34557 Fixes: https://github.com/nodejs/node/issues/34280 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Anna Henningsen authored
These tests were written a long time ago, and use the allocation of large amounts of unused memory as a way to detect use-after-free problems with Buffers. As a result, the tests are resource-intensive and may crash because of that. Replace them with a more modern test. We don’t explicitly try to *detect* use-after-free conditions, and instead rely on e.g. ASAN (or the process just crashing hard) to do that for us. Fixes: https://github.com/nodejs/node/issues/34527 PR-URL: https://github.com/nodejs/node/pull/34530 Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By:
-
Bradley Farias authored
This is a workaround for the REPL for a problem when multiple of the entries have the same source text Fixes: https://github.com/nodejs/node/issues/1337 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10284 PR-URL: https://github.com/nodejs/node/pull/34372 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
cjihrig authored
Update ESLint to 7.6.0 PR-URL: https://github.com/nodejs/node/pull/34589 Reviewed-By:
-
cjihrig authored
This commit adds the meta.fixable property to all fixable ESLint rules. This is required as of ESLint 7.6.0. PR-URL: https://github.com/nodejs/node/pull/34589 Reviewed-By:
-
Andrey Pechkurov authored
Native side of fast-path promise hook was not calling JS fastPromiseHook function when there were no async ids previously assigned to the promise. Because of that already created promises could not get id assigned in situations when an async hook without a before listener function is enabled after their creation. As the result executionAsyncId could return wrong id when called within promise's .then(). Refs: https://github.com/nodejs/node/pull/34512 PR-URL: https://github.com/nodejs/node/pull/34548 Reviewed-By:
-
Rich Trott authored
Tests don't fix things generally, so use "Refs:" to refer people to GitHub issues. PR-URL: https://github.com/nodejs/node/pull/34568 Reviewed-By:
-
Tim Perry authored
PR-URL: https://github.com/nodejs/node/pull/34531 Reviewed-By:
-
Robert Nagy authored
Refs: https://github.com/nodejs/node/pull/34578#issuecomment-667941698 PR-URL: https://github.com/nodejs/node/pull/34609 Reviewed-By:
-
Anna Henningsen authored
460c81dc introduced a bug where the execution resource was not stored properly if we needed to call into C++ to extend the stack size. Fix that bug by always storing the resource. Refs: https://github.com/nodejs/node/pull/34319 Fixes: https://github.com/nodejs/node/issues/34556 PR-URL: https://github.com/nodejs/node/pull/34573 Reviewed-By:
-
- Aug 06, 2020
-
-
Gerhard Stoebich authored
Use a microtask to call destroy hooks in case there are a lot queued as immediate may be scheduled late in case of long running promise chains. Queuing a mircrotasks in GC context is not allowed therefore an interrupt is triggered to do this in JS context as fast as possible. fixes: https://github.com/nodejs/node/issues/34328 refs: https://github.com/nodejs/node/issues/33896 PR-URL: https://github.com/nodejs/node/pull/34342 Fixes: https://github.com/nodejs/node/issues/34328 Refs: https://github.com/nodejs/node/issues/33896 Reviewed-By:
-
Renée Kooi authored
The documentation said `napi_typeof` is similar to the `typeof` operator, but the `typeof null` detects `'object'` while `napi_typeof(a_null_value)` detects `napi_null`. PR-URL: https://github.com/nodejs/node/pull/34577 Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Derek Lewis authored
Fixes: https://github.com/nodejs/node/issues/34369 PR-URL: https://github.com/nodejs/node/pull/34602 Reviewed-By:
-
Robert Nagy authored
headers timeout should not occur *after* headers have been received. Fixes: https://github.com/nodejs/node/issues/34576 PR-URL: https://github.com/nodejs/node/pull/34578 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Pranshu Srivastava <rexagod@gmail.com>
-
Rich Trott authored
Revise text for clarity, brevity, and conformance with our style guide. PR-URL: https://github.com/nodejs/node/pull/34566 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Robert Nagy authored
In http 1.1 persistent connection protocol there is a timing race where the client sends the request and then the server kills the connection (due to inactivity) before receiving the client's request. By providing a keep-alive header it is possible to provide the client a hint of when idle timeout would occur and avoid the race. Fixes: https://github.com/nodejs/node/issues/34560 PR-URL: https://github.com/nodejs/node/pull/34561 Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/34565 Reviewed-By:
-
Michael Dawson authored
Refs: https://github.com/nodejs/node-addon-api/issues/760 Clarify which version of 8.x in which N-API version 1 matches the shape in later versions like 10.x Signed-off-by:
-
- Aug 05, 2020
-
-
Gireesh Punathil authored
Absorb low level libuv failure in the process initialization phase Fixes: https://github.com/nodejs/node/issues/33759 Refs: https://github.com/nodejs/node/issues/33759#issuecomment-663980558 PR-URL: https://github.com/nodejs/node/pull/34519 Reviewed-By:
-
Anna Henningsen authored
Stack trace capturing currently accounts for 40 % of the benchmark running time. Always throwing the same exception object removes that overhead and lets the benchmark be more focused on what it is supposed to measure. Refs: https://github.com/nodejs/node/pull/34512#issuecomment-663977271 PR-URL: https://github.com/nodejs/node/pull/34523 Reviewed-By:
-
Derek Lewis authored
Prior to this commit, the custom loader hooks were: * missing the Node.js API ref docs types * missing the function signature from their sections * linking directly to the specification (not customary) * had an inconsistent non-nullable JSDoc promise return * had JSDoc object properties that weren't alpha-sorted * designated set of non-nullable types when single was fine Notes: https://www.typescriptlang.org/play/index.html?strictNullChecks=true&useJavaScript=true#code/PQKhCgAIUgBAHAhgJ0QW0gbwM4BdkCWAdgOYC+k28ApgMYEBmB1yUMCK6WmbkftAeyIATArgJDsALkgBCAILJUATwA8eQqQB8AGl58kyakVwBVAEoAZGbIAUG4iUgAfSAFcR1JkWrCAlHrQkGQUgibUAB64vByoGJgAYh604kIUwl6IbgA2uObU2ALZAG7UMUa4bshE2FgACsgCaATY1KqY7sjZMg6kwVpkbMDgkfACyLiQiNjKRLSQDMmpRJBGhSXU9jT0TCw6kGG4kbj7GQxZufnrpX5YUAeSkx2GxmZWkAC8kEQ52cGfD3CUQA3PdGJBbABZRC4AAWADpUCImrZblpIAAGeEAVluHWAwEgAGUmtRAaJlvD7nwCZAEuNKKTIAzENk-lQ6IxmMhsKcBIy0GTaG48E1INkBCQCPMGAy1kVio4qXwaYT5NkAO6IZS1CpVFaIFYCABGACs6JMBAxIHCybLkPEqt1IOp8I4BsqVXrqncVSqnTIXiYLJZIAB+al+77UDWQENbTm7ZD7INvSx+eGwozWqSRv0+WPxjk7bkZrNeQIqsigviDPjgqEwhFI4Qo26qTE4vGQWnyIgCW3IcliCRET2qyAAdVhxgOrOyjkgAAMzhc8gUFdQl-tbVNkCQ3IKTLVaIbIMayWgBKJdsJ4ZAAJIrOEtSO00+tSBiADktUQwlEPpDQHGch2KVk3DtBk0BhWhYUXMIKVHVlIFGcZcGwcdVmoSofVXHJ12uTZiy5PZfSjeFKMOY5Kz9RCR0kGQAG1KPhaiojYoQkMkfZv2AwcAFp6OWb8AF1aOCPwa2Ce5aQAES8FgbX5AA5a9qHhU1antKY2WZQdKG2UieU9b0Vnwy4Nw2BMSzI9iTkgCzCM3KTwDIIA https://closure-compiler.appspot.com/home#code%3D%252F%252F%2520%253D%253DClosureCompiler%253D%253D%250A%252F%252F%2520%2540compilation_level%2520ADVANCED_OPTIMIZATIONS%250A%252F%252F%2520%2540warning_level%2520VERBOSE%250A%252F%252F%2520%2540jscomp_error%2520strictCheckTypes%250A%252F%252F%2520%2540language_out%2520ECMASCRIPT_NEXT%250A%252F%252F%2520%2540checks_only%250A%252F%252F%2520%253D%253D%252FClosureCompiler%253D%253D%250A%250A%252F**%250A%2520*%2520%2540param%2520%257Bstring%257D%2520specifier%250A%2520*%2520%2540param%2520%257B%257B%250A%2520*%2520%2520%2520conditions%253A%2520!Array%253Cstring%253E%252C%250A%2520*%2520%2520%2520parentURL%253A%2520!(string%2520%257C%2520undefined)%252C%250A%2520*%2520%257D%257D%2520context%250A%2520*%2520%2540param%2520%257BFunction%257D%2520defaultResolve%250A%2520*%2520%2540returns%2520%257BPromise%253C%257B%2520url%253A%2520string%2520%257D%253E%257D%250A%2520*%252F%250Aexport%2520async%2520function%2520resolve(specifier%252C%2520context%252C%2520defaultResolve)%2520%257B%250A%2520%2520const%2520%257B%2520parentURL%2520%253D%2520null%2520%257D%2520%253D%2520context%253B%250A%2520%2520if%2520(Math.random()%2520%253E%25200.5)%2520%257B%2520%252F%252F%2520Some%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520For%2520some%2520or%2520all%2520specifiers%252C%2520do%2520some%2520custom%2520logic%2520for%2520resolving.%250A%2520%2520%2520%2520%252F%252F%2520Always%2520return%2520an%2520object%2520of%2520the%2520form%2520%257Burl%253A%2520%253Cstring%253E%257D.%250A%2520%2520%2520%2520return%2520%257B%250A%2520%2520%2520%2520%2520%2520url%253A%2520parentURL%2520%253F%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier%252C%2520parentURL).href%2520%253A%250A%2520%2520%2520%2520%2520%2520%2520%2520new%2520URL(specifier).href%252C%250A%2520%2520%2520%2520%257D%253B%250A%2520%2520%257D%250A%2520%2520if%2520(Math.random()%2520%253C%25200.5)%2520%257B%2520%252F%252F%2520Another%2520condition.%250A%2520%2520%2520%2520%252F%252F%2520When%2520calling%2520%2560defaultResolve%2560%252C%2520the%2520arguments%2520can%2520be%2520modified.%2520In%2520this%250A%2520%2520%2520%2520%252F%252F%2520case%2520it's%2520adding%2520another%2520value%2520for%2520matching%2520conditional%2520exports.%250A%2520%2520%2520%2520return%2520defaultResolve(specifier%252C%2520%257B%250A%2520%2520%2520%2520%2520%2520...context%252C%250A%2520%2520%2520%2520%2520%2520conditions%253A%2520%255B...context.conditions%252C%2520'another-condition'%255D%252C%250A%2520%2520%2520%2520%257D)%253B%250A%2520%2520%257D%250A%2520%2520%252F%252F%2520Defer%2520to%2520Node.js%2520for%2520all%2520other%2520specifiers.%250A%2520%2520return%2520defaultResolve(specifier%252C%2520context%252C%2520defaultResolve)%253B%250A%257D PR-URL: https://github.com/nodejs/node/pull/34240 Reviewed-By: -
Mary Marchini authored
PR-URL: https://github.com/nodejs/node/pull/34588 Reviewed-By:
-
Mary Marchini authored
PR-URL: https://github.com/nodejs/node/pull/34588 Reviewed-By:
-
Rich Trott authored
We use "falsy" in multiple places in our docs, but only use "false-y" in one place in url.md. Replace it with "falsy". PR-URL: https://github.com/nodejs/node/pull/34545 Reviewed-By:
Ron Korving <ron@ronkorving.nl> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34544 Reviewed-By:
-
Rich Trott authored
Sometimes _addon_ is capitalized and sometimes not. Capitalizing it seems peculiar and hard to justify. Standardize on treating it like other common nouns. PR-URL: https://github.com/nodejs/node/pull/34536 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Gabriel Schulhof authored
`napi_instanceof()` is insufficient for reliably establishing the data type to which a pointer stored with `napi_wrap()` or `napi_create_external()` inside a JavaScript object points. Thus, we need a way to "mark" an object with a value that, when later retrieved, can unambiguously tell us whether it is safe to cast the pointer stored inside it to a certain structure. Such a check must survive loading/unloading/multiple instances of an addon, so we use UUIDs chosen *a priori*. Fixes: https://github.com/nodejs/node/issues/28164 Co-authored-by:
Anna Henningsen <github@addaleax.net> PR-URL: https://github.com/nodejs/node/pull/28237 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Signed-off-by:
-
