Unverified Commit d6b0a406 authored by Anna Henningsen's avatar Anna Henningsen Committed by Shelley Vohr
Browse files

test: replace flaky pummel regression tests

These tests were written a long time ago, and use the allocation of
large amounts of unused memory as a way to detect use-after-free
problems with Buffers. As a result, the tests are resource-intensive
and may crash because of that.

Replace them with a more modern test. We don’t explicitly try to
*detect* use-after-free conditions, and instead rely on e.g. ASAN
(or the process just crashing hard) to do that for us.

Fixes: https://github.com/nodejs/node/issues/34527

PR-URL: https://github.com/nodejs/node/pull/34530


Reviewed-By: default avatarRich Trott <rtrott@gmail.com>
Reviewed-By: default avatarAndrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: default avatarJiawen Geng <technicalcute@gmail.com>
parent ae64ec46
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment