- Oct 20, 2020
-
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/35693 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Rich Trott authored
Use kbd element for key strokes and remove extra parentheses. PR-URL: https://github.com/nodejs/node/pull/35656 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com>
-
Pooja D.P authored
PR-URL: https://github.com/nodejs/node/pull/35585 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Michaël Zasso authored
It is guaranteed that V8 throws a syntax error when `import` or `export` is used outside of ESM. Fixes: https://github.com/nodejs/node/issues/35687 PR-URL: https://github.com/nodejs/node/pull/35691 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
lucasg authored
PR-URL: https://github.com/nodejs/node/pull/35659 Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32969 Refs: https://github.com/nodejs/node/blob/7893c70970adfbefb1684c48d42aff7385a2afb8/src/node_internals.h#L79-L85 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
David Carlier authored
Making sure using apis supported by both. PR-URL: https://github.com/nodejs/node/pull/34320 Reviewed-By:Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com>
-
- Oct 19, 2020
-
-
Michaël Zasso authored
It was removed upstream and is now inferred from the build config. PR-URL: https://github.com/nodejs/node/pull/35705 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
-
James M Snell authored
Signed-off-by:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/node/runs/1275049330 PR-URL: https://github.com/nodejs/node/pull/35709 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com>
-
Gireesh Punathil authored
The property `process.report.reportOnFatalError` was deemed experimental, as it was not honored under certain scenarios (for example out of memory conditions). The report configuration were previously stored on the `environment` structure which was not available on these types of fatal error cases. The referenced PR has addressed this case (sometime back), and the property is working as intended. Refs: https://github.com/nodejs/node/pull/32207 PR-URL: https://github.com/nodejs/node/pull/35654 Reviewed-By:
-
Rich Trott authored
Remove redundant "should not be considered stable" (it immediately follows a clause saying that it is "experimental") and replace with a more clear (to me, at least) statement that we don't recommend using the feature in production. PR-URL: https://github.com/nodejs/node/pull/35594 Reviewed-By:
-
Daijiro Wachi authored
Fixes: https://github.com/nodejs/node/issues/35571 Refs: https://github.com/whatwg/url/pull/550 Refs: https://github.com/web-platform-tests/wpt/pull/25989 PR-URL: https://github.com/nodejs/node/pull/35671 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Maya Lekova authored
This commit removes the WrapperTraits specialization for FastHrtime according to recent changes in the V8 API. Refs: https://github.com/nodejs/node/issues/33374 PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Clemens Backes authored
V8 is starting to use the job API for Wasm compilation, so the node platform should implement that. PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Ujjwal Sharma authored
PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
cjihrig authored
After the V8 8.5 update, the WASI APIs no longer require the use of --experimental-wasm-bigint. This commit removes its use. PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Kim-Anh Tran authored
PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Ujjwal Sharma authored
PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Anna Henningsen authored
Original commit message: [heap-profiler] Fix crash when a snapshot deleted while taking one Fix a crash/hang that occurred when deleting a snapshot during the GC that is part of taking another one. Specifically, when deleting the only other snapshot in such a situation, the `v8::HeapSnapshot::Delete()` method sees that there is only one (complete) snapshot at that point, and decides that it is okay to perform “delete all snapshots” instead of just deleting the requested one. That resets the internal string lookup table of the heap profiler, but the new snapshot that is currently in progress still holds references to the old string lookup table, leading to a use-after-free segfault or infinite loop. Fix this by guarding against resetting the string table while another heap snapshot is being taken, and add a test that would crash before this fix. This can be triggered in Node.js by repeatedly calling `v8.getHeapSnapshot()`, which provides heap snapshots as weakly held host objects. Change-Id: If9ac3728bf79114000982f1e7bb05e8034299e3c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2464823 Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#70445} Refs: https://github.com/v8/v8/commit/3176bfd447a909fa9608687fe3eabcf62ec7b2eb PR-URL: https://github.com/nodejs/node/pull/35612 Refs: https://github.com/nodejs/node/issues/35559 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Michaël Zasso authored
Original commit message: [wasm-simd][arm64] fix cross compile arm64 on windows See: https://github.com/nodejs/node/pull/35415 Change-Id: I5d77ae202d4bbfb0971246fe5de9c0ad17c485ff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2459491 Reviewed-by:Tobias Tebbi <tebbi@chromium.org> Auto-Submit: Jiawen Geng <technicalcute@gmail.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#70444} Refs: https://github.com/v8/v8/commit/d76abfed3512ceabf91ee1a148845c7592030f76 PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [zone]: fix build on msvc in wasm module Fix: https://github.com/nodejs/node-v8/issues/172 Change-Id: Ibdbee76470ec8a4c20af7650dc5fac4602873430 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414688 Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#70109} Refs: https://github.com/v8/v8/commit/717543bbf0ef79557dc7b3a7dc845dc5611621d9 PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Michaël Zasso authored
Original commit message: [coverage] IncBlockCounter should not be side-effect Incrementing coverage counter was triggering EvalError for evaluateOnCallFrame when throwOnSideEffect is true. R=jgruber@chromium.org, sigurds@chromium.org, yangguo@chromium.org Bug: v8:10856 Change-Id: I0552e19a3a14ff61a9cb626494fb4a21979d535e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2384011 Commit-Queue: Benjamin Coe <bencoe@google.com> Reviewed-by:Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#69628} Refs: https://github.com/v8/v8/commit/6be2f6e26e8ddfbc1a48c510672b319809674a34 PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Jiawen Geng authored
PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
cjihrig authored
This commit updates V8's gen-postmortem-metadata.py script to fix SmartOS compilation with V8 8.5. PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
cjihrig authored
This commit updates V8's gen-postmortem-metadata.py script to fix SmartOS compilation for V8 8.4. PR-URL: https://github.com/nodejs/node/pull/33579 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
Matheus Marchini authored
Patch V8 (wasm/wasm-module.cc) to remove const qualifier from type passed to template call of `OwnedVector::Of`. Xcode 8 can't convert 'OwnedVector<unsigned char>' to 'OwnedVector<const unsigned char>' when returning from a function (which is likely a bug on Xcode, considering this worked on the prior version of Xcode as well as newer versions). This workaround shouldn't affect the application, since the const qualifier is preserved in the AsmJsOffsetInformation::encoded_offset_. There's also a V8 test passing a const-qualified type to ::Of, but since we don't test V8 on Xcode 8, it should be fine to leave it as is. Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/26685 Reviewed-By:
Refael Ackermann <refack@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Joao Reis authored
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
This should be semver-patch since actual invocation is version conditional. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
Fixes a compilation issue on some platforms PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Ujjwal Sharma authored
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional property, which is a fairly new C++ feature, since that requires a newer XCode version than the minimum requirement in BUILDING.md and thus breaks CI. PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Refael Ackermann authored
Original commit message: [testrunner] delete ancient junit compatible format support Testrunner has ancient support for JUnit compatible XML output. This CL removes this old feature. R=mstarzinger@chromium.org,jgruber@chromium.org,jkummerow@chromium.org CC=machenbach@chromium.org Bug: v8:8728 Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1430065 Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59045} Refs: https://github.com/v8/v8/commit/bd019bdb725cebaa34327634d73936cd7003d17c PR-URL: https://github.com/nodejs/node/pull/32116 Reviewed-By:
-
Michaël Zasso authored
Major V8 updates are usually API/ABI incompatible with previous versions. This commit adapts NODE_MODULE_VERSION for V8 8.6. Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/35415 Reviewed-By:
-
Myles Borins authored
This partially reverts c87641aa as node-gyp no longer puts shared objects in an inconsistent location. PR-URL: https://github.com/nodejs/node/pull/35667 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
-
Myles Borins authored
Refs: https://github.com/npm/cli/blob/latest/CHANGELOG.md#702-2020-10-16 PR-URL: https://github.com/nodejs/node/pull/35667 Reviewed-By:
-
