- Jun 20, 2018
-
-
James M Snell authored
Set the thread name for workers in trace events. Also, use uint64_t for thread_id_ because there's really no reason for those to be doubles PR-URL: https://github.com/nodejs/node/pull/21246 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/21377 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Yang Guo authored
PR-URL: https://github.com/nodejs/node/pull/21330 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
This commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE. PR-URL: https://github.com/nodejs/node/pull/21381 Reviewed-By:
Matheus Marchini <matheus@sthima.com> Reviewed-By:
Ujjwal Sharma <usharma1998@gmail.com>
-
Rich Trott authored
Check that benchmark tests are not running longer than necessary by confirming that they only produce one set of configs to report on per benchmark file. PR-URL: https://github.com/nodejs/node/pull/21046 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Rich Trott authored
Move C++ benchmark useful for NAPI to its own directory. This will isolate the benchmark so it can be excluded from testing that applies to all other benchmarks but not this one. PR-URL: https://github.com/nodejs/node/pull/21046 Reviewed-By:
-
Rich Trott authored
Prevent misc benchmark files from running more than one benchmark during tests. PR-URL: https://github.com/nodejs/node/pull/21046 Reviewed-By:
-
- Jun 19, 2018
-
-
Rich Trott authored
Fixes: https://github.com/nodejs/node/issues/18254 PR-URL: https://github.com/nodejs/node/pull/21393 Reviewed-By:
Yuta Hiroto <hello@hiroppy.me>
-
Rich Trott authored
The STYLE_GUIDE indicates that personal pronouns like "you" should be avoided in reference documentation. Remove "you" from N-API doc. PR-URL: https://github.com/nodejs/node/pull/21382 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
- Jun 18, 2018
-
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/21354 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Brett Kiefer authored
Don't set `writable` to true when a socket connects if the socket is already in an ending state. In the existing code, afterConnect always set `writable` to true. This has been the case for a long time, but previous to commit 9b7a6914, the socket would still be destroyed by `destroySoon` and emit a `'close'` event. Since that commit removed this masking behavior, we have relied on maybeDestroy to destroy the socket when the readble state is ended, and that won't happen if `writable` is set to true. If the socket has `allowHalfOpen` set to true, then `destroy` will still not be called and `'close'` will not be emitted. PR-URL: https://github.com/nodejs/node/pull/21290 Fixes: https://github.com/nodejs/node/issues/21268 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Rich Trott authored
Re-enable `quotes` rule in .eslintrc.js and fix code to abide by the rule. As a bonus, this makes the code (IMO, anyway) more readable. (It certainly isn't *less* readable, at least not IMO.) PR-URL: https://github.com/nodejs/node/pull/21338 Reviewed-By:
Weijia Wang <starkwang@126.com> Reviewed-By:
-
Rich Trott authored
Instead of wording the paragraph about communicating deprecations with the ecosystem as if it were directed at the ecosystem, write it as in imperative directed at the collaborator, since that is the audience for the COLLABORATOR_GUIDE. Instead of assuring the reader that a best effort will be made, instruct the reader to make the effort to communicate with the ecosystem. PR-URL: https://github.com/nodejs/node/pull/21340 Reviewed-By:
-
Rich Trott authored
Remove obsolete wiki references from BUILDING.md. PR-URL: https://github.com/nodejs/node/pull/21369 Reviewed-By:
-
Jamie Davis authored
PR-URL: https://github.com/nodejs/node/pull/21273 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
- Jun 17, 2018
-
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/21256 Reviewed-By:
-
Daniel Bevenius authored
Currently the following compiler warning is reported: ../src/node_stat_watcher.cc:113:13: warning: unused variable 'argc' [-Wunused-variable] const int argc = args.Length(); ^ 1 warning generated. This commit removes the unused argc variable. PR-URL: https://github.com/nodejs/node/pull/21337 Reviewed-By: -
Anna Henningsen authored
Fix a memory leak that occurs with header names that are short and not present in the static table of default headers. PR-URL: https://github.com/nodejs/node/pull/21336 Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/21367 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/21311 Reviewed-By:
-
- Jun 16, 2018
-
-
Rich Trott authored
The Buffer doc has a helpful "Class Method" label before static methods on the Buffer class. The only other class in the docs that I can find with static methods is ECDH in crypto. Add the label to the one static method on the ECDH class. PR-URL: https://github.com/nodejs/node/pull/21357 Reviewed-By:
-
Rich Trott authored
Makefile tasks only lint doc/**/*.md files but omit files that match doc/*.md. This change adds these previously-omitted files to the list of files to be linted. PR-URL: https://github.com/nodejs/node/pull/21361 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/21361 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/21361 Reviewed-By:
-
Rich Trott authored
Linking URL text to itself is superfluous. It will display as a link in GitHub anyway. Bonus: This makes it possible to wrap the line at 80 characters. PR-URL: https://github.com/nodejs/node/pull/21361 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/21361 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/21361 Reviewed-By:
-
James M Snell authored
This reverts commit a24b691c. PR-URL: https://github.com/nodejs/node/pull/21363 Reviewed-By:
-
Joseph Gordon authored
This change places the links to Writable stream and Readble stream in the order these sections appear when scrolling down the screen. PR-URL: https://github.com/nodejs/node/pull/21333 Reviewed-By:
-
James M Snell authored
Set the thread name for workers in trace events. Also, use uint64_t for thread_id_ because there's really no reason for those to be doubles PR-URL: https://github.com/nodejs/node/pull/21246 Reviewed-By:
-
James M Snell authored
While `perf_hooks` is still in experimental, remove less useful bootstrap milestones. PR-URL: https://github.com/nodejs/node/pull/21247 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/21247 Reviewed-By:
-
- Jun 15, 2018
-
-
Tobias Nießen authored
The old implementation silently failed in EVP_CipherInit_ex in EVP_CIPH_WRAP_MODE, this commit should fix that. PR-URL: https://github.com/nodejs/node/pull/21287 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/21265 Reviewed-By:
Lance Ball <lball@redhat.com> Reviewed-By:
-
Rod Vagg authored
Pending OpenSSL 1.1.0i release. PR-URL: https://github.com/nodejs/node/pull/21282 Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By:
Guido Vranken <guidovranken@gmail.com> (cherry picked from commit 91f7361f47b082ae61ffe1a7b17bb2adf213c7fe) Reviewed-by:
Tim Hudson <tjh@openssl.org> Reviewed-by:
Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/6457)
-
Rich Trott authored
The Deprecation cycle explanation in the COLLABORATOR_GUIDE.md file is now more concise. PR-URL: https://github.com/nodejs/node/pull/21303 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Eugene Ostroukhov authored
It is now easily accessible from the Environment Reviewed-By:
-
James M Snell authored
Begin moving `process` object function definitions out of `node.cc` ... continuing the process of making `node.cc` smaller and easier to maintain. PR-URL: https://github.com/nodejs/node/pull/21105 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Michael Dawson authored
Clarify that calls to N-API should be avoided in the 'execute' callback. PR-URL: https://github.com/nodejs/node/pull/21217 Refs: https://github.com/nodejs/help/issues/1318 Reviewed-By:
-
Joyee Cheung authored
PR-URL: https://github.com/nodejs/node/pull/21255 Refs: https://github.com/nodejs/node/pull/21237 Reviewed-By:
-
