- Jul 22, 2020
-
-
Anna Henningsen authored
646e5a47 changed the way that the domain hook callback is called. Previously, the callback was only used in the case that async_hooks were *not* being used (since domains already integrate with async hooks the way they should), and the corresponding deprecation warning also only emitted in that case. However, that commit didn’t move that condition along when the code was ported from C++ to JS. As a consequence, the domain hook callback was used when it wasn’t necessary to use it, and the deprecation warning emitted accidentally along with it. Refs: https://github.com/nodejs/node/commit/646e5a471766e27e8317bb54d1fd1d2c72cffb69#diff-9f21ce1b9d6d46fdd07b969e8a04e140L192 Refs: https://github.com/nodejs/node/commit/646e5a471766e27e8317bb54d1fd1d2c72cffb69#diff-e6db408e12db906ead6ddfac3de15a6fR119 Refs: https://github.com/nodejs/node/pull/33801#issuecomment-654744913 PR-URL: https://github.com/nodejs/node/pull/34245 Fixes: https://github.com/nodejs/node/issues/34069 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com>
-
- Jul 15, 2020
-
-
Luigi Pinca authored
Refs: https://github.com/nodejs/node/pull/32644 Refs: https://github.com/nodejs/node/pull/32662 PR-URL: https://github.com/nodejs/node/pull/32667 Backport-PR-URL: https://github.com/nodejs/node/pull/34275 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Rich Trott authored
Use `bash` instead of `shell` for code language flag in doc/guides/maintaining-ngtcp2-nghttp3.md to conform with our other docs and upcoming lint requirements. PR-URL: https://github.com/nodejs/node/pull/33852 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com>
-
Rich Trott authored
This adds linting for code fence language/grammar strings. This is so, for example, we have only one of ```text and ```txt and not both. PR-URL: https://github.com/nodejs/node/pull/33852 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/34045 Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/28426 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Kirill Shatskiy authored
Fixes: https://github.com/nodejs/node/issues/33348 PR-URL: https://github.com/nodejs/node/pull/33395 Refs: https://github.com/nodejs/node/issues/33348 Reviewed-By:
-
patr0nus authored
macOS app sandbox makes tcsetattr return EPERM. The CHECK_EQ(0, err) here would fail when a sandboxed Node.js process is exiting. This commit fixes this issue. * test: add test for running in macOS app sandbox Bare-bone command-line executables cannot run directly in the app sandbox. To test that Node.js is able to run in the sandbox (and to test the fix in 317621b4a12562eb75055a67bb2c5556f53fe017), this commit creates a typical Cocoa app bundle, puts the node executable in it and calles Apple's codesign command to enable sandbox. * test: use process.execPath to get path of testing node PR-URL: https://github.com/nodejs/node/pull/33944 Reviewed-By:
-
Yash Ladha authored
PR-URL: https://github.com/nodejs/node/pull/33680 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Pranshu Srivastava authored
PR-URL: https://github.com/nodejs/node/pull/33956 Reviewed-By:
-
Pranshu Srivastava authored
Fixes: https://github.com/nodejs/node/issues/32388 PR-URL: https://github.com/nodejs/node/pull/33519 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
-
sapics authored
PR-URL: https://github.com/nodejs/node/pull/33839 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure the DEL character (ASCII 127) is detected as a zero width character even if Node.js is not built with ICU. Signed-off-by:
-
Ruben Bridgewater authored
This adds support for the "Combining Diacritical Marks for Symbols" unicode group to calculate a zero length width even if Node.js is built without ICU. Signed-off-by:
-
Derek Lewis authored
This commit adds the list of agreed-upon info strings to the documentation style guide to aid with future development and maintenance. Refs: https://github.com/nodejs/node/pull/33510 Refs: https://github.com/nodejs/node/pull/33507 Refs: https://github.com/nodejs/node/pull/33483 Refs: https://github.com/nodejs/node/pull/33531 Refs: https://github.com/nodejs/node/pull/33542 Refs: https://github.com/nodejs/node/pull/33028 Refs: https://github.com/nodejs/node/pull/33548 Refs: https://github.com/nodejs/node/pull/33486 PR-URL: https://github.com/nodejs/node/pull/34024 Reviewed-By:
-
wenningplus authored
PR-URL: https://github.com/nodejs/node/pull/33939 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/33867 Refs: https://github.com/nodejs/node/blob/master/src/README.md#checked-conversion Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Nathan Blair authored
Fixes: https://github.com/nodejs/node/issues/29536 PR-URL: https://github.com/nodejs/node/pull/33860 Reviewed-By:
-
Ben Noordhuis authored
The build defaulted to the byte order of the host system but that can be different from the endianness of the target system. Refs: https://github.com/nodejs/node/issues/33703#issuecomment-644639158 PR-URL: https://github.com/nodejs/node/pull/33898 Reviewed-By:
-
Denys Otrishko authored
The `fs.realpath` / `fs.realpathSync` cache already seen symbolic links using the inode number which may be longer that max supported JS number (2**53) and will therefore be incorrectly handled by possibly entering infinite loop of calling stat on the same node. This PR changes those functions (where appropriate) to use bigint for inode numbers. Fixes: https://github.com/nodejs/node/issues/33936 PR-URL: https://github.com/nodejs/node/pull/33945 Reviewed-By:
-
Rich Trott authored
Remove noCallOrProp from tools/doc/json.js. It is a negative lookahead that is only used in one regex where it is placed immediately before a terminating $, thus rendering it meaningless. PR-URL: https://github.com/nodejs/node/pull/33998 Reviewed-By:
Jamie Davis <davisjam@vt.edu>
-
legendecas authored
PR-URL: https://github.com/nodejs/node/pull/33871 Reviewed-By:
-
Rich Trott authored
The collaborator guide suggests pinging individuals about npm upgrades. Change to pinging the npm team instead. PR-URL: https://github.com/nodejs/node/pull/33999 Reviewed-By:
-
Rich Trott authored
The http2 docs include invalid JavaScript values as defaults for three options. The intention was increased clarity, but we specify valid values everywhere else in our docs, so let's do that for consistency. PR-URL: https://github.com/nodejs/node/pull/33997 Reviewed-By:
-
Rich Trott authored
We mostly have a single space between the punctuation that ends a sentence and the start of the next sentence. Change instances with two spaces to one. PR-URL: https://github.com/nodejs/node/pull/33995 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/33952 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33986 Reviewed-By:
-
Shakil-Shahadat authored
First class heading is made to look like other headings. PR-URL: https://github.com/nodejs/node/pull/33820 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/33976 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/33976 Reviewed-By:
-
Alba Mendez authored
Add a note warning users that when using tls.connect(), the `servername` option must be set explicitely to enable SNI, otherwise the connection could fail. PR-URL: https://github.com/nodejs/node/pull/33855 Fixes: https://github.com/nodejs/node/issues/28167 Co-authored-by:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
Daniel Bevenius authored
This commit add a target specific variable named 'build_type' to the node and node_g targets. The motivation for doing this is that both targets share the same prerequisites, and the recepies are the same (apart from the build type) so some duplication can be avoided. PR-URL: https://github.com/nodejs/node/pull/33925 Reviewed-By:
-
Rich Trott authored
The links are sorted in lexical order except for the two RFC links which are reversed. Fix that. PR-URL: https://github.com/nodejs/node/pull/33987 Reviewed-By:
-
Rich Trott authored
"GitHub Repo & Issue Tracker" changed to "Code repository and issue tracker". PR-URL: https://github.com/nodejs/node/pull/33985 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Rich Trott authored
The docs contain 122 uses of `Class:` in headers and one use of `class:` in headers. This changes that one instance to conform with the other instances. PR-URL: https://github.com/nodejs/node/pull/33978 Reviewed-By:
-
James M Snell authored
The [Contributor's Survey results](https://github.com/nodejs/TSC/pull/882) highlight the fact that it is often not easy for contributors to know who the right people are to talk to about a proposed change or who to ask for reviews of a given subsystem. We briefly toyed around with codeowners before when GitHub introduced it but just as quickly disabled it because the structure of our repository made it exceedingly difficult to get right. Rather than start with a codeowners for the entire project, I propose that we start with a small experiment focused on specific subsystems. Specifically, codeowners for modules, streams, net/tls, http/http2, and quic (once that lands). We can expand out from there as we see how things go with the minimal starter set. Initially this just enables codeowners for the `quic` subsystem. A couple of points: 1. A codeowner should always be a team, never an individual person 2. Each codeowner team should contain at least one TSC member (to provide coverage for signing off on semver-major changes) 3. PRs touching any code with a codeowner must be signed off by at least one person on the codeowner team PR-URL: https://github.com/nodejs/node/pull/33895 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Pragyan Das authored
- Code sample updated by adding a hello-world (`demo.wat`) code example - Step for compiling `.wat` to `.wasm` added (with reference to `wabt` tools) - The sample code prints "hello world\n" in the console This update adds a very minimal change to the existing sample and can be treated as an extension. PR-URL: https://github.com/nodejs/node/pull/33626 Reviewed-By:
-
Pranshu Srivastava authored
Fixes: https://github.com/nodejs/node/issues/28001 PR-URL: https://github.com/nodejs/node/pull/33911 Reviewed-By:
-
Fábio Santos authored
When importing specific names from a CJS module, and renaming them using `as`, the example fix in the error message erroneously contains the keyword `as` in the destructuring variable declaration. Example of this issue: import { parse as acornParse } from "acorn"; ^^^^^ SyntaxError: The requested module 'acorn' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export. For example: import pkg from 'acorn'; const { parse as acornParse } = pkg; PR-URL: https://github.com/nodejs/node/pull/33882 Reviewed-By:Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Stephen Belanger authored
With the async_hooks callback trampoline, domains no longer need any native code. With this, domains can exist in pure JavaScript. PR-URL: https://github.com/nodejs/node/pull/33801 Reviewed-By:
-
