- Jul 28, 2020
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34471 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34471 Reviewed-By:
-
Myles Borins authored
This GitHub action takes quite a bit of time to build and is regularly flaky. Removing the OSX and Windows target from this action to avoid having red actions CI runs. Refs: https://github.com/nodejs/node/issues/34123 PR-URL: https://github.com/nodejs/node/pull/34440 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Daniele Belardi authored
Load self referential modules from the repl and using the preload flag `-r`. In both cases the base path used for resolution is the current `process.cwd()`. Also fixes an internal cycle bug in the REPL exports resolution. PR-URL: https://github.com/nodejs/node/pull/32261 Fixes: https://github.com/nodejs/node/issues/31595 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com>
-
sapics authored
PR-URL: https://github.com/nodejs/node/pull/34317 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com>
-
Rich Trott authored
The index ToC says "About these docs" but the document itself says "About this documentation" which I think is better. Use that. PR-URL: https://github.com/nodejs/node/pull/34449 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
AshCripps authored
PR-URL: https://github.com/nodejs/node/pull/34494 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Anna Henningsen authored
This test has not been working correctly since at least a555be2e. Since it tests internals, any replacement test might become invalid in a similar way. Refs: https://github.com/nodejs/node/pull/34057 PR-URL: https://github.com/nodejs/node/pull/34445 Reviewed-By:
-
Anna Henningsen authored
The messaging code uses `Object.defineProperty()`, which accesses `value` on `Object.prototype` by default, so some calls to the getter here would actually be expected. Instead, make the list of accessed properties more specific to the tested source map code to avoid flakiness. Refs: https://twitter.com/addaleax/status/1276289101671608320 Refs: https://github.com/nodejs/node/pull/34057 PR-URL: https://github.com/nodejs/node/pull/34446 Reviewed-By:
-
cjihrig authored
In the GitHub Actions CI, test-macos-app-sandbox.js can fail due to the application already being signed. This commit updates the test to handle that condition. Refs: https://github.com/nodejs/node/pull/33944 PR-URL: https://github.com/nodejs/node/pull/34331 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Ruy Adorno authored
The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: https://github.com/nodejs/node/pull/34381 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
-
Harshitha K P authored
Fixes: https://github.com/nodejs/node/issues/34242 PR-URL: https://github.com/nodejs/node/pull/34417 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com>
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/34048 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34420 Reviewed-By:
-
Anna Henningsen authored
In the termination case, we should not crash. There’s also no harm being done by ignoring the termination exception here, since the thread is about to be torn down anyway. Also, add a guard against running this during shutdown. That is the likely cause of https://github.com/nodejs/node/issues/34361. Fixes: https://github.com/nodejs/node/issues/34361 PR-URL: https://github.com/nodejs/node/pull/34362 Fixes: https://github.com/nodejs/node/issues/27261 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/34464 Reviewed-By:
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/34387 Reviewed-By:
-
Pranshu Srivastava authored
Fixes: https://github.com/nodejs/node/issues/34121 PR-URL: https://github.com/nodejs/node/pull/34457 Reviewed-By:
-
Pekka Nikander authored
Add IPv6 link local scope ID suffix to the rinfo address in those received upd6 datagrams whose source address is a link local address. Add a new test case, test-dgram-udp6-link-local-address, to verify that IPv6 UDP datagrams received from a link-local source address do contain the scope ID suffix in the rinfo address field. When a packet is received from a link-local source address, if the address does not contain the scope ID suffix, it is impossible to reply back to the sender, as the kernel is not able to determine the right network interface to send the packet through and returns with an error. Ref: https://github.com/nodejs/node/issues/1649 PR-URL: https://github.com/nodejs/node/pull/14500 Refs: https://github.com/nodejs/node/issues/1649 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Stewart X Addison <sxa@uk.ibm.com>
-
cjihrig authored
Update ESLint to 7.5.0 PR-URL: https://github.com/nodejs/node/pull/34423 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34424 Reviewed-By:
-
Antoine du Hamel authored
Remove the "Current" label for Node.js 13 in the CHANGELOG. PR-URL: https://github.com/nodejs/node/pull/34436 Reviewed-By:
-
Jucke authored
PR-URL: https://github.com/nodejs/node/pull/34419 Reviewed-By:
-
Jucke authored
PR-URL: https://github.com/nodejs/node/pull/34419 Reviewed-By:
-
sapics authored
PR-URL: https://github.com/nodejs/node/pull/33718 Reviewed-By:
-
AshCripps authored
Add a flag that allows for the setting of a directory where all diagnostic output will be written to. e.g. --redirect-warnings Refs: https://github.com/nodejs/node/pull/33010#issuecomment-618544792 PR-URL: https://github.com/nodejs/node/pull/33584 Reviewed-By:
-
Ruben Bridgewater authored
This makes sure the common path does not normalize the input string. It's only required for characters that are outside of the ASCII range. Signed-off-by:
Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33674 Reviewed-By:
-
Richard Lau authored
Add Richard Lau and his Release key. Signed-off-by:
-
Rich Trott authored
Replace stream.respondWithFile(__filename) with stream.respondWithFile(process.execPath). The test file is probably small enough on some operating systems to be sent immediately, without waiting for the receiving side to do anything. The fix was figured out by addaleax. Co-authored-by:
-
Rich Trott authored
In one place, the fs docs use `previousStat` for an argument that is identified as `previous` everywhere else. Use `previous` for consistency. PR-URL: https://github.com/nodejs/node/pull/34405 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/34329 Reviewed-By:
-
Tobias Nießen authored
Refs: https://github.com/nodejs/node-v0.x-archive/pull/6900 Refs: https://github.com/nodejs/node-v0.x-archive/issues/6889 PR-URL: https://github.com/nodejs/node/pull/34323 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/34325 Reviewed-By:
-
Tobias Nießen authored
Refs: https://github.com/nodejs/node/issues/33715 PR-URL: https://github.com/nodejs/node/pull/34294 Reviewed-By:
-
Gireesh Punathil authored
The role helps triaging issue backlogs effectively Fixes: https://github.com/nodejs/node/issues/34054 Refs: https://github.com/nodejs/TSC/pull/891 PR-URL: https://github.com/nodejs/node/pull/34295 Reviewed-By:
-
Rich Trott authored
Sure, I'm advocating for permitting second-person pronouns in a current PR, but the use in errors.md is superfluous and weakens the sentence. Remove it. PR-URL: https://github.com/nodejs/node/pull/34390 Reviewed-By:
-
Rich Trott authored
Switch to tmpDir rather than fixtures for file writing. PR-URL: https://github.com/nodejs/node/pull/34376 Reviewed-By:
-
Rich Trott authored
common.localhostIPv6 is almost entirely unused and is unnecessary. Remove it. PR-URL: https://github.com/nodejs/node/pull/34373 Reviewed-By:
-
Stewart Addison authored
Zone IDs on Linux are network interface names. The regex we use to determine valid IPs does not allow for non-alphanumeric characters in the zone ID suffix. Some machines (including the RHEL Linux/s390x machines from Marist) have zone IDs with a '.' character in them which the regex in net.isIP rejects. This changes the regex. Ref: https://github.com/nodejs/node/pull/14500 Signed-off-by:
-
Rich Trott authored
Use `common.hasIPv6` instead of an OS check for more reliable operation. PR-URL: https://github.com/nodejs/node/pull/34359 Reviewed-By:
-
