- May 28, 2017
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/13146 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
In test/pummel/test-stream2-basic.js, check that noop functions are called the expected number of times. PR-URL: https://github.com/nodejs/node/pull/13146 Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/13145 Refs: http://eslint.org/docs/rules/no-useless-constructor Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
PR-URL: https://github.com/nodejs/node/pull/13138 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
Alexey Orlenko authored
* Wrap text at 80 characters. * Use periods consistently. PR-URL: https://github.com/nodejs/node/pull/13135 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Michael Dawson <mhdawson@ibm.com> Reviewed-By:
-
Alexey Orlenko authored
This commit fixes an incorrect keyboard shortcut in `doc/STYLE_GUIDE.md`: entering em-dashes is done via Alt+Shift+"-" on macOS, not via Ctrl+Alt+"-". Besides that, Option is more canonical name of Alt on Macs. PR-URL: https://github.com/nodejs/node/pull/13134 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Rich Trott authored
Use common.mustCall() in test-fs-makeStatsCallback to confirm that the callback is invoked. PR-URL: https://github.com/nodejs/node/pull/13132 Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
Rich Trott authored
When a no-op message event handler is used in a test, make it clear what is expected by using `common.mustCall()` and `common.mustNotCall()`. PR-URL: https://github.com/nodejs/node/pull/13125 Reviewed-By:
-
Michael Dawson authored
Add tests to validate that properties marked as static are available through the class as opposed to instances PR-URL: https://github.com/nodejs/node/pull/13124 Reviewed-By:
Jason Ginchereau <jasongin@microsoft.com> Reviewed-By:
Hitesh Kanwathirtha <digitalinfinity@gmail.com>
-
Michael Dawson authored
Fix mismatch in title for napi_get_value_string_utf16 Fixes: https://github.com/nodejs/abi-stable-node/issues/243 PR-URL: https://github.com/nodejs/node/pull/13123 Reviewed-By:
-
Marcel Laverdet authored
This fixes a race condition in the watchdog timer used for vm timeouts. The condition would terminate the main stack's execution instead of the code running under the sandbox. PR-URL: https://github.com/nodejs/node/pull/13074 Reviewed-By:
-
Marcel Laverdet authored
This option has been broken for almost a year when used with any of the vm.runIn.. family of functions, except for syntax errors. PR-URL: https://github.com/nodejs/node/pull/13074 Reviewed-By:
-
Sam Roberts authored
Use `file` as name of the argument, as the CLI documentation does. PR-URL: https://github.com/nodejs/node/pull/13120 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/13118 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/13113 Reviewed-By:
-
Ebrahim Byagowi authored
PR-URL: https://github.com/nodejs/node/pull/13012 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Rod Vagg authored
Fixes: https://github.com/nodejs/node/issues/12833 PR-URL: https://github.com/nodejs/node/pull/12957 Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
-
Anna Henningsen authored
Backport ABI-incompatible changes from dab18fb0bbcdd (“Make idle tasks optional in the default platform.”). Ref: https://codereview.chromium.org/2737743002 Ref: https://github.com/v8/v8/commit/dab18fb0bbcdd PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Jochen Eisinger authored
Original commit message: Add documentation for FunctionCallbackInfo R=verwaest@chromium.org,haraken@chromium.org,yukishiino@chromium.org BUG= Change-Id: I273f5ce305f80b2aa5e9c8c42a6e8e5afc51a0a7 Reviewed-on: https://chromium-review.googlesource.com/484422 Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#44927} Ref: https://github.com/v8/v8/commit/4fdf9fd4813 PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
Backport API-incompatible changes from 2e4a68733803 (“[v8] v8::StackTrace::AsArray returns correct array”). Ref: https://codereview.chromium.org/2806373005 Ref: https://github.com/v8/v8/2e4a68733803 PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
Backport ABI-incompatible changes from 94283dcf4459f (“[ESNext] Implement DynamicImportCall”). Ref: https://codereview.chromium.org/2703563002 Ref: https://github.com/v8/v8/commit/94283dcf4459f PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
Backport ABI-incompatible changes from bf463c4dc080 (“[async-iteration] implement AsyncGenerator”) and dc662e5b740c (“[inspector] move console to builtins”). This also requires relaxing one of the V8 unit tests. Ref: https://chromium-review.googlesource.com/446961 Ref: https://github.com/v8/v8/commit/bf463c4dc080 Ref: https://codereview.chromium.org/2785293002 Ref: https://github.com/v8/v8/commit/dc662e5b740c PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
Backport deprecation of `Context::EstimatedSize()` from da5b745dba387 (“[api] deprecate unused context size estimate”). Ref: https://github.com/v8/v8/commit/da5b745dba387d0afdb99cd385ba1467a3ca2831 PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
Backport removed methods from 6226576efa82ee (“[wasm] Deleted old way of checking embedder limits on wasm size.”). Ref: https://codereview.chromium.org/2772203005 Ref: https://github.com/v8/v8/commit/6226576efa82ee PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Anna Henningsen authored
Backport new virtual methods from 99743ad460e (“[wasm] Transferrable modules”). Ref: https://codereview.chromium.org/2748473004 Ref: https://github.com/v8/v8/commit/99743ad460e PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
jbroman authored
Original commit message: Give v8::Eternal a direct reference to the handle. This makes it more similar to other handle types (like PersistentBase), by simply storing an i::Object** cast to T*. This means that it is not necessary to look up the handle in the eternal handles table to access the underlying value. Like the built-in roots (null, etc.), an eternal handle can never be destroyed, so we don't even need to allocate a separate local handle. Instead, the Local<T> can point directly at the eternal reference. This makes Eternal<T>::Get trivial. Review-Url: https://codereview.chromium.org/2751263003 Cr-Commit-Position: refs/heads/master@{#43912} Ref: https://github.com/v8/v8/commit/4acdb5eec2c PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By: -
jbroman authored
Original commit message: Make v8::Eternal::Get and IsEmpty const. They do not modify the state of the handle. Review-Url: https://codereview.chromium.org/2753973002 Cr-Commit-Position: refs/heads/master@{#43907} Ref: https://github.com/v8/v8/commit/3700a01c82 PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By: -
Jochen Eisinger authored
Original commit message: Remove experimental fast accessor builder API As the code isn't used, but would have to be ported from hand-written assembly to CodeStubAssembler anyways, I propose to remove it and restore it if we decide that we actually need it. R=vogelheim@chromium.org BUG= Change-Id: Iffd7fc6ec534b1dd7a9144da900424355c8a7a02 Reviewed-on: https://chromium-review.googlesource.com/453461 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#43763} Ref: https://github.com/v8/v8/commit/2cd2f5feff3 PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
addaleax authored
Original commit message: Drop UniqueId from include/v8.h It's unused since March 2 2017 (https://chromium-review.googlesource.com/448539). This removes it assuming that leaving it in the header was an oversight. BUG=v8:5828 Review-Url: https://codereview.chromium.org/2732803002 Cr-Commit-Position: refs/heads/master@{#43605} Ref: https://github.com/v8/v8/commit/de1461b7efd PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By: -
Michael Lippautz authored
Original commit message: Remove object grouping Enbedders should switch to EmbedderHeapTracer API. BUG=v8:5828 Change-Id: I82f2bc583d246617865a17f5904e02cd35f92fec Reviewed-on: https://chromium-review.googlesource.com/448539 Reviewed-by:Hannes Payer <hpayer@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#43551} Ref: https://chromium-review.googlesource.com/448539 Ref: https://github.com/v8/v8/commit/78867ad8707a016 PR-URL: https://github.com/nodejs/node/pull/12875 Reviewed-By:
-
Daniel Bevenius authored
I came across this template class but I don't understand why it is there. It is not used in the template specialization following it. I just wanted to bring it up just in case this is something that has been overlooked. PR-URL: https://github.com/nodejs/node/pull/12993 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
-
Evan Lucas authored
This test ensures that a http client request with the default agent that has a socket that is immediately destroyed can still be caught by adding an error event listener to the request object. PR-URL: https://github.com/nodejs/node/pull/12854 Fixes: https://github.com/nodejs/node/issues/12841 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Evan Lucas authored
This reverts commit 571882c5. Removing the process.nextTick() call can prevent the consumer from being able to catch error events. PR-URL: https://github.com/nodejs/node/pull/12854 Fixes: https://github.com/nodejs/node/issues/12841 Reviewed-By:
-
Eugene Ostroukhov authored
PR-URL: https://github.com/nodejs/node/pull/12263 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Josh Gavant <josh.gavant@outlook.com> Reviewed-By:
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/12936 Reviewed-By:
-
Kat Marchán authored
PR-URL: https://github.com/nodejs/node/pull/12936 Reviewed-By:
-
Faiz Halde authored
AssertionError class is moved to interna/error in reference to the TODO in assert.js. This was suggested to get rid of the cyclic dependency between assert.js and internal/error.js PR-URL: https://github.com/nodejs/node/pull/12906 Reviewed-By:
-
- May 24, 2017
-
-
Daniel Bevenius authored
This test currently fails if node was configured --without-ssl. This commit adds crypto check and skips this test if crypto support is not available. PR-URL: https://github.com/nodejs/node/pull/13141 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/13122 Reviewed-By:
-
