- Apr 29, 2016
-
-
Rich Trott authored
In preparation for a lint rule enforcing function argument alignment, adjust function arguments to be aligned. PR-URL: https://github.com/nodejs/node/pull/6390 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Imran Iqbal <imran@imraniqbal.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ryan Graham <r.m.graham@gmail.com>
-
Rich Trott authored
The deprecation message for `crypto.Credentials` says to use `tls.createSecureContext` but the correct property to use is `tls.SecureContext()`. Fix the deprecation message and add a test that checks the mappings of deprecated properties and their warning messages. PR-URL: https://github.com/nodejs/node/pull/6344 Reviewed-By:
-
Rich Trott authored
Building Node.js on OS X requires XCode (because node-gyp requires XCode). Add that information to BUILDING.md. Additionally, this changes references to `Macintosh` in BUILDING.md to refer to `OS X`. This is consistent with the way other references are to operating system families (`Unix`, `Windows`) and not brand names or hardware architectures. PR-URL: https://github.com/nodejs/node/pull/6309 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
- Apr 28, 2016
-
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/6348 Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com>
-
Matt Loring authored
Net benchmarks create partial event emitters that do not have all of the required event emitter functions. They currently mock out `on`, `once`, and `emit` functions. This change mocks out `prependListener` as well to avoid crashing in `_stream_readable`. PR-URL: https://www.github.com/nodejs/node/pull/6407 Fixes: https://www.github.com/nodejs/node/issues/6405 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Matthew Loring <mattloring@google.com> Reviewed-By:
-
- Apr 27, 2016
-
-
Ben Noordhuis authored
Turn off the custom toolchain, we don't bundle ld.gold. It's not that useful anyway because it uses a fixed path. For people that do use a custom toolchain, there is the GCC_EXEC_PREFIX environment variable. PR-URL: https://github.com/nodejs/node/pull/6393 Reviewed-By:
-
Ben Noordhuis authored
Verify that a second call to handle.close() is a no-op. PR-URL: https://github.com/nodejs/node/pull/6395 Reviewed-By:
-
Ben Noordhuis authored
This also updates the tests to expect that a closed handle has no reference count. PR-URL: https://github.com/nodejs/node/pull/6395 Reviewed-By:
-
Ben Noordhuis authored
Don't implement an additional reference counting scheme on top of libuv. Libuv is the canonical source for that information so use it directly. PR-URL: https://github.com/nodejs/node/pull/6395 Reviewed-By:
-
Lance Ball authored
Addresses #5566. The `ee.once()` function is currently documented as invoking the listener, and then removing it when the event is triggered. However, this is not really the case. The listener is removed and _then_ invoked. This only matters in a narrow set of use cases, but when it matters, it matters that the docs are correct. See the issue (#5566) for a discussion on why the code has not been modified to match the documentation, but instead the documentation has been modified to match the code. Fixes: https://github.com/nodejs/node/issues/5566 PR-URL: https://github.com/nodejs/node/pull/6371 Reviewed-By:
Robert Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
Bryan English authored
Prevent misleading error messages when trailers are invalid. PR-URL: https://github.com/nodejs/node/pull/6308 Reviewed-By:
-
Jackson Tian authored
Use new API of Buffer to developers in most documents. PR-URL: https://github.com/nodejs/node/pull/6367 Reviewed-By:
-
Fedor Indutny authored
There is no official way to figure out if the socket that you have on hand is still connecting to the remote host. Introduce `Socket#connecting`, which is essentially an unprefixed `_connecting` property that we already had. PR-URL: https://github.com/nodejs/node/pull/6404 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Myles Borins authored
The unfortunate has happened, our CHANGELOG is now over 1 MB and cannot be viewed on github. This commit breaks the CHANGELOG into two files so that we can continue to show our changes rendered in the github UI. Closes: https://github.com/nodejs/node/issues/5533 PR-URL: https://github.com/nodejs/node/pull/6337 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By:
Roman Reiss <me@silverwind.io>
-
James M Snell authored
The following significant (semver-major) changes have been made since the previous Node v5.0.0 release. * Buffer * New Buffer constructors have been added [#4682](https://github.com/nodejs/node/pull/4682) * Previously deprecated Buffer APIs are removed [#5048](https://github.com/nodejs/node/pull/5048), [#4594](https://github.com/nodejs/node/pull/4594) * Improved error handling [#4514](https://github.com/nodejs/node/pull/4514) * Cluster * Worker emitted as first argument in 'message' event [#5361](https://github.com/nodejs/node/pull/5361). * Crypto * Improved error handling [#3100](https://github.com/nodejs/node/pull/3100), [#5611](https://github.com/nodejs/node/pull/5611) * Simplified Certificate class bindings [#5382](https://github.com/nodejs/node/pull/5382) * Improved control over FIPS mode [#5181](https://github.com/nodejs/node/pull/5181) * pbkdf2 digest overloading is deprecated [#4047](https://github.com/nodejs/node/pull/4047) * Dependencies * Reintroduce shared c-ares build support [#5775](https://github.com/nodejs/node/pull/5775). * V8 updated to 5.0.71.31 [#6111](https://github.com/nodejs/node/pull/6111). * DNS * Add resolvePtr API to query plain DNS PTR records [#4921](https://github.com/nodejs/node/pull/4921). * Domains * Clear stack when no error handler [#4659](https://github.com/nodejs/node/pull/4659). * File System * The `fs.realpath()` and `fs.realpathSync()` methods have been updated to use a more efficient libuv implementation. This change includes the removal of the `cache` argument and the method can throw new errors [#3594](https://github.com/nodejs/node/pull/3594) * FS apis can now accept and return paths as Buffers [#5616](https://github.com/nodejs/node/pull/5616). * Error handling and type checking improvements [#5616](https://github.com/nodejs/node/pull/5616), [#5590](https://github.com/nodejs/node/pull/5590), [#4518](https://github.com/nodejs/node/pull/4518), [#3917](https://github.com/nodejs/node/pull/3917). * fs.read's string interface is deprecated [#4525](https://github.com/nodejs/node/pull/4525) * HTTP * 'clientError' can now be used to return custom errors from an HTTP server [#4557](https://github.com/nodejs/node/pull/4557). * Modules * Current directory is now prioritized for local lookups [#5689](https://github.com/nodejs/node/pull/5689) * Symbolic links are preserved when requiring modules [#5950](https://github.com/nodejs/node/pull/5950) * Net * DNS hints no longer implicitly set [#6021](https://github.com/nodejs/node/pull/6021). * Improved error handling and type checking [#5981](https://github.com/nodejs/node/pull/5981), [#5733](https://github.com/nodejs/node/pull/5733), [#2904](https://github.com/nodejs/node/pull/2904) * OS X * MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7 [#6402](https://github.com/nodejs/node/pull/6402). * Path * Improved type checking [#5348](https://github.com/nodejs/node/pull/5348). * Process * Introduce process warnings API [#4782](https://github.com/nodejs/node/pull/4782). * Throw exception when non-function passed to nextTick [#3860](https://github.com/nodejs/node/pull/3860). * Readline * Emit key info unconditionally [#6024](https://github.com/nodejs/node/pull/6024) * REPL * Assignment to `_` will emit a warning. [#5535](https://github.com/nodejs/node/pull/5535) * Timers * Fail early when callback is not a function [#4362](https://github.com/nodejs/node/pull/4362) * TLS * Rename 'clientError' to 'tlsClientError' [#4557](https://github.com/nodejs/node/pull/4557) * SHA1 used for sessionIdContext [#3866](https://github.com/nodejs/node/pull/3866) * TTY * Previously deprecated setRawMode wrapper is removed [#2528](https://github.com/nodejs/node/pull/2528). * Util * Changes to Error object formatting [#4582](https://github.com/nodejs/node/pull/4582). * Windows * Windows XP and Vista are no longer supported [#5167](https://github.com/nodejs/node/pull/5167), [#5167](https://github.com/nodejs/node/pull/5167). -
Сковорода Никита Андреевич authored
Refs: https://github.com/nodejs/build/issues/367 libuv is going to drop 10.6 in v2. Ref: https://github.com/libuv/libuv/pull/758 OS X versions below 10.9 are not supported by Apple anymore and do not receive security patches. PR-URL: https://github.com/nodejs/node/pull/6402 Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Сковорода Никита Андреевич authored
This makes sure that `kNoZeroFill` flag is not accidentally set by moving the all the flag operations directly inside `createBuffer()`. It safeguards against logical errors like https://github.com/nodejs/node/issues/6006. This also ensures that `kNoZeroFill` flag is always restored to 0 using a try-finally block, as it could be not restored to 0 in cases of failed or zero-size `Uint8Array` allocation. It safeguards against errors like https://github.com/nodejs/node/issues/2930. It also makes the `size > 0` check not needed there. PR-URL: https://github.com/nodejs/node-private/pull/30 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Jeremiah Senkpiel authored
PR-URL: https://github.com/nodejs/node/pull/6399 Reviewed-By:
-
Myles Borins authored
With v6 we plan to rename the Stable release line to Current. This commit updates all references to Stable in the codebase. It will have to land along side updates to other repos within the org. Refs: https://github.com/nodejs/nodejs.org/issues/669 PR-URL: https://github.com/nodejs/node/pull/6318 Reviewed-By:
-
James M Snell authored
~116 new contributors since this was last updated! PR-URL: https://github.com/nodejs/node/pull/6373 Reviewed-By:
-
Yuval Brik authored
createSecurePair uses tls_legacy and the legacy Connection from node_crypto.cc. Deprecate them in favor of TLSSocket. PR-URL: https://github.com/nodejs/node/pull/6063 Reviewed-By:
-
- Apr 26, 2016
-
-
Stefan Budeanu authored
The OpenSSL configuration file allows custom crypto engines but those directives will not be respected if the config file is loaded after initializing all crypto subsystems. This patch reads the configuration file first. PR-URL: https://github.com/nodejs/node/pull/6374 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Jackson Tian authored
Added myself as a collaborator following the onboarding process. PR-URL: https://github.com/nodejs/node/pull/6388 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Minqi Pan authored
Also changed alias P.S.V.R to Minqi Pan. Reviewed-By:
-
Robert Jefe Lindstaedt authored
PR-URL: #6389 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com>
-
ronkorving authored
Reviewed-By:
-
Alexander Makarenko authored
PR-URL: https://github.com/nodejs/node/pull/6386 Reviewed-By:
Johan Bergström <bugs@bergstroemnu> Reviewed-By:
-
surya panikkal authored
1. The `historySize` to default to `30` only if `undefined`. 2. If `historySize` is set to 0, then disable caching the line. 3. Added unit tests. 4. Updated documentation. Fixes: https://github.com/nodejs/node/issues/6336 PR-URL: https://github.com/nodejs/node/pull/6352 Reviewed-By:
-
Evan Lucas authored
Replace it with worker.exitedAfterDisconnect. Print deprecation message when getting or setting until it is removed. PR-URL: https://github.com/nodejs/node/pull/3743 Fixes: https://github.com/nodejs/node/issues/3721 Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com>
-
Jeremiah Senkpiel authored
This fixes my perceived usability issues with 7d8882ba. Which, at the time of writing, has not landed in any release except v6 RCs. This should not be considered a breaking change due to that. It is useful if you have a handle, even if it has been closed, to be able to inspect whether that handle was unrefed or not. As such, this renames the method accordingly. If people need to check a handle's aliveness, that is a separate API we should consider exposing. Refs: https://github.com/nodejs/node/pull/5834 PR-URL: https://github.com/nodejs/node/pull/6204 Reviewed-By:
-
Alex Kocharin authored
Fixes: https://github.com/nodejs/node/issues/1435 PR-URL: https://github.com/nodejs/node/pull/1480 Reviewed-By:
-
Anna Henningsen authored
Instead of changing the way “simple” expressions are detected, switch to ignoring errors when completing. This approach is more generic than the previous one from 0b66b8f2, but also changes the way errors are thrown when completing. This reverts the code changes from commit 0b66b8f2. The test case is left intact. Fixes: https://github.com/nodejs/node/issues/6325 PR-URL: https://github.com/nodejs/node/pull/6328 Reviewed-By:
-
Ali Ijaz Sheikh authored
Pick up the latest bug fix from the V8 5.0 branch. Original commit message: V8-Commit: https://github.com/v8/v8/commit/c1d51c7c Version 5.0.71.35 (cherry-pick) Merged 2837cb387 disallow left-trim fast path when sampling heap profiler is active R=hablich@chromium.org, hpayer@chromium.org BUG=v8:4937 Review URL: https://codereview.chromium.org/1918453002 . PR-URL: https://github.com/nodejs/node/pull/6372 Reviewed-By:
Michaël Zasso <mic.besace@gmail.com>
-
Alex Lamar authored
Currently, required modules use the real location of the package/file as their __filename and __dirname, instead of the symlinked path if it exists. This behaviour is undocumented (it even goes against documentation in certain scenarios), creating hard-to-debug problems for developers who wish to leverage filesystem abstractions to lay out their application. This patch resolves all required modules to their canonical path while still preserving any symlinks within the path, instead of resolving to their canonical realpath. The one special case observed is when the main module is loaded -- in this case, the realpath does need to be used in order for the main module to load properly. PR-URL: https://github.com/nodejs/node/pull/5950 Reviewed-By:
-
- Apr 25, 2016
-
-
Jackson Tian authored
There are more powerful loggers in user land like `debug`, soft deprecate it. PR-URL: https://github.com/nodejs/node/pull/6161 Reviewed-By:
-
Eugene Obrezkov authored
When timeEnd() provided with label that doesn't exists it emits warning in the console, so developer get know about it. PR-URL: https://github.com/nodejs/node/pull/5901 Reviewed-By:
-
dcposch@dcpos.ch authored
* Remove unnecessary templating from SearchString SearchString used to have separate PatternChar and SubjectChar template type arguments, apparently to support things like searching for an 8-bit string inside a 16-bit string or vice versa. However, SearchString is only used from node_buffer.cc, where PatternChar and SubjectChar are always the same. Since this is extra complexity that's unused and untested (simplifying to a single Char template argument still compiles and didn't break any unit tests), I removed it. * Use Boyer-Hoore[-Horspool] for both indexOf and lastIndexOf Add test cases for lastIndexOf. Test the fallback from BMH to Boyer-Moore, which looks like it was totally untested before. * Extra bounds checks in node_buffer.cc * Extra asserts in string_search.h * Buffer.lastIndexOf: clean up, enforce consistency w/ String.lastIndexOf * Polyfill memrchr(3) for non-GNU systems PR-URL: https://github.com/nodejs/node/pull/4846 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/6365 Reviewed-By:
-
Sakthipriyan Vairamani authored
This patch fixes all the linter errors. PR-URL: https://github.com/nodejs/node/pull/6105 Reviewed-By:
-
Sakthipriyan Vairamani authored
As it is, check-install.sh does not show more helpful error messages, and supporting various shells could be a problem. This patch rewrites the same in Python. This patch also enables check-imports.py in the linting process PR-URL: https://github.com/nodejs/node/pull/6105 Reviewed-By:
-
