Commits · 87cef63ccbbc3db875c4d4e98c42d90623c2ed0e · github.com / v8-riscv / node

May 28, 2017

stream: fix destroy(err, cb) regression · 87cef63c

Matteo Collina authored May 22, 2017

Fixed a regression that caused the callback passed to destroy()
to not be called if the stream was already destroyed.
This caused a regression on the ws module in CITGM introduced by
https://github.com/nodejs/node/pull/12925.

PR-URL: https://github.com/nodejs/node/pull/13156
Fixes: https://github.com/websockets/ws/issues/1118


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>

87cef63c

stream: add destroy and _destroy methods. · b6e1d22f

Matteo Collina authored May 06, 2017

Adds destroy() and _destroy() methods to Readable, Writable, Duplex
and Transform. It also standardizes the behavior and the implementation
of destroy(), which has been inconsistent in userland and core.
This PR also updates all the subsystems of core to use the new
destroy().

PR-URL: https://github.com/nodejs/node/pull/12925


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Calvin Metcalf <calvin.metcalf@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

b6e1d22f

dgram: convert to using internal/errors · f2e3a670

Michael Dawson authored May 09, 2017

Covert lib/dgram.js over to using lib/internal/errors.js
for generating Errors. See
[using-internal-errors.md](https://github.com/nodejs/node/blob/master/doc/guides/using-internal-errors.md)
for more details.

I have not addressed the cases that use errnoException() and
exceptionWithHostPort() helper methods as changing these would require
fixing the tests across all of the different files that use them. In
addition, these helpers already add a `code` to the Error and we'll
have to discuss how that interacts with the `code` used by
lib/internal/errors.js.  I believe we should convert all users
of errnoException and exceptionWithHostPort in a PR dedicated to
that conversion.

PR-URL: https://github.com/nodejs/node/pull/12926


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben.bridgewater@fintura.de>

f2e3a670

test: move stream2 test from pummel to parallel · e012f5a4

Rich Trott authored May 21, 2017

test-stream2-basic runs in a few seconds. It can be moved to parallel.

PR-URL: https://github.com/nodejs/node/pull/13146


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

e012f5a4

test: simplify assert usage in test-stream2-basic · 9100cac1

Rich Trott authored May 21, 2017

PR-URL: https://github.com/nodejs/node/pull/13146


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

9100cac1

test: check noop function invocations · cd70a520

Rich Trott authored May 21, 2017

In test/pummel/test-stream2-basic.js, check that noop functions are
called the expected number of times.

PR-URL: https://github.com/nodejs/node/pull/13146


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

cd70a520

doc: don't use useless constructors in stream.md · db90b505

Vse Mozhet Byt authored May 21, 2017

PR-URL: https://github.com/nodejs/node/pull/13145
Refs: http://eslint.org/docs/rules/no-useless-constructor


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

db90b505

doc: update code example for Windows in stream.md · 2c45e6fd

Vse Mozhet Byt authored May 21, 2017

PR-URL: https://github.com/nodejs/node/pull/13138


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

2c45e6fd

doc: improve formatting of STYLE_GUIDE.md · 3c91145f

Alexey Orlenko authored May 21, 2017

* Wrap text at 80 characters.
* Use periods consistently.

PR-URL: https://github.com/nodejs/node/pull/13135


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

3c91145f

doc: fix incorrect keyboard shortcut · 1d587ef9

Alexey Orlenko authored May 21, 2017

This commit fixes an incorrect keyboard shortcut in
`doc/STYLE_GUIDE.md`: entering em-dashes is done via Alt+Shift+"-" on
macOS, not via Ctrl+Alt+"-". Besides that, Option is more canonical name
of Alt on Macs.

PR-URL: https://github.com/nodejs/node/pull/13134


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

1d587ef9

test: confirm callback is invoked in fs test · 110a3b26

Rich Trott authored May 20, 2017

Use common.mustCall() in test-fs-makeStatsCallback to confirm that the
callback is invoked.

PR-URL: https://github.com/nodejs/node/pull/13132


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

110a3b26

test: check number of message events · 1da674e2

Rich Trott authored May 19, 2017

When a no-op message event handler is used in a test, make it clear what
is expected by using `common.mustCall()` and `common.mustNotCall()`.

PR-URL: https://github.com/nodejs/node/pull/13125


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1da674e2

test: increase n-api constructor coverage · 4ccfd7cf

Michael Dawson authored May 19, 2017

Add tests to validate that properties marked as static
are available through the class as opposed to instances

PR-URL: https://github.com/nodejs/node/pull/13124


Reviewed-By: Jason Ginchereau <jasongin@microsoft.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

4ccfd7cf

doc: fix title/function name mismatch · 336d33b6

Michael Dawson authored May 19, 2017

Fix mismatch in title for napi_get_value_string_utf16

Fixes: https://github.com/nodejs/abi-stable-node/issues/243
PR-URL: https://github.com/nodejs/node/pull/13123


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

336d33b6

vm: fix race condition with timeout param · 6b25c75c

Marcel Laverdet authored May 18, 2017

This fixes a race condition in the watchdog timer used for vm timeouts.
The condition would terminate the main stack's execution instead of the
code running under the sandbox.

PR-URL: https://github.com/nodejs/node/pull/13074


Reviewed-By: Anna Henningsen <anna@addaleax.net>

6b25c75c

vm: fix displayErrors in runIn.. functions · 191bb5a3

Marcel Laverdet authored May 18, 2017

This option has been broken for almost a year when used with any of the
vm.runIn.. family of functions, except for syntax errors.

PR-URL: https://github.com/nodejs/node/pull/13074


Reviewed-By: Anna Henningsen <anna@addaleax.net>

191bb5a3

src: redirect-warnings to file, not path · 4cbdac31

Sam Roberts authored May 19, 2017

Use `file` as name of the argument, as the CLI documentation does.

PR-URL: https://github.com/nodejs/node/pull/13120


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

4cbdac31

doc: link to `common` docs in test writing guide · 9f01b34b

Anna Henningsen authored May 19, 2017

PR-URL: https://github.com/nodejs/node/pull/13118


Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

9f01b34b

stream: improve readable push performance · 8914f7b4

Brian White authored May 19, 2017

PR-URL: https://github.com/nodejs/node/pull/13113


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

8914f7b4

cmd: support dash as stdin alias · f146fe4e

Ebrahim Byagowi authored May 13, 2017

PR-URL: https://github.com/nodejs/node/pull/13012


Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

f146fe4e

build: avoid /docs/api and /docs/doc/api upload · 77dfa2b1

Rod Vagg authored May 11, 2017

Fixes: https://github.com/nodejs/node/issues/12833
PR-URL: https://github.com/nodejs/node/pull/12957


Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>

77dfa2b1

v8: backport pieces of dab18fb0bbcdd · 6d5ca4fe

Anna Henningsen authored May 07, 2017

Backport ABI-incompatible changes from
dab18fb0bbcdd (“Make idle tasks optional in the default platform.”).

Ref: https://codereview.chromium.org/2737743002
Ref: https://github.com/v8/v8/commit/dab18fb0bbcdd

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

6d5ca4fe

v8: do not test v8 with -Werror · 62eaa2a1

Anna Henningsen authored May 06, 2017

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

62eaa2a1

deps: backport 4fdf9fd4813 from upstream v8 · 6e1407c3

Jochen Eisinger authored Apr 21, 2017

Original commit message:

    Add documentation for FunctionCallbackInfo

    R=verwaest@chromium.org,haraken@chromium.org,yukishiino@chromium.org
    BUG=

    Change-Id: I273f5ce305f80b2aa5e9c8c42a6e8e5afc51a0a7
    Reviewed-on: https://chromium-review.googlesource.com/484422


Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#44927}

Ref: https://github.com/v8/v8/commit/4fdf9fd4813

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

6e1407c3

v8: backport header diff from 2e4a68733803 · f118f7ae

Anna Henningsen authored May 06, 2017

Backport API-incompatible changes from
2e4a68733803 (“[v8] v8::StackTrace::AsArray returns correct array”).

Ref: https://codereview.chromium.org/2806373005
Ref: https://github.com/v8/v8/2e4a68733803

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

f118f7ae

v8: backport header diff from 94283dcf4459f · a947cf9a

Anna Henningsen authored May 06, 2017

Backport ABI-incompatible changes from
94283dcf4459f (“[ESNext] Implement DynamicImportCall”).

Ref: https://codereview.chromium.org/2703563002
Ref: https://github.com/v8/v8/commit/94283dcf4459f

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

a947cf9a

v8: backport pieces of bf463c4dc0 and dc662e5b74 · 1bb880b5

Anna Henningsen authored May 06, 2017

Backport ABI-incompatible changes from
bf463c4dc080 (“[async-iteration] implement AsyncGenerator”) and
dc662e5b740c (“[inspector] move console to builtins”).

This also requires relaxing one of the V8 unit tests.

Ref: https://chromium-review.googlesource.com/446961
Ref: https://github.com/v8/v8/commit/bf463c4dc080
Ref: https://codereview.chromium.org/2785293002
Ref: https://github.com/v8/v8/commit/dc662e5b740c

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

1bb880b5

v8: backport header diff from da5b745dba387 · 04e646be

Anna Henningsen authored May 06, 2017

Backport deprecation of `Context::EstimatedSize()` from
da5b745dba387 (“[api] deprecate unused context size estimate”).

Ref: https://github.com/v8/v8/commit/da5b745dba387d0afdb99cd385ba1467a3ca2831

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

04e646be

v8: backport pieces of 6226576efa82ee · 39834bc4

Anna Henningsen authored May 06, 2017

Backport removed methods from 6226576efa82ee (“[wasm] Deleted old way
of checking embedder limits on wasm size.”).

Ref: https://codereview.chromium.org/2772203005
Ref: https://github.com/v8/v8/commit/6226576efa82ee

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

39834bc4

v8: backport pieces from 99743ad460e · 25430fd2

Anna Henningsen authored May 06, 2017

Backport new virtual methods from
99743ad460e (“[wasm] Transferrable modules”).

Ref: https://codereview.chromium.org/2748473004
Ref: https://github.com/v8/v8/commit/99743ad460e

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

25430fd2

deps: backport 4acdb5eec2c from upstream v8 · 385499cc

jbroman authored Mar 17, 2017

Original commit message:

    Give v8::Eternal a direct reference to the handle.

    This makes it more similar to other handle types (like PersistentBase),
    by simply storing an i::Object** cast to T*. This means that it is not
    necessary to look up the handle in the eternal handles table to access
    the underlying value.

    Like the built-in roots (null, etc.), an eternal handle can never be
    destroyed, so we don't even need to allocate a separate local handle.
    Instead, the Local<T> can point directly at the eternal reference.
    This makes Eternal<T>::Get trivial.

    Review-Url: https://codereview.chromium.org/2751263003
    Cr-Commit-Position: refs/heads/master@{#43912}

Ref: https://github.com/v8/v8/commit/4acdb5eec2c

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

385499cc

deps: backport 3700a01c82 from upstream v8 · 69161b5f

jbroman authored Mar 17, 2017

Original commit message:

    Make v8::Eternal::Get and IsEmpty const.

    They do not modify the state of the handle.

    Review-Url: https://codereview.chromium.org/2753973002
    Cr-Commit-Position: refs/heads/master@{#43907}

Ref: https://github.com/v8/v8/commit/3700a01c82

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

69161b5f

deps: backport 2cd2f5feff3 from upstream v8 · 9edd6d8d

Jochen Eisinger authored Mar 13, 2017

Original commit message:

    Remove experimental fast accessor builder API

    As the code isn't used, but would have to be ported from hand-written
    assembly to CodeStubAssembler anyways, I propose to remove it and
    restore it if we decide that we actually need it.

    R=vogelheim@chromium.org
    BUG=

    Change-Id: Iffd7fc6ec534b1dd7a9144da900424355c8a7a02
    Reviewed-on: https://chromium-review.googlesource.com/453461


    Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#43763}

Ref: https://github.com/v8/v8/commit/2cd2f5feff3

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

9edd6d8d

deps: backport de1461b7efd from upstream v8 · 19c0c074

addaleax authored Mar 06, 2017

Original commit message:

    Drop UniqueId from include/v8.h

    It's unused since March 2 2017 (https://chromium-review.googlesource.com/448539).
    This removes it assuming that leaving it in the header was an oversight.

    BUG=v8:5828

    Review-Url: https://codereview.chromium.org/2732803002
    Cr-Commit-Position: refs/heads/master@{#43605}

Ref: https://github.com/v8/v8/commit/de1461b7efd

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

19c0c074

deps: backport 78867ad8707a016 from v8 upstream · 95c4b0d8

Michael Lippautz authored Mar 02, 2017

Original commit message:

    Remove object grouping

    Enbedders should switch to EmbedderHeapTracer API.

    BUG=v8:5828

    Change-Id: I82f2bc583d246617865a17f5904e02cd35f92fec
    Reviewed-on: https://chromium-review.googlesource.com/448539


Reviewed-by: Hannes Payer <hpayer@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#43551}

Ref: https://chromium-review.googlesource.com/448539
Ref: https://github.com/v8/v8/commit/78867ad8707a016

PR-URL: https://github.com/nodejs/node/pull/12875


Reviewed-By: James M Snell <jasnell@gmail.com>

95c4b0d8

crypto: remove unnecessary template class · f06f8365

Daniel Bevenius authored May 12, 2017

I came across this template class but I don't understand why it is
there. It is not used in the template specialization following it.

I just wanted to bring it up just in case this is something that
has been overlooked.

PR-URL: https://github.com/nodejs/node/pull/12993


Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

f06f8365

test: add regression test for immediate socket errors · 6cfb876d

Evan Lucas authored May 11, 2017

This test ensures that a http client request with the default agent
that has a socket that is immediately destroyed can still be caught by
adding an error event listener to the request object.

PR-URL: https://github.com/nodejs/node/pull/12854
Fixes: https://github.com/nodejs/node/issues/12841


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

6cfb876d

Revert "net: remove unnecessary process.nextTick()" · 4fabcfc5

Evan Lucas authored May 05, 2017

This reverts commit 571882c5.

Removing the process.nextTick() call can prevent the consumer
from being able to catch error events.

PR-URL: https://github.com/nodejs/node/pull/12854
Fixes: https://github.com/nodejs/node/issues/12841


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

4fabcfc5

inspector: JavaScript bindings for the inspector · c7182b9d

Eugene Ostroukhov authored Dec 12, 2016

PR-URL: https://github.com/nodejs/node/pull/12263


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Josh Gavant <josh.gavant@outlook.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

c7182b9d

deps: upgrade npm beta to 5.0.0-beta.56 · 3c3b36af

Kat Marchán authored May 09, 2017

PR-URL: https://github.com/nodejs/node/pull/12936


Reviewed-By: Anna Henningsen <anna@addaleax.net>

3c3b36af