- Nov 22, 2017
-
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/17170 Reviewed-By:
Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Andreas Madsen authored
PR-URL: https://github.com/nodejs/node/pull/17147 Refs: https://github.com/nodejs/node/pull/16972 Reviewed-By:
-
Michał Gołębiowski-Owczarek authored
PR-URL: https://github.com/nodejs/node/pull/17239 Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Ali Ijaz Sheikh authored
PR-URL: https://github.com/nodejs/node/pull/17136 Reviewed-By:
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/16976 Refs: https://github.com/nodejs/node/pull/16248 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Matheus Marchini authored
Before these changes, only V8 added debug symbols to Node's binary, limiting the possibilities for debugger's developers to add some features that rely on investigating Node's internal structures. These changes are a first steps towards empowering debug tools to navigate Node's internals strucutres. One example of what can be achieved with this is shown at nodejs/llnode#122 (a command which prints information about handles and requests on the queue for a core dump file). Node debug symbols are prefixed with node_dbg_. Ref: https://github.com/nodejs/llnode/pull/122 PR-URL: https://github.com/nodejs/node/pull/14901 Refs: https://github.com/nodejs/post-mortem/issues/46 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/17197 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
-
suman-mitra authored
PR-URL: https://github.com/nodejs/node/pull/17173 Reviewed-By:
-
cjihrig authored
This commit fixes a -Winconsistent-missing-override warning. PR-URL: https://github.com/nodejs/node/pull/17195 Reviewed-By:
-
Francois KY authored
PR-URL: https://github.com/nodejs/node/pull/17185 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
cjihrig authored
Prior to this commit, the default search paths would be included in the require.resolve() process, even if user specified paths were provided. This commit causes the default paths to be omitted by using a fake parent module. Refs: https://github.com/nodejs/node/issues/5963 PR-URL: https://github.com/nodejs/node/pull/17113 Reviewed-By:
-
Alexey Orlenko authored
Convert `CHECK(0 && "wtf?")` (sic) assertions to more suitable `UNREACHABLE()` macro invocations in `node_zlib.cc`. PR-URL: https://github.com/nodejs/node/pull/17166 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
- Nov 21, 2017
-
-
Anatoli Papirovski authored
PR-URL: https://github.com/nodejs/node/pull/17194 Reviewed-By:
-
Fran Herrero authored
PR-URL: https://github.com/nodejs/node/pull/17193 Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Pierre-Loic Doulcet authored
Remove unused variable err in test/sequential/test-http-writable-true-after-close.js PR-URL: https://github.com/nodejs/node/pull/17186 Reviewed-By:
-
Anna Henningsen authored
V8 is switching APIs for scheduling tasks. Implement the new APIs. Fixes: https://github.com/nodejs/node-v8/issues/24 Refs: https://github.com/v8/v8/commit/c690f54d9580243c53f7d892fcff1ce6bae4bfc0 PR-URL: https://github.com/nodejs/node/pull/17134 Fixes: https://github.com/nodejs/node-v8/issues/24 Reviewed-By:
-
Anna Henningsen authored
Original commit message: [platform] Return task runners as shared_ptr At the moment, task runners are returned as unique_ptr. This is inconvenient, however. In all implementations I did, the platform holds a shared pointer of the task runner and wraps it in a wrapper class just to return it as a unique_ptr. With this CL the platform API is changed to return a shared_ptr directly. R=rmcilroy@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ide278db855199ea239ad0ae14d97fd17349dac8c Reviewed-on: https://chromium-review.googlesource.com/768867 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49366} Refs: https://github.com/v8/v8/commit/98c40a4bae915a9762c73de3307300c61e4fd91a PR-URL: https://github.com/nodejs/node/pull/17134 Fixes: https://github.com/nodejs/node-v8/iss...
-
Anna Henningsen authored
Original commit message: [platform] Add TaskRunner to the platform API With the existing platform API it is not possible to post foreground tasks from background tasks. This is, however, required to implement asynchronous compilation for WebAssembly. With this CL we add the concept of a TaskRunner to the platform API. The TaskRunner contains all data needed to post a foreground task and can be used both from a foreground task and a background task. Eventually the TaskRunner should replace the existing API. In addition, this CL contains a default implementation of the TaskRunner. This implementation has tempory workaround for platforms which do not provide a TaskRunner implementation yet. This default implementation should be deleted again when all platforms provide a TaskRunner implementation. R=rmcilroy@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I6ea4a1c9da1eb9a19e8ce8f2163000dbc2598802 Reviewed-on: https://chromium-review.googlesource.com/741588 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by: -
Guillaume Flandre authored
PR-URL: https://github.com/nodejs/node/pull/17187 Reviewed-By:
-
François Descamps authored
PR-URL: https://github.com/nodejs/node/pull/17184 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
Xavier Balloy authored
PR-URL: https://github.com/nodejs/node/pull/17188 Reviewed-By:
-
Michaël Zasso authored
PR-URL: https://github.com/nodejs/node/pull/16571 Reviewed-By:
-
Anna Henningsen authored
`Promise` instances are already tracked by V8 itself. This fixes `sequential/test-inspector-async-stack-traces-promise-then` in debug mode (it previously crashed because our tracking and the V8 tracking were not properly nested). PR-URL: https://github.com/nodejs/node/pull/17118 Refs: https://chromium-review.googlesource.com/c/v8/v8/+/707058 Fixes: https://github.com/nodejs/node/issues/17017 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/17117 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/17117 Reviewed-By:
-
James M Snell authored
This update does several significant things: 1. It eliminates the base Nghttp2* classes and folds those in to node::http2::Http2Session and node::http2::Http2Stream 2. It makes node::http2::Http2Stream a StreamBase instance and sends that out to JS-land to act as the [kHandle] for the JavaScript Http2Stream class. 3. It shifts some of the callbacks from C++ off of the JavaScript Http2Session class to the Http2Stream class. 4. It refactors the data provider structure for FD and Stream based sending to help encapsulate those functions easier 5. It streamlines some of the functions at the C++ layer to eliminate now unnecessary redirections 6. It cleans up node_http2.cc for better readability and maintainability 7. It refactors some of the debug output 8. Because Http2Stream instances are now StreamBases, they are now also trackable using async-hooks 9. The Stream::OnRead algorithm has been simplified with a couple bugs fixed. 10. I've eliminated node_http2_core.h and node_http2_core-inl.h 11. Detect invalid handshake a report protocol error to session 12. Refactor out of memory error, improve other errors 13. Add Http2Session.prototype.ping PR-URL: https://github.com/nodejs/node/pull/17105 Reviewed-By:
Sebastiaan Deckers <sebdeckers83@gmail.com>
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17125 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17125 Reviewed-By:
-
Tobias Nießen authored
The first occurrence of path.join() can easily be replaced with path.resolve(). The second occurrence should be unnecessary as ESLint will resolve the path internally, and the old check probably did not work as intended anyway. PR-URL: https://github.com/nodejs/node/pull/17121 Reviewed-By:
-
Tobias Nießen authored
PR-URL: https://github.com/nodejs/node/pull/17120 Reviewed-By:
-
cjihrig authored
This fixes a compiler warning. PR-URL: https://github.com/nodejs/node/pull/17150 Reviewed-By:
-
Anna Henningsen authored
Add a utility functions for addons to use when they need a reference to the current event loop. While the libuv API is not directly part of N-API, it provides a quite stable C API as well, and is tightly integrated with Node itself. As a particular use case, without access to the event loop it is hard to do something interesting from inside a N-API finalizer function, since calls into JS and therefore virtually all other N-API functions are not allowed. PR-URL: https://github.com/nodejs/node/pull/17109 Reviewed-By:
-
Anna Henningsen authored
Add a utility functions for addons to use when they need a reference to the current event loop. Currently, `uv_default_loop()` works if the embedder is the single-threaded default node executable, but even without the presence of e.g. workers that might not really an API guarantee for when Node is embedded. PR-URL: https://github.com/nodejs/node/pull/17109 Reviewed-By:
-
Ben Noordhuis authored
This method is undocumented and depends on a V8 API that is slated for removal. The inspector and node-inspect don't use it and I could find no third-party code that depends on it. Remove it. PR-URL: https://github.com/nodejs/node/pull/17060 Reviewed-By:
-
Ben Noordhuis authored
Report (for example) "node[1337]" as the human-readable name rather than the more generic and less helpful "Node.js Main Context." While not perfect yet, it should be an improvement to people that debug multiple processes from DevTools, VS Code, etc. PR-URL: https://github.com/nodejs/node/pull/17087 Reviewed-By:
-
Ben Noordhuis authored
There are a few places where we paper over the fact that getpid() is called GetCurrentProcessId() on Windows. Let's move it into a function. PR-URL: https://github.com/nodejs/node/pull/17087 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17106 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17106 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17106 Reviewed-By:
-
Rich Trott authored
The IRC link is mentioned in CONTRIBUTING.md which is linked immediately above. We should encourage people to read that doc before hoping on the IRC channel. PR-URL: https://github.com/nodejs/node/pull/17106 Ref: https://github.com/nodejs/node/pull/16533#discussion_r147292940 Reviewed-By:
-
