Commits · 7e5bf48998f7bd0a512d7e5340e1614dfdc8cf97 · github.com / v8-riscv / node

Dec 11, 2020

build,lib,test: change whitelist to allowlist · 7e5bf489

Michaël Zasso authored Dec 06, 2020

PR-URL: https://github.com/nodejs/node/pull/36406


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

7e5bf489

doc: update terminology · 72b07e4f

Michael Dawson authored Dec 10, 2020



Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/36475


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

72b07e4f

stream: support abortsignal in constructor · 040a27ae

Benjamin Gruenbaum authored Dec 07, 2020

PR-URL: https://github.com/nodejs/node/pull/36431


Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

040a27ae

inspector: refactor to use more primordials · 80658836

Antoine du Hamel authored Nov 21, 2020

PR-URL: https://github.com/nodejs/node/pull/36356


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

80658836

Dec 10, 2020

test: increase execFile abort coverage · 5dd58d06

Moshe vilner authored Dec 07, 2020

Verify that if something different than Abortcontroller.signal is passed
to child_process.execFile(), ERR_INVALID_ARG_TYPE is thrown.

PR-URL: https://github.com/nodejs/node/pull/36429


Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

5dd58d06

doc: reword POSIX threads text in addons.md · 8b697246

Rich Trott authored Dec 07, 2020

PR-URL: https://github.com/nodejs/node/pull/36436


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

8b697246

src: fix node version · 87dc1522

Richard Lau authored Dec 09, 2020

PR-URL: https://github.com/nodejs/node/pull/36460
Refs: https://github.com/nodejs/node/commit/348b7a9606da61fbb5437e27f479363114ecf4eb#r44957158
Refs: https://github.com/nodejs/node/pull/36385


Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>

87dc1522

tools: enable no-unsafe-optional-chaining lint rule · a26ae70f

cjihrig authored Dec 06, 2020

This rule is new in ESLint 7.15.0.

PR-URL: https://github.com/nodejs/node/pull/36411


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

a26ae70f

tools: update ESLint to 7.15.0 · 514da381

cjihrig authored Dec 06, 2020

Update ESLint to 7.15.0

PR-URL: https://github.com/nodejs/node/pull/36411


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

514da381

Dec 09, 2020

doc: add RaisinTen as a triager · 27a63ee8

raisinten authored Dec 06, 2020

I would like to apply for the role of a triager in this project.
My motivation to become a triager is to help with the issues in
this repo and the help repo, as well as learn deeper internals
of Node.js, and to eventually become a collaborator!
I hearby declare that I have read and understood the Code of
Conduct of the project and will adhere to that.

PR-URL: https://github.com/nodejs/node/pull/36404


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

27a63ee8

deps: upgrade npm to 7.1.0 · 8d8c7af1

Ruy Adorno authored Dec 04, 2020

PR-URL: https://github.com/nodejs/node/pull/36395


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

8d8c7af1

2020-12-09, Version 15.4.0 (Current) · 348b7a96

Danielle Adams authored Dec 07, 2020

PR-URL: https://github.com/nodejs/node/pull/36435

Notable changes:

* child_processes:
  * add AbortSignal support (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/36308)
* deps:
  * update ICU to 68.1 (Michaël Zasso) (https://github.com/nodejs/node/pull/36187)
* events:
  * support signal in EventTarget (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/36258)
  * graduate Event, EventTarget, AbortController (James M Snell) (https://github.com/nodejs/node/pull/35949)
* http:
  * enable call chaining with setHeader() (pooja d.p) (https://github.com/nodejs/node/pull/35924)
* module:
  * add isPreloading indicator (James M Snell) (https://github.com/nodejs/node/pull/36263)
* stream:
  * support abort signal (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/36061)
  * add FileHandle support to Read/WriteStream (Momtchil Momtchev) (https://github.com/nodejs/node/pull/35922)
* worker:
  * add experimental BroadcastChannel (James M Snell) (https://github.com/nodejs/node/pull/36271)

348b7a96

test: fix flaky test-repl · 9b237774

Rich Trott authored Dec 06, 2020

The timeout is insufficient in CI (failures on Raspberry Pi) and I can
reproduce locally (on macOS) with
`tools/test.py -j 96 --repeat 192 test-repl`.

Increase timeout drastically as it only is useful in an error
condition.

PR-URL: https://github.com/nodejs/node/pull/36415


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

9b237774

src: fix indentation in memory_tracker-inl.h · ea6df032

Daniel Bevenius authored Dec 07, 2020

PR-URL: https://github.com/nodejs/node/pull/36425


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

ea6df032

src: remove identical V macro · 748d98ae

Daniel Bevenius authored Dec 07, 2020

This commit removes one of the V macros in IsolateData::MemoryInfo as
they are identical as far as I can tell.

PR-URL: https://github.com/nodejs/node/pull/36427


Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>

748d98ae

src: use using declarations consistently · 344a5447

Daniel Bevenius authored Dec 03, 2020

PR-URL: https://github.com/nodejs/node/pull/36365


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

344a5447

doc: document ABORT_ERR code · 13e21708

Benjamin Gruenbaum authored Nov 29, 2020

We added an `AbortError` with the same code and name as the web's as
part of the consensus in https://github.com/nodejs/node/issues/36084 but
never actually documented the error in our error codes list.

This PR adds the error code.

PR-URL: https://github.com/nodejs/node/pull/36319


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

13e21708

tools: update doc tool dependencies · 8dbeac6c

Michaël Zasso authored Dec 06, 2020

PR-URL: https://github.com/nodejs/node/pull/36407


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

8dbeac6c

Dec 08, 2020

src: add missing context scopes · e31a99f0

Anna Henningsen authored Dec 06, 2020

Add scopes that ensure that the context associated with the
current Environment is always entered when working with it.

PR-URL: https://github.com/nodejs/node/pull/36413


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

e31a99f0

test: check null proto-of-proto in util.inspect() · 7a39d892

Rich Trott authored Dec 05, 2020

Add a test to check util.inspect()'s handling of a null
prototype-of-an-iterable-prototype. This covers a previously uncovered
code branch.

Refs: https://coverage.nodejs.org/coverage-0fd121e00c9d5987/lib/internal/util/inspect.js.html#L597

PR-URL: https://github.com/nodejs/node/pull/36399


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

7a39d892

test: add SIGTRAP to test-signal-handler · a45f6224

Ash Cripps authored Dec 03, 2020

PR-URL: https://github.com/nodejs/node/pull/36368


Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

a45f6224

test: fix child-process-pipe-dataflow · ca8eb795

Santiago Gimeno authored Dec 03, 2020

Make sure all the `wc` process stdout data is received before checking
its validity.

Fixes: https://github.com/nodejs/node/issues/25988

PR-URL: https://github.com/nodejs/node/pull/36366


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

ca8eb795

doc: provide more context on techinical values · 6d3775e2

Michael Dawson authored Nov 20, 2020

In the discussion of https://github.com/nodejs/node/pull/35323


it was suggested that we should add some
additional context/clarification to the technical
values documented for the project.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/36201


Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

6d3775e2

dns: refactor to use more primordials · 96b4950d

Antoine du Hamel authored Nov 20, 2020

PR-URL: https://github.com/nodejs/node/pull/36314


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

96b4950d

tools: enable no-unused-expressions lint rule · bf31d3c3

Michaël Zasso authored Nov 24, 2020

Fixes: https://github.com/nodejs/node/issues/36246

PR-URL: https://github.com/nodejs/node/pull/36248


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

bf31d3c3

net: refactor to use more primordials · 0869b829

Antoine du Hamel authored Nov 18, 2020

PR-URL: https://github.com/nodejs/node/pull/36303


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

0869b829

tools: upgrade to @babel/eslint-parser 7.12.1 · 5f1bf80b

Antoine du Hamel authored Nov 29, 2020

PR-URL: https://github.com/nodejs/node/pull/36321
Fixes: https://github.com/ensure


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

5f1bf80b

worker: refactor to use more primordials · 23f4b6ea

Antoine du Hamel authored Dec 04, 2020

PR-URL: https://github.com/nodejs/node/pull/36393


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

23f4b6ea

lib: add uncurried accessor properties to `primordials` · c83e5994

ExE Boss authored Nov 30, 2020

Closes: https://github.com/nodejs/node/pull/32127

PR-URL: https://github.com/nodejs/node/pull/36329
Fixes: https://github.com/nodejs/node/issues/32127


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

c83e5994

http2: refactor to use more primordials · b5bb0944

Antoine du Hamel authored Nov 21, 2020

PR-URL: https://github.com/nodejs/node/pull/36357


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

b5bb0944

string_decoder: refactor to use more primordials · 4027e36d

Antoine du Hamel authored Nov 21, 2020

PR-URL: https://github.com/nodejs/node/pull/36358


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

4027e36d

lib: fix typo in internal/errors.js · 7e5fc9c7

raisinten authored Dec 07, 2020

PR-URL: https://github.com/nodejs/node/pull/36426


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

7e5fc9c7

stream: support abort signal · 5bd1eecf

Benjamin Gruenbaum authored Nov 09, 2020

PR-URL: https://github.com/nodejs/node/pull/36061


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

5bd1eecf

Dec 07, 2020

test: fix comment misspellings of transferred · 51224568

Rich Trott authored Dec 02, 2020

PR-URL: https://github.com/nodejs/node/pull/36360


Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>

51224568

test: fix flaky test-http2-respond-file-error-pipe-offset · f178c5a1

Rich Trott authored Nov 28, 2020

Fixes: https://github.com/nodejs/node/issues/35881

PR-URL: https://github.com/nodejs/node/pull/36305


Reviewed-By: Anna Henningsen <anna@addaleax.net>

f178c5a1

test: fix bootstrap test · 537da195

Benjamin Gruenbaum authored Dec 06, 2020

PR-URL: https://github.com/nodejs/node/pull/36418


Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>

537da195

buffer: refactor to use primordials instead of Array#reduce · ff048bd7

Antoine du Hamel authored Dec 04, 2020

PR-URL: https://github.com/nodejs/node/pull/36392


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

ff048bd7

test: increase coverage for readline · d2e4b98d

Zijian Liu authored Dec 05, 2020

1. test call readline.Interface without new should return instance
Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/readline.js.html#L101

2. test keypress ctrl + c should close readline interface
Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/readline.js.html#L891

PR-URL: https://github.com/nodejs/node/pull/36389
Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/readline.js.html#L101
Refs: https://coverage.nodejs.org/coverage-f7dd330ba0e7bfa9/lib/readline.js.html#L891

Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

d2e4b98d

doc: add Powershell oneliner to get Windows version · 5fa7c2ab

Michael Bashurov authored Nov 06, 2019



Co-authored-by: Michaël Zasso <targos@protonmail.com>

PR-URL: https://github.com/nodejs/node/pull/30289


Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

5fa7c2ab

Dec 06, 2020

doc: add version metadata to timers/promises · 2f49720b

cjihrig authored Dec 03, 2020

Refs: https://github.com/nodejs/node/pull/33950

PR-URL: https://github.com/nodejs/node/pull/36378


Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

2f49720b